Re: release of maven-source-plugin

2024-03-27 Thread Herve Boutemy
https://github.com/apache/maven-source-plugin/pull/24 does not seem to get any positive traction: be it MSOURCE-140 and MSOURCE-141 are assigned to 3.3.1 release but nobody wants to work with me on it to solve something: it seems they are not a real problem I won't hold the 3.3.1 release foreve

Re: release of maven-source-plugin

2024-03-25 Thread Hervé Boutemy
PR ready for review: https://github.com/apache/maven-source-plugin/pull/24 I think it does the right job at differentiating 2 cases that the initial MSOURCES-121 merged too aggressively: 1. do not fail when executed twice with the same output file 2. but fail when re-attach happens to another out

Re: release of maven-source-plugin

2024-03-24 Thread Hervé Boutemy
IIUC, this is an explanation of the mystery failure that started the MSOURCE-121 update but after MSOURCE-121, the plugin itself stops with a failure when detecting re-addition: that's why Gary can't upgrade, the failure is now happening at plugin level, and always "mvn install deploy" (with so

Re: release of maven-source-plugin

2024-03-24 Thread Gary Gregory
I'm glad to hear there is nothing fundamentally wrong. Thank you for the detailed explanation. Gary On Sun, Mar 24, 2024, 3:40 PM Romain Manni-Bucau wrote: > Hi, > > I think it is fixed for v4 serie. > Main issue comes from the default v3 pom ( > > https://github.com/apache/maven/blob/maven-3.

Re: release of maven-source-plugin

2024-03-24 Thread Romain Manni-Bucau
Hi, I think it is fixed for v4 serie. Main issue comes from the default v3 pom ( https://github.com/apache/maven/blob/maven-3.9.2/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml#L113) which is no more a thing in v4 so the merge of the plugin executions does not happen t

Re: release of maven-source-plugin

2024-03-24 Thread Gary Gregory
Hi All, As long as https://issues.apache.org/jira/browse/MSOURCES-143 is in play, Commons will stay on a pre-3.3.0 version. I re-read the comments, I still don't know what we can do in Commons to address this as this feels like some deep Maven Magic. Gary On Sun, Mar 24, 2024 at 11:48 AM Hervé

release of maven-source-plugin

2024-03-24 Thread Hervé Boutemy
I'd like to release maven-source-plugin 3.3.1 to drop the umask sensitivity during Reproducible Builds :)1 but there are a few issues open https://issues.apache.org/jira/projects/MSOURCES/versions/12353471 they are related to https://issues.apache.org/jira/browse/MSOURCES-121: I don't get what