Re: svn commit: r1783494 - /maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java

2017-02-19 Thread Tibor Digana
yes, PrintStream, but we have OutputStream which does not flush like PrintStream. Nevertheless, I found we implement FlushReceiver which allows me to flush entire word. This fix flushed a byte. So we perform better in Surefire with flushed word and maybe we would not need to have this fix in

Re: svn commit: r1783494 - /maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java

2017-02-18 Thread Hervé BOUTEMY
notice: on PrintStream, autoflush does such flush only when newline is appended see https://docs.oracle.com/javase/7/docs/api/java/io/ PrintStream.html#PrintStream(java.io.OutputStream,%20boolean) Regards, Hervé Le samedi 18 février 2017, 13:45:14 CET Robert Scholte a écrit : > I've added a

Re: svn commit: r1783494 - /maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java

2017-02-18 Thread Robert Scholte
I've added a unittest, just to be sure. Not sure about the price of flushing, but seems expensive to do it after every write of a single byte. Robert On Sat, 18 Feb 2017 08:41:54 +0100, wrote: Author: tibordigana Date: Sat Feb 18 07:41:54 2017 New Revision: 1783494