RE: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-25 Thread Brian E. Fox
-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java Actually, I think this is a great idea. I'd love this for our sample projects for the stuff I work on that we ship with the full kits. There is no point to deploy

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-25 Thread Jason van Zyl
Then why wouldn't you just configure the release plugin to go where you wanted it to go in the lifecycle? On 24-Feb-08, at 5:27 PM, Daniel Kulp wrote: Actually, I think this is a great idea. I'd love this for our sample projects for the stuff I work on that we ship with the full kits.

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-25 Thread Daniel Kulp
On Monday 25 February 2008, Jason van Zyl wrote: Then why wouldn't you just configure the release plugin to go where you wanted it to go in the lifecycle? I'm not sure I get what your trying to say. I WANT the release plugin to consider those projects. If I'm releasing version 2.1, I WANT

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-25 Thread Daniel Kulp
That all said, IMO, the proliferation of skip flags into all the plugins kind of begs for their to be standard support for this idea right in the core. Kind of like, set: org.apache.maven.plugins:maven-deploy-plugin.skip=true or something like that so that ANY plugin could be skipped.

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-25 Thread John Casey
For the skip flag discussion, I'd refer you to: http://docs.codehaus.org/display/MAVEN/Suppression%2C+Ordering%2C+and +Replacement+of+Plugins+and+Mojos+Bindings which is something I'm trying to build up to with the refactoring of the lifecycle support in Maven 2.1-snapshot (trunk). See

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-24 Thread Jason van Zyl
On 22-Feb-08, at 2:57 PM, [EMAIL PROTECTED] wrote: Author: olamy Date: Fri Feb 22 14:57:35 2008 New Revision: 630347 URL: http://svn.apache.org/viewvc?rev=630347view=rev Log: [MDEPLOY-63] Allow disabling deployment for artifacts that should not be deployed What's the reasoning behind

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-24 Thread Jason van Zyl
On 24-Feb-08, at 10:57 AM, Olivier Lamy wrote: My goal is only to help users which need some features in maven. But if you say/think the feature is bad : No problem I can revert the commit and mark the jira issue as won't fix. What was the use case? I'm all for helping users, but generally

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-24 Thread Olivier Lamy
My goal is only to help users which need some features in maven. But if you say/think the feature is bad : No problem I can revert the commit and mark the jira issue as won't fix. -- Olivier 2008/2/24, Jason van Zyl [EMAIL PROTECTED]: On 22-Feb-08, at 2:57 PM, [EMAIL PROTECTED] wrote:

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-24 Thread Olivier Lamy
Vincent Massol asked it for cargo build. -- Olivier 2008/2/24, Jason van Zyl [EMAIL PROTECTED]: On 24-Feb-08, at 10:57 AM, Olivier Lamy wrote: My goal is only to help users which need some features in maven. But if you say/think the feature is bad : No problem I can revert the

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-24 Thread Jason van Zyl
Vincent, What's the use case for optional deployment? On 24-Feb-08, at 11:34 AM, Olivier Lamy wrote: Vincent Massol asked it for cargo build. -- Olivier 2008/2/24, Jason van Zyl [EMAIL PROTECTED]: On 24-Feb-08, at 10:57 AM, Olivier Lamy wrote: My goal is only to help users which need

Re: svn commit: r630347 - in /maven/plugins/trunk/maven-deploy-plugin/src: main/java/org/apache/maven/plugin/deploy/DeployMojo.java test/java/org/apache/maven/plugin/deploy/DeployMojoTest.java

2008-02-24 Thread Daniel Kulp
Actually, I think this is a great idea. I'd love this for our sample projects for the stuff I work on that we ship with the full kits. There is no point to deploy them into the repositories as there is no value in that at all. However, I'd like them built as part of the build to make