Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/29/16 um 02:12 schrieb Christian Schulte: > Am 12/29/16 um 00:41 schrieb Michael Osipov: >> Am 2016-12-28 um 22:51 schrieb Christian Schulte: >>> I just pushed a fix for this. I could also have made that transitive >>> dependency a direct one, where it is used, and could have left the scope

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Michael Osipov
Am 2016-12-28 um 21:34 schrieb Guillaume Boué: I have the same results as Hervé, both on Windows and Ubuntu. This is what I have with Maven 3.3.9: - Windows 10 64bit, OpenJDK 1.8.0_102, Test failure: Timeout in HugeFileDownloadTest (perhaps the timeout should be increased?) How often did you

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/28/16 um 22:21 schrieb Guillaume Boué: > > How come the tests compile fine with Maven 2.2.1, 3.0.5 and 3.3.9 then? > I'd say this is the root cause of nearly all issues we are having a hard time fixing and shipping. It does not make sense to compare some recent behaviour to some former

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Michael Osipov
Am 2016-12-28 um 22:51 schrieb Christian Schulte: I just pushed a fix for this. I could also have made that transitive dependency a direct one, where it is used, and could have left the scope management in. "Dependency management overrides are not transitive." Just checked this commit. It

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Michael Osipov
Am 2016-12-28 um 22:50 schrieb Robert Scholte: Which makes me wonder if this really is a fix. Wagon can be built with a wide range of Maven version covering a lot of years AND the maven-dependency-plugin shows what you would expect: junit is available with test-scope. "That's always been that

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/29/16 um 00:41 schrieb Michael Osipov: > If this is how it should (I am neither pro nor cons) work, we should > deprecate this element or at least put a big WARNING on it. We should spit out a big fat warning whenever someone overrides hers/his own management. It shouldn't even be possible

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/29/16 um 02:41 schrieb Christian Schulte: > Am 12/29/16 um 02:36 schrieb Christian Schulte: >> Am 12/29/16 um 00:41 schrieb Michael Osipov: >>> If this is how it should (I am neither pro nor cons) work, we should >>> deprecate this element or at least put a big WARNING on it. >> >> We

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/29/16 um 00:41 schrieb Michael Osipov: > Am 2016-12-28 um 22:51 schrieb Christian Schulte: >> I just pushed a fix for this. I could also have made that transitive >> dependency a direct one, where it is used, and could have left the scope >> management in. >> >> "Dependency management

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
>> Right now I see Wagon as a reference project for Maven 3.4.0: I disagree. It relies on overriding management althought that correctly is not supported when consumed. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/29/16 um 02:36 schrieb Christian Schulte: > Am 12/29/16 um 00:41 schrieb Michael Osipov: >> If this is how it should (I am neither pro nor cons) work, we should >> deprecate this element or at least put a big WARNING on it. > > We should spit out a big fat warning whenever someone

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/29/16 um 03:19 schrieb Christian Schulte: > Am 12/29/16 um 02:41 schrieb Christian Schulte: >> Am 12/29/16 um 02:36 schrieb Christian Schulte: >>> Am 12/29/16 um 00:41 schrieb Michael Osipov: If this is how it should (I am neither pro nor cons) work, we should deprecate this

Re: [1/2] maven-wagon git commit: [WAGON-474] Upgrade and revise all tests for Jetty 8

2016-12-28 Thread Michael Osipov
Am 2016-12-28 um 15:07 schrieb Olivier Lamy: 2017 is in few days so maybe java 1.7 shouldn't be a big problem While this is correct, I don't want to change 10 things at once. At last, if no one changes the code to 1.7, there won't be any benefit. I'd move this for n+1 release. Michael

Re: svn commit: r1775971 - /maven/plugins/trunk/maven-pmd-plugin/pom.xml

2016-12-28 Thread Robert Scholte
On Wed, 28 Dec 2016 11:47:40 +0100, Hervé BOUTEMY wrote: Le mardi 27 décembre 2016, 14:48:56 CET Robert Scholte a écrit : >> The fact right now is that if I add/change a test-scoped dependency, it >> could happen that the project won't run due to a missing

Re: [1/2] maven-wagon git commit: [WAGON-474] Upgrade and revise all tests for Jetty 8

2016-12-28 Thread Olivier Lamy
2017 is in few days so maybe java 1.7 shouldn't be a big problem On Wed, 28 Dec 2016 at 11:09 am, Michael Osipov wrote: Am 2016-12-28 um 08:54 schrieb Olivier Lamy: > Hi > What about at least Jetty 9.2? (8.x is not anymore supported) Wagon is still Java 1.6,

Re: svn commit: r1775971 - /maven/plugins/trunk/maven-pmd-plugin/pom.xml

2016-12-28 Thread Hervé BOUTEMY
Le mardi 27 décembre 2016, 14:48:56 CET Robert Scholte a écrit : > >> The fact right now is that if I add/change a test-scoped dependency, it > >> could happen that the project won't run due to a missing transitive > >> dependency. > >> We are very, very lucky this doesn't happen that often. > >

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Hervé BOUTEMY
the branch runs without issue on my machine now: mvn: 3.3.9, jdk: Oracle 1.7.0_71, OS: Linux the proposed release was consistently failing on HugeFileDownloadTest Notice that with Maven 3.4.0-SNAPSHOT, there is a compilation failure: testCompile (default-testCompile) on project wagon-file Using

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Michael Osipov
Am 2016-12-28 um 06:05 schrieb Dan Tran: i still see the same timeout error on the jetty8 branch. No issue at master [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project wagon-http: There was a timeout or other error in the fork ->

Re: [1/2] maven-wagon git commit: [WAGON-474] Upgrade and revise all tests for Jetty 8

2016-12-28 Thread Michael Osipov
Am 2016-12-28 um 08:54 schrieb Olivier Lamy: Hi What about at least Jetty 9.2? (8.x is not anymore supported) Wagon is still Java 1.6, therefore I had to stick to Jetty 8. Moving from 8 to 9 is easier than from 6 to 9. See:

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Michael Osipov
Am 2016-12-28 um 06:05 schrieb Dan Tran: i still see the same timeout error on the jetty8 branch. No issue at master [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project wagon-http: There was a timeout or other error in the fork ->

Re: svn commit: r1775971 - /maven/plugins/trunk/maven-pmd-plugin/pom.xml

2016-12-28 Thread Robert Scholte
So can we remove the commandline option? And anything we cannot agree on push to Model 5.0.0? This way model 4.0.0 works as it did (apart from the real bugfixes) and we can finally start making milestones for M3.4.0 For 5.0.0 we need to reach out to other third parties anyway, so let's

Re: [VOTE] Releasing Wagon 2.11 - Cancel

2016-12-28 Thread Dan Tran
Hi I am going to cancel this vote due to inconsistent test failure at wagon-http provider on huge download test. Thanks -Dan On Wed, Dec 28, 2016 at 7:08 AM, Michael Osipov wrote: > Am 2016-12-28 um 06:05 schrieb Dan Tran: > >> i still see the same timeout error on the jetty8

Re: [1/2] maven-wagon git commit: [WAGON-474] Upgrade and revise all tests for Jetty 8

2016-12-28 Thread Dan Tran
strange, i placed your recommended logger settings under systemPropertyVariables and see no log for the timeout issue Anyway I am going to cancel the vote and have to roll it again Thanks -Dan On Wed, Dec 28, 2016 at 6:18 AM, Michael Osipov wrote: > Am 2016-12-28 um

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Guillaume Boué
I have the same results as Hervé, both on Windows and Ubuntu. This is what I have with Maven 3.3.9: - Windows 10 64bit, OpenJDK 1.8.0_102, Test failure: Timeout in HugeFileDownloadTest (perhaps the timeout should be increased?) - Ubuntu 16.04 32bit, OpenJDK 1.8.0_111, Maven 3.3.9: All OK -

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/28/16 um 21:34 schrieb Guillaume Boué: > I have the same results as Hervé, both on Windows and Ubuntu. This is > what I have with Maven 3.3.9: > > - Windows 10 64bit, OpenJDK 1.8.0_102, Test failure: Timeout in > HugeFileDownloadTest (perhaps the timeout should be increased?) > - Ubuntu

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Guillaume Boué
Le 28/12/2016 à 21:49, Christian Schulte a écrit : Am 12/28/16 um 21:34 schrieb Guillaume Boué: I have the same results as Hervé, both on Windows and Ubuntu. This is what I have with Maven 3.3.9: - Windows 10 64bit, OpenJDK 1.8.0_102, Test failure: Timeout in HugeFileDownloadTest (perhaps the

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/28/16 um 22:21 schrieb Guillaume Boué: > > How come the tests compile fine with Maven 2.2.1, 3.0.5 and 3.3.9 then? Because it does not come with MRESOLVER-9 fixed. - To unsubscribe, e-mail:

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
I just pushed a fix for this. I could also have made that transitive dependency a direct one, where it is used, and could have left the scope management in. "Dependency management overrides are not transitive." - To

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Robert Scholte
Which makes me wonder if this really is a fix. Wagon can be built with a wide range of Maven version covering a lot of years AND the maven-dependency-plugin shows what you would expect: junit is available with test-scope. "That's always been that way." Well, apparently not. Maybe it was

Re: svn commit: r1775971 - /maven/plugins/trunk/maven-pmd-plugin/pom.xml

2016-12-28 Thread Hervé BOUTEMY
Le mercredi 28 décembre 2016, 14:33:58 CET Robert Scholte a écrit : > On Wed, 28 Dec 2016 11:47:40 +0100, Hervé BOUTEMY > > wrote: > > Le mardi 27 décembre 2016, 14:48:56 CET Robert Scholte a écrit : > >> >> The fact right now is that if I add/change a test-scoped

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Hervé BOUTEMY
Le mercredi 28 décembre 2016, 22:50:52 CET Robert Scholte a écrit : > Which makes me wonder if this really is a fix. Wagon can be built with a > wide range of Maven version covering a lot of years AND the > maven-dependency-plugin shows what you would expect: junit is available > with test-scope.

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/28/16 um 22:50 schrieb Robert Scholte: > Which makes me wonder if this really is a fix. Wagon can be built with a > wide range of Maven version covering a lot of years AND the > maven-dependency-plugin shows what you would expect: junit is available > with test-scope. > > "That's

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
To be even more clear: It's bullshit you can override the management in the POM when those overrides disappear transitively. Do not override management and be done with it. - To unsubscribe, e-mail:

Re: [VOTE] Releasing Wagon 2.11

2016-12-28 Thread Christian Schulte
Am 12/28/16 um 22:21 schrieb Guillaume Boué: > This is the tree with Maven 3.3.9: > > [DEBUG] org.apache.maven.wagon:wagon-file:jar:2.12-SNAPSHOT > [DEBUG]org.codehaus.plexus:plexus-utils:jar:3.0.24:compile > [DEBUG]org.slf4j:slf4j-simple:jar:1.7.19:test > [DEBUG]