Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
No problem, the change was minimal, I will start from scratch
---
-
To unsubscribe, e-mail:
Good. Thanks a lot
On Sun, Nov 19, 2017 at 8:35 PM, Robert Scholte
wrote:
> Thanks for picking this up and the great results!
>
> Robert
>
>
> On Sun, 19 Nov 2017 18:59:00 +0100, Hervé BOUTEMY
> wrote:
>
> issue fixed, and even more!!!
>> every
merged
thank you
Le jeudi 16 novembre 2017, 22:46:54 CET Arnaud Héritier a écrit :
> +1
>
> On Thu, Nov 16, 2017 at 11:48 AM, Robert Scholte
>
> wrote:
> > +1
> >
> >
> >
> > On Thu, 16 Nov 2017 18:24:09 +0100, Hervé BOUTEMY
> > wrote:
> >
> >
issue fixed, and even more!!!
every issue with rewrite rules are fixed: thenks to Sebb idea, I replaced the
rewrite rules with symlinks
now it's easy to understand (even the mirror script can) and everything works
as expected: no more /components redirection when you forgot trailing / on a
Thanks for picking this up and the great results!
Robert
On Sun, 19 Nov 2017 18:59:00 +0100, Hervé BOUTEMY
wrote:
issue fixed, and even more!!!
every issue with rewrite rules are fixed: thenks to Sebb idea, I
replaced the
rewrite rules with symlinks
now it's
Github user asfgit closed the pull request at:
https://github.com/apache/maven/pull/136
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860059
--- Diff: maven-surefire-plugin/src/site/markdown/java9.md ---
@@ -17,15 +17,6 @@ specific language governing permissions and limitations
under
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
I had to prefer pushing my commit regarding Jigsaw modularity supported in
Surefire project because it was too big to merge after yours. Please create a
new PR with your changes.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Try to name the PR like this ([] brackets):
[SUREFIRE-1424] javax.transaction.TransactionManager not visible with Java9
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860152
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
---
@@ -78,12 +83,13 @@ public void
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
It was done. But I don't think you can easily rebase it since some classes
were deleted or methods moved.
---
-
To
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
Did you test it with Ubuntu UTF-8 and on Windows with encoding 1252 and
with special characters and some language dialects as well?
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/170
@claycephas
Nice! Please create Jira ticket and rename this PR to format:
[SUREFIRE-]
---
-
To unsubscribe,
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/169
Thx for your effort but we have to wait for this till the version 3.0.
The branch will have more merge conflicts. Please rebase this in few months
when we will be about develop 3.0.
---
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860070
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
---
@@ -78,12 +83,13 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860088
--- Diff: maven-surefire-plugin/src/site/markdown/java9.md ---
@@ -17,15 +17,6 @@ specific language governing permissions and limitations
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Sure, I will rebase once you merged your big changes
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For
GitHub user chonton opened a pull request:
https://github.com/apache/maven-plugins/pull/138
MDEPLOY-226: DeployAtEnd fails when module has extension
MDEPLOY-225: DeployAtEnd fails when overriding skip
MDEPLOY-224: Overriding deployAtEnd fails
You can merge this pull request
18 matches
Mail list logo