[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...

2017-11-19 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/maven-surefire/pull/168 No problem, the change was minimal, I will start from scratch --- - To unsubscribe, e-mail:

Re: Download links

2017-11-19 Thread Arnaud Héritier
Good. Thanks a lot On Sun, Nov 19, 2017 at 8:35 PM, Robert Scholte wrote: > Thanks for picking this up and the great results! > > Robert > > > On Sun, 19 Nov 2017 18:59:00 +0100, Hervé BOUTEMY > wrote: > > issue fixed, and even more!!! >> every

Re: merging MNG-6302 to master

2017-11-19 Thread Hervé BOUTEMY
merged thank you Le jeudi 16 novembre 2017, 22:46:54 CET Arnaud Héritier a écrit : > +1 > > On Thu, Nov 16, 2017 at 11:48 AM, Robert Scholte > > wrote: > > +1 > > > > > > > > On Thu, 16 Nov 2017 18:24:09 +0100, Hervé BOUTEMY > > wrote: > > > >

Re: Download links

2017-11-19 Thread Hervé BOUTEMY
issue fixed, and even more!!! every issue with rewrite rules are fixed: thenks to Sebb idea, I replaced the rewrite rules with symlinks now it's easy to understand (even the mirror script can) and everything works as expected: no more /components redirection when you forgot trailing / on a

Re: Download links

2017-11-19 Thread Robert Scholte
Thanks for picking this up and the great results! Robert On Sun, 19 Nov 2017 18:59:00 +0100, Hervé BOUTEMY wrote: issue fixed, and even more!!! every issue with rewrite rules are fixed: thenks to Sebb idea, I replaced the rewrite rules with symlinks now it's

[GitHub] maven pull request #136: [MNG-6302] logging the module count

2017-11-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/136 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...

2017-11-19 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/168#discussion_r151860059 --- Diff: maven-surefire-plugin/src/site/markdown/java9.md --- @@ -17,15 +17,6 @@ specific language governing permissions and limitations under

[GitHub] maven-surefire issue #168: SUREFIRE-1424 javax.transaction.TransactionManage...

2017-11-19 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 I had to prefer pushing my commit regarding Jigsaw modularity supported in Surefire project because it was too big to merge after yours. Please create a new PR with your changes. ---

[GitHub] maven-surefire issue #168: SUREFIRE-1424 javax.transaction.TransactionManage...

2017-11-19 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 Try to name the PR like this ([] brackets): [SUREFIRE-1424] javax.transaction.TransactionManager not visible with Java9 ---

[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...

2017-11-19 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/168#discussion_r151860152 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java --- @@ -78,12 +83,13 @@ public void

[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...

2017-11-19 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 It was done. But I don't think you can easily rebase it since some classes were deleted or methods moved. --- - To

[GitHub] maven-surefire issue #167: Speedup Standard Output if Tests

2017-11-19 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/167 Did you test it with Ubuntu UTF-8 and on Windows with encoding 1252 and with special characters and some language dialects as well? ---

[GitHub] maven-surefire issue #170: Clarified specifying multiple categories

2017-11-19 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/170 @claycephas Nice! Please create Jira ticket and rename this PR to format: [SUREFIRE-] --- - To unsubscribe,

[GitHub] maven-surefire issue #169: [SUREFIRE-1405] Allows user to extend RunOrder & ...

2017-11-19 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/169 Thx for your effort but we have to wait for this till the version 3.0. The branch will have more merge conflicts. Please rebase this in few months when we will be about develop 3.0. ---

[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...

2017-11-19 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/168#discussion_r151860070 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java --- @@ -78,12 +83,13 @@ public void

[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...

2017-11-19 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/168#discussion_r151860088 --- Diff: maven-surefire-plugin/src/site/markdown/java9.md --- @@ -17,15 +17,6 @@ specific language governing permissions and limitations

[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...

2017-11-19 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/maven-surefire/pull/168 Sure, I will rebase once you merged your big changes --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For

[GitHub] maven-plugins pull request #138: MDEPLOY-226: DeployAtEnd fails when module ...

2017-11-19 Thread chonton
GitHub user chonton opened a pull request: https://github.com/apache/maven-plugins/pull/138 MDEPLOY-226: DeployAtEnd fails when module has extension MDEPLOY-225: DeployAtEnd fails when overriding skip MDEPLOY-224: Overriding deployAtEnd fails You can merge this pull request