Re: ITs in maven-release

2019-07-14 Thread Tibor Digana
Hi Clemens, Simply I am using JDK 1.7.0_80-b15 and our Jenkins also has this version. I could not find and download later update of JDK 1.7 neither the Update 131. So that's maybe the reason why I recommended to use TLS 1.2 in the system property. Our build system also specifies the property only

Re: Naming of ITs in maven-release

2019-07-14 Thread Olivier Lamy
Hi I agree the name is a bit confusing... maybe name the IT: MRELEASE-229-RemoveScmTagPhase? On Sun, 14 Jul 2019 at 20:06, Clemens Quoss wrote: > Hello everyone, > > one more question regarding the name of the ITs in maven-release (or > maybe generally): > > Seeing that the tests are named

Re: ITs in maven-release

2019-07-14 Thread Clemens Quoss
Hi Tibor, with this system property set it works with JDK 7. Why is it a pre-requisite?  It works with JDK 7 Update 80 that has no backport for TLS 1.2.  It came with Update 131 [1]. Are you simply running all the IT on your side with this system property set when using JDK 7?  What Update of

Re: ITs in maven-release

2019-07-14 Thread Tibor Digana
Did you already run the build like this on J7? mvn verify -P run-its -Dhttps.protocols=TLSv1.2 and you have got those errors as in previous email? Cheers Tibor On Sun, Jul 14, 2019 at 6:32 PM Clemens Quoss wrote: > Hi Tibor, > > by looking further into it I noticed this: > >

Re: ITs in maven-release

2019-07-14 Thread Clemens Quoss
Hi Tibor, by looking further into it I noticed this: MRELEASE-459/build.log (JDK 7): ... [DEBUG] Additional arguments: -Dhttps.protocols=null -P custom-release -DperformRelease=true -f pom.xml ... MRELEASE-459/build.log (JDK 8): ... [DEBUG] Additional arguments: -P custom-release

Re: ITs in maven-release

2019-07-14 Thread Tibor Digana
Hi Clemens, I think you are right, I also have to add -Dhttps.protocols=TLSv1.2 in to CLI when using J7. The Jenkinsfile does it [1] already but we should investigate the ITs and add TLS in CLI of the ITs as well unless it's in there. [1]:

Re: ITs in maven-release

2019-07-14 Thread Enrico Olivelli
Il dom 14 lug 2019, 11:52 Clemens Quoss ha scritto: > Hello everyone, > > I have provided a PR for MRELEASE-229 [1] and added some JUnit tests > recently. > > Now I was wondering if i should provide an IT, too, and had a look into it: > > Running > > mvn verify -Prun-its > > with Maven 3.6.1 and

Naming of ITs in maven-release

2019-07-14 Thread Clemens Quoss
Hello everyone, one more question regarding the name of the ITs in maven-release (or maybe generally): Seeing that the tests are named after the jira issues i am wondering if that would be the right thing to do. Shouldn't they be named after the functionality they are testing? I for my

ITs in maven-release

2019-07-14 Thread Clemens Quoss
Hello everyone, I have provided a PR for MRELEASE-229 [1] and added some JUnit tests recently. Now I was wondering if i should provide an IT, too, and had a look into it: Running mvn verify -Prun-its with Maven 3.6.1 and JDK 7 Update 80 fails: ... [INFO] Building: