Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Robert Scholte
On Sat, 19 Oct 2019 02:25:47 +0200, Jason van Zyl wrote: Inline: On Oct 18, 2019, at 5:15 PM, Stuart McCulloch wrote: Any string apart from "default" or the empty string will work here - I happened to chose "core" because I viewed it as a core implementation. Also a quick reminder that th

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Hervé BOUTEMY
+1 just added a comment on a typo for the name of the component, perhaps "core-default", but I won't complain about any choice: the javadoc is what was really needed notice: perhaps we have other component that should have the same improvement to permit overriding in the future Regards, Hervé

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Tibor Digana
Are you talking about @Named( “not-default” ) @Named( “coreAllowingOverride” ) or @Named( “coreExtensionPoint” )? In Java EE (and these annotations are from Java EE application servers) mean the name of the bean which is unique - it is not a group of beans. Please notice that beans container is Ma

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Stuart McCulloch
OK, so this rabbit-hole is exactly what I wanted to avoid and which is why I added a detailed description in the original patch (and not just the annotation change) To clarify: plugins and extensions can already override any component, because their baseline priority is always higher than maven c

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Stuart McCulloch
@Named is not specific to Java EE, it's from JSR 330 which actually targets Java SE (and there are many SE based containers that support it) All @Named does is give a component an identity in the container (think of @Named like the hint in Plexus [1]) so it can be referenced by that name elsewhere

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Tibor Digana
Stuart, you are wrong. It is no more Java SE It is JakartaEE ans if you want to obey wrong design of Java SE go for it but then Maven would become a mess of Java EE annotations in non-EE container. Do you understand that @Name represents a key in the container? And how can you create a string like

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Robert Scholte
Tibor, please lower your voice. You're turning this topic into an unnecessary fight. We're solving a regression introduced in 3.6.2. Stuart was able to identify the problem, provide the fix and clearly explain what happened. Code has been review, fix is confirmed, so we're good to go. So don't

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Tibor Digana
Robert we suffer from bad design in Maven. There is Jira issue where Maven accepted these annotation maybe because they are so famous and I do not remember if we had any Vote for this significant change. If there was a Vote I would vote -1 and I would explain why. We can talk about it in the confer

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Enrico Olivelli
+1 Thank you Stuart Maybe it would be better to add a test case so that we want break this so-called corner-case in the future. side note: if we create pull requests it is easier to review changes Enrico Il giorno ven 18 ott 2019 alle ore 20:04 Robert Scholte < rfscho...@apache.org> ha scritto:

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Robert Scholte
Tibor, you're doing it again. The title of this topic is "Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)" and none of your comments helped on that, i.e. trying to move it forward. Based on your reply you should a new discussion on the mailinglist. Robert ps. I won't

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

2019-10-19 Thread Tibor Digana
I am trying to explain to you in second thread that removing Guice will remove all related issues. On Sat, Oct 19, 2019 at 5:09 PM Robert Scholte wrote: > Tibor, > > you're doing it again. The title of this topic is "Second MNG-6765 > ([Regression] tycho pom-less builds fails with 3.6.2)" and no

[VOTE] Release Apache Maven Archiver version 3.5.0

2019-10-19 Thread Hervé BOUTEMY
Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12345174&styleName=Text Staging repo: https://repository.apache.org/content/repositories/maven-1531/ https://repository.apache.org/content/repositories/maven-1531/org/apache/maven/maven-a

Re: [VOTE] Release Apache Maven Archiver version 3.5.0

2019-10-19 Thread Tibor Digana
+1 On Sat, Oct 19, 2019 at 7:41 PM Hervé BOUTEMY wrote: > Hi, > > We solved 6 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12345174&styleName=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-1531/ > > https://repos

Re: Did you see dependabot?

2019-10-19 Thread Tibor Digana
The dependabot looks interesting, cli has more possibilities than a pure button on GUI. >> does anyone enabled it I am all the ear how it can be enabled. On Fri, Oct 18, 2019 at 3:32 PM Enrico Olivelli wrote: > Hey guys, > Did you see dependabot on our repos? > > Like this automatic PR > > https

Re: [VOTE] Release Apache Maven Archiver version 3.5.0

2019-10-19 Thread Karl Heinz Marbaise
Hi Hervé, +1 from me. Kind regards Karl Heinz Marbaise On 19.10.19 19:40, Hervé BOUTEMY wrote: Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12345174&styleName=Text Staging repo: https://repository.apache.org/content/repositories/mav

Re: Did you see dependabot?

2019-10-19 Thread Enrico Olivelli
I see value in it. But from a legal point of viewthere is no human who sends the PR, so in theory we cannot accept such patches, can we? Enrico Il sab 19 ott 2019, 20:26 Tibor Digana ha scritto: > The dependabot looks interesting, cli has more possibilities than a pure > button on GUI. > >>

Re: Did you see dependabot?

2019-10-19 Thread Paul Hammant
Pretty sure that small changes that could not be done any other way are not subject to copyright claims. s/1.199/1.200/g ^ Being an example. On Sat, Oct 19, 2019 at 7:51 PM Enrico Olivelli wrote: > I see value in it. > But from a legal point of viewthere is no human who sends the PR, so in

Re: [VOTE] Release Apache Maven Archiver version 3.5.0

2019-10-19 Thread Romain Manni-Bucau
+1 Le sam. 19 oct. 2019 à 20:31, Karl Heinz Marbaise a écrit : > Hi Hervé, > > +1 from me. > > Kind regards > Karl Heinz Marbaise > On 19.10.19 19:40, Hervé BOUTEMY wrote: > > Hi, > > > > We solved 6 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=

Re: [VOTE] Release Apache Maven Archiver version 3.5.0

2019-10-19 Thread Sylwester Lachiewicz
+1 sob., 19 paź 2019 o 21:06 Romain Manni-Bucau napisał(a): > +1 > > Le sam. 19 oct. 2019 à 20:31, Karl Heinz Marbaise a > écrit : > > > Hi Hervé, > > > > +1 from me. > > > > Kind regards > > Karl Heinz Marbaise > > On 19.10.19 19:40, Hervé BOUTEMY wrote: > > > Hi, > > > > > > We solved 6 issue

Re: [jira] [Updated] (MSHARED-841) Upgrade Commons Collections to 4.2

2019-10-19 Thread Robert Scholte
Maybe it is me, be I don't think having a separate jira issue for every updated dependency adds value. It makes the release notes unnecessary long (in a time where people already are bad readers). As a user I expect dependency updates to be part of every release. 1 Jira item would be good enou

Re: [jira] [Updated] (MSHARED-841) Upgrade Commons Collections to 4.2

2019-10-19 Thread Sylwester Lachiewicz
Yes Robert, thank you for the suggestions - more changes of this type will be combined. Sylwester sob., 19 paź 2019 o 22:32 Robert Scholte napisał(a): > Maybe it is me, be I don't think having a separate jira issue for every > updated dependency adds value. > It makes the release notes unnecessa

Re: [jira] [Updated] (MSHARED-841) Upgrade Commons Collections to 4.2

2019-10-19 Thread Eric Lilja
On 2019-10-19 23:55, Sylwester Lachiewicz wrote: I always read the release notes very carefully and I don't mind seeing individual JIRA's per upgrade, even if does increase the length of the release notes. I guess others only want to see features and possibly bug fixes. Personally I like detai