Hi,
maven-site-plugin has a dependency on sisu-inject-plexus [1] but it
doesn't seem to be used. The project still builds and the tests pass
without it.
Is it safe to assume it can be removed?
Emmanuel Bourg
[1]
What does maven dependency:analyze say?
On Tue, Feb 9, 2021 at 2:25 PM Emmanuel Bourg wrote:
>
> Hi,
>
> maven-site-plugin has a dependency on sisu-inject-plexus [1] but it
> doesn't seem to be used. The project still builds and the tests pass
> without it.
>
> Is it safe to assume it can be
elharo opened a new pull request #36:
URL: https://github.com/apache/maven-site-plugin/pull/36
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Seems maven dependency:analyze thinks we need this one. At least it
doesn't call it out as unused:
[WARNING] Used undeclared dependencies found:
[WARNING]javax.servlet:javax.servlet-api:jar:3.1.0:compile
[WARNING] Unused declared dependencies found:
[WARNING]
Sorry, but I have to clarify this "Plexus et al is one of the reasons..."
misleading statement:
It is not Plexus per se THE reason, but the "neglected and stale"
dependencies, or better "dependencies like these"...
T
On Tue, Feb 9, 2021 at 5:38 PM Tamás Cservenák wrote:
> Howdy,
>
> my 5
Project used class like org.codehaus.plexus.PlexusContainer
We can remove direct dependency because we have transitive dependency
from other artifacts - of course we needn't remove it.
[INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @
maven-site-plugin ---
[WARNING] Using Maven 2
Howdy,
my 5 cents:
Something is stale, very stale in there, as plexus-container-default was
abandoned about 10 (maybe 12?) years ago, and sisu "shim"
(sisu-inject-plexus) was created as the direct replacement (as functional
and as API).
If your project has Plexus "the old container"
PlexusContainer is used by AbstractDeployMojo: it's a good thing to keep an
explicit direct dependency, even if it's also a transitive
on this class being both in plexus-container and sisu-inject, it's because
sisu-inject is meant to be a replacement: it's not a bug, it's a feature
on runtime
