Re: [DISCUSS] Automatically format and sort imports

2022-10-14 Thread Łukasz Dywicki
Hello Tomas and Guillaume, On 13.10.2022 20:58, Tamás Cservenák wrote: Agree, it does overhead, just like checkstyle (already present) does, but trust me, minimal overhead (please try some of the PRs). I might be overreacting about making it default, cause openhab does also static code

Re: [DISCUSS] Automatically format and sort imports

2022-10-14 Thread Delany
Can I answer that? Because devs are principled, and the thought of the build changing source is anathema. In practice it happens with versions, release, sortpom plugins so why not format too. Personally I draw the line at commit time. But crickey, in Golang you cant even save an incorrectly

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

2022-10-14 Thread Martin Kanters
Hello, I agree with Tamás and Maarten. I'm sure I can convince people around me to start using and testing Maven 4 (locally) when it's in alpha, but they would be reluctant if it's a SNAPSHOT. Cheers, Martin Op wo 12 okt. 2022 om 10:01 schreef Tamás Cservenák : > Howdy, > > +1 for release

Re: [DISCUSS] Automatically format and sort imports

2022-10-14 Thread Guillaume Nodet
So here's my new proposal. I've already merged the two first PRs which did not change anything, as they were just about moving the existing resources (eclipse and intellij xml config) from the website to maven-shared and updating the website. I've updated the two interesting PRs to use spotless,

[VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-14 Thread Guillaume Nodet
I've staged a release candidate at https://repository.apache.org/content/repositories/maven-1811 The binaries are available at: https://repository.apache.org/service/local/repositories/maven-1811/content/org/apache/maven/apache-maven/4.0.0-alpha-2/ The tag is available at:

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

2022-10-14 Thread Gary Gregory
Why are you bumping the version if it failed? Gary On Fri, Oct 14, 2022, 18:13 Guillaume Nodet wrote: > Just FYI, I've attempted to release 4.0.0-alpha-1, but it failed. I'll try > to cut another version once the problems are resolved. So 4.0.0-alpha-1 is > a burnt version and next attempt

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

2022-10-14 Thread Guillaume Nodet
Just FYI, I've attempted to release 4.0.0-alpha-1, but it failed. I'll try to cut another version once the problems are resolved. So 4.0.0-alpha-1 is a burnt version and next attempt will be 4.0.0-alpha-2. Stay tuned ! Le lun. 10 oct. 2022 à 22:32, Guillaume Nodet a écrit : > The master

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

2022-10-14 Thread Guillaume Nodet
The release:prepare has succeeded but the release:perform failed. Hence, the tag has been created on github and can't be deleted. Le sam. 15 oct. 2022 à 00:26, Gary Gregory a écrit : > Why are you bumping the version if it failed? > > Gary > > On Fri, Oct 14, 2022, 18:13 Guillaume Nodet wrote:

Re: [DISCUSS] Change maven code style

2022-10-14 Thread Jochen Wiedmann
Hi, Guillaume, rather than suggesting (and, what's worse: discussing) code change details: Is there, by any change, an existing code style, that we might adopt? In particular.could we reuse tools, like an Eclipse fornatter, and the like? Apart from that, I'd be more than happy about the changes,