Re: svn commit: r1125604 - /maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java

2011-05-21 Thread Dennis Lundberg
Excellent stuff Stephen, thanks. We should try to get this into a release as soon as possible. On 2011-05-21 02:21, steph...@apache.org wrote: Author: stephenc Date: Sat May 21 00:21:26 2011 New Revision: 1125604 URL: http://svn.apache.org/viewvc?rev=1125604view=rev Log: No point sitting

Re: svn commit: r1125604 - /maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java

2011-05-21 Thread Anders Hammar
But the groupId of Apache Maven plugins is org.apache.maven.plugins. The code checks against org.apache.maven.plugin... /Anders On Sat, May 21, 2011 at 10:26, Dennis Lundberg denn...@apache.org wrote: Excellent stuff Stephen, thanks. We should try to get this into a release as soon as

Re: svn commit: r1125604 - /maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java

2011-05-21 Thread Dan Tran
good catch Anders, wonder what is the original intention of that code :-) -Dan On Sat, May 21, 2011 at 10:28 AM, Anders Hammar and...@hammar.net wrote: But the groupId of Apache Maven plugins is org.apache.maven.plugins. The code checks against org.apache.maven.plugin... /Anders On Sat,

Re: svn commit: r1125604 - /maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java

2011-05-21 Thread Karl Heinz Marbaise
Hi, just a question about that... does this mean that in the future a Maven Plugin is not allowed to be named like: maven-WhatEverThisIs-plugin ? Based on the given code this means that future plugin developers have to change their plugin names into WhatEverThisIs-maven-plugin... Is this

Re: svn commit: r1125604 - /maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java

2011-05-21 Thread Mark Struberg
Actually this is the recommendation since years. I'm sure this was discussed a few times in the past already. Remember, maven-jetty-plugin got renamed to jetty-maven-plugin exactly because of that. But yes, this piece of source was pretty useless the way it got implemented... LieGrue, strub

Re: svn commit: r1125604 - /maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java

2011-05-21 Thread Stephen Connolly
1. yes there is a typo. as soon as I am at a pc the typo will be fixed. 2. the pmc is permitting persons who develop plugins for maven to use the mark maven in their plugin name provided the name and its usage meets certain criteria, amongst which is the ___ maven plugin naming scheme. we will be