Re: svn commit: r1690282 - /maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/usage.apt.vm

2015-07-10 Thread Benson Margulies
You might also mention the interaction with generated code. On Fri, Jul 10, 2015 at 12:07 PM, wrote: > Author: dkulp > Date: Fri Jul 10 16:07:30 2015 > New Revision: 1690282 > > URL: http://svn.apache.org/r1690282 > Log: > Add a note about the difference in behavior when checkstyle is configured

[GitHub] maven-plugins pull request: Suggest using verify phase for Checkst...

2015-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-plugins/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-07-10 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/57#issuecomment-120431206 My preferred strategy is to resolve only released versions within a version range (```"onlyReleases"```). If a developer needs a SNAPSHOT version, it is possible to insert

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-07-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/57#issuecomment-120428315 And so what strategy are you going to implement? I realized you've made it a strategy but that doesn't negate potential for problematic issues. I'm just trying to determin

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-07-10 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/57#issuecomment-120420443 The `org.eclipse.aether.resolution.VersionRangeRequest` contains the artifact . If you implement an odd/even version range resolver strategy only for your artifac

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-07-10 Thread ifedorenko
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/57#issuecomment-120415902 What will happen when projects using new/custom version range resolution strategy are deployed to shared repository like Central? Won't this break consumers of project

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-07-10 Thread barthel
GitHub user barthel opened a pull request: https://github.com/apache/maven/pull/57 MNG-3092: Add strategy based version range resolver. The discussion on issue [MNG-3092](https://issues.apache.org/jira/browse/MNG-3092) shows the seriously needs of different kinds of version range r

[GitHub] maven pull request: MNG-3092: strategy based version resolver

2015-07-10 Thread barthel
Github user barthel closed the pull request at: https://github.com/apache/maven/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] maven pull request: MNG-3092: strategy based version resolver

2015-07-10 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/56#issuecomment-120301859 I'll open a new pull request with a stashed commit and more explanation. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

RE: Maven structure plugin

2015-07-10 Thread Sander Verhagen
Did you know there is an annotation-based way to specify the details of your mojos, instead of using the Javadoc. It's interesting that you include a junit dependency, yet there's not a single test. I commend everyone writing Maven plugins, though! Go, Maven! Did you have a specific use case in