[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-25 Thread kgyrtkirk
Github user kgyrtkirk commented on the pull request: https://github.com/apache/maven-surefire/pull/113#issuecomment-221739676 I've used `Pattern.compile` to keep the regexp's problem description; i thinked it makes it more clear how it will be used eventually. I picked `TestLi

[GitHub] maven pull request: Fixing misspellings in test names

2016-05-25 Thread august782
GitHub user august782 opened a pull request: https://github.com/apache/maven/pull/84 Fixing misspellings in test names Similar to Pull Request #83, I found more test names I believe are misspelled, and this pull request simply addresses those misspellings. You can merge this pull r

[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-25 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/113#discussion_r64666590 --- Diff: surefire-api/src/main/java/org/apache/maven/surefire/testset/TestListResolver.java --- @@ -479,6 +481,27 @@ else if ( hasMethod )

[GitHub] maven pull request: MNG-5288 prevent NPE, not all ProjectBuildingE...

2016-05-25 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/52#issuecomment-221695504 @mkleint If you have a working example upload it to the JIRA issue and request for reopening. I will take a look. Otherwise close this PR. --- If your project is set up

[GitHub] maven pull request: Mac OS X - way of getting JAVA_HOME location

2016-05-25 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/31#issuecomment-221695023 Please close this PR. the shell script has been drastically reduced and your change isn't mergeable anymore. --- If your project is set up for it, you can reply to this

[GitHub] maven pull request: Fixing misspellings in test names (Progessed t...

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: Fixing misspellings in test names (Progessed t...

2016-05-25 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/83#issuecomment-221693034 Merged, please close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [VOTE] Release Apache Maven Parent POMs version 30

2016-05-25 Thread Karl Heinz Marbaise
Hi Hervé, On 5/25/16 9:18 PM, Hervé BOUTEMY wrote: as the comment says , since the version is already set in Apache parent, what is the issue? The issue was that I didn't read carefully...sorry ... And is really a Jira issue necessary for removing such temporary local update in maven-paren

Re: [VOTE] Release Apache Maven Parent POMs version 30

2016-05-25 Thread Hervé BOUTEMY
same as gpg plugin: configuration is now in ASF parent Regards, Hervé Le mardi 24 mai 2016 21:15:08 Karl Heinz Marbaise a écrit : > Hi, > > an other thing which i see is that the supplemental configuration for > apache-rat-plugin: > > > > >

Re: [VOTE] Release Apache Maven Parent POMs version 30

2016-05-25 Thread Hervé BOUTEMY
as the comment says , since the version is already set in Apache parent, what is the issue? And is really a Jira issue necessary for removing such temporary local update in maven-parent? Regards, Hervé Le mardi 24 mai 2016 21:03:45 Karl Heinz Marbaise a écrit : > Hi, > > one question: > > Is

[GitHub] maven pull request: Fixing misspellings in test names (Progessed t...

2016-05-25 Thread august782
GitHub user august782 opened a pull request: https://github.com/apache/maven/pull/83 Fixing misspellings in test names (Progessed to Progressed) I noticed that there seem to be some misspellings in the test names in this test class (along with some similar misspellings in local vari

[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...

2016-05-25 Thread eddiewebb
Github user eddiewebb commented on the pull request: https://github.com/apache/maven-scm/pull/44#issuecomment-221606935 @olamy @rodrigc @msperisen - I also submitted https://github.com/apache/maven-scm/pull/45 around the same time for similar issue with native git client. --- If you

[GitHub] maven-scm pull request: [FIX] allow jgit provider to work with bui...

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-scm/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] maven-scm pull request: [FIX] allow jgit provider to work with bui...

2016-05-25 Thread olamy
Github user olamy commented on the pull request: https://github.com/apache/maven-scm/pull/48#issuecomment-221550605 issue SCM-825 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] maven-scm pull request: Adding mavenHome to Bootstrap

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-scm/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

Re: [1/2] maven-scm git commit: [SCM-824] Upgrade of 'plexus-utils' to 3.0.23.

2016-05-25 Thread Olivier Lamy
Hi This change has generated a lot of test failure. command line generation is really different. And I don't have all the tools to test this change Thanks Olivier On 6 May 2016 at 12:05, wrote: > Repository: maven-scm > Updated Branches: > refs/heads/master ff63ef9a3 -> 9f30e46c6 > > > [S

[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-scm/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en