[GitHub] maven-surefire pull request #121: Fix for issue SUREFIRE-1278

[khospodarysko]

Github user khospodarysko closed the pull request at:

https://github.com/apache/maven-surefire/pull/121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

[britter]

Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
@Tibor17 you have to follow the workflow described 
[here](http://wiki.apache.org/commons/UsingGIT#Applying_Pull_Requests_.28for_git_based_components.29).
 It's not possible to merge using the UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
>>Did you know, that it is possible to mark PRs as merged in GitHub?
I don't see such option in GUI. Is not it because of we are not the owner 
of this repo `apache`?
Maybe they sould make be ASF member, however I am in ASF Maven group.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [SUREFIRE] Branch for JUnit 5 integration?

[Benedikt Ritter]

Hello,

the branch with the first JUnit 5 IT is ready for reintegration. My
proposal is to create a separate branch for working on JUnit 5 so that we
can merge it to master only when all work on JUnit 5 support is done.

Regards,
Benedikt

Tibor Digana  schrieb am Mo., 12. Sep. 2016 um
01:13 Uhr:

> ok, go on with the branch but then please create CI job in
> https://builds.apache.org/job/maven-surefire/.
> We will nicely see how the branch is still in green.
> I want to be brief. I understand that this work takes private time, I was
> idle for cca 5 months in Surefire and recovered recently. Many colleagues
> in Maven are idle for years and only send some emails but these emails move
> us ahead which is positive as well.
>
> On Sat, Sep 10, 2016 at 2:49 PM, Benedikt Ritter [via Maven] <
> ml-node+s40175n5880358...@n5.nabble.com> wrote:
>
> > Hi,
> >
> > I'm currently a bit stuck with the JUnit 5 integration, because I don't
> > really know where it should be going. At first I thought we should just
> > merge the Integration tests I'm about to write directly to master. But
> > maybe that's not the best idea. But I don't want to implement the whole
> > thing in my fork as well since this will lead to a unmanagable huge
> change
> > set when it will be reintegrated. So my proposal is to create a separate
> > branch in the maven-surefire repo I can open PRs against. This way I can
> > iteratively add more stuff in small chucks but is does not land directly
> > on
> > master.
> >
> > WDYT?
> >
> > Regards,
> > Benedikt
> >
> >
> > --
> > If you reply to this email, your message will be added to the discussion
> > below:
> > http://maven.40175.n5.nabble.com/SUREFIRE-Branch-for-JUnit-
> > 5-integration-tp5880358.html
> > To start a new topic under Maven Developers, email
> > ml-node+s40175n142166...@n5.nabble.com
> > To unsubscribe from Maven Developers, click here
> > <
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code=142166=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==
> >
> > .
> > NAML
> > <
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer=instant_html%21nabble%3Aemail.naml=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> >
> >
>
>
>
>
> --
> View this message in context:
> http://maven.40175.n5.nabble.com/Re-SUREFIRE-Branch-for-JUnit-5-integration-tp5880473.html
> Sent from the Maven Developers mailing list archive at Nabble.com.

[GitHub] maven-surefire issue #118: Add basic integration test for JUnit 5

[britter]

Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/118
  
@Tibor17 I've assed the assume statement using the API introduced in #120. 
I propose that you create a new branch for JUnit 5, where we can merge this PR 
and all follow up PRs for JUnit 5 integration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #120: Add convinient method to check for the cur...

[britter]

Github user britter closed the pull request at:

https://github.com/apache/maven-surefire/pull/120


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

[britter]

Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
@Tibor17 thank you for integrating this. Did you know, that it is possible 
to mark PRs as merged in GitHub? I've documented the workflow in the [Apache 
Commons 
Wiki](http://wiki.apache.org/commons/UsingGIT#Applying_Pull_Requests_.28for_git_based_components.29).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org