Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-05 Thread Tibor Digana
Hello guys,

Sorry for late reply.
I do not want to remove your work from the commit - it's not fair to anyone
and therefore I would like to open PR at GitHub and I would like to amend
the commit with my proposal and *you guys feel free to comment on the PR -
everybody is welcome*.
I understand that this takes your and my spare time but that's the only way
we can friendly continue.
In my experiences the professionals must communicate in code review and
however they have good technical understanding always they may have
different decisions and consensus is the only way we will coexist.

:) I will send you link in GitHub in a day.

I see we will make good job together!





On Mon, Jan 2, 2017 at 3:42 PM, Tibor Digana  wrote:

> I also have such feeling that Maven became a playground.
> Last week I saw it in reality and after Robert told me we made playground
> in our sources I could not believe this could happen in such professional
> project like Maven.
>
> I would appreciate it if the change [1] 
> e5a6b9c8d4f514100a01dea2acf1fb059e294968
> was reverted in Surefire and a new pull request was open at GitHub making
> the code review.
> I use to do this with myself with big changes and I am waiting for anyone
> in the PR. We are doing the same with one excellent guy from another ASF
> project who is supporting us with JUnit 5 addons and this works pretty well.
>
> The situation in Surefire is quite ambitious to release Versions 2.19.2
> and 3.0.0-RC1 in parallel with 2.19.3 JDK9 support and JUnit 5 support now
> in January.
>
> The problem is that these Surefire three plugins are so easy to crash with
> whatever changes and therefore I implemented dumping internal errors to
> dump files which will help us investigate two Jira issues - critical and
> blocker. And there are much more thinks to talk about the features...
>
> I would really appreciate if we could behave like ordinal users in our
> project and provide a pull request in GitHub and call for code review.
> This does not mean only Surefire.
>
> So now please revert last change [1] and let's start from the ground.
> We should again learn from the beginning and start communicating in the
> community; otherwise this is the end of the project.
>
> [1] https://git1-us-west.apache.org/repos/asf?p=maven-
> surefire.git=commit=e5a6b9c8d4f514100a01dea2acf1fb059e294968
>
> We can talk about more visions, or I can open Wiki for such talks which I
> think we will appreciate because everybody can add her/his visions.
>
> WDYT?
>
> Cheers
> Tibor
>


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-05 Thread Robert Scholte

Regarding the proposed changes:

Stephen Connolly:
MNG-5823 - mvnDebug doesn't work with M2_HOME with spaces - missing quotes

is this one superseded by MNG-5607?

MNG-5837 - Syntax error in bin/mvn on Solaris SPARC

Cannot confirm

MNG-5904 - Remove the whole Ant Build

I'd say 3.5.1

MNG-5967 - Dependency updates.
There's no list, so it's unclear which have been updated (and if some  
are for a specific fix)

MNG-5968 - Default plugin version updates.

 We've starting moving these versions to there matching packaging plugin

MNG-6150 - Javadoc improvements for 3.5.0

This one is fine for 3.5.0


Christian Schulte:
All have comments from Stephen, which I agree on

Guillaume Boué:
None issues left

Michael Osipov:
MNG-5457 - Show repository id when downloading or uploading from/to a  
remote repository
Based on some commits it seems like some build.log files are verified  
on these lines. Will require a bit more work, so 3.5.1 for me

MNG-5567 - Zip files are not included in classpaths at all
True according to specs, but hardly ever seen this as an issue. I'd  
like to push this to 5.0.0 and combine it with the PDT files. I have  
some more usecases

MNG-6136 - Upgrade Maven Wagon to 2.11
I don't see critical issues and IMHO the period is too short that 2.11  
has proven itself
MNG-6137 - Clean up duplicate dependencies caused by incomplete Wagon HTTP  
Provider exclusions

depends on MNG-6136


Hervé Boutemy:
It seems that all issues have to do with expanding URLs and connections.  
Right now there's business logic in the ModelBuilder to calculate such  
values. We already had some discussions about this :) My question is: is  
this really necessary for the effective pom or are the related plugins  
(m-site-p, m-release-p, etc) capable to calculate it? For the SCM  
connections it is quite clear for that the SCM provider should  
(re)-calculate the connection, and don't use the SVN concept as done right  
now (in fact, you can find scm-specific hacks in the code)
I really hope it is not necessary to introduce these special properties. I  
have more hope in the distribution-pom or leave the responsibility to the  
plugins using these values. For that reason no 3.5.0 for me.


Robert Scholte
Agree on all, just waiting for others to confirm ;)

Robert

On Sat, 31 Dec 2016 21:10:47 +0100, Stephen Connolly  
 wrote:


Here are the changes in current master since 3.3.9 (with some minor  
changes

omitted)

Issue ID   Target Version   Summary
   ==   
MNG-1577   WONTFIX  dependencyManagement does not work for
transitive dependencies
MNG-2199   WONTFIX  Support version ranges in parent elements
MNG-2478   WONTFIX  add "resources-filtered" filtered resource
directories to super POM
MNG-3507   WONTFIX  added support for multi-lines error message
with color
MNG-3507   WONTFIX  ANSI Color logging for improved output
visibility.
MNG-3705   WONTFIX  fixed mojo execution id color display
MNG-3825   WONTFIX  Dependencies with classifier should not
always require a version.
MNG-4345   WONTFIX  [regression] Plugin executions contributed
by default lifecycle mapping execute after
other plugin executions bound to the same
phase"
MNG-4347   WONTFIX  import-scoped dependencies of direct
dependencies are not resolved using profile
modifications from settings.xml
MNG-4463   WONTFIX  Dependency management import should support
version ranges.
MNG-4645   WONTFIX  Move central repo definition out of Maven's
core so it can be more easily changed.
MNG-5227   WONTFIX  The 'optional' flag of a dependency should
be manageable.
MNG-5297   WONTFIX  improved explanations on prerequisites.maven
in Maven 3
MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
to lifecycle (regression)
MNG-5368   WONTFIX  UnsupportedOperationException thrown when
version range is not correct in
dependencyManagement definitions
MNG-5457   WONTFIX  Show repository id when downloading or
uploading from/to a remote repository
MNG-5527   WONTFIX  Relocation does not work for imported poms
MNG-5538   WONTFIX  mvn start script causes cygwin warning
MNG-5567   WONTFIX  Zip files are not included in classpaths at
all
MNG-5600   WONTFIX  Dependency management import should support
   

Re: FOSDEM 2017

2017-01-05 Thread Arnaud Héritier
Still negotiating at home but I'm trying to be here
AFAIK Hervé won't be able to come

On Thu, Jan 5, 2017 at 2:20 PM, Robert Scholte  wrote:

> Hi,
>
> Just like the last couple of years FOSDEM has been a great opportunity to
> meet several Maven developers.
> Some of the new features and improvements started here when the Maven
> committers shared their ideas.
>
> FOSDEM 2017 will take place at ULB Campus Solbosch on Saturday 4 and
> Sunday 5 February 2017.
> I plan to go this year and I'm wondering who considers to come as well.
>
> thanks,
> Robert
>
> [1] https://fosdem.org/2017/
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
-
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier


FOSDEM 2017

2017-01-05 Thread Robert Scholte

Hi,

Just like the last couple of years FOSDEM has been a great opportunity to  
meet several Maven developers.
Some of the new features and improvements started here when the Maven  
committers shared their ideas.


FOSDEM 2017 will take place at ULB Campus Solbosch on Saturday 4 and  
Sunday 5 February 2017.

I plan to go this year and I'm wondering who considers to come as well.

thanks,
Robert

[1] https://fosdem.org/2017/

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org