Re: Maven Resolver 1.1

[Christian Schulte]

Am 03/15/17 um 23:31 schrieb Hervé BOUTEMY:
> it would be great if MNG-6183 description included a sample debug message 
> before the change and after the change: I can't get what this change is about 
> really

Will update the issue.

> And of course, I don't get the next step with Resolver API...

Just read the Java comments I added in this commit starting with TODO:



The resolver just needs to provide a liddle bit more information to have
those messages complete.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Maven Site vs Reporting Plugin workflows?

[Alex O'Ree]

Hervé thanks for the pointer. The Default Reporting Converter looks
like it reads and normalizes content from the pom's various formats to
the maven model. I don't see anything in that class that would
indicate it converting into
`org.apache.maven.reporting.exec.ReportPlugin` and injecting that into
the maven site plugin (or any other mojo). I'm a bit new to maven
plugin development. Again I'm doing this to try and revitalize the PDF
plugin, which should basically do the same as the maven site plugin
(convert markdown/etc to the output format and run the report
plugins), only the output is to PDF instead.

On Wed, Mar 15, 2017 at 6:20 PM, Hervé BOUTEMY  wrote:
> Hi,
>
> The change is explained here:
> http://maven.apache.org/plugins/maven-site-plugin/maven-3.html
>
> The injection is done in DefaultReportingConverter [1]
>
> At the beginning, the dream was to remove  element from pom.xml:
> then we later found that we could not since this is the only place where
> reporting plugin inheritance can happen (no inheritance in reportPlugin
> parameter of maven-site-plugin).
>
> Then this idea about  removal was abandonned, I took time to
> document the strategy revert as much as possible. But I didn't take time to do
> some cleanup: this parameter that is magically injected by Maven core should
> probably be changed into a classical "${project.reporting}" parameter default
> value.
>
> Regards,
>
> Hervé
>
> [1] http://maven.apache.org/ref/3-LATEST/maven-model-builder/apidocs/org/
> apache/maven/model/plugin/DefaultReportingConverter.html
>
> Le mardi 14 mars 2017, 00:03:45 CET Alex O'Ree a écrit :
>> Hi everyone, I'm trying to troubleshoot an issue with the PDF plugin,
>> https://issues.apache.org/jira/browse/MPDF-62. Root cause seems to be
>> that the reportPlugins:
>> @Parameter( readonly = true )
>> private org.apache.maven.reporting.exec.ReportPlugin[] reportPlugins;
>>
>> are not injected to the Mojo plugin and that at some point in time the
>> behavior had changed. Does anyone know approximately when this
>> occurred or what version the change was in effect?
>>
>> Moving on, I also checked out the maven-site plugin as it performs the
>> same task and found nearly identical code for the parts referring to
>> the reporting plugins, except that when ran, the reportPlugins
>> parameter is populated by maven. I'm not too sure what the delta is
>> here nor do I know where to look, but if anyone has any clues or
>> pointers to what could be wrong or areas to look at it, I'm all ears.
>> Is there perhaps some resource file or magic string in play?
>>
>> Related question, where does the parameter injection happen?
>>
>> Finally, I also didn't find any other references to how the site
>> plugin causes the report plugins to fire off. Is there any good
>> resources that I can read up on the current workflow and/or
>> architecture of all things related to report plugins and site
>> generation?
>>
>> Thanks!
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Distribution file permission issue with current master.

[Christian Schulte]

Am 03/15/17 um 23:37 schrieb Hervé BOUTEMY:
> no issue for me on Linux
> I don't understand what happens to you: I suppose this is once again related 
> to FreeBSD
> I can't do anything for you

Thanks for taking a look. It's happening with the zip distribution only.
It's not happening using the tar distribution. Will take a look at the
assembly plugin for what is going on.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Release build failing with current master (was Re: [PING] The GIT master branch of Maven has unreleased changes that do not pass a release build)

[Stephen Connolly]

Well I'm not feeling 100% atm with the flu, so probably be Monday before I
have the energy for a release

On Wed 15 Mar 2017 at 22:16, Christian Schulte  wrote:

> Am 03/15/17 um 23:00 schrieb Robert Scholte:
> > The javadoc-fix is easy, but the result of
> modello-maven-plugin:1.9.0:xdoc
> > now causes issues because html4 is not the same as balanced xml. Need to
> > think about how to fix this.
> > Maybe this commit should be reverted.
>
> Cannot tell. Stephen? Can we upgrade/fix the modello plugin before
> alpha-2? The Maven release will be done using JDK 7, IIRC. I just wanted
> to start a release status build with current master to see how the other
> codebases behave but could not.
>
> 
>
> Regards,
> --
> Christian
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone

Re: Distribution file permission issue with current master.

[Hervé BOUTEMY]

no issue for me on Linux
I don't understand what happens to you: I suppose this is once again related 
to FreeBSD
I can't do anything for you

Regards,

Hervé

Le mardi 14 mars 2017, 22:29:28 CET Christian Schulte a écrit :
> Hi,
> 
> see the attachment. After unzipping the binary distribution, I cannot
> delete it anymore without updating file permissions.
> 
> Regards,



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Maven Resolver 1.1

[Hervé BOUTEMY]

it would be great if MNG-6183 description included a sample debug message 
before the change and after the change: I can't get what this change is about 
really

And of course, I don't get the next step with Resolver API...

Regards,

Hervé

Le mardi 14 mars 2017, 21:24:58 CET Christian Schulte a écrit :
> Hi,
> 
> are there any plans to release another Maven Resolver 1.0.x? Can I
> update the POMs to 1.1-SNAPSHOT? See the comments I added in this
> commit:
>  3192399237750c15f96fa021977dd83b>
> 
> I would need to add some methods to the Resolver API to add support for
> those messages. This would require a bump of the minor version.
> 
> Regards,



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Maven Site vs Reporting Plugin workflows?

[Hervé BOUTEMY]

Hi,

The change is explained here:
http://maven.apache.org/plugins/maven-site-plugin/maven-3.html

The injection is done in DefaultReportingConverter [1] 

At the beginning, the dream was to remove  element from pom.xml: 
then we later found that we could not since this is the only place where 
reporting plugin inheritance can happen (no inheritance in reportPlugin 
parameter of maven-site-plugin).

Then this idea about  removal was abandonned, I took time to 
document the strategy revert as much as possible. But I didn't take time to do 
some cleanup: this parameter that is magically injected by Maven core should 
probably be changed into a classical "${project.reporting}" parameter default 
value.

Regards,

Hervé

[1] http://maven.apache.org/ref/3-LATEST/maven-model-builder/apidocs/org/
apache/maven/model/plugin/DefaultReportingConverter.html

Le mardi 14 mars 2017, 00:03:45 CET Alex O'Ree a écrit :
> Hi everyone, I'm trying to troubleshoot an issue with the PDF plugin,
> https://issues.apache.org/jira/browse/MPDF-62. Root cause seems to be
> that the reportPlugins:
> @Parameter( readonly = true )
> private org.apache.maven.reporting.exec.ReportPlugin[] reportPlugins;
> 
> are not injected to the Mojo plugin and that at some point in time the
> behavior had changed. Does anyone know approximately when this
> occurred or what version the change was in effect?
> 
> Moving on, I also checked out the maven-site plugin as it performs the
> same task and found nearly identical code for the parts referring to
> the reporting plugins, except that when ran, the reportPlugins
> parameter is populated by maven. I'm not too sure what the delta is
> here nor do I know where to look, but if anyone has any clues or
> pointers to what could be wrong or areas to look at it, I'm all ears.
> Is there perhaps some resource file or magic string in play?
> 
> Related question, where does the parameter injection happen?
> 
> Finally, I also didn't find any other references to how the site
> plugin causes the report plugins to fire off. Is there any good
> resources that I can read up on the current workflow and/or
> architecture of all things related to report plugins and site
> generation?
> 
> Thanks!
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Release build failing with current master (was Re: [PING] The GIT master branch of Maven has unreleased changes that do not pass a release build)

[Christian Schulte]

Am 03/15/17 um 23:00 schrieb Robert Scholte:
> The javadoc-fix is easy, but the result of modello-maven-plugin:1.9.0:xdoc  
> now causes issues because html4 is not the same as balanced xml. Need to  
> think about how to fix this.
> Maybe this commit should be reverted.

Cannot tell. Stephen? Can we upgrade/fix the modello plugin before
alpha-2? The Maven release will be done using JDK 7, IIRC. I just wanted
to start a release status build with current master to see how the other
codebases behave but could not.



Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Release build failing with current master (was Re: [PING] The GIT master branch of Maven has unreleased changes that do not pass a release build)

[Robert Scholte]

The javadoc-fix is easy, but the result of modello-maven-plugin:1.9.0:xdoc  
now causes issues because html4 is not the same as balanced xml. Need to  
think about how to fix this.

Maybe this commit should be reverted.

Robert

On Wed, 15 Mar 2017 22:40:54 +0100, Christian Schulte   
wrote:



Am 03/15/17 um 22:30 schrieb Robert Scholte:

ok, so that argument should be moved to a java8 activated profile.


Can you do this, please?

Regards,


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Release build failing with current master (was Re: [PING] The GIT master branch of Maven has unreleased changes that do not pass a release build)

[Christian Schulte]

Am 03/15/17 um 22:30 schrieb Robert Scholte:
> ok, so that argument should be moved to a java8 activated profile.

Can you do this, please?

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Release build failing with current master (was Re: [PING] The GIT master branch of Maven has unreleased changes that do not pass a release build)

[Robert Scholte]

ok, so that argument should be moved to a java8 activated profile.

On Wed, 15 Mar 2017 22:27:11 +0100, Christian Schulte   
wrote:



Am 03/15/17 um 21:50 schrieb Michael Osipov:

Am 2017-03-15 um 21:39 schrieb Christian Schulte:

Hi,

this is a real issue. A release build using JDK 7 with current master  
is

not possible. See



Exit code: 1 - javadoc: error - invalid flag: -Xdoclint:none


doclint should actually be in a profile for Java 8+. Confusing that it
didn't fail earlier...





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Release build failing with current master (was Re: [PING] The GIT master branch of Maven has unreleased changes that do not pass a release build)

[Christian Schulte]

Am 03/15/17 um 21:50 schrieb Michael Osipov:
> Am 2017-03-15 um 21:39 schrieb Christian Schulte:
>> Hi,
>>
>> this is a real issue. A release build using JDK 7 with current master is
>> not possible. See
>>
>> 
>>
>> Exit code: 1 - javadoc: error - invalid flag: -Xdoclint:none
> 
> doclint should actually be in a profile for Java 8+. Confusing that it 
> didn't fail earlier...




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Release build failing with current master (was Re: [PING] The GIT master branch of Maven has unreleased changes that do not pass a release build)

[Michael Osipov]

Am 2017-03-15 um 21:39 schrieb Christian Schulte:

Hi,

this is a real issue. A release build using JDK 7 with current master is
not possible. See



Exit code: 1 - javadoc: error - invalid flag: -Xdoclint:none


doclint should actually be in a profile for Java 8+. Confusing that it 
didn't fail earlier...



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: New Branch SUREFIRE-1342

[Tibor Digana]

Hi Guillaume Boué,

Have you found a spare time to test the branch?

Cheers
Tibor

On Mon, Mar 13, 2017 at 11:04 PM, Guillaume Boué  wrote:

> Hi,
>
> I finished setting up a FreeBSD VM with a couple of Maven and JDK
> versions, so I'll be testing this extensively (on Ubuntu as well). Thanks
> for the work!
>
> Guillaume
>
>
>
> Le 13/03/2017 à 10:46, Tibor Digana a écrit :
>
>> Hi All,
>>
>> The new branch SUREFIRE-1342 solves an issue when entire testset completed
>> however the surefire's forked JVM  finished printing serious issue. We
>> know
>> that the JVM did not crash however it looks so:
>>
>> The forked VM terminated without saying properly goodbye. VM crash or
>> System.exit called ?
>>
>>
>> The problem is solved in the branch and ready to be tested.
>>
>> The entire problem was concurrency issue where the forked JVM sent "bye"
>> event to the Maven process via stdout but Maven process has not drained
>> shared memory yet and Maven process was therefore slower to receive the
>> event than the forked process which exited. Due to the "bye" event was not
>> determined by Maven process in particular time, this error came up.
>> We implemented ACK command which confirms such event has been received by
>> Maven process. The shared memory is drained directly by Maven process.
>>
>> Cheers
>> Tibor
>>
>>
>
> ---
> L'absence de virus dans ce courrier électronique a été vérifiée par le
> logiciel antivirus Avast.
> https://www.avast.com/antivirus
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Release build failing with current master (was Re: [PING] The GIT master branch of Maven has unreleased changes that do not pass a release build)

[Christian Schulte]

Hi,

this is a real issue. A release build using JDK 7 with current master is
not possible. See



Exit code: 1 - javadoc: error - invalid flag: -Xdoclint:none

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [DISCUSS] Retrospective on Maven 3.5.0-alpha-1

[Stephen Connolly]

--first-parent

On Wed 15 Mar 2017 at 00:39, Christian Schulte  wrote:

> Am 03/14/17 um 01:27 schrieb Jeff Jensen:
> >> The date of the commit is not the date it got committed to master, but
> the
> > date it got committed to some branch, no longer existing after the
> commit.
> > If this is the way GIT works, so be it. I just don't like it. It could
> not
> > be more confusing.
> >
> > A couple of thoughts in case they help you.
> >
> > 1. Git has "author date" and "commit date" for each commit.
> > * author date is the original date of the first commit, never
> changes.
> > * commit date is the last time the commit was modified (e.g. amended,
> > committed to a branch).
> > Each date is useful, depending on the situation investigating.
>
> Yes. It is lacking information about when a commit got added to a
> specific branch. Create a branch of master, work on it for a few months,
> then merge it back to master. Information about when the months old
> commits have been merged to master is missing. Maybe I am just using the
> tool incorrectly. Currently I am creating a branch from master to work
> on using 'git pull --rebase origin/master' followed by a fast-forward
> push to master using 'git push origin branchname:master'. That way the
> commits appear in order. If I would do 'git merge' the months old
> commits appear at a months old place in time on master with possibly
> other commits done in between by others mixed in. This is what 'man
> git-merge' tells me is the way things are supposed to be. I am not even
> sure I got that correctly.
>
> >
> > To help with the date displays, which git client(s) do you use?
>
> git and gitk.
>
> > Please ask for more git help if you like.  Many people on the list know
> it
> > well, and happy to help your productivity.
>
> Thanks for the clarifications.
>
> Regards,
> --
> Christian
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone