Re: [MNG-6084] Support JSR 250 annotations

[Dan Tran]

Thanks Michael for pushing this out. Looking forward to use it in 3.5.1

-D

On Wed, May 24, 2017 at 4:04 PM, Michael Osipov  wrote:

> Who seconds MNG-6084 for 3.5.1?
>
> This one was developed by Dan Tran. I added non-functional fixes to it.
> All ITs pass as well as its own IT.
>
> Michael
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: convert maven-resolver-provider to jsr330

[Jason Dillon]

Yes please, thank you :-]

—jason


On May 24, 2017 at 2:38:24 PM, Igor Fedorenko (i...@ifedorenko.com) wrote:

I'd like to ask for somebody to second my change described in  
[MNG-6233]. The change cleans up mixture of jsr330 and plexus  
annotations used in maven-resolver-provider, leaving only jsr330. The  
change is small and I believe safe, does not change any user-observable  
behaviour during normal maven build and all ITs pass.  

[MNG-6233] https://issues.apache.org/jira/browse/MNG-6233  

--  
Regards,  
Igor  

PS: Unfortunately I already submitted the change to master (by bad,  
sorry about that) but will revert the change if I don't get +1s or get  
any -1s within usual 72h.  

-  
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org  
For additional commands, e-mail: dev-h...@maven.apache.org  

Re: convert maven-resolver-provider to jsr330

[Olivier Lamy]

+1

On 25 May 2017 at 07:41, Manfred Moser  wrote:

> Lgtm +1
>
> Igor Fedorenko wrote on 2017-05-24 14:38:
>
> > I'd like to ask for somebody to second my change described in
> > [MNG-6233]. The change cleans up mixture of jsr330 and plexus
> > annotations used in maven-resolver-provider, leaving only jsr330. The
> > change is small and I believe safe, does not change any user-observable
> > behaviour during normal maven build and all ITs pass.
> >
> > [MNG-6233] https://issues.apache.org/jira/browse/MNG-6233
> >
> > --
> > Regards,
> > Igor
> >
> > PS: Unfortunately I already submitted the change to master (by bad,
> > sorry about that) but will revert the change if I don't get +1s or get
> > any -1s within usual 72h.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

[MNG-6084] Support JSR 250 annotations

[Michael Osipov]

Who seconds MNG-6084 for 3.5.1?

This one was developed by Dan Tran. I added non-functional fixes to it. 
All ITs pass as well as its own IT.


Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

[michael-o]

Github user michael-o commented on the issue:

https://github.com/apache/maven/pull/116
  
@jdillon Igor merged his PR contained your fix. This PR is obsolete now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: convert maven-resolver-provider to jsr330

[Manfred Moser]

Lgtm +1

Igor Fedorenko wrote on 2017-05-24 14:38:

> I'd like to ask for somebody to second my change described in
> [MNG-6233]. The change cleans up mixture of jsr330 and plexus
> annotations used in maven-resolver-provider, leaving only jsr330. The
> change is small and I believe safe, does not change any user-observable
> behaviour during normal maven build and all ITs pass.
> 
> [MNG-6233] https://issues.apache.org/jira/browse/MNG-6233
> 
> -- 
> Regards,
> Igor
> 
> PS: Unfortunately I already submitted the change to master (by bad,
> sorry about that) but will revert the change if I don't get +1s or get
> any -1s within usual 72h.
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

convert maven-resolver-provider to jsr330

[Igor Fedorenko]

I'd like to ask for somebody to second my change described in
[MNG-6233]. The change cleans up mixture of jsr330 and plexus
annotations used in maven-resolver-provider, leaving only jsr330. The
change is small and I believe safe, does not change any user-observable
behaviour during normal maven build and all ITs pass.

[MNG-6233] https://issues.apache.org/jira/browse/MNG-6233

-- 
Regards,
Igor

PS: Unfortunately I already submitted the change to master (by bad,
sorry about that) but will revert the change if I don't get +1s or get
any -1s within usual 72h.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #149: Add a doctype to the StatelessXmlReporter output

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/149
  
DOCTYPE is old. 
Do you mean report XML e.g. `surefire-reports/TEST-MyTest.xml`?
```

http://www.w3.org/2001/XMLSchema-instance; 
xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd;
 name="MyTest" time="0.36" tests="8" errors="0" skipped="0" failures="0">
```
It is a typical XML.
Why should I use two types of metadata?
Did Eclipse have any statement to this issue? The issues originated with 
error in Eclipse so I would expect them to do the best effort first. Would it 
be possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

[michael-o]

Github user michael-o commented on the issue:

https://github.com/apache/maven/pull/116
  
Thanks for the explanation. So it is not a prerequisite directly. I'd still 
insist for an JIRA because I need another committer to second this and have 
this in our release notes. Do you have a simple usecase to turn into an IT? I 
am fine with merging your change, looks pretty reasonable to me. Clearly a bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

[jdillon]

Github user jdillon commented on the issue:

https://github.com/apache/maven/pull/116
  
Igor's change is the more correct/ideal change to avoid future mismatch 
between plexus-annotation configuration and JSR-330 annotations.  The problem 
is that plexus @Requirement injects directly to the field, but JSR-330 uses 
@Inject on the ctor, and the ctor impl ignores one of the parameters and 
doesn't fully setup the object properly.  Its generally bad to have a mix of 
these annotations, as the lifecycle between plexus and jsr-330 is slightly 
different, but if you do mix them, you have to ensure that both means wire up 
the object correctly. 

My change simply fixes the bug, so that the versionRangeResolver component, 
which is required for the DefaultArtifactDescriptorReader impl to function 
properly actually gets set.

My recommendation is you merge this change as its very simple and easy to 
comprehend (or at least I thought) and then consider merging Igor's change as 
this is more ideal for the future of the library.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

[michael-o]

Github user michael-o commented on the issue:

https://github.com/apache/maven/pull/116
  
Just to be clear, Igor's change is s prerequisite to your issue? If so, we 
need two tickets. The IT assures that nothing will break your fix -- no more, 
no less. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

[jdillon]

Github user jdillon commented on the issue:

https://github.com/apache/maven/pull/116
  
Igor already created https://issues.apache.org/jira/browse/MNG-6233 but if 
you really need another issue I can file one just to fix this specific problem.

Seems a bit odd though that you want an IT to apply a clear coding mistake 
due to the ctor parameter being ignored and not setting the component causing 
NPE when used. :-(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

[michael-o]

Github user michael-o commented on the issue:

https://github.com/apache/maven/pull/116
  
@jdillon I'd like to merge this but need a JIRA issue. At best, an IT too. 
Can you provide a simple one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

[jdillon]

Github user jdillon commented on the issue:

https://github.com/apache/maven/pull/116
  
Hey folks can we get some movement on this and/or 
https://github.com/apache/maven/compare/MNG-6233_maven-resolver-provider-jsr330

ATM its broken, either of these fixes the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Inject Maven parameters to Plexus components

[DK]

Is it possible to Inject Maven paramaters into Plexus components

I've tried this without success. Both repoSession and repositories are null

@Component(role = ResolverComponent.class, instantiationStrategy =
"per-lookup")
public class ResolverComponent {

@Requirement
private Logger logger;

@Requirement
private RepositorySystem repoSystem;

@Parameter(defaultValue = "${repositorySystemSession}", readonly = true,
required = true)
private RepositorySystemSession repoSession;

@Parameter(defaultValue = "${project.remoteProjectRepositories}",
readonly = true, required = true)
private List repositories;

:
:
}



--
View this message in context: 
http://maven.40175.n5.nabble.com/Inject-Maven-parameters-to-Plexus-components-tp5908783.html
Sent from the Maven Developers mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org