Re: Improvements to analyze goal of maven-dependency-plugin

2017-06-14 Thread jieryn
Yah, looks great! Would use it!

On Wed, Jun 14, 2017 at 7:55 AM, Mark Raynsford
 wrote:
> On 2017-06-14T11:51:46 +
> Jonathan Haber  wrote:
>> Here an is example of the output before and after:
>>
>> https://gist.github.com/jhaber/d8204829fe61569e0034250df74300fb
>>
>> Do you think this feature adds value? Any suggestions?
>
> This is wonderful! Nice work.
>
> M

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Improvements to analyze goal of maven-dependency-plugin

2017-06-14 Thread Mark Raynsford
On 2017-06-14T11:51:46 +
Jonathan Haber  wrote:
> Here an is example of the output before and after:
>
> https://gist.github.com/jhaber/d8204829fe61569e0034250df74300fb
> 
> Do you think this feature adds value? Any suggestions?

This is wonderful! Nice work.

M


pgp9I3Nk8m4p4.pgp
Description: OpenPGP digital signature


Improvements to analyze goal of maven-dependency-plugin

2017-06-14 Thread Jonathan Haber
I wanted to get feedback on a proposed improvement to the
maven-dependency-plugin, specifically for the goals that analyze dependency
usages. We have the plugin configured to fail our build if there are any
used undeclared or unused declared dependencies. In the case of used
undeclared, it is often helpful to know which classes are being used and
where they are being used. Previously we had a few workarounds to try to
expose this information to our developers after-the-fact (by grepping class
files, using IDE features, etc.) but it would be great if this was just
included in the plugin output. We've implemented this feature in our fork
of the plugin and our developers love it. Here an is example of the output
before and after:
https://gist.github.com/jhaber/d8204829fe61569e0034250df74300fb

I've written this up as a JIRA:
https://issues.apache.org/jira/browse/MSHARED-632

And sent a pull request with the required changes to the
maven-dependency-analyzer (which needs to expose more information so that
the plugin can generate this output):
https://github.com/apache/maven-shared/pull/21

Do you think this feature adds value? Any suggestions?

Thanks,
Jonathan


[GitHub] maven-surefire pull request #156: SUREFIRE-1382: fixing OutOfMemoryError

2017-06-14 Thread nicolaferraro
GitHub user nicolaferraro opened a pull request:

https://github.com/apache/maven-surefire/pull/156

SUREFIRE-1382: fixing OutOfMemoryError

We experienced out of memory errors also on Apache Camel with JUnit 4. The 
reason is probably this infinite loop whenever the `exceptions` Queue contains 
at least one element.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nicolaferraro/maven-surefire SUREFIRE-1382

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-surefire/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #156


commit 7176d3c17b438c60e48a525ef96e6812f00bec46
Author: Nicola Ferraro 
Date:   2017-06-14T10:48:06Z

SUREFIRE-1382: fixing out of memory error




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven issue #107: Fixes to various JIRA issues.

2017-06-14 Thread ChristianSchulte
Github user ChristianSchulte commented on the issue:

https://github.com/apache/maven/pull/107
  
You'll need to merge the resolver bugfixes as well to make the IT work, of 
course. 


[MRESOLVER-8](https://github.com/ChristianSchulte/maven-resolver/commit/2813a8f9e290f8a6523486c0ca30cca8c9b7cc45)

[MRESOLVER-9](https://github.com/ChristianSchulte/maven-resolver/commit/67a37de1feabcb420152981cd9b07c2288b46108)

This will make the resolver discard any non-transitive dependencies 
(optional and test-scope) correctly. Existing builds relying on the incorrect 
behaviour will stop working. The POMs of the resolver itself rely on that 
incorrect behaviour. Working on those issues is a waste of time! It will sadly 
never pass a release vote.

I haven't split the unit tests into smaller commits. To be able to merge 
the unit tests, you'll need to merge the following commits as well.


[MRESOLVER-10](https://github.com/ChristianSchulte/maven-resolver/commit/fb743981623504a00bf88c6c060ced9d08880355)

[MRESOLVER-12](https://github.com/ChristianSchulte/maven-resolver/commit/e0f9180da1532adbdc30f5f9470c445a2d9cc199)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org