Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

[Peter Ansell]

Upgrading to the latest Mockito 2.x version has been enough in my
other projects to eliminate its Java-9 warnings/errors without any
code changes, but YMMV.

Cheers,

Peter

On 29 July 2017 at 07:44, Karl Heinz Marbaise  wrote:
> Hi,
>
> +1 from me.
>
>
> Tested with JDK 9+180 the following Maven versions:
>  o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5, Maven 3.1.1, Maven 3.0.5
>
> Tested with JDK 1.8.0_144 the following Maven versions:
>  o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5, Maven 3.1.1, Maven 3.0.5
> Tested with JDK 1.8.0_131, Maven 3.5.0, Maven 3.3.9
>
> Only got a warnings with JDK 9: Should be addressed for final 3.0.0...
>
> Running org.apache.maven.plugins.enforcer.TestDefaultEnforcementRuleHelper
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by org.mockito.cglib.core.ReflectUtils$2
> (file:/Users/kama/.m2/repository/org/mockito/mockito-core/1.9.5/mockito-core-1.9.5.jar)
> to method
> java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
> WARNING: Please consider reporting this to the maintainers of
> org.mockito.cglib.core.ReflectUtils$2
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
>
> Second:
> [INFO] --- maven-invoker-plugin:2.0.0:run (integration-test) @
> maven-enforcer-plugin ---
> [INFO] Building: always-fail/pom.xml
> [INFO] ..SUCCESS (2.7 s)
> [INFO] Building: always-fail-warn/pom.xml
> [INFO] run script verify.groovy
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.codehaus.groovy.reflection.CachedClass$3$1
> (file:/Users/kama/.m2/repository/org/codehaus/groovy/groovy/2.0.1/groovy-2.0.1.jar)
> to method java.lang.Object.finalize()
> WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass$3$1
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> [INFO] ..SUCCESS (3.0 s)
>
> which is based on Maven Invoker Plugin 2.0.0 should be fine with Maven
> Invoker Plugin 3.0.0...
>
> Kind regards
> Karl Heinz Marbaise
>
>
> On 26/07/17 22:58, Robert Scholte wrote:
>>
>> Hi,
>>
>> We solved 14 issues:
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12330768=Text
>>
>> There are still a couple of issues left in JIRA:
>>
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317520%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1349
>>
>> https://repository.apache.org/service/local/repositories/maven-1349/content/org/apache/maven/enforcer/enforcer/3.0.0-M1/enforcer-3.0.0-M1-source-release.zip
>>
>> Source release checksum(s):
>> enforcer-3.0.0-M1-source-release.zip sha1:
>> 20b6e4800bb6357a25db6da3bdacc45675b9b5c8
>>
>> Staging site:
>> https://maven.apache.org/enforcer-archives/enforcer-LATEST/
>>
>> Guide to testing staged releases:
>> https://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> NOTE: this is a milestone release, because there are still some open
>> issues which need to be fixed before the official 3.0.0.
>> This release is mainly there to provide a Java9 compatible plugin
>> (previous versions fail the build).
>>
>> Vote open for at least 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>>
>
>
> Mit freundlichem Gruß
> Karl-Heinz Marbaise
> --
> SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893
> Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579
> Hauptstrasse 177
> 52146 Würselen   http://www.soebes.de
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

[carlspring]

Github user carlspring commented on a diff in the pull request:

https://github.com/apache/maven-indexer/pull/17#discussion_r130204917
  
--- Diff: indexer-core/pom.xml ---
@@ -84,21 +84,25 @@ under the License.
 
   org.apache.lucene
   lucene-core
+  6.1.0
--- End diff --

Yeah, that's the place! :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #159: SUREFIRE-1391: Eliminate redundant call in calcul...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/159
  
@andrew-j-cohen 
thx, merged. This PR can be closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #158: Fix typo in docs

[StephenKing]

Github user StephenKing commented on the issue:

https://github.com/apache/maven-surefire/pull/158
  
👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #158: Fix typo in docs

[StephenKing]

Github user StephenKing closed the pull request at:

https://github.com/apache/maven-surefire/pull/158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #158: Fix typo in docs

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/158
  
@StephenKing 
Thx, this PR was pushed to master and can be closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

[Manfred Moser]

Wow Karl! Very nice testing effort.

+1 from me (with less testing but still some ubuntu and osx based runs..) 

Manfred

Karl Heinz Marbaise wrote on 2017-07-28 14:44:

> Hi,
> 
> +1 from me.
> 
> 
> Tested with JDK 9+180 the following Maven versions:
>  o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5, Maven 3.1.1, Maven 3.0.5
> 
> Tested with JDK 1.8.0_144 the following Maven versions:
>  o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5, Maven 3.1.1, Maven 3.0.5
> Tested with JDK 1.8.0_131, Maven 3.5.0, Maven 3.3.9
> 
> Only got a warnings with JDK 9: Should be addressed for final 3.0.0...
> 
> Running org.apache.maven.plugins.enforcer.TestDefaultEnforcementRuleHelper
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by 
> org.mockito.cglib.core.ReflectUtils$2 
> (file:/Users/kama/.m2/repository/org/mockito/mockito-core/1.9.5/mockito-core-1.9.5.jar)
> 
> to method 
> java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
> WARNING: Please consider reporting this to the maintainers of 
> org.mockito.cglib.core.ReflectUtils$2
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> 
> Second:
> [INFO] --- maven-invoker-plugin:2.0.0:run (integration-test) @ 
> maven-enforcer-plugin ---
> [INFO] Building: always-fail/pom.xml
> [INFO] ..SUCCESS (2.7 s)
> [INFO] Building: always-fail-warn/pom.xml
> [INFO] run script verify.groovy
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by 
> org.codehaus.groovy.reflection.CachedClass$3$1 
> (file:/Users/kama/.m2/repository/org/codehaus/groovy/groovy/2.0.1/groovy-2.0.1.jar)
> 
> to method java.lang.Object.finalize()
> WARNING: Please consider reporting this to the maintainers of 
> org.codehaus.groovy.reflection.CachedClass$3$1
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> [INFO] ..SUCCESS (3.0 s)
> 
> which is based on Maven Invoker Plugin 2.0.0 should be fine with Maven 
> Invoker Plugin 3.0.0...
> 
> Kind regards
> Karl Heinz Marbaise
> 
> On 26/07/17 22:58, Robert Scholte wrote:
>> Hi,
>> 
>> We solved 14 issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12330768=Text
>> 
>> 
>> 
>> There are still a couple of issues left in JIRA:
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317520%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>> 
>> 
>> 
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1349
>> https://repository.apache.org/service/local/repositories/maven-1349/content/org/apache/maven/enforcer/enforcer/3.0.0-M1/enforcer-3.0.0-M1-source-release.zip
>> 
>> 
>> 
>> Source release checksum(s):
>> enforcer-3.0.0-M1-source-release.zip sha1: 
>> 20b6e4800bb6357a25db6da3bdacc45675b9b5c8
>> 
>> Staging site:
>> https://maven.apache.org/enforcer-archives/enforcer-LATEST/
>> 
>> Guide to testing staged releases:
>> https://maven.apache.org/guides/development/guide-testing-releases.html
>> 
>> NOTE: this is a milestone release, because there are still some open 
>> issues which need to be fixed before the official 3.0.0.
>> This release is mainly there to provide a Java9 compatible plugin 
>> (previous versions fail the build).
>> 
>> Vote open for at least 72 hours.
>> 
>> [ ] +1
>> [ ] +0
>> [ ] -1
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>> 
>> 
> 
> 
> Mit freundlichem Gruß
> Karl-Heinz Marbaise
> -- 
> SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893
> Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579
> Hauptstrasse 177
> 52146 Würselen   http://www.soebes.de
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

[Karl Heinz Marbaise]

Hi,

+1 from me.


Tested with JDK 9+180 the following Maven versions:
 o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5, Maven 3.1.1, Maven 3.0.5

Tested with JDK 1.8.0_144 the following Maven versions:
 o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5, Maven 3.1.1, Maven 3.0.5
Tested with JDK 1.8.0_131, Maven 3.5.0, Maven 3.3.9

Only got a warnings with JDK 9: Should be addressed for final 3.0.0...

Running org.apache.maven.plugins.enforcer.TestDefaultEnforcementRuleHelper
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by 
org.mockito.cglib.core.ReflectUtils$2 
(file:/Users/kama/.m2/repository/org/mockito/mockito-core/1.9.5/mockito-core-1.9.5.jar) 
to method 
java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of 
org.mockito.cglib.core.ReflectUtils$2
WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations

WARNING: All illegal access operations will be denied in a future release

Second:
[INFO] --- maven-invoker-plugin:2.0.0:run (integration-test) @ 
maven-enforcer-plugin ---

[INFO] Building: always-fail/pom.xml
[INFO] ..SUCCESS (2.7 s)
[INFO] Building: always-fail-warn/pom.xml
[INFO] run script verify.groovy
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by 
org.codehaus.groovy.reflection.CachedClass$3$1 
(file:/Users/kama/.m2/repository/org/codehaus/groovy/groovy/2.0.1/groovy-2.0.1.jar) 
to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of 
org.codehaus.groovy.reflection.CachedClass$3$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations

WARNING: All illegal access operations will be denied in a future release
[INFO] ..SUCCESS (3.0 s)

which is based on Maven Invoker Plugin 2.0.0 should be fine with Maven 
Invoker Plugin 3.0.0...


Kind regards
Karl Heinz Marbaise

On 26/07/17 22:58, Robert Scholte wrote:

Hi,

We solved 14 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12330768=Text 



There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317520%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC 



Staging repo:
https://repository.apache.org/content/repositories/maven-1349
https://repository.apache.org/service/local/repositories/maven-1349/content/org/apache/maven/enforcer/enforcer/3.0.0-M1/enforcer-3.0.0-M1-source-release.zip 



Source release checksum(s):
enforcer-3.0.0-M1-source-release.zip sha1: 
20b6e4800bb6357a25db6da3bdacc45675b9b5c8


Staging site:
https://maven.apache.org/enforcer-archives/enforcer-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

NOTE: this is a milestone release, because there are still some open 
issues which need to be fixed before the official 3.0.0.
This release is mainly there to provide a Java9 compatible plugin 
(previous versions fail the build).


Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





Mit freundlichem Gruß
Karl-Heinz Marbaise
--
SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893
Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579
Hauptstrasse 177
52146 Würselen   http://www.soebes.de

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

[Peter Ansell]

Yes, +1

On 28 July 2017 at 18:18, Robert Scholte  wrote:
> Thanks for testing. Can I translate this to a +1 vote?
>
> Robert
>
>
> On Fri, 28 Jul 2017 02:04:40 +0200, Peter Ansell 
> wrote:
>
>> The sha1 matches for me and the plugin (including requireJavaVersion)
>> works under both Oracle JDK 8+u131 and Oracle JDK 9+177.
>>
>> Thanks,
>>
>> Peter
>>
>> On 27 July 2017 at 06:58, Robert Scholte  wrote:
>>>
>>> Hi,
>>>
>>> We solved 14 issues:
>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12330768=Text
>>>
>>> There are still a couple of issues left in JIRA:
>>>
>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317520%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>>>
>>> Staging repo:
>>> https://repository.apache.org/content/repositories/maven-1349
>>>
>>> https://repository.apache.org/service/local/repositories/maven-1349/content/org/apache/maven/enforcer/enforcer/3.0.0-M1/enforcer-3.0.0-M1-source-release.zip
>>>
>>> Source release checksum(s):
>>> enforcer-3.0.0-M1-source-release.zip sha1:
>>> 20b6e4800bb6357a25db6da3bdacc45675b9b5c8
>>>
>>> Staging site:
>>> https://maven.apache.org/enforcer-archives/enforcer-LATEST/
>>>
>>> Guide to testing staged releases:
>>> https://maven.apache.org/guides/development/guide-testing-releases.html
>>>
>>> NOTE: this is a milestone release, because there are still some open
>>> issues
>>> which need to be fixed before the official 3.0.0.
>>> This release is mainly there to provide a Java9 compatible plugin
>>> (previous
>>> versions fail the build).
>>>
>>> Vote open for at least 72 hours.
>>>
>>> [ ] +1
>>> [ ] +0
>>> [ ] -1
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #160: SUREFIRE-1398 threadCount is set for JUnit only w...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/160
  
@MatousJobanek 
It should be sanity check and Mojo should fail if `threadCount` is <= 0 && 
isApplicable.
IsApplicable is TRUE if `forkMode` is "pertest" OR `parallel` is any of 
("classes", "methods", "both", "suites", "suitesAndClasses", 
"suitesAndMethods", "classesAndMethods", "all").

The Mojo should fail even if `threadCount` is <> 0 AND `forkMode` != 
"pertest" AND `parallel` == NULL.

The Mojo should fail if `forkCount` is < 0 AND `forkMode` == "once" 
(default).

`AbstractSurefireMojo` is some methods which maybe solve this and convert 
old forkMode to forkCount so it is not so direct to do like I wrote this pseudo 
code.

The most important is to run the build `mvn install -P run-its`, cca 50 
minutes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

MNG-6174 for Maven 3.5.1

[Karl Heinz Marbaise]

Hi,

I would like to integrate MNG-6174[1] into Maven 3.5.1 (master)..

The IT's are fine see[2]

Are any objections?

If there are no objections I would like to merge to master on tuesday...

Kind regards
Karl Heinz Marbaise

[1]: https://issues.apache.org/jira/browse/MNG-6174
[2]: 
https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/mvn-3.5.1%252FMNG-6174/


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

MNG-6123 for Maven 3.5.1

[Karl Heinz Marbaise]

Hi,

I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which 
needs a small change to one of the integration tests[2]


The IT's are fine see[3]

Are any objections?

If there are no objections I would like to merge to master on tuesday...

Kind regards
Karl Heinz Marbaise


[1]: https://issues.apache.org/jira/browse/MNG-6123
[2]: 
https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=3a1f095ec845c94b8e21ea28e4ffe69a01c29f4b
[3]: 
https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6123-detect-self-references/


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

[scela]

Github user scela commented on a diff in the pull request:

https://github.com/apache/maven-indexer/pull/17#discussion_r130105466
  
--- Diff: indexer-core/pom.xml ---
@@ -84,21 +84,25 @@ under the License.
 
   org.apache.lucene
   lucene-core
+  6.1.0
--- End diff --

https://github.com/apache/maven-indexer/blob/master/pom.xml#L91 here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

[carlspring]

Github user carlspring commented on a diff in the pull request:

https://github.com/apache/maven-indexer/pull/17#discussion_r130101051
  
--- Diff: 
indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java ---
@@ -0,0 +1,19 @@
+package org.apache.maven.index;
+
+import org.apache.lucene.document.FieldType;
+
+public class FieldTypeFactory {
+   
+   private static StoredNotAnalyzedFieldType snaft = new 
StoredNotAnalyzedFieldType();
--- End diff --

No, I believe you're using tabs, instead of spaces.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

[scela]

Github user scela commented on a diff in the pull request:

https://github.com/apache/maven-indexer/pull/17#discussion_r130093790
  
--- Diff: 
indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java ---
@@ -0,0 +1,19 @@
+package org.apache.maven.index;
+
+import org.apache.lucene.document.FieldType;
+
+public class FieldTypeFactory {
+   
+   private static StoredNotAnalyzedFieldType snaft = new 
StoredNotAnalyzedFieldType();
--- End diff --

Sure. Does this mean I have to put the long name there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

[scela]

Github user scela commented on the issue:

https://github.com/apache/maven-indexer/pull/17
  
https://issues.apache.org/jira/browse/MINDEXER-104 Done

On Fri, Jul 28, 2017 at 3:43 PM, Martin Todorov 
wrote:

> @scela  ,
>
> You can file a new issue under MINDEXER
>  Jira.
>
> Cheers,
>
> Martin
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

[carlspring]

Github user carlspring commented on the issue:

https://github.com/apache/maven-indexer/pull/17
  
@scela ,

You can file a new issue under 
[MINDEXER](https://issues.apache.org/jira/browse/MINDEXER) Jira.

Cheers,

Martin



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Robert Scholte]

Nice catch. Looks a lot like MNG-6262

On Fri, 28 Jul 2017 14:12:19 +0200, Dawid Weiss   
wrote:


IIUC the failing project isn't always failing. This could be an  
explanation.


I didn't say it isn't always failing -- I said it is failing
deterministically (as in: always) from the same location, but
sometimes isn't failing on the same project when executed from
*another* location.

I know what the problem is and I attached a longer comment on the
issue, please take a look. Don't know if we should discuss it here or
in Jira, up to you.

Dawid

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

[scela]

Github user scela commented on the issue:

https://github.com/apache/maven-indexer/pull/17
  
Sure. Can you point me where the Jira project is hosted? Lucene usually
makes major changes so I suspect going to 6.6 would be much more work. I'd
prefer to move to 6.1 first and then after that in a second iteration I
could port to later versions when I get the chance.

On Fri, Jul 28, 2017 at 6:46 AM, Olivier Lamy 
wrote:

> @scela  maybe you can create a Jira entry for
> the project?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

[carlspring]

Github user carlspring commented on the issue:

https://github.com/apache/maven-indexer/pull/17
  
The changes, (despite my minor remarks), look good! Thanks for this pull! :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

[carlspring]

Github user carlspring commented on a diff in the pull request:

https://github.com/apache/maven-indexer/pull/17#discussion_r130087375
  
--- Diff: 
indexer-core/src/test/java/org/apache/maven/index/FullIndexNexusIndexerTest.java
 ---
@@ -1,26 +1,8 @@
 package org.apache.maven.index;
 
-/*
--- End diff --

So, what happened to the license header? :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

[carlspring]

Github user carlspring commented on a diff in the pull request:

https://github.com/apache/maven-indexer/pull/17#discussion_r130086143
  
--- Diff: 
indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java ---
@@ -0,0 +1,19 @@
+package org.apache.maven.index;
+
+import org.apache.lucene.document.FieldType;
+
+public class FieldTypeFactory {
+   
+   private static StoredNotAnalyzedFieldType snaft = new 
StoredNotAnalyzedFieldType();
--- End diff --

Could you also please use the project's code formatting convention?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

[carlspring]

Github user carlspring commented on a diff in the pull request:

https://github.com/apache/maven-indexer/pull/17#discussion_r130085893
  
--- Diff: indexer-core/pom.xml ---
@@ -84,21 +84,25 @@ under the License.
 
   org.apache.lucene
   lucene-core
+  6.1.0
--- End diff --

Hi,

Just a small remark, if I may -- this is not the right place to be changing 
the version. There is a version property defined in the aggregator's `pom.xml`. 
You should be changing that instead.

Cheers,

Martin



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

[cstamas]

Github user cstamas commented on the issue:

https://github.com/apache/maven-indexer/pull/17
  
@olamy @scela  sounds fine to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Dawid Weiss]

> IIUC the failing project isn't always failing. This could be an explanation.

I didn't say it isn't always failing -- I said it is failing
deterministically (as in: always) from the same location, but
sometimes isn't failing on the same project when executed from
*another* location.

I know what the problem is and I attached a longer comment on the
issue, please take a look. Don't know if we should discuss it here or
in Jira, up to you.

Dawid

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Apache Maven Compiler 3.6.2

[Robert Scholte]

+1

On Wed, 26 Jul 2017 01:44:01 +0200, Olivier Lamy  wrote:


Hi,
I'd like to release Apache Maven Compiler Plugin version 3.6.2.

We fixed 3 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317225=12339154

Staging repo:  
https://repository.apache.org/content/repositories/maven-1348/


Source release:
*
https://repository.apache.org/content/repositories/maven-1348/org/apache/maven/plugins/maven-compiler-plugin/3.6.2/maven-compiler-plugin-3.6.2-source-release.zip

Staging site:
http://maven.apache.org/components/plugins-archives/maven-compiler-plugin-LATEST/
Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

My +1

Cheers


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Robert Scholte]

Well, file permission/access is indeed something to keep in mind.

E.g. virusscanner are known to block access to a file for a short moment.
IDEs can also cause issues. If some file/code changes causes background  
rebuild and you're doing an explicit Maven build yourself at the same  
time, you could have an issue.


IIUC the failing project isn't always failing. This could be an  
explanation.


Robert

On Fri, 28 Jul 2017 10:52:50 +0200, Dawid Weiss   
wrote:



Have you double checked file permissions? if it can't read the parent
pom (maybe not all dirs are +x etc) then it wil have the behavior you
see


Come on, guys.  :) I wouldn't ask if I didn't try it in many multiple
combinations. It is a heisenbug, but the reason for it is not a
trivial mistake on my part -- again: it fails on multiple (Windows)
machines; and it fails or not on the same machine, depending on the
path.

Weird, sure, but the more interesting.

I'll do some digging to see what this is, but pointers to code where I
could inject some debugging statements would be very welcome.

D.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Dawid Weiss]

Thanks, I'll dig and let you know if I can figure it out. (or not).

Dawid

> https://maven.apache.org/ref/3.5.0/maven-resolver-provider/
> This is the module responsible for resolving parents, dependencies, etc.
>
> https://github.com/apache/maven
> Here it is at github
>
>> Adding -X doesn't really yield any useful logs as to where
>> it tries to locate those relative parent POMs, prior to just breaking.
>> I'll take a look at it, but it'd save me some time if you could point
>> me at the code that performs this.
>>
>> Dawid
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Robert Scholte]

On Fri, 28 Jul 2017 10:49:42 +0200, Dawid Weiss   
wrote:



There must be a difference between the 2 projects.


There is no difference. It's the same repo on the same commit, I
called "git clean -xfd ." prior to executing those maven commands (and
obviously there are no other changes).

But as long as there's no attachment which reproduces the issue, we  
can't

help. Ensure that you've seen the attached project fail.


I know, Robert. But you have to trust me that it does fail  
(non-predictably).


- rename the directory (for backup), do a fresh checkout and try to do  
it again.


git clean -xfd .


- try to follow the path as displayed in the exception.  It shows all
required Maven coordinates and even the precise location in the pom.xml


It's an identical (relative path); the resolution of those relative
paths is broken somehow.

Where is the Maven code (on github) that's responsible for this pom
resolution?


https://maven.apache.org/ref/3.5.0/maven-resolver-provider/
This is the module responsible for resolving parents, dependencies, etc.

https://github.com/apache/maven
Here it is at github


Adding -X doesn't really yield any useful logs as to where
it tries to locate those relative parent POMs, prior to just breaking.
I'll take a look at it, but it'd save me some time if you could point
me at the code that performs this.

Dawid

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Dawid Weiss]

> Have you double checked file permissions? if it can't read the parent
> pom (maybe not all dirs are +x etc) then it wil have the behavior you
> see

Come on, guys.  :) I wouldn't ask if I didn't try it in many multiple
combinations. It is a heisenbug, but the reason for it is not a
trivial mistake on my part -- again: it fails on multiple (Windows)
machines; and it fails or not on the same machine, depending on the
path.

Weird, sure, but the more interesting.

I'll do some digging to see what this is, but pointers to code where I
could inject some debugging statements would be very welcome.

D.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Dawid Weiss]

> There must be a difference between the 2 projects.

There is no difference. It's the same repo on the same commit, I
called "git clean -xfd ." prior to executing those maven commands (and
obviously there are no other changes).

> But as long as there's no attachment which reproduces the issue, we can't
> help. Ensure that you've seen the attached project fail.

I know, Robert. But you have to trust me that it does fail (non-predictably).

> - rename the directory (for backup), do a fresh checkout and try to do it 
> again.

git clean -xfd .

> - try to follow the path as displayed in the exception.  It shows all
> required Maven coordinates and even the precise location in the pom.xml

It's an identical (relative path); the resolution of those relative
paths is broken somehow.

Where is the Maven code (on github) that's responsible for this pom
resolution? Adding -X doesn't really yield any useful logs as to where
it tries to locate those relative parent POMs, prior to just breaking.
I'll take a look at it, but it'd save me some time if you could point
me at the code that performs this.

Dawid

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Thomas Matthijs]

Have you double checked file permissions? if it can't read the parent
pom (maybe not all dirs are +x etc) then it wil have the behavior you
see

On Thu, Jul 27, 2017 at 10:07 PM, Dawid Weiss  wrote:
> I added a comment on that issue. The problem is not deterministic for
> some reason -- I can execute identical maven on identical code on the
> same computer and get two different outcomes (consistenly). I have no
> idea how to debug it better too -- passing -X doesn't yield any
> reasonable logs. Looks very strange.
>
> Dawid
>
>
> On Thu, Jul 27, 2017 at 7:37 PM, Robert Scholte  wrote:
>> I had a look at it, but can't reproduce the issue with the attached project
>> Even when using exactly the same directory
>> (D:\repositories\carrotsearch.com\lingo4g) my build succeeds.
>> A failing project is really required to fix this.
>>
>> Robert
>>
>>
>> On Thu, 27 Jul 2017 13:41:16 +0200, Dawid Weiss 
>> wrote:
>>
>>> Hello,
>>>
>>> Just wanted to hear if anybody has any idea about MNG-6261 I filed
>>> recently -- there is a relatively simple repro attached and it fails
>>> with Maven 3.5.0+; I've been wondering if it's a bug or an illegal
>>> abuse of the submodule/parent pom relationship.
>>>
>>> Dawid
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Any feedback for MNG-6261?

[Robert Scholte]

There must be a difference between the 2 projects.
But as long as there's no attachment which reproduces the issue, we can't  
help. Ensure that you've seen the attached project fail.


Just some suggestions to help:
- rename the directory (for backup), do a fresh checkout and try to do it  
again.
- try to follow the path as displayed in the exception.  It shows all  
required Maven coordinates and even the precise location in the pom.xml
- try to run it at different (valid) locations within the multimodule  
project.


Robert

On Thu, 27 Jul 2017 22:07:24 +0200, Dawid Weiss   
wrote:



I added a comment on that issue. The problem is not deterministic for
some reason -- I can execute identical maven on identical code on the
same computer and get two different outcomes (consistenly). I have no
idea how to debug it better too -- passing -X doesn't yield any
reasonable logs. Looks very strange.

Dawid


On Thu, Jul 27, 2017 at 7:37 PM, Robert Scholte   
wrote:
I had a look at it, but can't reproduce the issue with the attached  
project

Even when using exactly the same directory
(D:\repositories\carrotsearch.com\lingo4g) my build succeeds.
A failing project is really required to fix this.

Robert


On Thu, 27 Jul 2017 13:41:16 +0200, Dawid Weiss 
wrote:


Hello,

Just wanted to hear if anybody has any idea about MNG-6261 I filed
recently -- there is a relatively simple repro attached and it fails
with Maven 3.5.0+; I've been wondering if it's a bug or an illegal
abuse of the submodule/parent pom relationship.

Dawid

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

[Robert Scholte]

Thanks for testing. Can I translate this to a +1 vote?

Robert

On Fri, 28 Jul 2017 02:04:40 +0200, Peter Ansell   
wrote:



The sha1 matches for me and the plugin (including requireJavaVersion)
works under both Oracle JDK 8+u131 and Oracle JDK 9+177.

Thanks,

Peter

On 27 July 2017 at 06:58, Robert Scholte  wrote:

Hi,

We solved 14 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12330768=Text

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317520%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1349
https://repository.apache.org/service/local/repositories/maven-1349/content/org/apache/maven/enforcer/enforcer/3.0.0-M1/enforcer-3.0.0-M1-source-release.zip

Source release checksum(s):
enforcer-3.0.0-M1-source-release.zip sha1:
20b6e4800bb6357a25db6da3bdacc45675b9b5c8

Staging site:
https://maven.apache.org/enforcer-archives/enforcer-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

NOTE: this is a milestone release, because there are still some open  
issues

which need to be fixed before the official 3.0.0.
This release is mainly there to provide a Java9 compatible plugin  
(previous

versions fail the build).

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-wagon pull request #34: Added FTP over HTTP proxy wagon

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/maven-wagon/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org