[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

[jon-bell]

Github user jon-bell commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/161#discussion_r130497860
  
--- Diff: 
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
 ---
@@ -0,0 +1,61 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.plugins.surefire
+  surefire-test-classpath-provider
+  1.0-SNAPSHOT
+  Test provider
+
+  
+2.21-SNAPSHOT
--- End diff --

Sorry about that - hadn't noticed that it wasn't specified. Added it to 
both the provider and the test project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

[Tibor17]

Github user Tibor17 commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/161#discussion_r130488490
  
--- Diff: 
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
 ---
@@ -0,0 +1,61 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.plugins.surefire
+  surefire-test-classpath-provider
+  1.0-SNAPSHOT
+  Test provider
+
+  
+2.21-SNAPSHOT
--- End diff --

You should specify parent pom
```

org.apache.maven.surefire
it-parent
1.0
../pom.xml
  
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

[jon-bell]

Github user jon-bell commented on the issue:

https://github.com/apache/maven-surefire/pull/161
  
Thanks - I made the fixes you suggested above, and confirmed that the build 
passed on `mvn clean install -P run-its`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/150
  
ok, take your time. No worries. Just rebase the PR after your team finished 
the release. Surefire need some week to make release as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

[mpkorstanje]

Github user mpkorstanje commented on the issue:

https://github.com/apache/maven-surefire/pull/150
  
Yes! We're satisfied with the current state of the code and more people are 
now able to make releases. As such we're finalizing the release at the moment, 
I expect we'll do a couple of last minute bug fixes but that should be it. I 
can't make any promises about a time frame but I reckon it will be soon now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

[Tibor17]

Github user Tibor17 commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/161#discussion_r130447743
  
--- Diff: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ---
@@ -2755,7 +2755,16 @@ public Classpath getProviderClasspath()
 throws ArtifactResolutionException, ArtifactNotFoundException
 {
 final Map pluginArtifactMap = 
getPluginArtifactMap();
-Artifact plugin = pluginArtifactMap.get( 
"org.apache.maven.plugins:maven-surefire-plugin" );
+Class c = AbstractSurefireMojo.this.getClass();
+Artifact plugin;
+if ( c.getName().equals( 
"org.apache.maven.plugin.failsafe.IntegrationTestMojo" ) )
--- End diff --

I guess this is in method `getProviderClasspath()`
Please split the method in two. First it would call `protected abstract 
Artifact getMojoArtifact()` and then the original statement `return 
dependencyResolver.addProviderToClasspath( pluginArtifactMap, plugin );` where 
`plugin` is `Artifact`. Then force both subclasse to implement 
`getMojoArtifact` which means surefire mojo will implement it as follows:
`final Map pluginArtifactMap = getPluginArtifactMap();
Artifact plugin = pluginArtifactMap.get( 
"org.apache.maven.plugins:maven-surefire-plugin" );`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

[jon-bell]

Github user jon-bell commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/161#discussion_r130447222
  
--- Diff: 
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
 ---
@@ -0,0 +1,61 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.plugins.surefire
+  surefire-test-classpath-provider
+  1.0-SNAPSHOT
+  Test provider
+
+  
+2.21-SNAPSHOT
--- End diff --

I did a `mvn verify` from the top level. I will do a `mvn install -P 
run-its` now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

[jon-bell]

Github user jon-bell commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/161#discussion_r130446456
  
--- Diff: 
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
 ---
@@ -0,0 +1,61 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.plugins.surefire
+  surefire-test-classpath-provider
+  1.0-SNAPSHOT
+  Test provider
+
+  
+2.21-SNAPSHOT
+  
+  
+
+  org.apache.maven.surefire
+  surefire-api
+  ${surefire.version}
+
+  
+
+  
+
+  
+src/main/resources/META-INF
+META-INF
+  
+
+
+  
+org.apache.maven.plugins
+maven-compiler-plugin
--- End diff --

Thanks. I will clean this up. FYI, the entire pom.xml is copied from the 
[SUREFIRE-141  IT 
pom.xml](https://github.com/apache/maven-surefire/blob/cba4adb1b93002c5b4bb2d2f22f461cc53bd8738/surefire-integration-tests/src/test/resources/surefire-141-pluggableproviders-provider/pom.xml).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

[Tibor17]

Github user Tibor17 commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/161#discussion_r130445462
  
--- Diff: 
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
 ---
@@ -0,0 +1,61 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.plugins.surefire
+  surefire-test-classpath-provider
+  1.0-SNAPSHOT
+  Test provider
+
+  
+2.21-SNAPSHOT
+  
+  
+
+  org.apache.maven.surefire
+  surefire-api
+  ${surefire.version}
+
+  
+
+  
+
+  
+src/main/resources/META-INF
+META-INF
+  
+
+
+  
+org.apache.maven.plugins
+maven-compiler-plugin
--- End diff --

This plugin is again in parent pom. Not necessary here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

[Tibor17]

Github user Tibor17 commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/161#discussion_r130445317
  
--- Diff: 
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
 ---
@@ -0,0 +1,61 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.plugins.surefire
+  surefire-test-classpath-provider
+  1.0-SNAPSHOT
+  Test provider
+
+  
+2.21-SNAPSHOT
+  
+  
+
+  org.apache.maven.surefire
+  surefire-api
--- End diff --

Why?
See the `build.log` in target and you will see project version and all 
necessary dependencies hidden in the fork transitive deps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

[Tibor17]

Github user Tibor17 commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/161#discussion_r130444914
  
--- Diff: 
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
 ---
@@ -0,0 +1,61 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+
+  org.apache.maven.plugins.surefire
+  surefire-test-classpath-provider
+  1.0-SNAPSHOT
+  Test provider
+
+  
+2.21-SNAPSHOT
--- End diff --

Pls do not use this property. It comes from [parent 
pom](https://github.com/apache/maven-surefire/blob/master/surefire-integration-tests/src/test/resources/pom.xml).
Did you run the build like this `mvn install -P run-its`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/150
  
@mpkorstanje 
You changed something in your code or what happened that snapshot was not 
available?
Is the release 2.0.0 coming soon?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Apache Maven Compiler 3.6.2

[Karl Heinz Marbaise]

Hi Robert,
On 30/07/17 18:08, Robert Scholte wrote:

Hi,

All these tests are actually testing other libraries:

error-prone-compiler: javac-with-errorprone
groovy-project-with-new-plexus-compiler: 
groovy-eclipse-compiler

MCOMPILER-197: true

So it means that those libraries nor Java 9 ready, but the 
maven-compiler-plugin itself is.


Ok. Good to know...Than it's fine.

Thanks for the explanations.

Kind regards
Karl Heinz Marbaise


Robert

On Sun, 30 Jul 2017 15:21:51 +0200, Karl Heinz Marbaise 
 wrote:



Hi,

I have rechecked the whole log files (testing my release checker 
script ;-() of the runs and found the following for the JDK 9 tests:


And yes the error message is correct cause the "modules" in the JDK 9 
is a single file and not a directory...(was there change?)...



[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.6.2:compile 
(default-compile) on project error-prone-compiler: Fatal error 
compiling: CompilerException: InvocationTargetException: 
java.nio.file.NotDirectoryException: 
/Library/Java/JavaVirtualMachines/jdk1.9.0_ea+180.jdk/Contents/Home/lib/modules 
-> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to 
execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.6.2:compile 
(default-compile) on project error-prone-compiler: Fatal error compiling
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217) 

at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) 

at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) 

at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) 

at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) 

at 
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) 

at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) 


at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)

Furthermore I found the following:

[parsing 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/Helloable.groovy 
- #1/3]
[parsing 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/GroovyHello.groovy 
- #2/3]
[parsing 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/GroovyMain.groovy 
- #3/3]

[readinggroovy/lang/GroovyObject.class]
[readinggroovy/lang/MetaClass.class]
[analyzing 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/Helloable.groovy 
- #1/3]

Annotation processing got disabled, since it requires a 1.6 compliant JVM
--
1. ERROR in 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/Helloable.groovy 
(at line 1)

/*
^
[analyzing 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/GroovyHello.groovy 
- #2/3]
[completed 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/Helloable.groovy 
- #1/3]
[analyzing 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/GroovyMain.groovy 
- #3/3]
[completed 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/GroovyHello.groovy 
- #2/3]

[writingGroovyMain.class - #1]
The type java.lang.Object cannot be resolved. It is indirectly 
referenced from required .class files

--
--
2. ERROR in 
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+180.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.6.2/target/it/groovy-project-with-new-plexus-compiler/src/main/groovy/GroovyHello.groovy 
(at line 1)

/*
^
The type java.lang.String cannot be resolved. It is indirectly 
referenced from required .class files

--

Re: Maven BOF session @ JavaOne

[Brian Fox]

Cool. I'll be there as well.

On Sat, Jul 29, 2017 at 5:58 AM, Robert Scholte 
wrote:

> Hi,
>
> Both my talk and the BOF have been accepted for JavaOne 2017.
> I will host the BOF session together with Manfred Moser.
> All are invited to join.
>
>
> thanks,
> Robert
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

[ANN] Apache Maven Compiler Plugin 3.6.2

[Olivier Lamy]

Hi
The Apache Maven team is pleased to announce the release of the Apache
Maven Compiler plugin, version 3.6.2.
http://maven.apache.org/plugins/maven-compiler-plugin/

You should specify the version in your project's plugin configuration:


 org.apache.maven.plugins
 maven-compiler-plugin
 3.6.2


Release Notes - Maven Compiler Plugin - Version 3.6.2

** Bug
* [MCOMPILER-290] - Fix invalid comment out in the examples of the
module-info documentation
* [MCOMPILER-301] - Upgrade QDox

** Improvement
* [MCOMPILER-298] - Support "-parameters" compiler option as a
configuration key

Enjoy!
-- 
The Apache Maven team