Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1
Is there a snapshot i can test with my production? only see 2.21-SNAPSHOT Thanks -Dan On Mon, Sep 11, 2017 at 5:05 AM, Enrico Olivelliwrote: > +1 (non binding) > > run unit tests on surefire project itself > > on JDK 9+181 run unit tests of other Java8 projects which required > java.se.ee module to be present > > Thank you ! > > Enrico > > > 2017-09-11 5:33 GMT+02:00 Tibor Digana : > > > Hi, > > > > We solved 24 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > projectId=12317927=12340297 > > > > There are 101 issues left in JIRA: > > https://issues.apache.org/jira/i#issues/?jql=project+% > > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1366/ > > https://repository.apache.org/content/repositories/maven- > > 1366/org/apache/maven/surefire/surefire/2.20.1/surefire-2.20.1-source- > > release.zip > > > > Source release checksum(s): > > maven-surefire-plugin-2.20.1-site-source.zip sha1: > > 4187a7932268c7ad467973254d87584085e305c1 > > > > Staging site: > > http://maven.apache.org/surefire-archives/surefire-LATEST/ > > > > Guide to testing staged releases: > > http://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > -- > > Cheers > > Tibor > > >
Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0-alpha-1 (First Public Release)
+1 (to the vote and the comments :) ) Regards, Hervé Le lundi 11 septembre 2017, 21:12:35 CEST Robert Scholte a écrit : > +1 for an alpha > > would be nice if there were ITs so see what would be the result. > > thanks, > Robert > > On Sat, 09 Sep 2017 16:19:52 +0200, Karl Heinz Marbaise > >wrote: > > Hi, > > > > this is the VOTE for the first public release for Maven JLink Plugin... > > > > We solved 1 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321432; > > version=12341361 > > > > There are currently no issues left in JIRA. > > > > If you have any issue to report please open an issue in JIRA > > https://issues.apache.org/jira/projects/MJLINK > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1362/ > > > > https://repository.apache.org/content/repositories/maven-1362/org/apache/m > > aven/plugins/maven-jlink-plugin/3.0.0-alpha-1/maven-jlink-plugin-3.0.0-alp > > ha-1-source-release.zip > > > > Source release checksum(s): > > maven-jlink-plugin-3.0.0-alpha-1-source-release.zip sha1: > > c21ee8085a0ed29adee0e80d47de0c851f96cd54 > > > > Staging site: > > https://maven.apache.org/plugins-archives/maven-jlink-plugin-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > Kind regards > > Karl Heinz Marbaise > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Dependency Plugin version 3.0.2
+1 Regards, Hervé Le samedi 9 septembre 2017, 14:34:49 CEST Karl Heinz Marbaise a écrit : > Hi, > > We solved 7 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227 > rsion=12341254 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDEP%20AND%20reso > lution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C% > 20updated%20DESC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1360 > https://repository.apache.org/content/repositories/maven-1360/org/apache/mav > en/plugins/maven-dependency-plugin/3.0.2/maven-dependency-plugin-3.0.2-sourc > e-release.zip > > Source release checksum(s): > maven-dependency-plugin-3.0.2-source-release.zip sha1: > 3c4aa716e28b241834d47d22e1ff5f6e62f16b9b > > Staging site: > https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Kind regards > Karl Heinz Marbaise > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to ...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/129 Closed as per conversation with @hboutemy on JIRA, see this [comment](https://issues.apache.org/jira/browse/MNG-6282?focusedCommentId=16161977=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16161977). --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in or...
Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/129 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.1
just for the records: it is Windows + Git Bash (MINGW64) only and there is a chance that adding -Djansi.force=true can force JAnsi activation (even if JAnsi fails to detect that it should auto-activate) details on issue in https://issues.apache.org/jira/browse/MNG-6282 , and a future JAnsi issue... Regards, Hervé Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a écrit : > So that is windows only, or were they lost on other OSes for you. > > I have colours on linux (via docker) and os-x > > On 11 September 2017 at 12:35, dejan2...@gmail.com> > wrote: > > +1 (conditionally). > > > > Tested via project that includes dozen of plugins: 1st tier, MojoHaus and > > few 3rd party plugins (so to say). > > > > Everything looks good with one notable regression: > > https://issues.apache.org/jira/browse/MNG-6282 Console output has no > > colors (regression in Maven 3.5.1) > > > > Regards, > > Dejan > > > > On 2017-09-10 17:39, Stephen Connolly > > > > wrote: > > > Hi, > > > > > > We solved 25 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > > version=12338964=Text=12316922 > > > > > There are 350 issues left in JIRA for Maven core: > > > https://issues.apache.org/jira/issues/?jql=project%20% > > > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1364/ > > > > > > The distributable binaries and sources can be found here: > > > https://repository.apache.org/content/repositories/maven-> > > > 1364/org/apache/maven/apache-maven/3.5.1/ > > > > > Specifically the zip, tarball and source archives can be found here: > > > https://repository.apache.org/content/repositories/maven-> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > > > > > https://repository.apache.org/content/repositories/maven-> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > > > > > https://repository.apache.org/content/repositories/maven-> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > > > > > https://repository.apache.org/content/repositories/maven-> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > > > > Source release checksum(s): > > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7 > > > > bd2059560d > > > > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab > > > > 69e698eb0e > > > > > Git tag: > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h= > > > > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > > > > Staging site: > > > https://maven.apache.org/components/ref/3-LATEST/ > > > > > > Vote open for 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > Thanks, > > > > > > Stephen. > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.1
+1 On Sun, 10 Sep 2017 17:39:12 +0200, Stephen Connollywrote: Hi, We solved 25 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12338964=Text=12316922 There are 350 issues left in JIRA for Maven core: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC Staging repo: https://repository.apache.org/content/repositories/maven-1364/ The distributable binaries and sources can be found here: https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/ Specifically the zip, tarball and source archives can be found here: https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz Source release checksum(s): apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7bd2059560d apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab69e698eb0e Git tag: https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=094e4e31a5af55bb17be87675da41d9aeca062f3 Staging site: https://maven.apache.org/components/ref/3-LATEST/ Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 Thanks, Stephen. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 I'll try to address the minor changes soontm. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...
Github user mpkorstanje commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/150#discussion_r138170535 --- Diff: surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/MatchMethodDescriptions.java --- @@ -0,0 +1,74 @@ +package org.apache.maven.surefire.common.junit48; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.junit.runner.Description; +import org.junit.runner.manipulation.Filter; + +import java.util.ArrayList; +import java.util.List; + +/** + * Only run test methods in the given failure set + * + * @author mpkorstanje + */ +final class MatchMethodDescriptions +extends Filter +{ + +private final List filters = new ArrayList(); + +MatchMethodDescriptions( Iterable descriptions ) +{ +for ( Description description : descriptions ) +{ +filters.add( matchMethodDescription ( description ) ); +} +} + +@Override +public boolean shouldRun( Description description ) +{ +for ( Filter filter : filters ) --- End diff -- `MatchMethodDescriptions` is created with a list of failed test descriptions. FailingMethodFilter was created with a list of failed class-method tuples. When `shouldRun` is called the `FailingMethodFilter` would recurse down the description tree to find a leave (a test case). For each leave it uses the class of the description to find the set of failed methods for that class. Then it tests if the set of failed methods contain the method of the description. If so it returns true and the test should be rerun. When `shouldRun` is called the `MatchMethodDescriptions` will check for each failed-test-description if it can be found in the the tree of descriptions. This is done by delegating the recursive descent search to `Filter#matchMethodDescription`. `matchMethodDescription` recurses until it finds a leave, when found it compares descriptions. This should explain where the recursion has been removed. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0-alpha-1 (First Public Release)
+1 for an alpha would be nice if there were ITs so see what would be the result. thanks, Robert On Sat, 09 Sep 2017 16:19:52 +0200, Karl Heinz Marbaisewrote: Hi, this is the VOTE for the first public release for Maven JLink Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321432=12341361 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJLINK Staging repo: https://repository.apache.org/content/repositories/maven-1362/ https://repository.apache.org/content/repositories/maven-1362/org/apache/maven/plugins/maven-jlink-plugin/3.0.0-alpha-1/maven-jlink-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jlink-plugin-3.0.0-alpha-1-source-release.zip sha1: c21ee8085a0ed29adee0e80d47de0c851f96cd54 Staging site: https://maven.apache.org/plugins-archives/maven-jlink-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
Hi, isn't it weird that jmod:create has parameters for classpath and modulepath? why not start using the dependencies as specified in the pom? and the plugin shouldn't use artifactId as default for the modulename. Current best practice is to include the packagename as namespace. And if the module-info.class is there, it is also possible to extract this value with plexus-java I'm sorry, but I have to give this a -1. I can help fix these things. Robert On Sat, 09 Sep 2017 15:52:24 +0200, Karl Heinz Marbaisewrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1361/ https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in or...
GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/129 [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to solve issues s on Windows/GitBash JIRA ticket: https://issues.apache.org/jira/browse/MNG-6282 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejan2609/maven MNG-6282-jansi-downgrade Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit e1f140fbfc5aa2b443b56bcd88759a78221ce335 Author: dejan2609Date: 2017-09-11T17:25:55Z [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to solve issues on Windows/GitBash note: related to MNG-6205 and MNG-6218 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
Hi, here is my +1, Kind Regards Karl Heinz Marbaise On 09/09/17 15:52, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1361/ https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0-alpha-1 (First Public Release)
Hi, here is my +1 Kind regards Karl Heinz Marbaise On 09/09/17 16:19, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JLink Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321432=12341361 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJLINK Staging repo: https://repository.apache.org/content/repositories/maven-1362/ https://repository.apache.org/content/repositories/maven-1362/org/apache/maven/plugins/maven-jlink-plugin/3.0.0-alpha-1/maven-jlink-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jlink-plugin-3.0.0-alpha-1-source-release.zip sha1: c21ee8085a0ed29adee0e80d47de0c851f96cd54 Staging site: https://maven.apache.org/plugins-archives/maven-jlink-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Apache Maven BOF
Hi, I've started the preparations for the BOF session at JavaOne this year. Time and location have been set: Tuesday, Oct 03, 7:45 p.m. - 8:30 p.m. | Moscone West - Room 2007[1] I'll be there together with Brian and Manfred. I've also received the confirmation the do the same session at Devoxx[2] Anyone who wants to join can contact me. thanks, Robert [1] https://events.rainfocus.com/catalog/oracle/oow17/catalogjavaone17 [2] https://cfp.devoxx.be/2017/talk/KAE-3592/Apache_Maven_BOF - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.1
Nice fix On Mon, 11 Sep 2017 11:31:34 +0200, Stephen Connollywrote: http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the test going forward, with that change on Azul's Zulu JDK 7 I get: Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.7.0_154, vendor: Azul Systems, Inc. Java home: /usr/lib/jvm/zulu-7-amd64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" mvn verify => SUCCESS On 11 September 2017 at 02:00, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: So Azul's Zulu 7 does not have com.sun.script.javascript.RhinoScriptEngineFactory or any ScriptEngineFactory in the base classloader... Zulu 8 has jdk.nashorn.api.scripting.NashornScriptEngineFactory So at this point in time, my analysis is that the DefaultClassRealmManagerTest is not a valid test when the default classloader does not have any ScriptEngineFactory... I'm going to commit a fix, but this should not invalidate the 3.5.1 release On 11 September 2017 at 01:53, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: With https://github.com/apache/maven-integration-testing/ commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get Michael's test failures: Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.7.0_154, vendor: Azul Systems, Inc. Java home: /usr/lib/jvm/zulu-7-amd64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" --- Test set: org.apache.maven.classrealm.DefaultClassRealmManagerTest --- Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 2.128 sec <<< FAILURE! - in org.apache.maven.classrealm.De faultClassRealmManagerTest testMNG6275_mavenApiRealmDefaultParentClassLoader(org. apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 1.12 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes tMNG6275_mavenApiRealmDefaultParentClassLoader(DefaultClassR ealmManagerTest.java:91) testMNG6275_coreRealmDefaultParentClassLoader(org.apache. maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.271 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes tMNG6275_coreRealmDefaultParentClassLoader(DefaultClassRealm ManagerTest.java:99) testMNG6275_extensionRealmDefaultParentClassLoader(org. apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.251 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes tMNG6275_extensionRealmDefaultParentClassLoader(DefaultClass RealmManagerTest.java:73) testMNG6275_pluginRealmDefaultParentClassLoader(org.apache. maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.244 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes tMNG6275_pluginRealmDefaultParentClassLoader(DefaultClassRea lmManagerTest.java:62) testMNG6275_projectRealmDefaultParentClassLoader(org.apache. maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.242 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes tMNG6275_projectRealmDefaultParentClassLoader(DefaultClassRe almManagerTest.java:83) investigating... On 11 September 2017 at 01:44, Stephen Connolly <
[GitHub] maven-enforcer pull request #28: [MENFORCER-281] added IT to show the issue.
GitHub user jtnord opened a pull request: https://github.com/apache/maven-enforcer/pull/28 [MENFORCER-281] added IT to show the issue. Added an IT to demonstrate [MENFORCER-281](https://issues.apache.org/jira/browse/MENFORCER-281) Fails with the following which is slightly different to what is observed in the real project, but is at least a starter for 10 ``` [ERROR] /org/apache/maven/its/enforcer/menforcer281-parent/$%7Brevision%7D/menforcer281-parent-$%7Brevision%7D.pom java.lang.IllegalArgumentException: Illegal character in path at index 110: https://X/org/apache/maven/its/enforcer/m enforcer281-parent/${revision}/maven-metadata.xml at java.net.URI.create(URI.java:852) at org.apache.maven.wagon.providers.http.httpclient.client.methods.HttpGet.(HttpGet.java:69) at org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:972) at org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:962) at org.apache.maven.wagon.StreamWagon.getInputStream(StreamWagon.java:126) at org.apache.maven.wagon.StreamWagon.getIfNewer(StreamWagon.java:88) at org.apache.maven.wagon.StreamWagon.get(StreamWagon.java:61) at org.apache.maven.repository.legacy.DefaultWagonManager.getRemoteFile(DefaultWagonManager.java:413) at org.apache.maven.repository.legacy.DefaultWagonManager.getArtifactMetadata(DefaultWagonManager.java:233) at org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.resolve(DefaultRepositoryMetadataManager.java:132) at org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.resolve(DefaultRepositoryMetadataManager.java:71) at org.codehaus.mojo.mrm.maven.ProxyArtifactStore.getMetadata(ProxyArtifactStore.java:480) at org.codehaus.mojo.mrm.maven.ProxyArtifactStore.getMetadataLastModified(ProxyArtifactStore.java:536) at org.codehaus.mojo.mrm.impl.maven.CompositeArtifactStore.getMetadataLastModified(CompositeArtifactStore.java:339) at org.codehaus.mojo.mrm.impl.maven.ArtifactStoreFileSystem.listEntries(ArtifactStoreFileSystem.java:147) at org.codehaus.mojo.mrm.impl.digest.AutoDigestFileSystem.listEntries(AutoDigestFileSystem.java:100) at org.codehaus.mojo.mrm.api.BaseFileSystem.get(BaseFileSystem.java:89) at org.codehaus.mojo.mrm.impl.digest.AutoDigestFileSystem.get(AutoDigestFileSystem.java:185) at org.codehaus.mojo.mrm.servlet.FileSystemServlet.doGet(FileSystemServlet.java:157) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:362) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139) at org.mortbay.jetty.Server.handle(Server.java:313) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:506) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:830) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:381) at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:227) at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442) Caused by: java.net.URISyntaxException: Illegal character in path at index 110: https://XX/org/apache/maven/its/enforc er/menforcer281-parent/${revision}/maven-metadata.xml at java.net.URI$Parser.fail(URI.java:2848) at java.net.URI$Parser.checkChars(URI.java:3021) at java.net.URI$Parser.parseHierarchical(URI.java:3105) at java.net.URI$Parser.parse(URI.java:3053) at java.net.URI.(URI.java:588) at java.net.URI.create(URI.java:850) ... 33 more [INFO] ..FAILED (5.7 s) ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/jtnord/maven-enforcer MENFORCER-281 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-enforcer/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message:
Re: [VOTE] Release Apache Maven 3.5.1
+1 S. On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338964=Text=12316922 > > There are 350 issues left in JIRA for Maven core: > https://issues.apache.org/jira/issues/?jql=project%20% > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1364/ > > The distributable binaries and sources can be found here: > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/ > > Specifically the zip, tarball and source archives can be found here: > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > Source release checksum(s): > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7 > bd2059560d > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab69e698eb0e > > Git tag: > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h= > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > Staging site: > https://maven.apache.org/components/ref/3-LATEST/ > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Thanks, > > Stephen. >
Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1
+1 (non binding) run unit tests on surefire project itself on JDK 9+181 run unit tests of other Java8 projects which required java.se.ee module to be present Thank you ! Enrico 2017-09-11 5:33 GMT+02:00 Tibor Digana: > Hi, > > We solved 24 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12317927=12340297 > > There are 101 issues left in JIRA: > https://issues.apache.org/jira/i#issues/?jql=project+% > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1366/ > https://repository.apache.org/content/repositories/maven- > 1366/org/apache/maven/surefire/surefire/2.20.1/surefire-2.20.1-source- > release.zip > > Source release checksum(s): > maven-surefire-plugin-2.20.1-site-source.zip sha1: > 4187a7932268c7ad467973254d87584085e305c1 > > Staging site: > http://maven.apache.org/surefire-archives/surefire-LATEST/ > > Guide to testing staged releases: > http://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > -- > Cheers > Tibor >
Re: [VOTE] Release Apache Maven 3.5.1
So that is windows only, or were they lost on other OSes for you. I have colours on linux (via docker) and os-x On 11 September 2017 at 12:35, dejan2...@gmail.comwrote: > +1 (conditionally). > > Tested via project that includes dozen of plugins: 1st tier, MojoHaus and > few 3rd party plugins (so to say). > > Everything looks good with one notable regression: > https://issues.apache.org/jira/browse/MNG-6282 Console output has no > colors (regression in Maven 3.5.1) > > Regards, > Dejan > > On 2017-09-10 17:39, Stephen Connolly > wrote: > > Hi, > > > > We solved 25 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338964=Text=12316922 > > > > There are 350 issues left in JIRA for Maven core: > > https://issues.apache.org/jira/issues/?jql=project%20% > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1364/ > > > > The distributable binaries and sources can be found here: > > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/ > > > > Specifically the zip, tarball and source archives can be found here: > > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > > > Source release checksum(s): > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7 > bd2059560d > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab > 69e698eb0e > > > > Git tag: > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h= > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > > > Staging site: > > https://maven.apache.org/components/ref/3-LATEST/ > > > > Vote open for 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > Thanks, > > > > Stephen. > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven 3.5.1
+1 (conditionally). Tested via project that includes dozen of plugins: 1st tier, MojoHaus and few 3rd party plugins (so to say). Everything looks good with one notable regression: https://issues.apache.org/jira/browse/MNG-6282 Console output has no colors (regression in Maven 3.5.1) Regards, Dejan On 2017-09-10 17:39, Stephen Connollywrote: > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12338964=Text=12316922 > > There are 350 issues left in JIRA for Maven core: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1364/ > > The distributable binaries and sources can be found here: > https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/ > > Specifically the zip, tarball and source archives can be found here: > https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > https://repository.apache.org/content/repositories/maven-1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > Source release checksum(s): > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7bd2059560d > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab69e698eb0e > > Git tag: > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=094e4e31a5af55bb17be87675da41d9aeca062f3 > > Staging site: > https://maven.apache.org/components/ref/3-LATEST/ > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Thanks, > > Stephen. > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.1
On 11 Sep 2017, at 18:10, Stephen Connolly wrote: > I wonder if mng-6275 is affecting that plugin Didn't manage to get a chance to look into this tonight :( Tho that ticket mentions nashorn, phantonjs is a C/native headless browser library, so it doesn't feel like it could be related. If there's a build available with a fix for that, welcome to give it a bash. I'll try carve out some time in the morning to see if I can make a simple standalone project... --- "The ease with which a change can be implemented has no relevance at all to whether it is the right change for the (Java) Platform for all time." Mark Reinhold. Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt signature.asc Description: OpenPGP digital signature
Re: Tests for MNG-6275 fail on Java 1.7.0_151-b01
Tibor, yes, but with Java 8 the class loader that has the script engine changed, which is what MNG-6275 is all about... the failing tests are because Zulu JDK 7 doesn't have any script engine in the boot classpath and the test (as originally written) assumes there is at least one On 11 September 2017 at 11:51, Tibor Diganawrote: > ServiceLoader in Java takes System ClassLoader by default. > > On Mon, Sep 11, 2017 at 11:41 AM, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > > https://github.com/apache/maven/commit/542a7a89156263b34d1472e9d9c1a2 > > 795afccd2d > > > > If the JRE does not have a ScriptEngineFactory then the test cannot pass > as > > it relies on the assumption (invalid for Java 7) that there is always > > a ScriptEngineFactory available. > > > > You can use this small class to check your JRE for ScriptEngineFactory > > implementations: > > > > import java.util.ServiceLoader; > > > > import javax.script.ScriptEngineFactory; > > > > public class ProbeScriptEngineFactory { > > public static void main(String[] args) { > > ServiceLoader sef = ServiceLoader.load( > > ScriptEngineFactory.class ); > > System.out.println("Boot classloader"); > > System.out.println(""); > > System.out.println(); > > for (ScriptEngineFactory f: sef) { > > System.out.println(f.getClass().getName()); > > } > > System.out.println(); > > sef = ServiceLoader.load( ScriptEngineFactory.class, > > ProbeScriptEngineFactory.class.getClassLoader() ); > > System.out.println("Main classloader"); > > System.out.println(""); > > System.out.println(); > > for (ScriptEngineFactory f: sef) { > > System.out.println(f.getClass().getName()); > > } > > } > > } > > > > Here are some outputs: > > > > Apple JVM > > -- > > > > java version "1.6.0_24" > > Java(TM) SE Runtime Environment (build 1.6.0_24-b07-334) > > Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02-334, mixed mode) > > Boot classloader > > > > > > com.sun.script.javascript.RhinoScriptEngineFactory > > > > Main classloader > > > > > > com.sun.script.javascript.RhinoScriptEngineFactory > > > > OpenJDK 7 u60 > > - > > > > openjdk version "1.7.0-u60-unofficial" > > OpenJDK Runtime Environment (build 1.7.0-u60-unofficial-b30) > > OpenJDK 64-Bit Server VM (build 24.60-b09, mixed mode) > > Boot classloader > > > > > > > > Main classloader > > > > > > Oracle Java 7u80 > > --- > > > > java version "1.7.0_80" > > Java(TM) SE Runtime Environment (build 1.7.0_80-b15) > > Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode) > > Boot classloader > > > > > > com.sun.script.javascript.RhinoScriptEngineFactory > > > > Main classloader > > > > > > com.sun.script.javascript.RhinoScriptEngineFactory > > > > Azul's Zulu 7u154 > > --- > > > > openjdk version "1.7.0_154" > > OpenJDK Runtime Environment (Zulu 7.20.0.3-linux64) (build 1.7.0_154-b01) > > OpenJDK 64-Bit Server VM (Zulu 7.20.0.3-linux64) (build 24.154-b01, mixed > > mode) > > Boot classloader > > > > > > > > Main classloader > > > > > > Oracle Java 8u131 > > - > > > > java version "1.8.0_131" > > Java(TM) SE Runtime Environment (build 1.8.0_131-b11) > > Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode) > > Boot classloader > > > > > > jdk.nashorn.api.scripting.NashornScriptEngineFactory > > > > Main classloader > > > > > > jdk.nashorn.api.scripting.NashornScriptEngineFactory > > > > > > Now IIUC, Nashorn is part of Java 8 but Rhino was not required as part of > > Java 7, hence from Java 8 onwards there should always be a > > ScriptEngineFactory, but not every Java 7 was required to have one. > > > > On 10 September 2017 at 14:58, Stephen Connolly < > > stephen.alan.conno...@gmail.com> wrote: > > > > > Might just be the test is looking for an implementation class not > > > available on those jres. Do you have the failure messages > > > > > > On Sun 10 Sep 2017 at 22:29, Tibor Digana > > > > wrote: > > > > > >> You think it has to do you the commit fixing Class Loader issue or the > > >> previous commits as well? > > >> > > >> On Sun, Sep 10, 2017 at 11:23 PM, Michael Osipov > > > >> wrote: > > >> > > >> > Am 2017-09-10 um 23:19 schrieb Tibor Digana: > > >> > > > >> >> Definitely I agree! > > >> >> Let's see if it is JDK issue or platform issue. Let's exclude > Oracle > > >> Java > > >> >> suspicion and then it's serious issue. > > >> >> > > >> > > > >> > Not a platform one. Reproduced on Windows 10 with Zulu 7 Update > 154. I > > >> > will download Oracla Java 7 from MOSC and test again. I am pretty > sure > > >> that > > >> > it will fail too. > > >> > > > >> > > > >> > On Sun, Sep 10, 2017 at 11:17 PM, Michael Osipov <
Re: Tests for MNG-6275 fail on Java 1.7.0_151-b01
ServiceLoader in Java takes System ClassLoader by default. On Mon, Sep 11, 2017 at 11:41 AM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > https://github.com/apache/maven/commit/542a7a89156263b34d1472e9d9c1a2 > 795afccd2d > > If the JRE does not have a ScriptEngineFactory then the test cannot pass as > it relies on the assumption (invalid for Java 7) that there is always > a ScriptEngineFactory available. > > You can use this small class to check your JRE for ScriptEngineFactory > implementations: > > import java.util.ServiceLoader; > > import javax.script.ScriptEngineFactory; > > public class ProbeScriptEngineFactory { > public static void main(String[] args) { > ServiceLoader sef = ServiceLoader.load( > ScriptEngineFactory.class ); > System.out.println("Boot classloader"); > System.out.println(""); > System.out.println(); > for (ScriptEngineFactory f: sef) { > System.out.println(f.getClass().getName()); > } > System.out.println(); > sef = ServiceLoader.load( ScriptEngineFactory.class, > ProbeScriptEngineFactory.class.getClassLoader() ); > System.out.println("Main classloader"); > System.out.println(""); > System.out.println(); > for (ScriptEngineFactory f: sef) { > System.out.println(f.getClass().getName()); > } > } > } > > Here are some outputs: > > Apple JVM > -- > > java version "1.6.0_24" > Java(TM) SE Runtime Environment (build 1.6.0_24-b07-334) > Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02-334, mixed mode) > Boot classloader > > > com.sun.script.javascript.RhinoScriptEngineFactory > > Main classloader > > > com.sun.script.javascript.RhinoScriptEngineFactory > > OpenJDK 7 u60 > - > > openjdk version "1.7.0-u60-unofficial" > OpenJDK Runtime Environment (build 1.7.0-u60-unofficial-b30) > OpenJDK 64-Bit Server VM (build 24.60-b09, mixed mode) > Boot classloader > > > > Main classloader > > > Oracle Java 7u80 > --- > > java version "1.7.0_80" > Java(TM) SE Runtime Environment (build 1.7.0_80-b15) > Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode) > Boot classloader > > > com.sun.script.javascript.RhinoScriptEngineFactory > > Main classloader > > > com.sun.script.javascript.RhinoScriptEngineFactory > > Azul's Zulu 7u154 > --- > > openjdk version "1.7.0_154" > OpenJDK Runtime Environment (Zulu 7.20.0.3-linux64) (build 1.7.0_154-b01) > OpenJDK 64-Bit Server VM (Zulu 7.20.0.3-linux64) (build 24.154-b01, mixed > mode) > Boot classloader > > > > Main classloader > > > Oracle Java 8u131 > - > > java version "1.8.0_131" > Java(TM) SE Runtime Environment (build 1.8.0_131-b11) > Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode) > Boot classloader > > > jdk.nashorn.api.scripting.NashornScriptEngineFactory > > Main classloader > > > jdk.nashorn.api.scripting.NashornScriptEngineFactory > > > Now IIUC, Nashorn is part of Java 8 but Rhino was not required as part of > Java 7, hence from Java 8 onwards there should always be a > ScriptEngineFactory, but not every Java 7 was required to have one. > > On 10 September 2017 at 14:58, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > > Might just be the test is looking for an implementation class not > > available on those jres. Do you have the failure messages > > > > On Sun 10 Sep 2017 at 22:29, Tibor Digana> > wrote: > > > >> You think it has to do you the commit fixing Class Loader issue or the > >> previous commits as well? > >> > >> On Sun, Sep 10, 2017 at 11:23 PM, Michael Osipov > >> wrote: > >> > >> > Am 2017-09-10 um 23:19 schrieb Tibor Digana: > >> > > >> >> Definitely I agree! > >> >> Let's see if it is JDK issue or platform issue. Let's exclude Oracle > >> Java > >> >> suspicion and then it's serious issue. > >> >> > >> > > >> > Not a platform one. Reproduced on Windows 10 with Zulu 7 Update 154. I > >> > will download Oracla Java 7 from MOSC and test again. I am pretty sure > >> that > >> > it will fail too. > >> > > >> > > >> > On Sun, Sep 10, 2017 at 11:17 PM, Michael Osipov > > >> >> wrote: > >> >> > >> >> Am 2017-09-10 um 23:15 schrieb Tibor Digana: > >> >>> > >> >>> This one 1.7.0_80 which is 7u80: > >> http://www.oracle.com/technetwork/java/javase/downloads/ > >> java-archive-downloads-javase7-521261.html > >> > >> > >> >>> No one will seriously run this one. So if we say that our stuff runs > >> off > >> >>> 7 > >> >>> then we have to test OpenJDK and Zulu too. > >> >>> > >> >>> Michael > >> >>> > >> >>> > >> >>> On Sun, Sep 10, 2017 at 11:12 PM, Michael Osipov > >> wrote: > >> >>> > >> > >> Am 2017-09-10 um 23:07 schrieb Tibor Digana: > >> > >> > > >> >
Re: Tests for MNG-6275 fail on Java 1.7.0_151-b01
https://github.com/apache/maven/commit/542a7a89156263b34d1472e9d9c1a2795afccd2d If the JRE does not have a ScriptEngineFactory then the test cannot pass as it relies on the assumption (invalid for Java 7) that there is always a ScriptEngineFactory available. You can use this small class to check your JRE for ScriptEngineFactory implementations: import java.util.ServiceLoader; import javax.script.ScriptEngineFactory; public class ProbeScriptEngineFactory { public static void main(String[] args) { ServiceLoader sef = ServiceLoader.load( ScriptEngineFactory.class ); System.out.println("Boot classloader"); System.out.println(""); System.out.println(); for (ScriptEngineFactory f: sef) { System.out.println(f.getClass().getName()); } System.out.println(); sef = ServiceLoader.load( ScriptEngineFactory.class, ProbeScriptEngineFactory.class.getClassLoader() ); System.out.println("Main classloader"); System.out.println(""); System.out.println(); for (ScriptEngineFactory f: sef) { System.out.println(f.getClass().getName()); } } } Here are some outputs: Apple JVM -- java version "1.6.0_24" Java(TM) SE Runtime Environment (build 1.6.0_24-b07-334) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02-334, mixed mode) Boot classloader com.sun.script.javascript.RhinoScriptEngineFactory Main classloader com.sun.script.javascript.RhinoScriptEngineFactory OpenJDK 7 u60 - openjdk version "1.7.0-u60-unofficial" OpenJDK Runtime Environment (build 1.7.0-u60-unofficial-b30) OpenJDK 64-Bit Server VM (build 24.60-b09, mixed mode) Boot classloader Main classloader Oracle Java 7u80 --- java version "1.7.0_80" Java(TM) SE Runtime Environment (build 1.7.0_80-b15) Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode) Boot classloader com.sun.script.javascript.RhinoScriptEngineFactory Main classloader com.sun.script.javascript.RhinoScriptEngineFactory Azul's Zulu 7u154 --- openjdk version "1.7.0_154" OpenJDK Runtime Environment (Zulu 7.20.0.3-linux64) (build 1.7.0_154-b01) OpenJDK 64-Bit Server VM (Zulu 7.20.0.3-linux64) (build 24.154-b01, mixed mode) Boot classloader Main classloader Oracle Java 8u131 - java version "1.8.0_131" Java(TM) SE Runtime Environment (build 1.8.0_131-b11) Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode) Boot classloader jdk.nashorn.api.scripting.NashornScriptEngineFactory Main classloader jdk.nashorn.api.scripting.NashornScriptEngineFactory Now IIUC, Nashorn is part of Java 8 but Rhino was not required as part of Java 7, hence from Java 8 onwards there should always be a ScriptEngineFactory, but not every Java 7 was required to have one. On 10 September 2017 at 14:58, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Might just be the test is looking for an implementation class not > available on those jres. Do you have the failure messages > > On Sun 10 Sep 2017 at 22:29, Tibor Digana> wrote: > >> You think it has to do you the commit fixing Class Loader issue or the >> previous commits as well? >> >> On Sun, Sep 10, 2017 at 11:23 PM, Michael Osipov >> wrote: >> >> > Am 2017-09-10 um 23:19 schrieb Tibor Digana: >> > >> >> Definitely I agree! >> >> Let's see if it is JDK issue or platform issue. Let's exclude Oracle >> Java >> >> suspicion and then it's serious issue. >> >> >> > >> > Not a platform one. Reproduced on Windows 10 with Zulu 7 Update 154. I >> > will download Oracla Java 7 from MOSC and test again. I am pretty sure >> that >> > it will fail too. >> > >> > >> > On Sun, Sep 10, 2017 at 11:17 PM, Michael Osipov >> >> wrote: >> >> >> >> Am 2017-09-10 um 23:15 schrieb Tibor Digana: >> >>> >> >>> This one 1.7.0_80 which is 7u80: >> http://www.oracle.com/technetwork/java/javase/downloads/ >> java-archive-downloads-javase7-521261.html >> >> >> >>> No one will seriously run this one. So if we say that our stuff runs >> off >> >>> 7 >> >>> then we have to test OpenJDK and Zulu too. >> >>> >> >>> Michael >> >>> >> >>> >> >>> On Sun, Sep 10, 2017 at 11:12 PM, Michael Osipov >> wrote: >> >>> >> >> Am 2017-09-10 um 23:07 schrieb Tibor Digana: >> >> > >> > Michael, now try with Oracle Java 7. >> > >> >> >> >> >> >> Last public version or up-to-date paid version? >> > >> > On Sun, Sep 10, 2017 at 11:02 PM, Michael Osipov < >> micha...@apache.org> >> > >> > wrote: >> >> >> >> Am 2017-09-10 um 22:27 schrieb Stephen Connolly: >> >> >> >> >> >>> Well I ran the release with 1.7.0_80 which iirc is the last public >> >>> >> >>> release >> of Oracle Java 7... >>
Re: [VOTE] Release Apache Maven 3.5.1
http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the test going forward, with that change on Azul's Zulu JDK 7 I get: Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.7.0_154, vendor: Azul Systems, Inc. Java home: /usr/lib/jvm/zulu-7-amd64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" mvn verify => SUCCESS On 11 September 2017 at 02:00, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > So Azul's Zulu 7 does not have > > com.sun.script.javascript.RhinoScriptEngineFactory or any > ScriptEngineFactory in the base classloader... > > Zulu 8 has jdk.nashorn.api.scripting.NashornScriptEngineFactory > > So at this point in time, my analysis is that the > DefaultClassRealmManagerTest is not a valid test when the default > classloader does not have any ScriptEngineFactory... I'm going to commit > a fix, but this should not invalidate the 3.5.1 release > > On 11 September 2017 at 01:53, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > >> With https://github.com/apache/maven-integration-testing/ >> commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get >> Michael's test failures: >> >> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; >> 2017-09-10T12:42:54Z) >> Maven home: /work/bin >> Java version: 1.7.0_154, vendor: Azul Systems, Inc. >> Java home: /usr/lib/jvm/zulu-7-amd64/jre >> Default locale: en_US, platform encoding: UTF-8 >> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" >> >> >> >> --- >> Test set: org.apache.maven.classrealm.DefaultClassRealmManagerTest >> >> --- >> Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 2.128 sec >> <<< FAILURE! - in org.apache.maven.classrealm.De >> faultClassRealmManagerTest >> testMNG6275_mavenApiRealmDefaultParentClassLoader(org. >> apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: >> 1.12 sec <<< FAILURE! >> junit.framework.AssertionFailedError: null >> at junit.framework.Assert.fail(Assert.java:55) >> at junit.framework.Assert.assertTrue(Assert.java:22) >> at junit.framework.Assert.assertTrue(Assert.java:31) >> at junit.framework.TestCase.assertTrue(TestCase.java:201) >> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes >> tMNG6275_mavenApiRealmDefaultParentClassLoader(DefaultClassR >> ealmManagerTest.java:91) >> >> testMNG6275_coreRealmDefaultParentClassLoader(org.apache. >> maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.271 sec >> <<< FAILURE! >> junit.framework.AssertionFailedError: null >> at junit.framework.Assert.fail(Assert.java:55) >> at junit.framework.Assert.assertTrue(Assert.java:22) >> at junit.framework.Assert.assertTrue(Assert.java:31) >> at junit.framework.TestCase.assertTrue(TestCase.java:201) >> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes >> tMNG6275_coreRealmDefaultParentClassLoader(DefaultClassRealm >> ManagerTest.java:99) >> >> testMNG6275_extensionRealmDefaultParentClassLoader(org. >> apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: >> 0.251 sec <<< FAILURE! >> junit.framework.AssertionFailedError: null >> at junit.framework.Assert.fail(Assert.java:55) >> at junit.framework.Assert.assertTrue(Assert.java:22) >> at junit.framework.Assert.assertTrue(Assert.java:31) >> at junit.framework.TestCase.assertTrue(TestCase.java:201) >> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes >> tMNG6275_extensionRealmDefaultParentClassLoader(DefaultClass >> RealmManagerTest.java:73) >> >> testMNG6275_pluginRealmDefaultParentClassLoader(org.apache. >> maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.244 sec >> <<< FAILURE! >> junit.framework.AssertionFailedError: null >> at junit.framework.Assert.fail(Assert.java:55) >> at junit.framework.Assert.assertTrue(Assert.java:22) >> at junit.framework.Assert.assertTrue(Assert.java:31) >> at junit.framework.TestCase.assertTrue(TestCase.java:201) >> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes >> tMNG6275_pluginRealmDefaultParentClassLoader(DefaultClassRea >> lmManagerTest.java:62) >> >> testMNG6275_projectRealmDefaultParentClassLoader(org.apache. >> maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.242 sec >> <<< FAILURE! >> junit.framework.AssertionFailedError: null >> at junit.framework.Assert.fail(Assert.java:55) >> at junit.framework.Assert.assertTrue(Assert.java:22) >> at junit.framework.Assert.assertTrue(Assert.java:31) >> at junit.framework.TestCase.assertTrue(TestCase.java:201) >> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes >>
[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...
Github user KroArtem commented on the issue: https://github.com/apache/maven-surefire/pull/141 Not sure about 3.0 stuff but 2.20.1 with last fixes is highly forthcoming. ð --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #143: maven-surefire-parser: add new method isEr...
Github user surli commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/143#discussion_r138015510 --- Diff: surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java --- @@ -156,6 +158,15 @@ public boolean hasFailure() return hasFailure; } +public boolean isError() { --- End diff -- > You are not calling the getter in SurefireReportGenerator I just committed something in that direction but not sure about the modification of the ID in the generated report... --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.1
So Azul's Zulu 7 does not have com.sun.script.javascript.RhinoScriptEngineFactory or any ScriptEngineFactory in the base classloader... Zulu 8 has jdk.nashorn.api.scripting.NashornScriptEngineFactory So at this point in time, my analysis is that the DefaultClassRealmManagerTest is not a valid test when the default classloader does not have any ScriptEngineFactory... I'm going to commit a fix, but this should not invalidate the 3.5.1 release On 11 September 2017 at 01:53, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > With https://github.com/apache/maven-integration-testing/commit/ > a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get Michael's test > failures: > > Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; > 2017-09-10T12:42:54Z) > Maven home: /work/bin > Java version: 1.7.0_154, vendor: Azul Systems, Inc. > Java home: /usr/lib/jvm/zulu-7-amd64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" > > > > --- > Test set: org.apache.maven.classrealm.DefaultClassRealmManagerTest > > --- > Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 2.128 sec > <<< FAILURE! - in org.apache.maven.classrealm.DefaultClassRealmManagerTest > testMNG6275_mavenApiRealmDefaultParentClassLoader(org.apache.maven. > classrealm.DefaultClassRealmManagerTest) Time elapsed: 1.12 sec <<< > FAILURE! > junit.framework.AssertionFailedError: null > at junit.framework.Assert.fail(Assert.java:55) > at junit.framework.Assert.assertTrue(Assert.java:22) > at junit.framework.Assert.assertTrue(Assert.java:31) > at junit.framework.TestCase.assertTrue(TestCase.java:201) > at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_ > mavenApiRealmDefaultParentClassLoader(DefaultClassRealmManagerTest. > java:91) > > testMNG6275_coreRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest) > Time elapsed: 0.271 sec <<< FAILURE! > junit.framework.AssertionFailedError: null > at junit.framework.Assert.fail(Assert.java:55) > at junit.framework.Assert.assertTrue(Assert.java:22) > at junit.framework.Assert.assertTrue(Assert.java:31) > at junit.framework.TestCase.assertTrue(TestCase.java:201) > at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_ > coreRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:99) > > testMNG6275_extensionRealmDefaultParentClassLoader(org.apache.maven. > classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.251 sec <<< > FAILURE! > junit.framework.AssertionFailedError: null > at junit.framework.Assert.fail(Assert.java:55) > at junit.framework.Assert.assertTrue(Assert.java:22) > at junit.framework.Assert.assertTrue(Assert.java:31) > at junit.framework.TestCase.assertTrue(TestCase.java:201) > at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_ > extensionRealmDefaultParentClassLoader(DefaultClassRealmManagerTest. > java:73) > > testMNG6275_pluginRealmDefaultParentClassLoader(org.apache.maven. > classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.244 sec <<< > FAILURE! > junit.framework.AssertionFailedError: null > at junit.framework.Assert.fail(Assert.java:55) > at junit.framework.Assert.assertTrue(Assert.java:22) > at junit.framework.Assert.assertTrue(Assert.java:31) > at junit.framework.TestCase.assertTrue(TestCase.java:201) > at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_ > pluginRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:62) > > testMNG6275_projectRealmDefaultParentClassLoader(org.apache.maven. > classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.242 sec <<< > FAILURE! > junit.framework.AssertionFailedError: null > at junit.framework.Assert.fail(Assert.java:55) > at junit.framework.Assert.assertTrue(Assert.java:22) > at junit.framework.Assert.assertTrue(Assert.java:31) > at junit.framework.TestCase.assertTrue(TestCase.java:201) > at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_ > projectRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:83) > > investigating... > > On 11 September 2017 at 01:44, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > >> Building the source bundles with the binary bundles in the staging repo >> using the Dockerfile environments in https://github.com/apache/mave >> n-integration-testing/tree/master/environments >> >> Debian JDK 7 >> === >> >> Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 >> GNU/Linux >> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; >> 2017-09-10T12:42:54Z) >> Maven home: /work/bin >> Java version: 1.7.0_151, vendor: Oracle Corporation >> Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre >> Default locale: en, platform encoding: UTF-8 >> OS
Re: [VOTE] Release Apache Maven 3.5.1
With https://github.com/apache/maven-integration-testing/commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get Michael's test failures: Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.7.0_154, vendor: Azul Systems, Inc. Java home: /usr/lib/jvm/zulu-7-amd64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" --- Test set: org.apache.maven.classrealm.DefaultClassRealmManagerTest --- Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 2.128 sec <<< FAILURE! - in org.apache.maven.classrealm.DefaultClassRealmManagerTest testMNG6275_mavenApiRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 1.12 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_mavenApiRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:91) testMNG6275_coreRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.271 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_coreRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:99) testMNG6275_extensionRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.251 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_extensionRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:73) testMNG6275_pluginRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.244 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_pluginRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:62) testMNG6275_projectRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest) Time elapsed: 0.242 sec <<< FAILURE! junit.framework.AssertionFailedError: null at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertTrue(Assert.java:31) at junit.framework.TestCase.assertTrue(TestCase.java:201) at org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_projectRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:83) investigating... On 11 September 2017 at 01:44, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Building the source bundles with the binary bundles in the staging repo > using the Dockerfile environments in https://github.com/apache/ > maven-integration-testing/tree/master/environments > > Debian JDK 7 > === > > Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 > GNU/Linux > Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; > 2017-09-10T12:42:54Z) > Maven home: /work/bin > Java version: 1.7.0_151, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre > Default locale: en, platform encoding: UTF-8 > OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" > > mvn verify => SUCCESS > > Debian JDK 8 > === > > Linux 11ef1c114b6b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 > GNU/Linux > Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; > 2017-09-10T12:42:54Z) > Maven home: /work/bin > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre > Default locale: en, platform encoding: UTF-8 > OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" > > mvn verify => SUCCESS > > Fedora JDK 8 > === > > Linux 54211a0e694e 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 > x86_64 x86_64 GNU/Linux > Apache
[GitHub] maven-surefire pull request #143: maven-surefire-parser: add new method isEr...
Github user surli commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/143#discussion_r138012247 --- Diff: surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java --- @@ -196,7 +196,8 @@ else if ( "failure".equals( qName ) ) } else if ( "error".equals( qName ) ) { -testCase.setFailure( attributes.getValue( "message" ), attributes.getValue( "type" ) ); +testCase.setFailure( attributes.getValue( "message" ), attributes.getValue( "type" ) ) --- End diff -- > If having an error, then failure and error are set both. Why? An error is a specific kind of failure: if I start to introduce error details, then I should also add error type, message, line, and I'll got every field of `ReportTestCase` duplicated. My purpose was to keep the field of `ReportTestCase` to report the information around the failure, but to be able to flag it as an error instead of a failure. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.1
Building the source bundles with the binary bundles in the staging repo using the Dockerfile environments in https://github.com/apache/maven-integration-testing/tree/master/environments Debian JDK 7 === Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.7.0_151, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre Default locale: en, platform encoding: UTF-8 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" mvn verify => SUCCESS Debian JDK 8 === Linux 11ef1c114b6b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.8.0_141, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre Default locale: en, platform encoding: UTF-8 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" mvn verify => SUCCESS Fedora JDK 8 === Linux 54211a0e694e 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.8.0_144, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.144-5.b01.fc26.x86_64/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" mvn verify => SUCCESS IBM JDK 8 Linux 199631edceed 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.8.0, vendor: IBM Corporation Java home: /opt/ibm/java/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" mvn verify => SUCCESS Asul Zulu JDK 8 = Linux 10e8f4e46138 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.8.0_144, vendor: Azul Systems, Inc. Java home: /usr/lib/jvm/zulu-8-amd64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix" mvn verify => SUCCESS If I get time later I'll run the integration tests. On 11 September 2017 at 00:20, Dan Tranwrote: > False alarm, I missed configure global settings.xml, it is missing the > default repository setup > > -D > > On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana < > tibor.dig...@googlemail.com> > wrote: > > > +1: > > 3.5.1 works in my project like a charm ;-) > > > > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < > > stephen.alan.conno...@gmail.com> wrote: > > > > > Hi, > > > > > > We solved 25 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > version=12338964=Text=12316922 > > > > > > There are 350 issues left in JIRA for Maven core: > > > https://issues.apache.org/jira/issues/?jql=project%20% > > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > > > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1364/ > > > > > > The distributable binaries and sources can be found here: > > > https://repository.apache.org/content/repositories/maven- > > > 1364/org/apache/maven/apache-maven/3.5.1/ > > > > > > Specifically the zip, tarball and source archives can be found here: > > > https://repository.apache.org/content/repositories/maven- > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > > > https://repository.apache.org/content/repositories/maven- > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > > > https://repository.apache.org/content/repositories/maven- > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > > > https://repository.apache.org/content/repositories/maven- > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > > > > > Source release checksum(s): > > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7 > > > bd2059560d > > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab > > 69e698eb0e > > > > > > Git tag: > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h= > > > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > > > > > Staging site: > > > https://maven.apache.org/components/ref/3-LATEST/ > > > > > > Vote open for 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > Thanks, > > > > > > Stephen. > > > > > > > > > > > -- > > Cheers > > Tibor > > >
[GitHub] maven-surefire issue #143: maven-surefire-parser: add new method isError in ...
Github user surli commented on the issue: https://github.com/apache/maven-surefire/pull/143 Hi @Tibor17 sorry I missed your previous review, I'll make changes in the coming days and open the issue on JIRA --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.1
False alarm, I missed configure global settings.xml, it is missing the default repository setup -D On Sun, Sep 10, 2017 at 11:47 PM, Tibor Diganawrote: > +1: > 3.5.1 works in my project like a charm ;-) > > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > > Hi, > > > > We solved 25 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > version=12338964=Text=12316922 > > > > There are 350 issues left in JIRA for Maven core: > > https://issues.apache.org/jira/issues/?jql=project%20% > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1364/ > > > > The distributable binaries and sources can be found here: > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/ > > > > Specifically the zip, tarball and source archives can be found here: > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > > > Source release checksum(s): > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7 > > bd2059560d > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab > 69e698eb0e > > > > Git tag: > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h= > > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > > > Staging site: > > https://maven.apache.org/components/ref/3-LATEST/ > > > > Vote open for 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > Thanks, > > > > Stephen. > > > > > > -- > Cheers > Tibor >
Re: [VOTE] Release Apache Maven 3.5.1
+1: 3.5.1 works in my project like a charm ;-) On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338964=Text=12316922 > > There are 350 issues left in JIRA for Maven core: > https://issues.apache.org/jira/issues/?jql=project%20% > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1364/ > > The distributable binaries and sources can be found here: > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/ > > Specifically the zip, tarball and source archives can be found here: > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > Source release checksum(s): > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7 > bd2059560d > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab69e698eb0e > > Git tag: > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h= > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > Staging site: > https://maven.apache.org/components/ref/3-LATEST/ > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Thanks, > > Stephen. > -- Cheers Tibor
Re: [VOTE] Release Apache Maven 3.5.1
I have no issue build maven 3.5.2-SNAPSHOT with clean verify at top level, but the following build fails mvn clean verify -f apache-maven C:\views\dev\maven\maven>mvn clean verify -f apache-maven [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building Apache Maven Distribution 3.5.2-SNAPSHOT [INFO] [WARNING] The POM for org.apache.maven:maven-embedder:jar:3.5.2-SNAPSHOT is missing, no dependency information available [WARNING] The POM for org.apache.maven:maven-core:jar:3.5.2-SNAPSHOT is missing, no dependency information available [WARNING] The POM for org.apache.maven:maven-compat:jar:3.5.2-SNAPSHOT is missing, no dependency information available [WARNING] The POM for org.apache.maven:maven-slf4j-provider:jar:3.5.2-SNAPSHOT is missing, no dependency information available [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 0.788 s [INFO] Finished at: 2017-09-10T23:29:22-07:00 [INFO] Final Memory: 10M/243M [INFO] [ERROR] Failed to execute goal on project apache-maven: Could not resolve dependencies for project org.apache.maven:apache-maven:pom:3.5.2-SNAPSHOT: The following artifacts could not be resolved: org.apache.maven:maven-embedder:jar:3.5.2-SNAPSHOT, org.apache.maven:maven-core:jar:3.5.2-SNAPSHOT, org.apache.maven:maven-compat:jar:3.5.2-SNAPSHOT, org.apache.maven:maven-slf4j-provider:jar:3.5.2-SNAPSHOT: Could not find artifact org.apache.maven:maven-embedder:jar:3.5.2-SNAPSHOT -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException no issue with mvn 3.5.0 -Dan On Sun, Sep 10, 2017 at 11:10 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > I wonder if mng-6275 is affecting that plugin > > On Mon 11 Sep 2017 at 01:00, Mark Derricuttwrote: > > > +0 non-commital - > > > > Tested on our tiles/osgi based projects and all seems to work, but for > > some reason - one project that uses the > > org.openqa.selenium.phantomjs.PhantomJSDriverService seems to blowing up > > when using 3.5.1 - need to do some more digging and see if I can spot > whats > > going on. > > > > Will try and dig into this after work tonight. > > > > Mark > > > > On 11 Sep 2017, at 8:01, Arnaud Héritier wrote: > > > > Tested on several projects > > > > +1 > > > > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < > > stephen.alan.conno...@gmail.com> wrote: > > > > Hi, > > > > We solved 25 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > version=12338964=Text=12316922 > > > > There are 350 issues left in JIRA for Maven core: > > https://issues.apache.org/jira/issues/?jql=project%20% > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1364/ > > > > The distributable binaries and sources can be found here: > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/ > > > > Specifically the zip, tarball and source archives can be found here: > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > > https://repository.apache.org/content/repositories/maven- > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > > > Source release checksum(s): > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7 > > bd2059560d > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab > 69e698eb0e > > > > Git tag: > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h= > > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > > > Staging site: > > https://maven.apache.org/components/ref/3-LATEST/ > > > > Vote open for 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > Thanks, > > > > Stephen. > > > > -- > > - > > Arnaud Héritier > > http://aheritier.net > > Mail/GTalk: aheritier AT gmail DOT com > > Twitter/Skype : aheritier > > > > -- > > > > "The ease with which a change can
Re: [VOTE] Release Apache Maven 3.5.1
I wonder if mng-6275 is affecting that plugin On Mon 11 Sep 2017 at 01:00, Mark Derricuttwrote: > +0 non-commital - > > Tested on our tiles/osgi based projects and all seems to work, but for > some reason - one project that uses the > org.openqa.selenium.phantomjs.PhantomJSDriverService seems to blowing up > when using 3.5.1 - need to do some more digging and see if I can spot whats > going on. > > Will try and dig into this after work tonight. > > Mark > > On 11 Sep 2017, at 8:01, Arnaud Héritier wrote: > > Tested on several projects > > +1 > > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338964=Text=12316922 > > There are 350 issues left in JIRA for Maven core: > https://issues.apache.org/jira/issues/?jql=project%20% > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1364/ > > The distributable binaries and sources can be found here: > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/ > > Specifically the zip, tarball and source archives can be found here: > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip > https://repository.apache.org/content/repositories/maven- > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz > > Source release checksum(s): > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7 > bd2059560d > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab69e698eb0e > > Git tag: > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h= > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > Staging site: > https://maven.apache.org/components/ref/3-LATEST/ > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Thanks, > > Stephen. > > -- > - > Arnaud Héritier > http://aheritier.net > Mail/GTalk: aheritier AT gmail DOT com > Twitter/Skype : aheritier > > -- > > "The ease with which a change can be implemented has no relevance at all > to whether it is the right change for the (Java) Platform for all time." — > Mark Reinhold. > > Mark Derricutt > http://www.theoryinpractice.net > http://www.chaliceofblood.net > http://plus.google.com/+MarkDerricutt > http://twitter.com/talios > http://facebook.com/mderricutt > -- Sent from my phone