[GitHub] maven-surefire issue #163: Surefire-report

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/163
  
@shafiullas
This commit is quite good but you have to fix the code style and register 
this issue at JIRA.
The code conventions are listed in 
https://maven.apache.org/developers/conventions/code.html
In the middle of the page is XML for Eclipse and IDEA. You can use it to 
configure your tool.
Then run the local build mvn install -P run-its. The build has 1400 tests, 
so it usually takes 50 minutes to complete on SSD disk.
Please rework the code style according to Maven convention in our project 
and use `git commit --ammend`. There should be only single commit per PR and 
the message should refer to JIRA ID, something like:
[SUREFIRE-12345] Surefire-report
and you can register at our JIRA here:
https://issues.apache.org/jira/projects/SUREFIRE


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #26: [MNG-6298] 3.5.2: ClassNotFoundE...

[bengtsod]

GitHub user bengtsod opened a pull request:

https://github.com/apache/maven-integration-testing/pull/26

[MNG-6298] 3.5.2: ClassNotFoundException

Test for https://github.com/apache/maven/pull/139

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bengtsod/maven-integration-testing master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 01be66f166b2fe61cf9935cc1e5b1fc65e5e729e
Author: Bengt Söderberg 
Date:   2017-12-04T18:49:17Z

[MNG-6298] 3.5.2: ClassNotFoundException

Test for https://github.com/apache/maven/pull/139




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #140: Add org.slf4j.event to exported packages

[dconneely]

GitHub user dconneely opened a pull request:

https://github.com/apache/maven/pull/140

Add org.slf4j.event to exported packages

maven-core should export org.slf4j.event.* from slf4j-api 1.7.15 or later.
For example, this package is where the `Level` class is located.

Otherwise, issues similar to MNG-5842 and MNG-5845 will arise with plugins 
that use Slf4j themselves (or more likely plugins that use libraries that use 
Slf4j).

Discovered while working on in-house Maven plugin that failed with 
`java.lang.NoClassDefFoundError: org/slf4j/event/Level`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dconneely/maven patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit 34bb114b7dbd80380e3d10c6dcffcf08e1ffaf50
Author: David Conneely 
Date:   2017-12-04T18:42:18Z

Add org.slf4j.event to exported packages

maven-core should export org.slf4j.event.* from slf4j-api 1.7.15 or later.
For example, this package is where the `Level` class is located.




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz commented on issue #6: [DOXIA-566] Upgrade dependences and plugin versions

[GitBox]

slachiewicz commented on issue #6: [DOXIA-566] Upgrade dependences and plugin 
versions
URL: https://github.com/apache/maven-doxia/pull/6#issuecomment-348937905
 
 
   ok, plugin updates removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org