Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Sylwester Lachiewicz 
>From my tests looks like a problem with closing PrintStream in JAnsi 1.17.

Sylwester

wt., 27 lut 2018 o 19:21 użytkownik Guillaume Boué 
napisał:

> (Made a mistake and only sent this to Stephen... sorry)
>
> I've found a very small regression, but definitely not a blocker for the
> release I think. When the following is ran:
>
> mvn org.apache.maven.plugins:maven-archetype-plugin:3.0.1:generate
>
> There is a spurious " [0m [0m" at the very last line (note: there are
> escape characters before the two square brackets). Doesn't happen with
> 3.5.2, the line is empty. (Only tested on Windows).
>
> Also, I didn't reproduce Dan's issue on Windows with the Takari smart
> builder on a single sample project. Maybe the number of modules?
>
> Guillaume
>
>
> Le 27/02/2018 à 19:01, Dan Tran a écrit :
> > Hi all,
> >
> > I believe my usage of antrun is legit to make sure user who is using  mvn
> > install ( without clean) has a proper clean up before another plugin
> > execution
> >
> >
> >  org.apache.maven.plugins
> >  maven-antrun-plugin
> >  
> >
> >
> work.around.to.clean.up.classes.before.jsonschema.start
> >  generate-sources
> >  
> >run
> >  
> >  
> >
> >  
> >
> >  
> >
> >  
> >
> >
> >
> > here is the command to reproduce the antrun issue
> >
> >
> >mvn clean install --builder smart -T1.0C -DskipTests
> >
> >
> > Add  -B to remove the issue but it is not ideal
> >
> > Only only happens on windows ( i only test with windows and linux)
> >
> > -D
> >
> >
> >
> > On Tue, Feb 27, 2018 at 7:44 AM, Stephen Connolly <
> > stephen.alan.conno...@gmail.com> wrote:
> >
> >> On 27 February 2018 at 14:46, Mirko Friedenhagen <
> mfriedenha...@gmail.com>
> >> wrote:
> >>
> >>> +1 from my side, tested with 10 inhouse projects. Or is this vote
> >> canceled?
> >> Not cancelled yet. Unclear if Dan's issue is something forking maven and
> >> parsing the output... the task name
> >> "work.around.to.clean.up.classes.before.jsonschema.start" sounds like it
> >> could be doing something crazy like that, in which case it is not using
> -B
> >> when forking maven in Dan's codebase that could be the root cause.
> >>
> >>
> >>> Regards Mirko
> >>> --
> >>> http://illegalstateexception.blogspot.com/
> >>> https://github.com/mfriedenhagen/
> >>> https://bitbucket.org/mfriedenhagen/
> >>>
> >>>
> >>> On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran  wrote:
> correction
> 
>  found this reference, found on 3.5.2 but I only encounter this on
> 3.5.3
> >>> RC
>  https://stackoverflow.com/questions/48723899/maven-
>  numberformatexception-when-packaging
> 
> 
>  On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:
> 
> > found this reference, found on 3.5.2 but I only encounter this on
> >> 3.5.2
> >>> RC
> > https://stackoverflow.com/questions/48723899/maven-
> > numberformatexception-when-packaging
> >
> > On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran 
> wrote:
> >
> >> my build contains 270+ modules using java 8.  The failure found on
> >> windows. Have not tested on Linux  yet
> >>
> >> -D
> >>
> >> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran 
> >> wrote:
> >>> Encounter random failure at antrun MOJO + smart builder
> >>>
> >>> here is the error message
> >>>
> >>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> >>> maven-antrun-plugin:1.8:run
> >>> (work.around.to.clean.up.classes.before.jsonschema.start) on
> >> project
> >>> adm-schema: Error executing Ant tasks: For input string: "1;" ->
> >>> [Help 1]
> >>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> >>> execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> >>> (work.around.to.clean.up.classes.before.jsonschema.start) on
> >> project
> >>> adm-schema: Error executing Ant tasks: For input string: "1;"
> >>>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >>> (MojoExecutor.java:213)
> >>>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >>> (MojoExecutor.java:154)
> >>>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >>> (MojoExecutor.java:146)
> >>>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> >>> buildProject
> >>> (LifecycleModuleBuilder.java:117)
> >>>  at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
> >>> (SmartBuilderImpl.java:205)
> >>>  at io.takari.maven.builder.smart.SmartBuilderImpl$
> >>> ProjectBuildTask.run
> >>> (SmartBuilderImpl.java:77)
> >>>  at java.util.concurrent.Executors$RunnableAdapter.call
> >>> (Executors.java:511)
> >>>  at

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Arnaud Héritier 
+1
No problem found on my side (but light tests)

On Tue, Feb 27, 2018 at 10:31 PM, Olivier Lamy  wrote:

> +1
> Thanks to take care of this release!
>
>
> On Wed, 28 Feb 2018 at 7:03 am, Guillaume Boué  wrote:
>
> > +1
> >
> > Can make a JIRA for this after the release.
> >
> >
> > Le 27/02/2018 à 19:21, Guillaume Boué a écrit :
> > > (Made a mistake and only sent this to Stephen... sorry)
> > >
> > > I've found a very small regression, but definitely not a blocker for
> > > the release I think. When the following is ran:
> > >
> > > mvn org.apache.maven.plugins:maven-archetype-plugin:3.0.1:generate
> > >
> > > There is a spurious " [0m [0m" at the very last line (note: there are
> > > escape characters before the two square brackets). Doesn't happen with
> > > 3.5.2, the line is empty. (Only tested on Windows).
> > >
> > > Also, I didn't reproduce Dan's issue on Windows with the Takari smart
> > > builder on a single sample project. Maybe the number of modules?
> > >
> > > Guillaume
> > >
> > >
> > > Le 27/02/2018 à 19:01, Dan Tran a écrit :
> > >> Hi all,
> > >>
> > >> I believe my usage of antrun is legit to make sure user who is using
> > >> mvn
> > >> install ( without clean) has a proper clean up before another plugin
> > >> execution
> > >>
> > >>
> > >>  org.apache.maven.plugins
> > >> maven-antrun-plugin
> > >>  
> > >>
> > >> work.around.to.clean.up.classes.before.jsonschema.start
> > >>  generate-sources
> > >>  
> > >>run
> > >>  
> > >>  
> > >>
> > >>  
> > >>
> > >>  
> > >>
> > >>  
> > >>
> > >>
> > >>
> > >> here is the command to reproduce the antrun issue
> > >>
> > >>
> > >>mvn clean install --builder smart -T1.0C -DskipTests
> > >>
> > >>
> > >> Add  -B to remove the issue but it is not ideal
> > >>
> > >> Only only happens on windows ( i only test with windows and linux)
> > >>
> > >> -D
> > >>
> > >>
> > >>
> > >> On Tue, Feb 27, 2018 at 7:44 AM, Stephen Connolly <
> > >> stephen.alan.conno...@gmail.com> wrote:
> > >>
> > >>> On 27 February 2018 at 14:46, Mirko Friedenhagen
> > >>> 
> > >>> wrote:
> > >>>
> >  +1 from my side, tested with 10 inhouse projects. Or is this vote
> > >>> canceled?
> > >>> Not cancelled yet. Unclear if Dan's issue is something forking maven
> > >>> and
> > >>> parsing the output... the task name
> > >>> "work.around.to.clean.up.classes.before.jsonschema.start" sounds
> > >>> like it
> > >>> could be doing something crazy like that, in which case it is not
> > >>> using -B
> > >>> when forking maven in Dan's codebase that could be the root cause.
> > >>>
> > >>>
> >  Regards Mirko
> >  --
> >  http://illegalstateexception.blogspot.com/
> >  https://github.com/mfriedenhagen/
> >  https://bitbucket.org/mfriedenhagen/
> > 
> > 
> >  On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran 
> wrote:
> > >correction
> > >
> > > found this reference, found on 3.5.2 but I only encounter this on
> > > 3.5.3
> >  RC
> > > https://stackoverflow.com/questions/48723899/maven-
> > > numberformatexception-when-packaging
> > >
> > >
> > > On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran 
> wrote:
> > >
> > >> found this reference, found on 3.5.2 but I only encounter this on
> > >>> 3.5.2
> >  RC
> > >> https://stackoverflow.com/questions/48723899/maven-
> > >> numberformatexception-when-packaging
> > >>
> > >> On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran 
> > >> wrote:
> > >>
> > >>> my build contains 270+ modules using java 8.  The failure found
> on
> > >>> windows. Have not tested on Linux  yet
> > >>>
> > >>> -D
> > >>>
> > >>> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran 
> > >>> wrote:
> >  Encounter random failure at antrun MOJO + smart builder
> > 
> >  here is the error message
> > 
> >  [ERROR] Failed to execute goal org.apache.maven.plugins:
> >  maven-antrun-plugin:1.8:run
> >  (work.around.to.clean.up.classes.before.jsonschema.start) on
> > >>> project
> >  adm-schema: Error executing Ant tasks: For input string: "1;" ->
> >  [Help 1]
> >  org.apache.maven.lifecycle.LifecycleExecutionException: Failed
> to
> >  execute goal org.apache.maven.plugins:
> maven-antrun-plugin:1.8:run
> >  (work.around.to.clean.up.classes.before.jsonschema.start) on
> > >>> project
> >  adm-schema: Error executing Ant tasks: For input string: "1;"
> >   at org.apache.maven.lifecycle.
> internal.MojoExecutor.execute
> >  (MojoExecutor.java:213)
> >   at org.apache.maven.lifecycle.
> internal.MojoExecutor.execute
>

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Olivier Lamy 
+1
Thanks to take care of this release!


On Wed, 28 Feb 2018 at 7:03 am, Guillaume Boué  wrote:

> +1
>
> Can make a JIRA for this after the release.
>
>
> Le 27/02/2018 à 19:21, Guillaume Boué a écrit :
> > (Made a mistake and only sent this to Stephen... sorry)
> >
> > I've found a very small regression, but definitely not a blocker for
> > the release I think. When the following is ran:
> >
> > mvn org.apache.maven.plugins:maven-archetype-plugin:3.0.1:generate
> >
> > There is a spurious " [0m [0m" at the very last line (note: there are
> > escape characters before the two square brackets). Doesn't happen with
> > 3.5.2, the line is empty. (Only tested on Windows).
> >
> > Also, I didn't reproduce Dan's issue on Windows with the Takari smart
> > builder on a single sample project. Maybe the number of modules?
> >
> > Guillaume
> >
> >
> > Le 27/02/2018 à 19:01, Dan Tran a écrit :
> >> Hi all,
> >>
> >> I believe my usage of antrun is legit to make sure user who is using
> >> mvn
> >> install ( without clean) has a proper clean up before another plugin
> >> execution
> >>
> >>
> >>  org.apache.maven.plugins
> >> maven-antrun-plugin
> >>  
> >>
> >> work.around.to.clean.up.classes.before.jsonschema.start
> >>  generate-sources
> >>  
> >>run
> >>  
> >>  
> >>
> >>  
> >>
> >>  
> >>
> >>  
> >>
> >>
> >>
> >> here is the command to reproduce the antrun issue
> >>
> >>
> >>mvn clean install --builder smart -T1.0C -DskipTests
> >>
> >>
> >> Add  -B to remove the issue but it is not ideal
> >>
> >> Only only happens on windows ( i only test with windows and linux)
> >>
> >> -D
> >>
> >>
> >>
> >> On Tue, Feb 27, 2018 at 7:44 AM, Stephen Connolly <
> >> stephen.alan.conno...@gmail.com> wrote:
> >>
> >>> On 27 February 2018 at 14:46, Mirko Friedenhagen
> >>> 
> >>> wrote:
> >>>
>  +1 from my side, tested with 10 inhouse projects. Or is this vote
> >>> canceled?
> >>> Not cancelled yet. Unclear if Dan's issue is something forking maven
> >>> and
> >>> parsing the output... the task name
> >>> "work.around.to.clean.up.classes.before.jsonschema.start" sounds
> >>> like it
> >>> could be doing something crazy like that, in which case it is not
> >>> using -B
> >>> when forking maven in Dan's codebase that could be the root cause.
> >>>
> >>>
>  Regards Mirko
>  --
>  http://illegalstateexception.blogspot.com/
>  https://github.com/mfriedenhagen/
>  https://bitbucket.org/mfriedenhagen/
> 
> 
>  On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran  wrote:
> >correction
> >
> > found this reference, found on 3.5.2 but I only encounter this on
> > 3.5.3
>  RC
> > https://stackoverflow.com/questions/48723899/maven-
> > numberformatexception-when-packaging
> >
> >
> > On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:
> >
> >> found this reference, found on 3.5.2 but I only encounter this on
> >>> 3.5.2
>  RC
> >> https://stackoverflow.com/questions/48723899/maven-
> >> numberformatexception-when-packaging
> >>
> >> On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran 
> >> wrote:
> >>
> >>> my build contains 270+ modules using java 8.  The failure found on
> >>> windows. Have not tested on Linux  yet
> >>>
> >>> -D
> >>>
> >>> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran 
> >>> wrote:
>  Encounter random failure at antrun MOJO + smart builder
> 
>  here is the error message
> 
>  [ERROR] Failed to execute goal org.apache.maven.plugins:
>  maven-antrun-plugin:1.8:run
>  (work.around.to.clean.up.classes.before.jsonschema.start) on
> >>> project
>  adm-schema: Error executing Ant tasks: For input string: "1;" ->
>  [Help 1]
>  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>  execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>  (work.around.to.clean.up.classes.before.jsonschema.start) on
> >>> project
>  adm-schema: Error executing Ant tasks: For input string: "1;"
>   at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:213)
>   at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:154)
>   at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:146)
>   at
>  org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
>  buildProject
>  (LifecycleModuleBuilder.java:117)
>   at
>  io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Guillaume Boué 

+1

Can make a JIRA for this after the release.


Le 27/02/2018 à 19:21, Guillaume Boué a écrit :

(Made a mistake and only sent this to Stephen... sorry)

I've found a very small regression, but definitely not a blocker for 
the release I think. When the following is ran:


mvn org.apache.maven.plugins:maven-archetype-plugin:3.0.1:generate

There is a spurious "" at the very last line (note: there are 
escape characters before the two square brackets). Doesn't happen with 
3.5.2, the line is empty. (Only tested on Windows).


Also, I didn't reproduce Dan's issue on Windows with the Takari smart 
builder on a single sample project. Maybe the number of modules?


Guillaume


Le 27/02/2018 à 19:01, Dan Tran a écrit :

Hi all,

I believe my usage of antrun is legit to make sure user who is using  
mvn

install ( without clean) has a proper clean up before another plugin
execution

   
 org.apache.maven.plugins
maven-antrun-plugin
 
   
work.around.to.clean.up.classes.before.jsonschema.start
 generate-sources
 
   run
 
 
   
 
   
 
   
 
   


here is the command to reproduce the antrun issue


   mvn clean install --builder smart -T1.0C -DskipTests


Add  -B to remove the issue but it is not ideal

Only only happens on windows ( i only test with windows and linux)

-D



On Tue, Feb 27, 2018 at 7:44 AM, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

On 27 February 2018 at 14:46, Mirko Friedenhagen 


wrote:


+1 from my side, tested with 10 inhouse projects. Or is this vote

canceled?
Not cancelled yet. Unclear if Dan's issue is something forking maven 
and

parsing the output... the task name
"work.around.to.clean.up.classes.before.jsonschema.start" sounds 
like it
could be doing something crazy like that, in which case it is not 
using -B

when forking maven in Dan's codebase that could be the root cause.



Regards Mirko
--
http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/
https://bitbucket.org/mfriedenhagen/


On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran  wrote:

   correction

found this reference, found on 3.5.2 but I only encounter this on 
3.5.3

RC

https://stackoverflow.com/questions/48723899/maven-
numberformatexception-when-packaging


On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:


found this reference, found on 3.5.2 but I only encounter this on

3.5.2

RC

https://stackoverflow.com/questions/48723899/maven-
numberformatexception-when-packaging

On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran  
wrote:



my build contains 270+ modules using java 8.  The failure found on
windows. Have not tested on Linux  yet

-D

On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran 

wrote:

Encounter random failure at antrun MOJO + smart builder

here is the error message

[ERROR] Failed to execute goal org.apache.maven.plugins:

maven-antrun-plugin:1.8:run

(work.around.to.clean.up.classes.before.jsonschema.start) on

project

adm-schema: Error executing Ant tasks: For input string: "1;" ->

[Help 1]

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
(work.around.to.clean.up.classes.before.jsonschema.start) on

project

adm-schema: Error executing Ant tasks: For input string: "1;"
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:213)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:146)
 at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.

buildProject

(LifecycleModuleBuilder.java:117)
 at 
io.takari.maven.builder.smart.SmartBuilderImpl.buildProject

(SmartBuilderImpl.java:205)
 at io.takari.maven.builder.smart.SmartBuilderImpl$

ProjectBuildTask.run

(SmartBuilderImpl.java:77)
 at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:511)
 at java.util.concurrent.FutureTask.run (FutureTask.java:266)
 at java.util.concurrent.ThreadPoolExecutor.runWorker
(ThreadPoolExecutor.java:1149)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:624)
 at java.lang.Thread.run (Thread.java:748)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error
executing Ant tasks: For input string: "1;"
 at org.apache.maven.plugin.antrun.AntRunMojo.execute
(AntRunMojo.java:347)
 at org.apache.maven.plugin.DefaultBuildPluginManager.

executeMojo

(DefaultBuildPluginManager.java:137)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:208)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
 at

Fwd: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Stephen Connolly 


Sent from my iPhone

Begin forwarded message:

> From: Guillaume Boué 
> Date: 27 February 2018 at 18:00:29 GMT
> To: Stephen Connolly 
> Subject: Re: [VOTE] Release Apache Maven 3.5.3
> 
> I've found a very small regression, but definitely not a blocker for the 
> release I think. When the following is ran:
> 
> mvn org.apache.maven.plugins:maven-archetype-plugin:3.0.1:generate
> 
> There is a spurious "" at the very last line (note: there are escape 
> characters before the two square brackets). Doesn't happen with 3.5.2, the 
> line is empty. (Only tested on Windows)
> 
> 
>> Le 27/02/2018 à 16:44, Stephen Connolly a écrit :
>> On 27 February 2018 at 14:46, Mirko Friedenhagen 
>> wrote:
>> 
>>> +1 from my side, tested with 10 inhouse projects. Or is this vote canceled?
>>> 
>> Not cancelled yet. Unclear if Dan's issue is something forking maven and
>> parsing the output... the task name
>> "work.around.to.clean.up.classes.before.jsonschema.start" sounds like it
>> could be doing something crazy like that, in which case it is not using -B
>> when forking maven in Dan's codebase that could be the root cause.
>> 
>> 
>>> Regards Mirko
>>> --
>>> http://illegalstateexception.blogspot.com/
>>> https://github.com/mfriedenhagen/
>>> https://bitbucket.org/mfriedenhagen/
>>> 
>>> 
 On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran  wrote:
   correction
 
 found this reference, found on 3.5.2 but I only encounter this on 3.5.3
>>> RC
 https://stackoverflow.com/questions/48723899/maven-
 numberformatexception-when-packaging
 
 
> On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:
> 
> found this reference, found on 3.5.2 but I only encounter this on 3.5.2
>>> RC
> https://stackoverflow.com/questions/48723899/maven-
> numberformatexception-when-packaging
> 
>> On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran  wrote:
>> 
>> my build contains 270+ modules using java 8.  The failure found on
>> windows. Have not tested on Linux  yet
>> 
>> -D
>> 
>>> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran  wrote:
>>> 
>>> Encounter random failure at antrun MOJO + smart builder
>>> 
>>> here is the error message
>>> 
>>> [ERROR] Failed to execute goal org.apache.maven.plugins:
>>> maven-antrun-plugin:1.8:run
>>> (work.around.to.clean.up.classes.before.jsonschema.start) on project
>>> adm-schema: Error executing Ant tasks: For input string: "1;" ->
>>> [Help 1]
>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>>> execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>>> (work.around.to.clean.up.classes.before.jsonschema.start) on project
>>> adm-schema: Error executing Ant tasks: For input string: "1;"
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:213)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:154)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:146)
>>> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
>>> buildProject
>>> (LifecycleModuleBuilder.java:117)
>>> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>>> (SmartBuilderImpl.java:205)
>>> at io.takari.maven.builder.smart.SmartBuilderImpl$
>>> ProjectBuildTask.run
>>> (SmartBuilderImpl.java:77)
>>> at java.util.concurrent.Executors$RunnableAdapter.call
>>> (Executors.java:511)
>>> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
>>> at java.util.concurrent.ThreadPoolExecutor.runWorker
>>> (ThreadPoolExecutor.java:1149)
>>> at java.util.concurrent.ThreadPoolExecutor$Worker.run
>>> (ThreadPoolExecutor.java:624)
>>> at java.lang.Thread.run (Thread.java:748)
>>> Caused by: org.apache.maven.plugin.MojoExecutionException: Error
>>> executing Ant tasks: For input string: "1;"
>>> at org.apache.maven.plugin.antrun.AntRunMojo.execute
>>> (AntRunMojo.java:347)
>>> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
>>> (DefaultBuildPluginManager.java:137)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:208)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:154)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:146)
>>> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
>>> buildProject
>>> (LifecycleModuleBuilder.java:117)
>>> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>>> (SmartBuilderImpl.java:205)
>>> at

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Guillaume Boué 

(Made a mistake and only sent this to Stephen... sorry)

I've found a very small regression, but definitely not a blocker for the 
release I think. When the following is ran:


mvn org.apache.maven.plugins:maven-archetype-plugin:3.0.1:generate

There is a spurious "" at the very last line (note: there are 
escape characters before the two square brackets). Doesn't happen with 
3.5.2, the line is empty. (Only tested on Windows).


Also, I didn't reproduce Dan's issue on Windows with the Takari smart 
builder on a single sample project. Maybe the number of modules?


Guillaume


Le 27/02/2018 à 19:01, Dan Tran a écrit :

Hi all,

I believe my usage of antrun is legit to make sure user who is using  mvn
install ( without clean) has a proper clean up before another plugin
execution

   
 org.apache.maven.plugins
 maven-antrun-plugin
 
   
 work.around.to.clean.up.classes.before.jsonschema.start
 generate-sources
 
   run
 
 
   
 
   
 
   
 
   


here is the command to reproduce the antrun issue


   mvn clean install --builder smart -T1.0C -DskipTests


Add  -B to remove the issue but it is not ideal

Only only happens on windows ( i only test with windows and linux)

-D



On Tue, Feb 27, 2018 at 7:44 AM, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:


On 27 February 2018 at 14:46, Mirko Friedenhagen 
wrote:


+1 from my side, tested with 10 inhouse projects. Or is this vote

canceled?
Not cancelled yet. Unclear if Dan's issue is something forking maven and
parsing the output... the task name
"work.around.to.clean.up.classes.before.jsonschema.start" sounds like it
could be doing something crazy like that, in which case it is not using -B
when forking maven in Dan's codebase that could be the root cause.



Regards Mirko
--
http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/
https://bitbucket.org/mfriedenhagen/


On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran  wrote:

   correction

found this reference, found on 3.5.2 but I only encounter this on 3.5.3

RC

https://stackoverflow.com/questions/48723899/maven-
numberformatexception-when-packaging


On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:


found this reference, found on 3.5.2 but I only encounter this on

3.5.2

RC

https://stackoverflow.com/questions/48723899/maven-
numberformatexception-when-packaging

On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran  wrote:


my build contains 270+ modules using java 8.  The failure found on
windows. Have not tested on Linux  yet

-D

On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran 

wrote:

Encounter random failure at antrun MOJO + smart builder

here is the error message

[ERROR] Failed to execute goal org.apache.maven.plugins:

maven-antrun-plugin:1.8:run

(work.around.to.clean.up.classes.before.jsonschema.start) on

project

adm-schema: Error executing Ant tasks: For input string: "1;" ->

[Help 1]

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
(work.around.to.clean.up.classes.before.jsonschema.start) on

project

adm-schema: Error executing Ant tasks: For input string: "1;"
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:213)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:146)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.

buildProject

(LifecycleModuleBuilder.java:117)
 at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
(SmartBuilderImpl.java:205)
 at io.takari.maven.builder.smart.SmartBuilderImpl$

ProjectBuildTask.run

(SmartBuilderImpl.java:77)
 at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:511)
 at java.util.concurrent.FutureTask.run (FutureTask.java:266)
 at java.util.concurrent.ThreadPoolExecutor.runWorker
(ThreadPoolExecutor.java:1149)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:624)
 at java.lang.Thread.run (Thread.java:748)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error
executing Ant tasks: For input string: "1;"
 at org.apache.maven.plugin.antrun.AntRunMojo.execute
(AntRunMojo.java:347)
 at org.apache.maven.plugin.DefaultBuildPluginManager.

executeMojo

(DefaultBuildPluginManager.java:137)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:208)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:146)
 at

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Dan Tran 
Hi all,

I believe my usage of antrun is legit to make sure user who is using  mvn
install ( without clean) has a proper clean up before another plugin
execution

  
org.apache.maven.plugins
maven-antrun-plugin

  
work.around.to.clean.up.classes.before.jsonschema.start
generate-sources

  run


  

  

  

  


here is the command to reproduce the antrun issue


  mvn clean install --builder smart -T1.0C -DskipTests


Add  -B to remove the issue but it is not ideal

Only only happens on windows ( i only test with windows and linux)

-D



On Tue, Feb 27, 2018 at 7:44 AM, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> On 27 February 2018 at 14:46, Mirko Friedenhagen 
> wrote:
>
> > +1 from my side, tested with 10 inhouse projects. Or is this vote
> canceled?
> >
>
> Not cancelled yet. Unclear if Dan's issue is something forking maven and
> parsing the output... the task name
> "work.around.to.clean.up.classes.before.jsonschema.start" sounds like it
> could be doing something crazy like that, in which case it is not using -B
> when forking maven in Dan's codebase that could be the root cause.
>
>
> > Regards Mirko
> > --
> > http://illegalstateexception.blogspot.com/
> > https://github.com/mfriedenhagen/
> > https://bitbucket.org/mfriedenhagen/
> >
> >
> > On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran  wrote:
> > >   correction
> > >
> > > found this reference, found on 3.5.2 but I only encounter this on 3.5.3
> > RC
> > >
> > > https://stackoverflow.com/questions/48723899/maven-
> > > numberformatexception-when-packaging
> > >
> > >
> > > On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:
> > >
> > >> found this reference, found on 3.5.2 but I only encounter this on
> 3.5.2
> > RC
> > >>
> > >> https://stackoverflow.com/questions/48723899/maven-
> > >> numberformatexception-when-packaging
> > >>
> > >> On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran  wrote:
> > >>
> > >>> my build contains 270+ modules using java 8.  The failure found on
> > >>> windows. Have not tested on Linux  yet
> > >>>
> > >>> -D
> > >>>
> > >>> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran 
> wrote:
> > >>>
> >  Encounter random failure at antrun MOJO + smart builder
> > 
> >  here is the error message
> > 
> >  [ERROR] Failed to execute goal org.apache.maven.plugins:
> > maven-antrun-plugin:1.8:run
> >  (work.around.to.clean.up.classes.before.jsonschema.start) on
> project
> >  adm-schema: Error executing Ant tasks: For input string: "1;" ->
> > [Help 1]
> >  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> >  execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> >  (work.around.to.clean.up.classes.before.jsonschema.start) on
> project
> >  adm-schema: Error executing Ant tasks: For input string: "1;"
> >  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >  (MojoExecutor.java:213)
> >  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >  (MojoExecutor.java:154)
> >  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >  (MojoExecutor.java:146)
> >  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> > buildProject
> >  (LifecycleModuleBuilder.java:117)
> >  at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
> >  (SmartBuilderImpl.java:205)
> >  at io.takari.maven.builder.smart.SmartBuilderImpl$
> > ProjectBuildTask.run
> >  (SmartBuilderImpl.java:77)
> >  at java.util.concurrent.Executors$RunnableAdapter.call
> >  (Executors.java:511)
> >  at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> >  at java.util.concurrent.ThreadPoolExecutor.runWorker
> >  (ThreadPoolExecutor.java:1149)
> >  at java.util.concurrent.ThreadPoolExecutor$Worker.run
> >  (ThreadPoolExecutor.java:624)
> >  at java.lang.Thread.run (Thread.java:748)
> >  Caused by: org.apache.maven.plugin.MojoExecutionException: Error
> >  executing Ant tasks: For input string: "1;"
> >  at org.apache.maven.plugin.antrun.AntRunMojo.execute
> >  (AntRunMojo.java:347)
> >  at org.apache.maven.plugin.DefaultBuildPluginManager.
> executeMojo
> >  (DefaultBuildPluginManager.java:137)
> >  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >  (MojoExecutor.java:208)
> >  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >  (MojoExecutor.java:154)
> >  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> >  (MojoExecutor.java:146)
> >  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> > buildProject
> >

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Stephen Connolly 
On 27 February 2018 at 14:46, Mirko Friedenhagen 
wrote:

> +1 from my side, tested with 10 inhouse projects. Or is this vote canceled?
>

Not cancelled yet. Unclear if Dan's issue is something forking maven and
parsing the output... the task name
"work.around.to.clean.up.classes.before.jsonschema.start" sounds like it
could be doing something crazy like that, in which case it is not using -B
when forking maven in Dan's codebase that could be the root cause.


> Regards Mirko
> --
> http://illegalstateexception.blogspot.com/
> https://github.com/mfriedenhagen/
> https://bitbucket.org/mfriedenhagen/
>
>
> On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran  wrote:
> >   correction
> >
> > found this reference, found on 3.5.2 but I only encounter this on 3.5.3
> RC
> >
> > https://stackoverflow.com/questions/48723899/maven-
> > numberformatexception-when-packaging
> >
> >
> > On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:
> >
> >> found this reference, found on 3.5.2 but I only encounter this on 3.5.2
> RC
> >>
> >> https://stackoverflow.com/questions/48723899/maven-
> >> numberformatexception-when-packaging
> >>
> >> On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran  wrote:
> >>
> >>> my build contains 270+ modules using java 8.  The failure found on
> >>> windows. Have not tested on Linux  yet
> >>>
> >>> -D
> >>>
> >>> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran  wrote:
> >>>
>  Encounter random failure at antrun MOJO + smart builder
> 
>  here is the error message
> 
>  [ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-antrun-plugin:1.8:run
>  (work.around.to.clean.up.classes.before.jsonschema.start) on project
>  adm-schema: Error executing Ant tasks: For input string: "1;" ->
> [Help 1]
>  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>  execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>  (work.around.to.clean.up.classes.before.jsonschema.start) on project
>  adm-schema: Error executing Ant tasks: For input string: "1;"
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:213)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:154)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:146)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> buildProject
>  (LifecycleModuleBuilder.java:117)
>  at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>  (SmartBuilderImpl.java:205)
>  at io.takari.maven.builder.smart.SmartBuilderImpl$
> ProjectBuildTask.run
>  (SmartBuilderImpl.java:77)
>  at java.util.concurrent.Executors$RunnableAdapter.call
>  (Executors.java:511)
>  at java.util.concurrent.FutureTask.run (FutureTask.java:266)
>  at java.util.concurrent.ThreadPoolExecutor.runWorker
>  (ThreadPoolExecutor.java:1149)
>  at java.util.concurrent.ThreadPoolExecutor$Worker.run
>  (ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run (Thread.java:748)
>  Caused by: org.apache.maven.plugin.MojoExecutionException: Error
>  executing Ant tasks: For input string: "1;"
>  at org.apache.maven.plugin.antrun.AntRunMojo.execute
>  (AntRunMojo.java:347)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
>  (DefaultBuildPluginManager.java:137)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:208)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:154)
>  at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>  (MojoExecutor.java:146)
>  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> buildProject
>  (LifecycleModuleBuilder.java:117)
>  at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>  (SmartBuilderImpl.java:205)
>  at io.takari.maven.builder.smart.SmartBuilderImpl$
> ProjectBuildTask.run
>  (SmartBuilderImpl.java:77)
>  at java.util.concurrent.Executors$RunnableAdapter.call
>  (Executors.java:511)
>  at java.util.concurrent.FutureTask.run (FutureTask.java:266)
>  at java.util.concurrent.ThreadPoolExecutor.runWorker
>  (ThreadPoolExecutor.java:1149)
>  at java.util.concurrent.ThreadPoolExecutor$Worker.run
>  (ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run (Thread.java:748)
>  Caused by: java.lang.NumberFormatException: For input string: "1;"
>  at java.lang.NumberFormatException.forInputString
>  (NumberFormatException.java:65)
>  at java.lang.Integer.parseInt (Integer.java:580)
>  at java.lang.Integer. (Integer.java:867)
>  at org.fusesource.jansi.AnsiPrintStream.filter
>

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Karl Heinz Marbaise 

Hi,

tested with several projects working the last day with it...No issues..

So +1 from me.

Kind regards
Karl Heinz Marbaise
On 24/02/18 23:00, Stephen Connolly wrote:

Hi,

We solved 22 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12341428=Text=12316922

There are 381 issues left in JIRA for Maven core:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC

Staging repo:
https://repository.apache.org/content/repositories/maven-1401/

The distributable binaries and sources can be found here:
https://repository.apache.org/content/repositories/maven-1401/org/apache/maven/apache-maven/3.5.3/

Specifically the zip, tarball and source archives can be found here:
https://repository.apache.org/content/repositories/maven-1401/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-bin.zip
https://repository.apache.org/content/repositories/maven-1401/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-bin.tar.gz
https://repository.apache.org/content/repositories/maven-1401/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-src.zip
https://repository.apache.org/content/repositories/maven-1401/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-src.tar.gz

The release artifacts are staged for distribution in:
https://dist.apache.org/repos/dist/dev/maven/maven-3/3.5.3

Source release checksum(s):
apache-maven-3.5.3-src.tar.gz sha1:
60905d8b8b025b091f456ec25ad60dda56c26ad5
sha256: 471748340cdc7f78b0b0c7bdf9e5399738e6721c08e166f59ef400f1dd107e19
apache-maven-3.5.3-src.zip: sha1: a9be51d571165261dfb2e0c8ecc6b4f1c4c96766
sha256: 109ac07fa337e582b8e6741f179e9f09166cae0fc9b3f44d4a35a2a2c7ccbd57

Git tag:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=3383c37e1f9e9b3bc3df5050c29c8aff9f295297

Staging site:
https://maven.apache.org/components/ref/3-LATEST/

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Thanks,

Stephen.



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-27 Thread Mirko Friedenhagen 
+1 from my side, tested with 10 inhouse projects. Or is this vote canceled?
Regards Mirko
--
http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/
https://bitbucket.org/mfriedenhagen/


On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran  wrote:
>   correction
>
> found this reference, found on 3.5.2 but I only encounter this on 3.5.3 RC
>
> https://stackoverflow.com/questions/48723899/maven-
> numberformatexception-when-packaging
>
>
> On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:
>
>> found this reference, found on 3.5.2 but I only encounter this on 3.5.2 RC
>>
>> https://stackoverflow.com/questions/48723899/maven-
>> numberformatexception-when-packaging
>>
>> On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran  wrote:
>>
>>> my build contains 270+ modules using java 8.  The failure found on
>>> windows. Have not tested on Linux  yet
>>>
>>> -D
>>>
>>> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran  wrote:
>>>
 Encounter random failure at antrun MOJO + smart builder

 here is the error message

 [ERROR] Failed to execute goal 
 org.apache.maven.plugins:maven-antrun-plugin:1.8:run
 (work.around.to.clean.up.classes.before.jsonschema.start) on project
 adm-schema: Error executing Ant tasks: For input string: "1;" -> [Help 1]
 org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
 execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
 (work.around.to.clean.up.classes.before.jsonschema.start) on project
 adm-schema: Error executing Ant tasks: For input string: "1;"
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
 (MojoExecutor.java:213)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
 (MojoExecutor.java:154)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
 (MojoExecutor.java:146)
 at 
 org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
 (LifecycleModuleBuilder.java:117)
 at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
 (SmartBuilderImpl.java:205)
 at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
 (SmartBuilderImpl.java:77)
 at java.util.concurrent.Executors$RunnableAdapter.call
 (Executors.java:511)
 at java.util.concurrent.FutureTask.run (FutureTask.java:266)
 at java.util.concurrent.ThreadPoolExecutor.runWorker
 (ThreadPoolExecutor.java:1149)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run
 (ThreadPoolExecutor.java:624)
 at java.lang.Thread.run (Thread.java:748)
 Caused by: org.apache.maven.plugin.MojoExecutionException: Error
 executing Ant tasks: For input string: "1;"
 at org.apache.maven.plugin.antrun.AntRunMojo.execute
 (AntRunMojo.java:347)
 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
 (DefaultBuildPluginManager.java:137)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
 (MojoExecutor.java:208)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
 (MojoExecutor.java:154)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute
 (MojoExecutor.java:146)
 at 
 org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
 (LifecycleModuleBuilder.java:117)
 at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
 (SmartBuilderImpl.java:205)
 at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
 (SmartBuilderImpl.java:77)
 at java.util.concurrent.Executors$RunnableAdapter.call
 (Executors.java:511)
 at java.util.concurrent.FutureTask.run (FutureTask.java:266)
 at java.util.concurrent.ThreadPoolExecutor.runWorker
 (ThreadPoolExecutor.java:1149)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run
 (ThreadPoolExecutor.java:624)
 at java.lang.Thread.run (Thread.java:748)
 Caused by: java.lang.NumberFormatException: For input string: "1;"
 at java.lang.NumberFormatException.forInputString
 (NumberFormatException.java:65)
 at java.lang.Integer.parseInt (Integer.java:580)
 at java.lang.Integer. (Integer.java:867)
 at org.fusesource.jansi.AnsiPrintStream.filter
 (AnsiPrintStream.java:129)
 at org.fusesource.jansi.FilterPrintStream.write
 (FilterPrintStream.java:59)
 at org.fusesource.jansi.FilterPrintStream.write
 (FilterPrintStream.java:70)
 at java.io.PrintStream.write (PrintStream.java:480)
 at sun.nio.cs.StreamEncoder.writeBytes (StreamEncoder.java:221)
 at sun.nio.cs.StreamEncoder.implFlushBuffer (StreamEncoder.java:291)
 at sun.nio.cs.StreamEncoder.flushBuffer (StreamEncoder.java:104)
 at java.io.OutputStreamWriter.flushBuffer
 (OutputStreamWriter.java:185)
 at

Re: Surefire roadmap

2018-02-27 Thread Stephen Connolly 
On Mon 26 Feb 2018 at 20:55, Tibor Digana  wrote:

> Hi Enrico,
>
> I do not like this test because this may easily be against Java Prog. Lang.
> Spec.
> I have no idea why Kristian created like this and allowed testing non-ASCII
> characters in Java test method and Java test class.
> Here are Japanese or Chinese characters.
> The point was to fix https://issues.apache.org/jira/browse/SUREFIRE-857
> I saw Windows having problems with file name while copying original file
> name with non-ASCII characters and Java placed question marks ??? in the
> file name instead.
> I think better could be to print non-ASCII characters on std/out and check
> if it exists in the report XML.
>
> IMHO the class/method name as Java identifiers should be a-zA-Z0-9_$ and
> should not start with a number.


While that is a noble ideal, the java spec does not agree with you. Any
Unicode letter can be used for method/class names (though there are some OS
int interop issues if the user chooses to go down that path.

We have to be forgiving in what we accept and strict in what we produce


>
>
> https://stackoverflow.com/questions/65475/valid-characters-in-a-java-class-name
> https://stackoverflow.com/questions/11774099/legal-identifiers-in-java
> https://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.8
> http://www.oracle.com/technetwork/java/codeconventions-135099.html
>
>
>
>
> On Mon, Feb 26, 2018 at 2:32 PM, Enrico Olivelli 
> wrote:
>
> > Branch SUREFIRE-1489 works almost fine on my jdk10 / Linux Fedora
> >
> > Only 1 unit test failure ( I think this is addressed in another branch)
> >
> > checkFileNamesWithUnicode(org.apache.maven.surefire.its.
> > UnicodeTestNamesIT)
> > Time elapsed: 0.001 sec  <<< FAILURE!
> > junit.framework.AssertionFailedError: Did not find expected message in
> log
> > at junit.framework.Assert.fail(Assert.java:57)
> > at
> > org.apache.maven.surefire.its.fixture.TestFile.
> > assertContainsText(TestFile.java:142)
> > at
> > org.apache.maven.surefire.its.UnicodeTestNamesIT.
> > checkFileNamesWithUnicode(UnicodeTestNamesIT.java:67)
> >
> >
> > I have tested branch feature/jdk-10 from Olivier and it is working the
> same
> >
> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.009 sec
> > <<< FAILURE!
> > checkFileNamesWithUnicode(org.apache.maven.surefire.its.
> > UnicodeTestNamesIT)
> > Time elapsed: 0.001 sec  <<< FAILURE!
> > junit.framework.AssertionFailedError: Did not find expected message in
> log
> > at junit.framework.Assert.fail(Assert.java:57)
> > at
> > org.apache.maven.surefire.its.fixture.TestFile.
> > assertContainsText(TestFile.java:142)
> > at
> > org.apache.maven.surefire.its.UnicodeTestNamesIT.
> > checkFileNamesWithUnicode(UnicodeTestNamesIT.java:67)
> >
> >
> > I did run a
> > git diff SUREFIRE-1489 feature/jdk10
> >
> > and it seems to me that in SUREFIRE-1489 we only have changes in Jenkins
> > DSL files
> >
> >
> > what about merging SUREFIRE-1489 to master ? this will fix all the
> problems
> > reported during last days and fix the Jenkins pipeline
> >
> > hope that helps
> >
> > Enrico
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > 2018-02-25 23:25 GMT+01:00 Enrico Olivelli :
> >
> > >
> > >
> > > Il dom 25 feb 2018, 21:45 Tibor Digana  ha
> > > scritto:
> > >
> > >> Hi Enrico,
> > >>
> > >> Sorry for notifying.
> > >> I would like to ask you for a help.
> > >> Maybe you can see my previous e-mail in this thread on mailing list
> with
> > >> CLI running a build on the branch SUREFIRE-1489.
> > >> Can you please try to run the build on your side and let us know the
> > >> result?
> > >> I appreciate!
> > >>
> > >
> > > Sure will do tomorrow, today I have run tests with jdk8 on that non
> > > masterbranch and all worked well. The suite takes very long time so I
> > will
> > > try tomorrow with jdk10
> > >
> > > Master is broken for me too, but we already knew
> > >
> > > Enrico
> > >
> > >
> > >> (If the CLI command is not clear, do not hesitate to ask beforehand.)
> > >>
> > >> Thx
> > >> Tibor
> > >>
> > >>
> > >> On Sun, Feb 25, 2018 at 9:34 PM, Tibor Digana  >
> > >> wrote:
> > >>
> > >>> Hey guys,
> > >>>
> > >>> We really do not properly read the e-mails.
> > >>> All the links you sent me was from master branch.
> > >>>
> > >>> We are NOT working in master branch. Do not test master yet.
> > >>>
> > >>> Our focus is the branch named "SUREFIRE-1489".
> > >>> Please run only the build on branch "SUREFIRE-1489" and nothing else
> > >>> yet. We should proceed step by step.
> > >>>
> > >>> Please try to be patient and:
> > >>> $ git clone 
> > >>> $ git fetch
> > >>> $ git checkout SUREFIRE-1489
> > >>> $ mvn clean install -nsu -P run-its -Djdk.home=/path/to/jdk10
> > >>> -Djacoco.skip=true
> > >>>
> > >>> I will be waiting.
> > >>>
> > >>> All my previous emails about ASF Jenkins was from the branch
> > >>>