Re: issue with junit 5 integration

[Dan Tran]

Odd, I am under impression  surefire auto detect  junit-jupiter-engine  at
runtime

am I missing something?

-D

On Tue, Sep 4, 2018 at 10:08 PM Romain Manni-Bucau 
wrote:

> It does _NOT_ work and as mentionned you can test on meecrowave trying to
> upgrade the version in junit module.
>
> The test classpath build ignores project and plugin dependencies. It faked
> working until 5.3.0-RC1 cause no breakage was visible.
>
> When testing, dont forget to use jupiter, vintage engines + platform stack,
> otherwise code is compatible with 1.2 which gets loaded. The doc ignores
> the platform and vintage engine and guess it was not tested at all checking
> the code ;). Not a big deal since it is a "first" release but we should be
> ablz to get it fixed quickly.
>
>
> Le mar. 4 sept. 2018 23:51, Olivier Lamy  a écrit :
>
> > Ok perso I don't mind (it just need to be documented)
> > But the issue is: users are used to simply upgrade their junit
> dependency.
> >
> >
> > On Wed, 5 Sep 2018 at 07:37, Christian Stein  wrote:
> >
> > > No, it works with Surefire 2.22.0 and JUnit 5.3.
> > >
> > > Just add (or move) the test-runtime dependencies to the Surefire plugin
> > > element:
> > >
> > > 
> > >
> > >   
> > >   
> > >  maven-surefire-plugin
> > >  2.22.0
> > >  
> > >
> > >org.junit.jupiter
> > >junit-jupiter-engine
> > >5.3.0
> > >
> > >  
> > >   
> > >
> > > 
> > >
> > >
> > > Just checking our sample builds over at JUnit 5. Which do _NOT_ do this
> > at
> > > the moment.
> > >
> > >
> > >
> > > On Tue, Sep 4, 2018 at 11:32 PM Olivier Lamy  wrote:
> > >
> > > > Hi
> > > > very embarrassing issue which probably worth a quick release!
> > > > Can you create a jira?
> > > > As junit 5.3.0 has just been released,  I might be happy to cut
> 2.22.1
> > > very
> > > > quickly with only this fix.
> > > > others wdyt?
> > > >
> > > >
> > > > On Wed, 5 Sep 2018 at 06:46, Romain Manni-Bucau <
> rmannibu...@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hi guys,
> > > > >
> > > > > Jira seems down so sending a mail.
> > > > >
> > > > > I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I
> > > > realized
> > > > > the way surefire provider was developped for JUnit 5 was forcing
> the
> > > > > junit-platform-engine even adding it manually in the test
> > dependencies
> > > or
> > > > > plugin dependencies.
> > > > >
> > > > > Side note: I didn't investigated other providers but I guess it is
> > the
> > > > > exact same but the API breakage are happening less often.
> > > > >
> > > > > I therefore created a PR to fix that ->
> > > > > https://github.com/apache/maven-surefire/pull/193
> > > > >
> > > > > Note: I didn't upgrade the JUnit 5 version in the same release but
> it
> > > > > should probably be done too in another commit/PR.
> > > > >
> > > > > I wonder if you have release plans which could include this. In
> terms
> > > of
> > > > > issues I have in mind the other thing about JUnit 5 which would be
> > > great
> > > > to
> > > > > add is the support for display names instead of using the
> class+test
> > > > names
> > > > > in the logs and reports but this is less mandatory than previous
> one
> > > > which
> > > > > fails with a NoSuchMethod error when using vintage engine.
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau  |  Blog
> > > > >  | Old Blog
> > > > >  | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn  | Book
> > > > > <
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Olivier Lamy
> > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >
> > >
> >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>

Re: issue with junit 5 integration

[Romain Manni-Bucau]

It does _NOT_ work and as mentionned you can test on meecrowave trying to
upgrade the version in junit module.

The test classpath build ignores project and plugin dependencies. It faked
working until 5.3.0-RC1 cause no breakage was visible.

When testing, dont forget to use jupiter, vintage engines + platform stack,
otherwise code is compatible with 1.2 which gets loaded. The doc ignores
the platform and vintage engine and guess it was not tested at all checking
the code ;). Not a big deal since it is a "first" release but we should be
ablz to get it fixed quickly.


Le mar. 4 sept. 2018 23:51, Olivier Lamy  a écrit :

> Ok perso I don't mind (it just need to be documented)
> But the issue is: users are used to simply upgrade their junit dependency.
>
>
> On Wed, 5 Sep 2018 at 07:37, Christian Stein  wrote:
>
> > No, it works with Surefire 2.22.0 and JUnit 5.3.
> >
> > Just add (or move) the test-runtime dependencies to the Surefire plugin
> > element:
> >
> > 
> >
> >   
> >   
> >  maven-surefire-plugin
> >  2.22.0
> >  
> >
> >org.junit.jupiter
> >junit-jupiter-engine
> >5.3.0
> >
> >  
> >   
> >
> > 
> >
> >
> > Just checking our sample builds over at JUnit 5. Which do _NOT_ do this
> at
> > the moment.
> >
> >
> >
> > On Tue, Sep 4, 2018 at 11:32 PM Olivier Lamy  wrote:
> >
> > > Hi
> > > very embarrassing issue which probably worth a quick release!
> > > Can you create a jira?
> > > As junit 5.3.0 has just been released,  I might be happy to cut 2.22.1
> > very
> > > quickly with only this fix.
> > > others wdyt?
> > >
> > >
> > > On Wed, 5 Sep 2018 at 06:46, Romain Manni-Bucau  >
> > > wrote:
> > >
> > > > Hi guys,
> > > >
> > > > Jira seems down so sending a mail.
> > > >
> > > > I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I
> > > realized
> > > > the way surefire provider was developped for JUnit 5 was forcing the
> > > > junit-platform-engine even adding it manually in the test
> dependencies
> > or
> > > > plugin dependencies.
> > > >
> > > > Side note: I didn't investigated other providers but I guess it is
> the
> > > > exact same but the API breakage are happening less often.
> > > >
> > > > I therefore created a PR to fix that ->
> > > > https://github.com/apache/maven-surefire/pull/193
> > > >
> > > > Note: I didn't upgrade the JUnit 5 version in the same release but it
> > > > should probably be done too in another commit/PR.
> > > >
> > > > I wonder if you have release plans which could include this. In terms
> > of
> > > > issues I have in mind the other thing about JUnit 5 which would be
> > great
> > > to
> > > > add is the support for display names instead of using the class+test
> > > names
> > > > in the logs and reports but this is less mandatory than previous one
> > > which
> > > > fails with a NoSuchMethod error when using vintage engine.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau  |  Blog
> > > >  | Old Blog
> > > >  | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn  | Book
> > > > <
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > >
> > >
> > > --
> > > Olivier Lamy
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>

Re: issue with junit 5 integration

[Olivier Lamy]

Ok perso I don't mind (it just need to be documented)
But the issue is: users are used to simply upgrade their junit dependency.


On Wed, 5 Sep 2018 at 07:37, Christian Stein  wrote:

> No, it works with Surefire 2.22.0 and JUnit 5.3.
>
> Just add (or move) the test-runtime dependencies to the Surefire plugin
> element:
>
> 
>
>   
>   
>  maven-surefire-plugin
>  2.22.0
>  
>
>org.junit.jupiter
>junit-jupiter-engine
>5.3.0
>
>  
>   
>
> 
>
>
> Just checking our sample builds over at JUnit 5. Which do _NOT_ do this at
> the moment.
>
>
>
> On Tue, Sep 4, 2018 at 11:32 PM Olivier Lamy  wrote:
>
> > Hi
> > very embarrassing issue which probably worth a quick release!
> > Can you create a jira?
> > As junit 5.3.0 has just been released,  I might be happy to cut 2.22.1
> very
> > quickly with only this fix.
> > others wdyt?
> >
> >
> > On Wed, 5 Sep 2018 at 06:46, Romain Manni-Bucau 
> > wrote:
> >
> > > Hi guys,
> > >
> > > Jira seems down so sending a mail.
> > >
> > > I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I
> > realized
> > > the way surefire provider was developped for JUnit 5 was forcing the
> > > junit-platform-engine even adding it manually in the test dependencies
> or
> > > plugin dependencies.
> > >
> > > Side note: I didn't investigated other providers but I guess it is the
> > > exact same but the API breakage are happening less often.
> > >
> > > I therefore created a PR to fix that ->
> > > https://github.com/apache/maven-surefire/pull/193
> > >
> > > Note: I didn't upgrade the JUnit 5 version in the same release but it
> > > should probably be done too in another commit/PR.
> > >
> > > I wonder if you have release plans which could include this. In terms
> of
> > > issues I have in mind the other thing about JUnit 5 which would be
> great
> > to
> > > add is the support for display names instead of using the class+test
> > names
> > > in the logs and reports but this is less mandatory than previous one
> > which
> > > fails with a NoSuchMethod error when using vintage engine.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>


-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: issue with junit 5 integration

[Christian Stein]

No, it works with Surefire 2.22.0 and JUnit 5.3.

Just add (or move) the test-runtime dependencies to the Surefire plugin
element:


   
  
  
 maven-surefire-plugin
 2.22.0
 
   
   org.junit.jupiter
   junit-jupiter-engine
   5.3.0
   
 
  
   



Just checking our sample builds over at JUnit 5. Which do _NOT_ do this at
the moment.



On Tue, Sep 4, 2018 at 11:32 PM Olivier Lamy  wrote:

> Hi
> very embarrassing issue which probably worth a quick release!
> Can you create a jira?
> As junit 5.3.0 has just been released,  I might be happy to cut 2.22.1 very
> quickly with only this fix.
> others wdyt?
>
>
> On Wed, 5 Sep 2018 at 06:46, Romain Manni-Bucau 
> wrote:
>
> > Hi guys,
> >
> > Jira seems down so sending a mail.
> >
> > I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I
> realized
> > the way surefire provider was developped for JUnit 5 was forcing the
> > junit-platform-engine even adding it manually in the test dependencies or
> > plugin dependencies.
> >
> > Side note: I didn't investigated other providers but I guess it is the
> > exact same but the API breakage are happening less often.
> >
> > I therefore created a PR to fix that ->
> > https://github.com/apache/maven-surefire/pull/193
> >
> > Note: I didn't upgrade the JUnit 5 version in the same release but it
> > should probably be done too in another commit/PR.
> >
> > I wonder if you have release plans which could include this. In terms of
> > issues I have in mind the other thing about JUnit 5 which would be great
> to
> > add is the support for display names instead of using the class+test
> names
> > in the logs and reports but this is less mandatory than previous one
> which
> > fails with a NoSuchMethod error when using vintage engine.
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>

Re: issue with junit 5 integration

[Olivier Lamy]

Hi
very embarrassing issue which probably worth a quick release!
Can you create a jira?
As junit 5.3.0 has just been released,  I might be happy to cut 2.22.1 very
quickly with only this fix.
others wdyt?


On Wed, 5 Sep 2018 at 06:46, Romain Manni-Bucau 
wrote:

> Hi guys,
>
> Jira seems down so sending a mail.
>
> I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I realized
> the way surefire provider was developped for JUnit 5 was forcing the
> junit-platform-engine even adding it manually in the test dependencies or
> plugin dependencies.
>
> Side note: I didn't investigated other providers but I guess it is the
> exact same but the API breakage are happening less often.
>
> I therefore created a PR to fix that ->
> https://github.com/apache/maven-surefire/pull/193
>
> Note: I didn't upgrade the JUnit 5 version in the same release but it
> should probably be done too in another commit/PR.
>
> I wonder if you have release plans which could include this. In terms of
> issues I have in mind the other thing about JUnit 5 which would be great to
> add is the support for display names instead of using the class+test names
> in the logs and reports but this is less mandatory than previous one which
> fails with a NoSuchMethod error when using vintage engine.
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>


-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

issue with junit 5 integration

[Romain Manni-Bucau]

Hi guys,

Jira seems down so sending a mail.

I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I realized
the way surefire provider was developped for JUnit 5 was forcing the
junit-platform-engine even adding it manually in the test dependencies or
plugin dependencies.

Side note: I didn't investigated other providers but I guess it is the
exact same but the API breakage are happening less often.

I therefore created a PR to fix that ->
https://github.com/apache/maven-surefire/pull/193

Note: I didn't upgrade the JUnit 5 version in the same release but it
should probably be done too in another commit/PR.

I wonder if you have release plans which could include this. In terms of
issues I have in mind the other thing about JUnit 5 which would be great to
add is the support for display names instead of using the class+test names
in the logs and reports but this is less mandatory than previous one which
fails with a NoSuchMethod error when using vintage engine.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book