Re: 3.6.3 release?

[Robert Scholte]

There are more critical regressions, so it makes sense to do a Maven 3.6.3  
release before working on 3.7.0


@Team, please only merge regression related issues, dependency updates or  
equivalent fixes.

Leave more ambitious issues for the next release.

thanks,
Robert

[1] https://issues.apache.org/jira/projects/MNG/versions/12346152


On Thu, 24 Oct 2019 15:44:22 +0200, Enrico Olivelli   
wrote:



Il gio 24 ott 2019, 15:38 Vladimir Sitnikov 
ha scritto:


Mickael>there was no other critical issues pending

I guess https://issues.apache.org/jira/browse/MNG-6771 (licensing issues
with binary artifacts) is a blocker for the release.



Yes
I will take care of it, maybe with some help with Hervé

Thank you for pointing it

Enrico



Vladimir


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.6.3 release?

[Enrico Olivelli]

Il gio 24 ott 2019, 15:38 Vladimir Sitnikov 
ha scritto:

> Mickael>there was no other critical issues pending
>
> I guess https://issues.apache.org/jira/browse/MNG-6771 (licensing issues
> with binary artifacts) is a blocker for the release.
>

Yes
I will take care of it, maybe with some help with Hervé

Thank you for pointing it

Enrico


> Vladimir
>

Re: 3.6.3 release?

[Vladimir Sitnikov]

Mickael>there was no other critical issues pending

I guess https://issues.apache.org/jira/browse/MNG-6771 (licensing issues
with binary artifacts) is a blocker for the release.

Vladimir

3.6.3 release?

[Mickael Istria]

Hi all,

If I followed correctly previous discussions,
https://issues.apache.org/jira/browse/MNG-6765 was a candidate for a bugfix
release and there was no other critical issues pending.
As there is a desire to spin a 3.7.x branch, MNG-6765 and a 3.6.3 releases
were considered as blockers.

So now https://issues.apache.org/jira/browse/MNG-6765 is resolved; any
change a 3.6.3 releases happens soon so consumers won't face the pomless
bug anymore; and the Maven contributors can start having fun on a 3.7?

Cheers

-- 
Mickael Istria
Eclipse IDE 
developer, for Red Hat Developers 

Re: Using Maven JXR as base for report plugin

[Plamen Totev]

Hi Enrico,

Thanks for the reply.

On 24.10.2019 г. 0:57, Enrico Olivelli wrote:
> Il mer 23 ott 2019, 20:29 Plamen Totev  ha
> scritto:
>
>> Hi,
>>
>> I would like to create plugin that generates test coverage report.
> Yes, it my have sense.
>
> As far as I know we do not have a standard way to provide extensions to
> plugins, if anyone on the list has some suggestion please chime in,
> otherwise I would go to make the class name (JavaCodeTransform)
configurable
> as a mojo parameter

I don't have the plugin in mind. The plugin contains two modules -
maven-jxr and maven-jxr-plugin. I would like to use the former to
generate the HTML report but use it in my own plugin. Having the option
to annotate the reports made by JXR plugin might have value but it is
outside the scope of what I want to do.

What I have in mind is to modify JavaCodeTransform to make it
extensible(or plugable). The way it works now is to use a chain of
filters to generate the markup, but this chain is hard-coded. For
example you can't easily wrap a single line inside span tag. The filters
are implemented as private methods inside JavaCodeTransfor. A simple
change as making them protected would allow classes that extend
JavaCodeTransform to modify the generated markup.

>> Or it will be better to just create my own implementation using code from
>> JavaCodeTransform
>>
> If you mean 'forking' the plugin I think it won't be a good idea, as your
> fork won't receive updates from the community version
Not the entire code base, only JavaCodeTransform .

Regards,
Plamen Totev

p.s. Enrico, sorry for spamming you with personal mail. I need to pay more
attention to how the "reply" button works :)