Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5
+1 tested with our 300+ maven modules build Found the following new 'good' behaviors/fixes 1. Junit 4 test class now have 'public' scope at both class and method level. 2. Exception at test 'setup' ( ie @Before) now show up as failures, They are ignored at M4 Great works Thanks On Sat, Jun 13, 2020 at 3:40 PM Tibor Digana wrote: > Hi Herve, > > We can fork the discussion about this problem apart in the Slack. > Thx for finding this. > > T > > > On Sat, Jun 13, 2020 at 9:35 PM Hervé BOUTEMY > wrote: > > > +1 > > > > near full reproducibility of reference artifacts with JDK 8 on Windows: > 48 > > artifacts are ok, just 2 still have issues: > > - surefire-3.0.0-M5-source-release.zip: I don't know why my local build > > added 3 dependency-reduced-pom.xml that do not exist in reference build > > - surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for some > > shaded content, probably a subtle maven-shade-plugin bug > > > > Regards, > > > > Hervé > > > > Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit : > > > Hi, > > > > > > We solved 40 issues: > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927 > > > rsion=12344612 > > > > > > There are still a couple of issues left in JIRA: > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20 > > > status%20%3D%20Open%20ORDER%20BY%20priority%20DESC > > > > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1590/ > > > > > > https://repository.apache.org/content/repositories/maven-1590/org/apache/mav > > > en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip > > > > > > Source release checksum(s): > > > surefire-3.0.0-M5-source-release.zip sha1: > > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f > > > surefire-3.0.0-M5-source-release.zip sha512: > > > > > > e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0 > > > 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7 > > > > > > Staging site: > > > http://maven.apache.org/surefire-archives/surefire-LATEST/ > > > > > > Guide to testing staged releases: > > > http://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > Vote open for 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > Cheers > > > Tibor > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > >
Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5
John This is the best forum but please start another email thread. This is the official VOTE thread Thanks for reporting your finding. It is very precious Enrico Il Dom 14 Giu 2020, 21:45 John Patrick ha scritto: > What is the best forum to discuss issues or configuration around > compiler, surefire and jpms? > > Most of the issues I have, seam to be resolved with 3.0.0-M5, but; > - already raising issue with IntelliJ now as they don't support 2 > module-info.java files in the same project, one under src/main/java > and the other under src/test/java. > - how can package private methods be tested? as compiler is now seeing > the new test module-info.java but complaining about package exists in > main and test module-info. > - i might be making things more complex as i've using src/main/java > and src/test/java for java 8 code, and src/main/java11 and > src/test/java11 for java 11 code base. so creating multi version jars. > java 8 builds an tests, then java 11 does verify, i then rebuild and > test fully on java 11. > > John > > > On Sat, 13 Jun 2020 at 23:40, Tibor Digana wrote: > > > > Hi Herve, > > > > We can fork the discussion about this problem apart in the Slack. > > Thx for finding this. > > > > T > > > > > > On Sat, Jun 13, 2020 at 9:35 PM Hervé BOUTEMY > wrote: > > > > > +1 > > > > > > near full reproducibility of reference artifacts with JDK 8 on > Windows: 48 > > > artifacts are ok, just 2 still have issues: > > > - surefire-3.0.0-M5-source-release.zip: I don't know why my local build > > > added 3 dependency-reduced-pom.xml that do not exist in reference build > > > - surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for > some > > > shaded content, probably a subtle maven-shade-plugin bug > > > > > > Regards, > > > > > > Hervé > > > > > > Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit : > > > > Hi, > > > > > > > > We solved 40 issues: > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927 > > > > rsion=12344612 > > > > > > > > There are still a couple of issues left in JIRA: > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20 > > > > status%20%3D%20Open%20ORDER%20BY%20priority%20DESC > > > > > > > > Staging repo: > > > > https://repository.apache.org/content/repositories/maven-1590/ > > > > > > > > https://repository.apache.org/content/repositories/maven-1590/org/apache/mav > > > > en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip > > > > > > > > Source release checksum(s): > > > > surefire-3.0.0-M5-source-release.zip sha1: > > > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f > > > > surefire-3.0.0-M5-source-release.zip sha512: > > > > > > > > e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0 > > > > 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7 > > > > > > > > Staging site: > > > > http://maven.apache.org/surefire-archives/surefire-LATEST/ > > > > > > > > Guide to testing staged releases: > > > > > http://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > > Vote open for 72 hours. > > > > > > > > [ ] +1 > > > > [ ] +0 > > > > [ ] -1 > > > > > > > > Cheers > > > > Tibor > > > > > > > > > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5
What is the best forum to discuss issues or configuration around compiler, surefire and jpms? Most of the issues I have, seam to be resolved with 3.0.0-M5, but; - already raising issue with IntelliJ now as they don't support 2 module-info.java files in the same project, one under src/main/java and the other under src/test/java. - how can package private methods be tested? as compiler is now seeing the new test module-info.java but complaining about package exists in main and test module-info. - i might be making things more complex as i've using src/main/java and src/test/java for java 8 code, and src/main/java11 and src/test/java11 for java 11 code base. so creating multi version jars. java 8 builds an tests, then java 11 does verify, i then rebuild and test fully on java 11. John On Sat, 13 Jun 2020 at 23:40, Tibor Digana wrote: > > Hi Herve, > > We can fork the discussion about this problem apart in the Slack. > Thx for finding this. > > T > > > On Sat, Jun 13, 2020 at 9:35 PM Hervé BOUTEMY wrote: > > > +1 > > > > near full reproducibility of reference artifacts with JDK 8 on Windows: 48 > > artifacts are ok, just 2 still have issues: > > - surefire-3.0.0-M5-source-release.zip: I don't know why my local build > > added 3 dependency-reduced-pom.xml that do not exist in reference build > > - surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for some > > shaded content, probably a subtle maven-shade-plugin bug > > > > Regards, > > > > Hervé > > > > Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit : > > > Hi, > > > > > > We solved 40 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927 > > > rsion=12344612 > > > > > > There are still a couple of issues left in JIRA: > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20 > > > status%20%3D%20Open%20ORDER%20BY%20priority%20DESC > > > > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1590/ > > > > > https://repository.apache.org/content/repositories/maven-1590/org/apache/mav > > > en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip > > > > > > Source release checksum(s): > > > surefire-3.0.0-M5-source-release.zip sha1: > > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f > > > surefire-3.0.0-M5-source-release.zip sha512: > > > > > e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0 > > > 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7 > > > > > > Staging site: > > > http://maven.apache.org/surefire-archives/surefire-LATEST/ > > > > > > Guide to testing staged releases: > > > http://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > Vote open for 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > Cheers > > > Tibor > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Consumer pom and relative disk paths for parent pom
+1 from me (I have also approved on github) We need more eyes on this patch. Thanks Robert Enrico Il Dom 14 Giu 2020, 13:43 Robert Scholte ha scritto: > It looks like the branches[1][2] are ready for review, jenkins[3] is happy > too. > > Robert > > > [1] https://github.com/apache/maven/pull/286 > > [2] https://github.com/apache/maven-integration-testing/pull/66 > > [3] https://builds.apache.org/job/maven-box/job/maven/job/MNG-6656/ > On 25-5-2020 22:54:33, Robert Scholte wrote: > next on my list > > Robert > On 25-5-2020 17:42:23, Enrico Olivelli wrote: > Robert, > do we have news about this great feature ? > > Enrico > > Il giorno sab 30 nov 2019 alle ore 14:38 Enrico Olivelli > eolive...@gmail.com> ha scritto: > > > Good news > > > > Il giorno sab 30 nov 2019 alle ore 14:27 Robert Scholte > > rfscho...@apache.org> ha scritto: > > > >> Hi Enrico, > >> > >> current implementation says groupId+artifact are required, but you can > >> either specify version or relativePath (or omit it, meaning ../pom.xml) > >> I've decided to keep G+A so MAven can verify the pom is pointing to the > >> right parent. > >> MNG-6656 has a demo attached which shows you the new valid pom > structure. > >> > >> > > This is the link for reference > > > > > https://github.com/apache/maven/pull/286/files#diff-367b1a6eb386aada5bd28a0aaebe645bR36 > > > > I am totally ok for keeping G+A, it sounds very sensible to me. > > > > Thank you so much, I missed that part of the change, or at least I forgot > > about it > > > > I am really sure I want this new feature in 3.7.0 ! > > > > It looks like we are adding great stuff to Maven for this new major > release > > > > Enrico > > > > > >> thanks, > >> Robert > >> > >> On 30-11-2019 13:39:12, Enrico Olivelli wrote: > >> Hi, > >> when we move to the consumer pom we can leverage the disk layout of > >> projects inside the same repository while looking for the parent pom. > >> > >> Currently you can use the element to refer to the location > >> of a parent pom, AFAIK this is only an hint for Maven and for tools: you > >> must always copy all of the coordinates of the parent module because > when > >> you publish your pom the consumer must be able to find such parent > module > >> from remote repositories, without having the physical layout of the > source > >> code. > >> > >> With the consumer pom with can let the build pom have only the > >> relativePath > >> element and then we will fill the consumer (deployed) pom with the > >> effective parent coordinates. > >> > >> This will simply a lot this part of Maven that is quite annoying for > users > >> > >> Thoughts? > >> Enrico > >> > > >
[GitHub] [maven-site] elharo commented on a change in pull request #176: [MNGSITE-415] say Maven 3.0.x is EOL
elharo commented on a change in pull request #176: URL: https://github.com/apache/maven-site/pull/176#discussion_r439823779 ## File path: content/markdown/docs/history.md.vm ## @@ -93,6 +93,22 @@ Date format is: -MM-DD #release( "2013-10-04" "3.1.1" "announce/201310.mbox/%3C0D117268-CE78-4051-9484-DE2EE770B120%40apache.org%3E" "true" "Java 5" "17" ) #release( "2013-07-15" "3.1.0" "users/201307.mbox/%3C4C1F2A95-5EBB-473E-BC3F-4D3969A78421%40tesla.io%3E" "" "" "" ) #release( "2013-06-10" "3.1.0-alpha-1" "users/201306.mbox/%3C2D8B1BBD-FF9E-4537-A748-857C96664161%40tesla.io%3E" "" "" "" ) + + + +Maven 3.0.x Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Consumer pom and relative disk paths for parent pom
It looks like the branches[1][2] are ready for review, jenkins[3] is happy too. Robert [1] https://github.com/apache/maven/pull/286 [2] https://github.com/apache/maven-integration-testing/pull/66 [3] https://builds.apache.org/job/maven-box/job/maven/job/MNG-6656/ On 25-5-2020 22:54:33, Robert Scholte wrote: next on my list Robert On 25-5-2020 17:42:23, Enrico Olivelli wrote: Robert, do we have news about this great feature ? Enrico Il giorno sab 30 nov 2019 alle ore 14:38 Enrico Olivelli eolive...@gmail.com> ha scritto: > Good news > > Il giorno sab 30 nov 2019 alle ore 14:27 Robert Scholte > rfscho...@apache.org> ha scritto: > >> Hi Enrico, >> >> current implementation says groupId+artifact are required, but you can >> either specify version or relativePath (or omit it, meaning ../pom.xml) >> I've decided to keep G+A so MAven can verify the pom is pointing to the >> right parent. >> MNG-6656 has a demo attached which shows you the new valid pom structure. >> >> > This is the link for reference > > https://github.com/apache/maven/pull/286/files#diff-367b1a6eb386aada5bd28a0aaebe645bR36 > > I am totally ok for keeping G+A, it sounds very sensible to me. > > Thank you so much, I missed that part of the change, or at least I forgot > about it > > I am really sure I want this new feature in 3.7.0 ! > > It looks like we are adding great stuff to Maven for this new major release > > Enrico > > >> thanks, >> Robert >> >> On 30-11-2019 13:39:12, Enrico Olivelli wrote: >> Hi, >> when we move to the consumer pom we can leverage the disk layout of >> projects inside the same repository while looking for the parent pom. >> >> Currently you can use the element to refer to the location >> of a parent pom, AFAIK this is only an hint for Maven and for tools: you >> must always copy all of the coordinates of the parent module because when >> you publish your pom the consumer must be able to find such parent module >> from remote repositories, without having the physical layout of the source >> code. >> >> With the consumer pom with can let the build pom have only the >> relativePath >> element and then we will fill the consumer (deployed) pom with the >> effective parent coordinates. >> >> This will simply a lot this part of Maven that is quite annoying for users >> >> Thoughts? >> Enrico >> >
[GitHub] [maven-site] Tibor17 removed a comment on pull request #176: [MNGSITE-415] say Maven 3.0.x is EOL
Tibor17 removed a comment on pull request #176: URL: https://github.com/apache/maven-site/pull/176#issuecomment-643656541 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
