[GitHub] [maven-site-plugin] slachiewicz merged pull request #50: Bump maven-shared-utils from 3.3.3 to 3.3.4
slachiewicz merged pull request #50: URL: https://github.com/apache/maven-site-plugin/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request #50: Bump maven-shared-utils from 3.3.3 to 3.3.4
dependabot[bot] opened a new pull request #50: URL: https://github.com/apache/maven-site-plugin/pull/50 Bumps [maven-shared-utils](https://github.com/apache/maven-shared-utils) from 3.3.3 to 3.3.4. Commits https://github.com/apache/maven-shared-utils/commit/17091d82508deb9b7067f3434ba16f660ffc5023;>17091d8 [maven-release-plugin] prepare release maven-shared-utils-3.3.4 https://github.com/apache/maven-shared-utils/commit/9f40037bfb04d54dd997a9ab837390045c9a4348;>9f40037 [NOJIRA] Javadoc cleanup in preparation of release https://github.com/apache/maven-shared-utils/commit/4e93c5621ef45c7cf6a03d96ca7a3c45ac4e2062;>4e93c56 [SUREFIRE-1556] fail fast on empty element names (https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/11;>#11) https://github.com/apache/maven-shared-utils/commit/1461e4de42c324a71decfefe0c51a6f80f05f9e2;>1461e4d Revert remove unused plexus dependency https://github.com/apache/maven-shared-utils/commit/8f31df7af9383d278fc5513729e1bdcf254fd997;>8f31df7 update to JUnit 4.13.2 https://github.com/apache/maven-shared-utils/commit/5097ceefd24fc83e005bdfa4e254975b025733ad;>5097cee remove unused plexus dependency https://github.com/apache/maven-shared-utils/commit/b4577c968a84be979e31347d0525f3714724bcd5;>b4577c9 Merge pull request https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/70;>#70 from gnodet/MSHARED-965-help https://github.com/apache/maven-shared-utils/commit/eb4f6355d772739094bcf8edce5d7da894ca8be5;>eb4f635 Merge pull request https://github-redirect.dependabot.com/apache/maven-shared-utils/issues/67;>#67 from gnodet/MNG-6380 https://github.com/apache/maven-shared-utils/commit/0bb44cdc9541beeb9c78927c663d16b6d737eb09;>0bb44cd [MNG-6380] Use the new jansi AnsiMode to control the whether ansi sequences a... https://github.com/apache/maven-shared-utils/commit/f94bb250dcddcddadc610aa7cc28d7b07a9697ed;>f94bb25 [MNG-6915] Add a helper method to get the terminal width Additional commits viewable in https://github.com/apache/maven-shared-utils/compare/maven-shared-utils-3.3.3...maven-shared-utils-3.3.4;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath
We have already moved ahead and the new Resolver should solve this issue. This looks similar to the issue in Surefire which was closed as a bug of Resoler. Michael is currently working on a new Resolver and he was participating in the analysis of the bug too. So, maybe it is still the same root cause for this one. T On Sun, May 2, 2021 at 10:24 PM Dan Tran wrote: > we are in pain with this issue :-) > > -D > > On Sun, Jan 24, 2021 at 2:56 PM Tibor Digana > wrote: > > > Hi Falco, > > > > This is not the first time I have been talking about these principles in > > our team. > > Seven years ago and then in 2019. But sorry I cannot force the people to > do > > it and they have to start by themself. We have to do it together. > > All I can do is to provide some training and elaborate a problem but I am > > convinced that we will meet again after the next seven years if we > > don't understand the JMM. Thus we should prevent from redoing the same > bad > > and understand the process on how to make the code better in the early > > beginning. > > > > Cheers > > Tibor17 > > > > > > On Sun, Jan 24, 2021 at 10:51 PM Falko Modler wrote: > > > > > Hi Tibor, > > > > > > thanks for this very elaborate answer and I always appreciate your > > > feedback, but to me it kind of misses the point a bit...? > > > > > > > may not necessarily have to do with concurrent access. > > > But it does in this special case. Please see the issue and the linked > > > explanations. > > > > > > > The solution with ThreadLocal would eat too much memory. > > > Is that so? Are you sure about this? How much is "too much"? > > > Are there any predefined profiling tests I can run? > > > > > > I mean: yes, it is a workaround and immutable core classes that are > > > _designed_ for concurrent access would be much better, > > > but who is going to do such a massive refactoring (without breaking > > > Maven extensions that are today mutating MavenProject etc.)? > > > > > > TBH, this is one of the, IMHO, critical bugs that should have been > fixed > > > before Maven 4. > > > > > > Cheers, > > > Falko > > > > > > Am 21.01.2021 um 02:13 schrieb Tibor Digana: > > > > I commented on one issue regarding the NULL JAR file in Artifact a > few > > > days > > > > ago. > > > > The thing that some data is "missing" in some large object structures > > in > > > > the environment with multiple threads may not necessarily have to do > > with > > > > concurrent access. > > > > There may not be any writes to MavenProject or MavenSession causing > > > > "missed" data, and the answer why this happens is Memory Model. > > > > > > > > It's the fact that non-concurrent or non-immutable objects may lose > > some > > > > references very easily! > > > > This has all to do with JMM and not the happens-before relationship. > > > > > > > > Suppose that we have thread T1 creating ArrayList and adding elements > > > into > > > > this collection. > > > > artifacts = new ArrayList(); > > > > artifacts.add(new DefaultArtifact(...)); > > > > > > > > Suppose thread T2 reads the artifacts from the collection right after > > > > "artifacts.add()". > > > > Artifact a = artifacts.get(0); > > > > > > > > In practice the following happens: > > > > artifacts.size() returns 1 > > > > but artifacts.get(0) returns NULL > > > > > > > > Let;s explain why it happens. > > > > The implementation of ArrayList is not native. It is a pure Java > > > > implementation which has two variables inside: > > > > + count:int > > > > + array:Object[] > > > > These two variables always appear in a critical section and they do > not > > > > have proper treatments in ArrayList. > > > > Technically, the things are complicated on the CPU level and more > > > > complicated than happens-before theorems. > > > > T1 contains pointers and data in CPU registers or CPU cache. No > Thread > > > has > > > > a direct access to a stack of another Thread, and of course it does > not > > > > operate on main memory. > > > > The CPU uses memory barriers (assembler instructions) and a cache to > > > > operate with RAM and memory coherency. > > > > These instructions are used via Java keywords: final, volatile and > > > > synchronized. > > > > T2 may not see all elements completely from the ArrayList because > there > > > are > > > > no safety mechanisms in the implementation of ArrayList to make this > > > happen. > > > > Thus the T2 may see the values in the Java variable "count" *but it > may > > > not > > > > see the values in* "array", or vice versa. > > > > > > > > The results are NPE, or missing JAR artifacts or the issues with > Maven > > > > Resolver, as we can see in https://github.com/apache/maven/pull/310 > > > > > > > > The solution with ThreadLocal would eat too much memory. > > > > Reimplementing the POJO classes in Maven and making them thread safe > > > would > > > > solve many issues in the Core and Resolver. > > > > Considering my examples with ArrayList, the thread safety should > > continue > > > > deeper
[GitHub] [maven-artifact-transfer] cstamas edited a comment on pull request #24: [MSHARED-987] Make use of SISU
cstamas edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830872440 Added some cleanup (properties may need more) and for fun disabled 3.0.5 in ITs, and added 3.6.3 and 3.8.1, so ITs now run on "3.1.1", "3.2.5", "3.3.9", "3.5.4", "3.6.3", "3.8.1" and all pass OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830872440 Added some cleanup (properties may need more) and for fun disabled 3.0.5 mvn in its, and added 3.6.3 and 3.8.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath
we are in pain with this issue :-) -D On Sun, Jan 24, 2021 at 2:56 PM Tibor Digana wrote: > Hi Falco, > > This is not the first time I have been talking about these principles in > our team. > Seven years ago and then in 2019. But sorry I cannot force the people to do > it and they have to start by themself. We have to do it together. > All I can do is to provide some training and elaborate a problem but I am > convinced that we will meet again after the next seven years if we > don't understand the JMM. Thus we should prevent from redoing the same bad > and understand the process on how to make the code better in the early > beginning. > > Cheers > Tibor17 > > > On Sun, Jan 24, 2021 at 10:51 PM Falko Modler wrote: > > > Hi Tibor, > > > > thanks for this very elaborate answer and I always appreciate your > > feedback, but to me it kind of misses the point a bit...? > > > > > may not necessarily have to do with concurrent access. > > But it does in this special case. Please see the issue and the linked > > explanations. > > > > > The solution with ThreadLocal would eat too much memory. > > Is that so? Are you sure about this? How much is "too much"? > > Are there any predefined profiling tests I can run? > > > > I mean: yes, it is a workaround and immutable core classes that are > > _designed_ for concurrent access would be much better, > > but who is going to do such a massive refactoring (without breaking > > Maven extensions that are today mutating MavenProject etc.)? > > > > TBH, this is one of the, IMHO, critical bugs that should have been fixed > > before Maven 4. > > > > Cheers, > > Falko > > > > Am 21.01.2021 um 02:13 schrieb Tibor Digana: > > > I commented on one issue regarding the NULL JAR file in Artifact a few > > days > > > ago. > > > The thing that some data is "missing" in some large object structures > in > > > the environment with multiple threads may not necessarily have to do > with > > > concurrent access. > > > There may not be any writes to MavenProject or MavenSession causing > > > "missed" data, and the answer why this happens is Memory Model. > > > > > > It's the fact that non-concurrent or non-immutable objects may lose > some > > > references very easily! > > > This has all to do with JMM and not the happens-before relationship. > > > > > > Suppose that we have thread T1 creating ArrayList and adding elements > > into > > > this collection. > > > artifacts = new ArrayList(); > > > artifacts.add(new DefaultArtifact(...)); > > > > > > Suppose thread T2 reads the artifacts from the collection right after > > > "artifacts.add()". > > > Artifact a = artifacts.get(0); > > > > > > In practice the following happens: > > > artifacts.size() returns 1 > > > but artifacts.get(0) returns NULL > > > > > > Let;s explain why it happens. > > > The implementation of ArrayList is not native. It is a pure Java > > > implementation which has two variables inside: > > > + count:int > > > + array:Object[] > > > These two variables always appear in a critical section and they do not > > > have proper treatments in ArrayList. > > > Technically, the things are complicated on the CPU level and more > > > complicated than happens-before theorems. > > > T1 contains pointers and data in CPU registers or CPU cache. No Thread > > has > > > a direct access to a stack of another Thread, and of course it does not > > > operate on main memory. > > > The CPU uses memory barriers (assembler instructions) and a cache to > > > operate with RAM and memory coherency. > > > These instructions are used via Java keywords: final, volatile and > > > synchronized. > > > T2 may not see all elements completely from the ArrayList because there > > are > > > no safety mechanisms in the implementation of ArrayList to make this > > happen. > > > Thus the T2 may see the values in the Java variable "count" *but it may > > not > > > see the values in* "array", or vice versa. > > > > > > The results are NPE, or missing JAR artifacts or the issues with Maven > > > Resolver, as we can see in https://github.com/apache/maven/pull/310 > > > > > > The solution with ThreadLocal would eat too much memory. > > > Reimplementing the POJO classes in Maven and making them thread safe > > would > > > solve many issues in the Core and Resolver. > > > Considering my examples with ArrayList, the thread safety should > continue > > > deeper with the implementation of DefaultArtifact, etc. > > > In my experience, it's worth using the collection which appears in the > > > package "java.util.concurrent". > > > For instance, I use ConcurrentLinkedDequeue for simple iterators with > > small > > > amounts of elements. Alternatively use COWAL for large data and > > reordering > > > of elements by adding or removing them somewhere inside. > > > > > > Cheers > > > Tibor17 > > > > > > > > > > > > On Sat, Jan 16, 2021 at 10:21 PM Dan Tran wrote: > > > > > >> we are facing the same issue at work (300+ modules), classpath > > >> empty randomly empty > > >> > >
[GitHub] [maven-artifact-transfer] cstamas closed pull request #30: Add GH actions
cstamas closed pull request #30: URL: https://github.com/apache/maven-artifact-transfer/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830857877 > I think I know what you've done. Whereas I started with the single jar approach, you separated the code into modules. > I can't see the new structure, but I know there were sometimes even 3 implementation due to changes in Aether. How did you solve that? I found max two implementations (3.0 and 3.0.2) of RepositoryManager, the rest was "clean" (one 3.0 and one 3.1). So unsure where there are 3 implementations... In short, all the DefaultXXX classes extends this one https://github.com/apache/maven-artifact-transfer/blob/MSHARED-987-providers/maven-artifact-transfer-api/src/main/java/org/apache/maven/shared/transfer/support/DelegatorSupport.java And Selector (currently very roughly implemented, but we can easily refine it once needed for more differentiation) https://github.com/apache/maven-artifact-transfer/blob/MSHARED-987-providers/maven-artifact-transfer-api/src/main/java/org/apache/maven/shared/transfer/support/Selector.java It uses two key things: * SISU: on "collection lookup" (injecting map of components) will silently skip components that cannot be loaded due CNFEx (so org.sonatype using things will be silently omitted from delegate map in maven 3.1, and other way around, org.eclipse using things will be omitted in maven 3.0 (note: this does not stand for DIRECT lookup, ie. if you lookup single component by key, and you get CNFex, SISU will fail naturally). * Selector: then "narrows" and selects "proper" component (by detected runtime) from the map Note: sisu injection of map does NOT instantiate all found components, as map is "lazy" (sisu detail), so at the end, you end with ONLY ONE instantiated component doing the work for given runtime (components are created atomically when they are getted from map). Re selection: it is simple (only 3.0 vs 3.1) as I found no case of finer selection needed (there was 3.0 vs 3.0.2, but we upped 3.0 to 3.0.5). But, if needed, we can create fine grained or even hierarchical versioning, and make Selector "smarter", but as I said, is currently not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #24: [MSHARED-987] Make use of SISU
rfscholte commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830853914 I think I know what you've done. Whereas I started with the single jar approach, you separated the code into modules. I can't see the new structure, but I know there were sometimes even 3 implementation due to changes in Aether. How did you solve that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #30: Add GH actions
cstamas commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624738405
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Java CI
+
+on: [push, pull_request]
+
+jobs:
+ build:
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v2
+
+ - name: Set up cache for ~/.m2/repository
+uses: actions/cache@v2
+with:
+ path: ~/.m2/repository
+ key: maven-${{ matrix.os }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+maven-${{ matrix.os }}-
+
+ - name: Set up JDK 1.8
Review comment:
thanks @pzygielo for help! pls eyeball and approve if OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] pzygielo commented on a change in pull request #30: Add GH actions
pzygielo commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624737531
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Java CI
+
+on: [push, pull_request]
+
+jobs:
+ build:
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v2
+
+ - name: Set up cache for ~/.m2/repository
+uses: actions/cache@v2
+with:
+ path: ~/.m2/repository
+ key: maven-${{ matrix.os }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+maven-${{ matrix.os }}-
+
+ - name: Set up JDK 1.8
Review comment:
https://github.com/actions/setup-java/blob/main/docs/switching-to-v2.md
needs 1.8 -> 8 changed,
and distribution selected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] pzygielo commented on a change in pull request #30: Add GH actions
pzygielo commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624737531
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Java CI
+
+on: [push, pull_request]
+
+jobs:
+ build:
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v2
+
+ - name: Set up cache for ~/.m2/repository
+uses: actions/cache@v2
+with:
+ path: ~/.m2/repository
+ key: maven-${{ matrix.os }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+maven-${{ matrix.os }}-
+
+ - name: Set up JDK 1.8
Review comment:
https://github.com/actions/setup-java/blob/main/docs/switching-to-v2.md
needs 1.8 -> 8 changed,
+ distribution selected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #30: Add GH actions
cstamas commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624737309
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Java CI
+
+on: [push, pull_request]
+
+jobs:
+ build:
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v2
+
+ - name: Set up cache for ~/.m2/repository
+uses: actions/cache@v2
+with:
+ path: ~/.m2/repository
+ key: maven-${{ matrix.os }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+maven-${{ matrix.os }}-
+
+ - name: Set up JDK 1.8
+uses: actions/setup-java@v1
Review comment:
yup, updating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] pzygielo commented on a change in pull request #30: Add GH actions
pzygielo commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624737151
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Java CI
+
+on: [push, pull_request]
+
+jobs:
+ build:
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v2
+
+ - name: Set up cache for ~/.m2/repository
+uses: actions/cache@v2
+with:
+ path: ~/.m2/repository
+ key: maven-${{ matrix.os }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+maven-${{ matrix.os }}-
+
+ - name: Set up JDK 1.8
+uses: actions/setup-java@v1
Review comment:
why not current, maintained, v2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas opened a new pull request #30: Add GH actions
cstamas opened a new pull request #30: URL: https://github.com/apache/maven-artifact-transfer/pull/30 To run also ITs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850967 So to say, "restructure" the code, make these modules and remove the reflection cruft (to make easier to maintain and more readable), and then we merge this PR, and then as 2nd iteration we go and solve those NPEs and other stuff we think are not needed (the two 3.0.x related repomanagers, are to be merged into one class actually). But again, _this PR is not that PR_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850698 > Can you explain why we need `Maven302RepositoryManager` instead of just `Maven302RepositoryManager`? Again, old code that I did not touch (aside of making it component). I wanted to make this reshuffle least volatile re old code, keep it unchanged as much is posslble -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] michael-o edited a comment on pull request #24: [MSHARED-987] Make use of SISU
michael-o edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850011 Can you explain why we need `Maven302RepositoryManager` instead of just `Maven302RepositoryManager`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850011 Can you explain why we need `Maven302RepositoryManager? instead of just `Maven302RepositoryManager`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830849772 > > > General remark @michael-o : I did not made any other code change then: > > * added ProjectBuildingRequest parameter to methods, removed some unneeded members (like remote repositories). > > * removed reflection bits, replaced with direct calls > > * removed some reflection utilities, replaced with direct calls > > > My point is, that those NPE comments of your are about _old code_, I did not introduce any logic/code change in that area, and IMO we can do those later as improvement, but for now I'd leave code as is (is really just "reshuffled" into modules + changes I wrote above). I agree with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830849694 Applied PR comments (sans NPE, see above why), all ITs pass except the 3.0.5 (as before, as it's sisu does not speak sisu index) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734298
##
File path: maven-artifact-transfer/pom.xml
##
@@ -0,0 +1,188 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+
+org.apache.maven.shared
+maven-artifact-transfer-parent
+2.0.0-SNAPSHOT
+
+
+ maven-artifact-transfer
+
+ Apache Maven Artifact Transfer
+
+
+3.1.0
+
+
+
+
+ org.apache.maven.shared
+ maven-artifact-transfer-api
+
+
+ org.apache.maven.shared
+ maven-artifact-transfer-maven-3.0.x
+
+
+ org.apache.maven.shared
+ maven-artifact-transfer-maven-3.1.x
+
+
+
+
+ org.apache.maven
+ maven-core
+ ${downstreamMaven.version}
+
+
+
+ org.apache.maven
+ maven-artifact
+ ${downstreamMaven.version}
+
+
+
+ org.apache.maven.shared
+ maven-common-artifact-filters
+ ${artifactFilters.version}
+
+
+
+ org.codehaus.plexus
+ plexus-utils
+
+
+
+
+
+ junit
+ junit
+ test
+
+
+
+ org.slf4j
+ slf4j-simple
+ test
+
+
+
+ org.mockito
+ mockito-core
+ test
+
+
+
+ javax.inject
+ javax.inject
+ test
+
+
+
+
+
+
+org.eclipse.sisu
+sisu-maven-plugin
+
+
+org.apache.rat
+apache-rat-plugin
+
+
+org.codehaus.mojo
+animal-sniffer-maven-plugin
+
+
+
+
+
+
+ run-its
+
+
+
+org.apache.maven.plugins
+maven-invoker-plugin
+
+
+org.codehaus.groovy
+groovy
+3.0.7
+
+
+org.codehaus.gmaven.runtime
+gmaven-runtime-2.0
+1.5
+
+
+
+ true
+ false
+
${project.build.directory}/local-repo
+ ${project.build.directory}/it
+ src/it
+ true
+
+*/pom.xml
+
+ setup
+ verify
+ src/it/settings.xml
+
+ 1
+
+
${repository.proxy.url}
+
${project.build.directory}/local-repo
+
+
+
org.apache.maven:apache-maven:3.0.5:tar.gz:bin
+
org.apache.maven:apache-maven:3.1.1:tar.gz:bin
+
org.apache.maven:apache-maven:3.2.5:tar.gz:bin
+
org.apache.maven:apache-maven:3.3.1:tar.gz:bin
+
org.apache.maven:apache-maven:3.3.9:tar.gz:bin
+
org.apache.maven:apache-maven:3.5.0:tar.gz:bin
Review comment:
fixed, and added 3.6.3 and 3.8.1 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734274 ## File path: maven-artifact-transfer/pom.xml ## @@ -0,0 +1,188 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + +org.apache.maven.shared +maven-artifact-transfer-parent +2.0.0-SNAPSHOT + + + maven-artifact-transfer + + Apache Maven Artifact Transfer + + +3.1.0 Review comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734205 ## File path: maven-3.1.x/pom.xml ## @@ -0,0 +1,148 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + +org.apache.maven.shared +maven-artifact-transfer-parent +2.0.0-SNAPSHOT + + + maven-artifact-transfer-maven-3.1.x + + Apache Maven Artifact Transfer Maven 3.1.x provider + + +3.1.0 Review comment: fixed ## File path: maven-artifact-transfer-api/pom.xml ## @@ -0,0 +1,107 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + +org.apache.maven.shared +maven-artifact-transfer-parent +2.0.0-SNAPSHOT + + + maven-artifact-transfer-api + + Apache Maven Artifact Transfer API + + + + + javax.inject + javax.inject + provided + + + org.apache.maven + maven-core + 3.0 + provided + + + org.apache.maven + maven-artifact + 3.0 Review comment: moved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734173 ## File path: maven-3.0.x/src/main/java/org/apache/maven/shared/transfer/repository/internal/Maven302RepositoryManager.java ## @@ -20,18 +20,24 @@ */ import org.sonatype.aether.RepositorySystem; -import org.sonatype.aether.RepositorySystemSession; import org.sonatype.aether.repository.LocalRepository; +import javax.inject.Inject; +import javax.inject.Named; +import javax.inject.Singleton; + /** - * + * */ -class Maven302RepositoryManager -extends Maven30RepositoryManager +@Singleton +@Named( "maven-3.0.2" ) Review comment: fixed, as maven 3.0.x went to maven 3.0.5 (but kept original code, just make other abstract and this one MAVEN_3_0_X) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734045 ## File path: maven-3.0.x/pom.xml ## @@ -0,0 +1,148 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + +org.apache.maven.shared +maven-artifact-transfer-parent +2.0.0-SNAPSHOT + + + maven-artifact-transfer-maven-3.0.x + + Apache Maven Artifact Transfer Maven 3.0.x provider + + +3.0 +1.7 Review comment: updated, as maven went 3.0.5, sonatype aether MUST go in lockstep, is 1.13.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624730059 ## File path: maven-3.0.x/pom.xml ## @@ -0,0 +1,148 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + +org.apache.maven.shared +maven-artifact-transfer-parent +2.0.0-SNAPSHOT + + + maven-artifact-transfer-maven-3.0.x + + Apache Maven Artifact Transfer Maven 3.0.x provider + + +3.0 +1.7 Review comment: ? https://repo1.maven.org/maven2/org/sonatype/aether/aether-api/1.7/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas edited a comment on pull request #24: [MSHARED-987] Make use of SISU
cstamas edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830844133 General remark @michael-o : I did not made any other code change then: * added ProjectBuildingRequest parameter to methods, removed some unneeded members (like remote repositories). * removed reflection bits, replaced with direct calls * removed some reflection utilities, replaced with direct calls My point is, that those NPE comments of your are about _old code_, I did not introduce any logic/code change in that area, and IMO we can do those later as improvement, but for now I'd leave code as is (is really just "reshuffled" into modules + changes I wrote above). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU
cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830844133 General remark @michael-o : I did not made any other code change then: * added to methods ProjectBuildingRequest * removed reflection bits, replaced with direct calls * removed some reflection utilities, replaced with direct calls My point is, that those NPE comments of your are about _old code_, I did not introduce any logic/code change in that area, and IMO we can do those later as improvement, but for now I'd leave code as is (is really just "reshuffled" into modules + changes I wrote above). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #48: [MSITE-872] Set the Content-Type header
michael-o commented on pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#issuecomment-830843997 The test looks convoluted to me. Why not fire up Jetty, and get the `Content-Type` header from response? Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] qualitesys commented on a change in pull request #48: [MSITE-872] Set the Content-Type header
qualitesys commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r624727891 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -114,6 +117,16 @@ public void doFilter( ServletRequest servletRequest, ServletResponse servletResp path = path.substring( languageWanted.length() + 1 ); } } +// Set the contentType for the response +Path aPath = Paths.get( path ); +if ( null != aPath ) Review comment: corrected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] michael-o commented on a change in pull request #24: [MSHARED-987] Make use of SISU
michael-o commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624720934
##
File path: maven-3.0.x/pom.xml
##
@@ -0,0 +1,148 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+
+org.apache.maven.shared
+maven-artifact-transfer-parent
+2.0.0-SNAPSHOT
+
+
+ maven-artifact-transfer-maven-3.0.x
+
+ Apache Maven Artifact Transfer Maven 3.0.x provider
+
+
+3.0
+1.7
Review comment:
Does not exist in Maven Central:
https://search.maven.org/artifact/org.sonatype.aether/aether-api
##
File path:
maven-artifact-transfer-api/src/main/java/org/apache/maven/shared/transfer/artifact/install/internal/DefaultArtifactInstaller.java
##
@@ -0,0 +1,89 @@
+package org.apache.maven.shared.transfer.artifact.install.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.project.ProjectBuildingRequest;
+import org.apache.maven.shared.transfer.artifact.install.ArtifactInstaller;
+import
org.apache.maven.shared.transfer.artifact.install.ArtifactInstallerException;
+import org.apache.maven.shared.transfer.support.DelegatorSupport;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.util.Collection;
+import java.util.Map;
+
+/**
+ *
+ */
+@Singleton
+@Named
+public class DefaultArtifactInstaller
+extends DelegatorSupport
+implements ArtifactInstaller
+{
+@Inject
+public DefaultArtifactInstaller( Map
delegates )
+{
+super( delegates );
+}
+
+public void install( ProjectBuildingRequest request,
+ Collection mavenArtifacts )
+throws ArtifactInstallerException, IllegalArgumentException
+{
+validateParameters( request, mavenArtifacts );
+delegate.install( request, mavenArtifacts );
+}
+
+public void install( ProjectBuildingRequest request,
+ File localRepository,
+ Collection mavenArtifacts ) throws
ArtifactInstallerException
+{
+validateParameters( request, mavenArtifacts );
+if ( localRepository == null )
+{
+throw new IllegalArgumentException( "The parameter localRepository
is not allowed to be null." );
+}
+if ( !localRepository.isDirectory() )
+{
+throw new IllegalArgumentException( "The parameter localRepository
must be a directory." );
+}
+delegate.install( request, localRepository, mavenArtifacts );
+}
+
+private void validateParameters( ProjectBuildingRequest request,
Collection mavenArtifacts )
+{
+if ( request == null )
+{
+throw new IllegalArgumentException( "The parameter request is not
allowed to be null." );
+}
+if ( mavenArtifacts == null )
Review comment:
NPE
##
File path:
maven-artifact-transfer-api/src/main/java/org/apache/maven/shared/transfer/artifact/resolve/internal/DefaultArtifactResolver.java
##
@@ -0,0 +1,89 @@
+package org.apache.maven.shared.transfer.artifact.resolve.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the
[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #28: Bump maven-common-artifact-filters from 3.1.0 to 3.2.0
dependabot[bot] commented on pull request #28: URL: https://github.com/apache/maven-artifact-transfer/pull/28#issuecomment-830804334 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] asfgit closed pull request #28: Bump maven-common-artifact-filters from 3.1.0 to 3.2.0
asfgit closed pull request #28: URL: https://github.com/apache/maven-artifact-transfer/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] asfgit closed pull request #25: Bump aether-util from 0.9.0.M2 to 1.1.0
asfgit closed pull request #25: URL: https://github.com/apache/maven-artifact-transfer/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #25: Bump aether-util from 0.9.0.M2 to 1.1.0
dependabot[bot] commented on pull request #25: URL: https://github.com/apache/maven-artifact-transfer/pull/25#issuecomment-830804164 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #26: Bump aether-api from 0.9.0.M2 to 1.1.0
dependabot[bot] commented on pull request #26: URL: https://github.com/apache/maven-artifact-transfer/pull/26#issuecomment-830804047 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] asfgit closed pull request #26: Bump aether-api from 0.9.0.M2 to 1.1.0
asfgit closed pull request #26: URL: https://github.com/apache/maven-artifact-transfer/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] asfgit closed pull request #29: Bump aether-impl from 1.7 to 1.13.1
asfgit closed pull request #29: URL: https://github.com/apache/maven-artifact-transfer/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #29: Bump aether-impl from 1.7 to 1.13.1
dependabot[bot] commented on pull request #29: URL: https://github.com/apache/maven-artifact-transfer/pull/29#issuecomment-830803994 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] asfgit closed pull request #27: Bump maven-artifact from 3.0 to 3.8.1
asfgit closed pull request #27: URL: https://github.com/apache/maven-artifact-transfer/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #27: Bump maven-artifact from 3.0 to 3.8.1
dependabot[bot] commented on pull request #27: URL: https://github.com/apache/maven-artifact-transfer/pull/27#issuecomment-830803947 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #29: Bump aether-impl from 1.7 to 1.13.1
dependabot[bot] opened a new pull request #29: URL: https://github.com/apache/maven-artifact-transfer/pull/29 Bumps [aether-impl](https://github.com/sonatype/sonatype-aether) from 1.7 to 1.13.1. Commits https://github.com/sonatype/sonatype-aether/commit/50983e14b99ff694cbb150612352c621b3d7d695;>50983e1 [maven-release-plugin] prepare release aether-1.13.1 https://github.com/sonatype/sonatype-aether/commit/2edd0b8c2ee12cad48b718d3d4d11f991d868f2b;>2edd0b8 [maven-release-plugin] prepare for next development iteration https://github.com/sonatype/sonatype-aether/commit/2277471fc6fade88e66f1c637d90073cd4235831;>2277471 [maven-release-plugin] prepare release aether-1.13.1 https://github.com/sonatype/sonatype-aether/commit/bce194c4e13451ef3806401a338ab3d7ffe798e8;>bce194c o Declared content length for checksums to avoid chunked transfer encoding wh... https://github.com/sonatype/sonatype-aether/commit/7c6ea371877c3fae2cb645bee254df8505e975da;>7c6ea37 o Updated readme to mention Eclipse resources where appropriate https://github.com/sonatype/sonatype-aether/commit/a7aaf6318cd8b47ff2704bcdc9660b8d5b2d1fb6;>a7aaf63 [AETHER-127] Ordering implemented by GenericVersionScheme is not well-defined https://github.com/sonatype/sonatype-aether/commit/c249b3fe643312e6951dcdea586eeac849727626;>c249b3f o Fixed code to obey API contract with regard to null handling https://github.com/sonatype/sonatype-aether/commit/0c2020c338c65ba2bc2dfe8e0f472b7b658f9345;>0c2020c o Extended docs https://github.com/sonatype/sonatype-aether/commit/24f08a84528fea2e2055ab91f6c7fe8a06d0ca83;>24f08a8 o Improved docs https://github.com/sonatype/sonatype-aether/commit/b077ffd62364398a2d7ca4fec94e88cc7cd0bdc7;>b077ffd o Fixed typos Additional commits viewable in https://github.com/sonatype/sonatype-aether/compare/aether-1.7...aether-1.13.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #28: Bump maven-common-artifact-filters from 3.1.0 to 3.2.0
dependabot[bot] opened a new pull request #28: URL: https://github.com/apache/maven-artifact-transfer/pull/28 Bumps [maven-common-artifact-filters](https://github.com/apache/maven-common-artifact-filters) from 3.1.0 to 3.2.0. Commits https://github.com/apache/maven-common-artifact-filters/commit/637f9ed8f389481eac0e590effb0267e9186c269;>637f9ed [maven-release-plugin] prepare release maven-common-artifact-filters-3.2.0 https://github.com/apache/maven-common-artifact-filters/commit/07e5b4c3f266b0465b4e323dcf9bb5f9aaebe129;>07e5b4c (doc) update plugins, skin https://github.com/apache/maven-common-artifact-filters/commit/616005a50e59284345737249b9077de2d822e203;>616005a (doc) apply javadoc:fix https://github.com/apache/maven-common-artifact-filters/commit/303d99b16f3c22f08d3e3441a6e2cbf3a9a3f9e8;>303d99b Bump jmh from 1.26 to 1.27 https://github.com/apache/maven-common-artifact-filters/commit/4a6f6d6241626ff1f8bce09e9d393126019219f9;>4a6f6d6 [MSHARED-975] Big speed improvements for patterns that do not contain any wil... https://github.com/apache/maven-common-artifact-filters/commit/606754844b7024cfba8c73200eba1c35766ffc82;>6067548 [MSHARED-974] Cleanup after mvn dependency:analyze https://github.com/apache/maven-common-artifact-filters/commit/17819fe7a6d2ea5e76980e98798b3c3753a916fb;>17819fe [MSHARED-974] Remove obsolete code and references to Sonatype Aether https://github.com/apache/maven-common-artifact-filters/commit/1f6726680b6e2b2e615abe9aba65bbccb4b043c4;>1f67266 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-common-artifact-filters/commit/23581017a22558b75150eeac2d622f9179f9adfa;>2358101 [maven-release-plugin] prepare release maven-common-artifact-filters-3.1.1 https://github.com/apache/maven-common-artifact-filters/commit/a651c7a4e4ef44003dc29b823e3f062200d79543;>a651c7a (doc) Fix javadoc: tag not supported in the generated HTML version: tt Additional commits viewable in https://github.com/apache/maven-common-artifact-filters/compare/maven-common-artifact-filters-3.1.0...maven-common-artifact-filters-3.2.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #27: Bump maven-artifact from 3.0 to 3.8.1
dependabot[bot] opened a new pull request #27: URL: https://github.com/apache/maven-artifact-transfer/pull/27 Bumps [maven-artifact](https://github.com/apache/maven) from 3.0 to 3.8.1. Commits https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d;>05c21c6 [maven-release-plugin] prepare release maven-3.8.1 https://github.com/apache/maven/commit/d295dc362fe7d7b189b4976a5742a17362eb51a1;>d295dc3 [MNG-7128] keep blocked attribute from mirrors in artifact repositories https://github.com/apache/maven/commit/a46906806a31edb462b935e380a657b6efde6231;>a469068 next version in branch 3.8.x is 3.8.1-SNAPSHOT https://github.com/apache/maven/commit/dad8a3e1c55f34b7949945bc622f26447ddbf4f9;>dad8a3e [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/6aa1f4acf5d6323e9aa08b763cb9933dc96749b9;>6aa1f4a [maven-release-plugin] prepare release maven-3.8.0 https://github.com/apache/maven/commit/907d53ad3264718f66ff15e1363d76b07dd0c05f;>907d53a [MNG-7118] block HTTP repositories by default https://github.com/apache/maven/commit/899465aeec03753ea91e15a79579eab76369c016;>899465a [MNG-7117] add support for blocked mirror https://github.com/apache/maven/commit/fa79cb22e456cc65522b5bab8c4240fe08c5775f;>fa79cb2 [MNG-7116] add support for mirrorOf external:http:* https://github.com/apache/maven/commit/e5f6634e17362387282b3867c9b23d4b54fea871;>e5f6634 use Maven Resolver 1.6.2 https://github.com/apache/maven/commit/09f77da9b0c39848fe763bdd4a392151eec0d8c3;>09f77da [MNG-7119] Upgrade Maven Wagon to 3.4.3 Additional commits viewable in https://github.com/apache/maven/compare/maven-3.0...maven-3.8.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #26: Bump aether-api from 0.9.0.M2 to 1.1.0
dependabot[bot] opened a new pull request #26: URL: https://github.com/apache/maven-artifact-transfer/pull/26 Bumps aether-api from 0.9.0.M2 to 1.1.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #25: Bump aether-util from 0.9.0.M2 to 1.1.0
dependabot[bot] opened a new pull request #25: URL: https://github.com/apache/maven-artifact-transfer/pull/25 Bumps aether-util from 0.9.0.M2 to 1.1.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
