Re: [VOTE] Release Apache Maven version 3.8.2
Hello, I am not able to dedicate the time to do bisecting this issue -D On Mon, Aug 9, 2021 at 3:03 AM Eric Lilja wrote: > It's an impressive list of fixes and we are many that would like to see a > 3.8.2 release appear. Question for me is if the particular change > that appears to cause a general performance degradation on the scale of ten > percent is worth it (if it indeed can be isolated to particular JIRA and > not due to general performance creep). No word on the bisect? I find it a > bit hard to give a verdict now...if the fix was for a problem that only > affected a small number of users, but its solution makes everyone pay a > performance decrease, it might not be worth it in its current form > > - Eric L > > On Mon, Aug 9, 2021 at 11:50 AM Arnaud Héritier > wrote: > > > +1 > > Tested on several projects with no issue > > I agree that the performance is a bit degraded but nothing blocker > compared > > the value of the fixes introduced here. > > > > On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz < > > slachiew...@gmail.com> > > wrote: > > > > > +1 > > > > > > niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte < > > rfscho...@apache.org> > > > napisał: > > > > > > > +1 > > > > On 4-8-2021 22:02:18, Michael Osipov wrote: > > > > Hi, > > > > > > > > We solved 68 issues: > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965 > > > > > > > > There are still a couple of issues left in JIRA: > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC > > > > > > > > Staging repo: > > > > https://repository.apache.org/content/repositories/maven-1657/ > > > > > > > > Dev dist directory: > > > > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/ > > > > > > > > Source release checksums: > > > > apache-maven-3.8.2-src.zip sha512: > > > > > > > > > > > > > > 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd > > > > apache-maven-3.8.2-src.tar.gz sha512: > > > > > > > > > > > > > > 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6 > > > > > > > > Binary release checksums: > > > > apache-maven-3.8.2-bin.zip sha512: > > > > > > > > > > > > > > 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced > > > > apache-maven-3.8.2-bin.tar.gz sha512: > > > > > > > > > > > > > > b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222 > > > > > > > > Draft for release notes: > > > > https://github.com/apache/maven-site/pull/251 > > > > > > > > > > > > Guide to testing staged releases: > > > > > http://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > > Vote open for at least 72 hours. > > > > > > > > [ ] +1 > > > > [ ] +0 > > > > [ ] -1 > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > > > > > -- > > Arnaud Héritier > > Twitter/GitHub/... : aheritier > > >
Re: maven-shade-plugin question
Looking only at the log, both writers existed before it was promoted from the sandbox in 2007. Counter was introduced by Karl Heinz while refactoring. It could very well be there's a better solution for it right now. I would expect enough coverage by ITs to confirm that. Robert On 9-8-2021 16:35:13, Tamás Cservenák wrote: Howdy, re maven-shade-plugin's Java package org.apache.maven.plugins.shade.pom: 1. What is the goal of this code? As there are 3 classes in here, and Counter is used only by MavenJDOMWriter, while MavenJDOMWriter is used only by PomWriter, while PomWriter is used only by ShadeMojo (to write out dep reduced POM), but 2. ... the xpp3 writer is available as well, as maven-model is pulled in as direct dependency, 3. ... but moreover, the model-writer is there as well (true. as maven-core transitive dep) so, what is the reason these classes exist? Do I miss something? Thanks T
Re: Commandline inheritance
When I see "global" I think scope (applies to all users) not precedence (applies first). I'm happy with option 5 as it stands. It allows configuration to be set that can both overide or be overridden by the project, without changing system files. Delany On Mon, 9 Aug 2021, 15:09 Benjamin Marwell, wrote: > Hi Robert, > > I would like to propose another solution. > According to the wiki page and to the documentation, we have > > user < installation (aka global) < project. > > where "<" means "is overridden by". > > From what I understand from other build systems, a more common approach > would be > > installation (aka global) < user < project > > This would fix the naming issue (global becomes global). > Of course this is a breaking change, but for maven 4, this seems > reasonable to me. > > Am So., 8. Aug. 2021 um 11:48 Uhr schrieb Robert Scholte < > rfscho...@apache.org>: > > > > During a discussion with Michael we noticed there's something odd about > the names of some flags and the order of inheritance. > > > > I've tried to explain it on a separate wiki page[1] together with the > first 3 options how we could fix it. > > Please have a look at it and share your thoughts. > > > > thanks, > > Robert > > > > [1] > https://cwiki.apache.org/confluence/display/MAVEN/Commandline+inheritance > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Commandline inheritance
I'll add it, but it doesn't match the order of GIT[1] as mentioned by Michael. Maybe there should be a list of other comparable tools with their order Robert [1] https://git-scm.com/docs/git-config#FILES On 9-8-2021 15:09:30, Benjamin Marwell wrote: Hi Robert, I would like to propose another solution. According to the wiki page and to the documentation, we have user where " >From what I understand from other build systems, a more common approach would >be installation (aka global) This would fix the naming issue (global becomes global). Of course this is a breaking change, but for maven 4, this seems reasonable to me. Am So., 8. Aug. 2021 um 11:48 Uhr schrieb Robert Scholte : > > During a discussion with Michael we noticed there's something odd about the > names of some flags and the order of inheritance. > > I've tried to explain it on a separate wiki page[1] together with the first 3 > options how we could fix it. > Please have a look at it and share your thoughts. > > thanks, > Robert > > [1] https://cwiki.apache.org/confluence/display/MAVEN/Commandline+inheritance - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-shade-plugin question
Howdy, re maven-shade-plugin's Java package org.apache.maven.plugins.shade.pom: 1. What is the goal of this code? As there are 3 classes in here, and Counter is used only by MavenJDOMWriter, while MavenJDOMWriter is used only by PomWriter, while PomWriter is used only by ShadeMojo (to write out dep reduced POM), but 2. ... the xpp3 writer is available as well, as maven-model is pulled in as direct dependency, 3. ... but moreover, the model-writer is there as well (true. as maven-core transitive dep) so, what is the reason these classes exist? Do I miss something? Thanks T
Re: Commandline inheritance
Hi Robert, I would like to propose another solution. According to the wiki page and to the documentation, we have user < installation (aka global) < project. where "<" means "is overridden by". >From what I understand from other build systems, a more common approach would >be installation (aka global) < user < project This would fix the naming issue (global becomes global). Of course this is a breaking change, but for maven 4, this seems reasonable to me. Am So., 8. Aug. 2021 um 11:48 Uhr schrieb Robert Scholte : > > During a discussion with Michael we noticed there's something odd about the > names of some flags and the order of inheritance. > > I've tried to explain it on a separate wiki page[1] together with the first 3 > options how we could fix it. > Please have a look at it and share your thoughts. > > thanks, > Robert > > [1] https://cwiki.apache.org/confluence/display/MAVEN/Commandline+inheritance - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
It's an impressive list of fixes and we are many that would like to see a 3.8.2 release appear. Question for me is if the particular change that appears to cause a general performance degradation on the scale of ten percent is worth it (if it indeed can be isolated to particular JIRA and not due to general performance creep). No word on the bisect? I find it a bit hard to give a verdict now...if the fix was for a problem that only affected a small number of users, but its solution makes everyone pay a performance decrease, it might not be worth it in its current form - Eric L On Mon, Aug 9, 2021 at 11:50 AM Arnaud Héritier wrote: > +1 > Tested on several projects with no issue > I agree that the performance is a bit degraded but nothing blocker compared > the value of the fixes introduced here. > > On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz < > slachiew...@gmail.com> > wrote: > > > +1 > > > > niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte < > rfscho...@apache.org> > > napisał: > > > > > +1 > > > On 4-8-2021 22:02:18, Michael Osipov wrote: > > > Hi, > > > > > > We solved 68 issues: > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965 > > > > > > There are still a couple of issues left in JIRA: > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC > > > > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1657/ > > > > > > Dev dist directory: > > > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/ > > > > > > Source release checksums: > > > apache-maven-3.8.2-src.zip sha512: > > > > > > > > > 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd > > > apache-maven-3.8.2-src.tar.gz sha512: > > > > > > > > > 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6 > > > > > > Binary release checksums: > > > apache-maven-3.8.2-bin.zip sha512: > > > > > > > > > 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced > > > apache-maven-3.8.2-bin.tar.gz sha512: > > > > > > > > > b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222 > > > > > > Draft for release notes: > > > https://github.com/apache/maven-site/pull/251 > > > > > > > > > Guide to testing staged releases: > > > http://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > Vote open for at least 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > -- > Arnaud Héritier > Twitter/GitHub/... : aheritier >
Re: [VOTE] Release Apache Maven version 3.8.2
+1 Tested on several projects with no issue I agree that the performance is a bit degraded but nothing blocker compared the value of the fixes introduced here. On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz wrote: > +1 > > niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte > napisał: > > > +1 > > On 4-8-2021 22:02:18, Michael Osipov wrote: > > Hi, > > > > We solved 68 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965 > > > > There are still a couple of issues left in JIRA: > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1657/ > > > > Dev dist directory: > > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/ > > > > Source release checksums: > > apache-maven-3.8.2-src.zip sha512: > > > > > 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd > > apache-maven-3.8.2-src.tar.gz sha512: > > > > > 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6 > > > > Binary release checksums: > > apache-maven-3.8.2-bin.zip sha512: > > > > > 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced > > apache-maven-3.8.2-bin.tar.gz sha512: > > > > > b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222 > > > > Draft for release notes: > > https://github.com/apache/maven-site/pull/251 > > > > > > Guide to testing staged releases: > > http://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- Arnaud Héritier Twitter/GitHub/... : aheritier
