Follow up on https://issues.apache.org/jira/browse/MNG-6354

2021-09-19 Thread Romain Manni-Bucau 
Hi all,

Now that CDI is gone we still have some leaking packages not in a (almost)
pure maven ecosystem:
https://github.com/apache/maven/blob/406c525ec45da466387dbf19f7fd8ed1d9885e66/maven-core/src/main/resources/META-INF/maven/extension.xml#L98

(pure kind of means plexus/maven/sonatype/aether even if not 100% accurate
but conflicts there are very very rare)

We keep javax annotation, inject and slf4j exported.

I fully understand dropping them would break a lot of apps without some
careness but I think, due to our architecture and plugin/ext system, it
would be sane for maven to never export something not considered internal
since we take the risk to conflict or limit plugins with the related
packages (ex slf4 event was not exported at some point or newer version
usages will have issues).

I assume we'll not target it for 3.x but it sounds a good design fix for
4.x.

One option to not break is to rewrite the related classes/annotations with
asm - at build time for mojo if possible and inject in plugin.xml a flag
saying "it is done" - or at run time - with a ClassFileTransformer in the
ClassRealm - for existing instances.

I'm not yet 100% sure which path is the sanest but hope the issue, at
least, is clear.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book

Re: GitHub Actions on Maven projects

2021-09-19 Thread Benjamin Marwell 
That won't work for all plugins.
The jlink plugin and others are using complicated setups so they can use
toolchains on GitHub Actions. It's a little bit complicated there because
the plugin does work with java 8 as long as a java 9+ is configured via
toolchains.

Please make sure those actions continue to work.




On Sun, 19 Sep 2021, 20:22 Martin Kanters,  wrote:

> Sounds like a great idea!
>
> Martin
>
> Op zo 19 sep. 2021 om 00:26 schreef Tamás Cservenák :
>
> > +1 for global action
> >
> > T
> >
> > On Sat, Sep 18, 2021, 13:35 Slawomir Jaranowski 
> > wrote:
> >
> > > Hi,
> > >
> > > Thanks for your response. I know that jenkins build is the master for
> > > Apache projects,
> > > but most of the projects have some GA workflows configuration which
> many
> > > times are different.
> > > This situation generates more work for maintainer.
> > >
> > > Thanks to composite actions [1] we can create one global action which
> has
> > > defined all required steps and one action for providing configurations
> > > values like jkd list,
> > > both of these actions can be in one repository.
> > >
> > > In the rest of the project we can use those global actions, so when
> next
> > > time we want to change, e.g. jdk list (it changes every 6 month ;-) )
> we
> > > only change it in one place.
> > > This approach can make less maintenance work in maven projects.
> > >
> > > If you are interested let me know, I can prepare some spikes for you
> and
> > > provide more details.
> > >
> > >
> > > [1]
> > >
> > >
> >
> https://docs.github.com/en/actions/creating-actions/creating-a-composite-action
> > >
> > >
> > > sob., 18 wrz 2021 o 08:27 Martin Kanters 
> > > napisał(a):
> > >
> > > > Hi Slawomir, sorry for the late reply.
> > > >
> > > > Great that you see the value of the workflows.
> > > > I don't think there are any strict rules or guidelines around how the
> > > > workflow should be configured exactly, but I think it makes sense to
> > have
> > > > them in place.
> > > > Perhaps we should also look into a way of reusing workflows in all or
> > > most
> > > > of the projects (maven-core is a bit different).
> > > >
> > > > Just wanted to mention that for the Apache team the Apache Jenkins
> > server
> > > > is what matters most. GA are helpful for contributors and committers
> > > > working via PRs, but in the end Apache Jenkins has to pass before a
> > merge
> > > > is allowed. Hence, I think we should go for a reasonable workflow
> > > > configuration, it does not have to be more extensive than the Jenkins
> > > > setup. Still, having macOS builds is very useful, Jenkins does not
> have
> > > > that AFAIK.
> > > >
> > > > Martin
> > > >
> > > >
> > > >
> > > >
> > > > Op za 11 sep. 2021 om 20:43 schreef Slawomir Jaranowski <
> > > > s.jaranow...@gmail.com>:
> > > >
> > > > > Hi,
> > > > >
> > > > > Many of maven, maven plugins projects have GutHub Action build
> > > > configured.
> > > > > It is very useful for contributors - we can verify PR early,
> > especially
> > > > on
> > > > > many different operating systems - which can't be done locally, or
> is
> > > > more
> > > > > complicated.
> > > > >
> > > > > Most of workflows have define build matrix like:
> > > > >
> > > > >   matrix:
> > > > > os: [ubuntu-latest, windows-latest, macOS-latest]
> > > > > java: [8, 11, 16, 17-ea]
> > > > >
> > > > > But some have:
> > > > >
> > > > >   matrix:
> > > > >os: [ubuntu-latest, windows-latest, macOS-latest]
> > > > >java: [8, 11, 16, 17-ea]
> > > > >jdk: [adopt, zulu]
> > > > >
> > > > >
> > > > > Question:
> > > > >
> > > > > Are there some guidelines about how GitHub Action should be
> > configured?
> > > > > If no guidelines, which build matrix will be the most expected?
> > > > >
> > > > >  I ask in conjunction to
> > > https://issues.apache.org/jira/browse/MDEP-768
> > > > >
> > > > >
> > > > > --
> > > > > Sławomir Jaranowski
> > > > >
> > > > > https://twitter.com/SlawekJaran
> > > > > https://github.com/slawekjaranowski
> > > > > https://linkedin.com/in/slawomirjaranowski
> > > > >
> > > >
> > >
> > >
> > > --
> > > Sławomir Jaranowski
> > >
> >
>

Re: GitHub Actions on Maven projects

2021-09-19 Thread Martin Kanters 
Sounds like a great idea!

Martin

Op zo 19 sep. 2021 om 00:26 schreef Tamás Cservenák :

> +1 for global action
>
> T
>
> On Sat, Sep 18, 2021, 13:35 Slawomir Jaranowski 
> wrote:
>
> > Hi,
> >
> > Thanks for your response. I know that jenkins build is the master for
> > Apache projects,
> > but most of the projects have some GA workflows configuration which many
> > times are different.
> > This situation generates more work for maintainer.
> >
> > Thanks to composite actions [1] we can create one global action which has
> > defined all required steps and one action for providing configurations
> > values like jkd list,
> > both of these actions can be in one repository.
> >
> > In the rest of the project we can use those global actions, so when next
> > time we want to change, e.g. jdk list (it changes every 6 month ;-) ) we
> > only change it in one place.
> > This approach can make less maintenance work in maven projects.
> >
> > If you are interested let me know, I can prepare some spikes for you and
> > provide more details.
> >
> >
> > [1]
> >
> >
> https://docs.github.com/en/actions/creating-actions/creating-a-composite-action
> >
> >
> > sob., 18 wrz 2021 o 08:27 Martin Kanters 
> > napisał(a):
> >
> > > Hi Slawomir, sorry for the late reply.
> > >
> > > Great that you see the value of the workflows.
> > > I don't think there are any strict rules or guidelines around how the
> > > workflow should be configured exactly, but I think it makes sense to
> have
> > > them in place.
> > > Perhaps we should also look into a way of reusing workflows in all or
> > most
> > > of the projects (maven-core is a bit different).
> > >
> > > Just wanted to mention that for the Apache team the Apache Jenkins
> server
> > > is what matters most. GA are helpful for contributors and committers
> > > working via PRs, but in the end Apache Jenkins has to pass before a
> merge
> > > is allowed. Hence, I think we should go for a reasonable workflow
> > > configuration, it does not have to be more extensive than the Jenkins
> > > setup. Still, having macOS builds is very useful, Jenkins does not have
> > > that AFAIK.
> > >
> > > Martin
> > >
> > >
> > >
> > >
> > > Op za 11 sep. 2021 om 20:43 schreef Slawomir Jaranowski <
> > > s.jaranow...@gmail.com>:
> > >
> > > > Hi,
> > > >
> > > > Many of maven, maven plugins projects have GutHub Action build
> > > configured.
> > > > It is very useful for contributors - we can verify PR early,
> especially
> > > on
> > > > many different operating systems - which can't be done locally, or is
> > > more
> > > > complicated.
> > > >
> > > > Most of workflows have define build matrix like:
> > > >
> > > >   matrix:
> > > > os: [ubuntu-latest, windows-latest, macOS-latest]
> > > > java: [8, 11, 16, 17-ea]
> > > >
> > > > But some have:
> > > >
> > > >   matrix:
> > > >os: [ubuntu-latest, windows-latest, macOS-latest]
> > > >java: [8, 11, 16, 17-ea]
> > > >jdk: [adopt, zulu]
> > > >
> > > >
> > > > Question:
> > > >
> > > > Are there some guidelines about how GitHub Action should be
> configured?
> > > > If no guidelines, which build matrix will be the most expected?
> > > >
> > > >  I ask in conjunction to
> > https://issues.apache.org/jira/browse/MDEP-768
> > > >
> > > >
> > > > --
> > > > Sławomir Jaranowski
> > > >
> > > > https://twitter.com/SlawekJaran
> > > > https://github.com/slawekjaranowski
> > > > https://linkedin.com/in/slawomirjaranowski
> > > >
> > >
> >
> >
> > --
> > Sławomir Jaranowski
> >
>

[GitHub] [maven-site] elharo merged pull request #261: [MNGSITE-461] Remove IRC contact channel from documentation

2021-09-19 Thread GitBox 


elharo merged pull request #261:
URL: https://github.com/apache/maven-site/pull/261


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] elharo merged pull request #262: [MNGSITE-462] Update Maven jenkins address

2021-09-19 Thread GitBox 


elharo merged pull request #262:
URL: https://github.com/apache/maven-site/pull/262


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] elharo commented on pull request #261: [MNGSITE-461] Remove IRC contact channel from documentation

2021-09-19 Thread GitBox 


elharo commented on pull request #261:
URL: https://github.com/apache/maven-site/pull/261#issuecomment-922465915


   
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site/job/MNGSITE-461/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] puradawid commented on a change in pull request #261: [MNGSITE-461] Remove IRC contact channel from documentation

2021-09-19 Thread GitBox 


puradawid commented on a change in pull request #261:
URL: https://github.com/apache/maven-site/pull/261#discussion_r711733178



##
File path: content/markdown/community.md
##
@@ -85,8 +85,8 @@ Maven has a number of [Mailing Lists](./mailing-lists.html), 
and the Maven
 User List is specifically dedicated to answering questions about all
 Maven things.
 
- IRC (Internet Relay Chat)
-
-Log into the `#maven` IRC channel on `irc.freenode.net` with your
-favorite IRC client or [with web IRC chat](https://webchat.freenode.net/).
+ Slack
 
+For people actively contributing to Maven, especially committers, there
+is [the ASF Slack workspace](https://infra.apache.org) available to discuss

Review comment:
   Good point, thank you!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site-plugin] elharo closed pull request #61: Bump plexus-utils from 3.3.0 to 3.4.1

2021-09-19 Thread GitBox 


elharo closed pull request #61:
URL: https://github.com/apache/maven-site-plugin/pull/61


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #61: Bump plexus-utils from 3.3.0 to 3.4.1

2021-09-19 Thread GitBox 


dependabot[bot] commented on pull request #61:
URL: https://github.com/apache/maven-site-plugin/pull/61#issuecomment-922459713


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #60: Bump mavenVersion from 3.0.5 to 3.8.2

2021-09-19 Thread GitBox 


dependabot[bot] commented on pull request #60:
URL: https://github.com/apache/maven-site-plugin/pull/60#issuecomment-922459668


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. You can also ignore all major, minor, or patch 
releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site-plugin] elharo closed pull request #60: Bump mavenVersion from 3.0.5 to 3.8.2

2021-09-19 Thread GitBox 


elharo closed pull request #60:
URL: https://github.com/apache/maven-site-plugin/pull/60


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #44: Bump plexus-utils from 3.3.0 to 3.4.1

2021-09-19 Thread GitBox 


dependabot[bot] commented on pull request #44:
URL: 
https://github.com/apache/maven-artifact-transfer/pull/44#issuecomment-922457356


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-artifact-transfer] elharo closed pull request #44: Bump plexus-utils from 3.3.0 to 3.4.1

2021-09-19 Thread GitBox 


elharo closed pull request #44:
URL: https://github.com/apache/maven-artifact-transfer/pull/44


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] elharo commented on a change in pull request #261: [MNGSITE-461] Remove IRC contact channel from documentation

2021-09-19 Thread GitBox 


elharo commented on a change in pull request #261:
URL: https://github.com/apache/maven-site/pull/261#discussion_r711726877



##
File path: content/markdown/community.md
##
@@ -85,8 +85,8 @@ Maven has a number of [Mailing Lists](./mailing-lists.html), 
and the Maven
 User List is specifically dedicated to answering questions about all
 Maven things.
 
- IRC (Internet Relay Chat)
-
-Log into the `#maven` IRC channel on `irc.freenode.net` with your
-favorite IRC client or [with web IRC chat](https://webchat.freenode.net/).
+ Slack
 
+For people actively contributing to Maven, especially committers, there
+is [the ASF Slack workspace](https://infra.apache.org) available to discuss

Review comment:
   there is [the ASF Slack workspace](https://infra.apache.org) --> the 
[ASF Slack workspace](https://infra.apache.org) is




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] elharo commented on pull request #262: [MNGSITE-462] Update Maven jenkins address

2021-09-19 Thread GitBox 


elharo commented on pull request #262:
URL: https://github.com/apache/maven-site/pull/262#issuecomment-922456192


   Testing: 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site/job/MNGSITE-462/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] elharo commented on a change in pull request #261: [MNGSITE-461] Remove IRC contact channel from documentation

2021-09-19 Thread GitBox 


elharo commented on a change in pull request #261:
URL: https://github.com/apache/maven-site/pull/261#discussion_r711726877



##
File path: content/markdown/community.md
##
@@ -85,8 +85,8 @@ Maven has a number of [Mailing Lists](./mailing-lists.html), 
and the Maven
 User List is specifically dedicated to answering questions about all
 Maven things.
 
- IRC (Internet Relay Chat)
-
-Log into the `#maven` IRC channel on `irc.freenode.net` with your
-favorite IRC client or [with web IRC chat](https://webchat.freenode.net/).
+ Slack
 
+For people actively contributing to Maven, especially committers, there
+is [the ASF Slack workspace](https://infra.apache.org) available to discuss

Review comment:
   there is [the ASF Slack workspace](https://infra.apache.org) --> the 
[the ASF Slack workspace](https://infra.apache.org) is




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org