Re: [VOTE] Release Maven Doxia version 2.0.0-M2

2022-02-15 Thread Hervé BOUTEMY
+1

Reproducible Build ok: reference done with JDK 8 on Windows

Regards,

Hervé

Le dimanche 13 février 2022, 22:57:43 CET Michael Osipov a écrit :
> Hi,
> 
> We solved 4 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317230
> rsion=12351270
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DOXIA%20AND%20res
> olution%20%3D%20Unresolved
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1714/
> https://repository.apache.org/content/repositories/maven-1714/org/apache/mav
> en/doxia/doxia/2.0.0-M2/doxia-2.0.0-M2-source-release.zip
> 
> Source release checksum(s):
> doxia-2.0.0-M2-source-release.zip
> sha512:
> f01758edf78ae4dfdc71b6b08aca1f7f0c8d2d3bd918ef6950aa3b479f098d09504b438a4f0b
> 45d54b0a73e7312ec6bf47faa951b9e722dc7a212224c21acfb5
> 
> Staging site:
> http://maven.apache.org/doxia/doxia-archives/doxia-LATEST/
> 
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Maven Indexer 6.1.1

2022-02-15 Thread Sylwester Lachiewicz
+1

pon., 14 lut 2022, 11:48 użytkownik Tamás Cservenák 
napisał:

> Howdy,
>
> We solved many issues (6.1.0 canceled release + 6.1.1 are both assigned to
> 6.1.1 version):
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317523=12351333
>
> There are still some issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MINDEXER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> Staging repository:
> https://repository.apache.org/content/repositories/maven-1715/
>
> Source release and SHA512 checksum:
>
> https://repository.apache.org/content/repositories/maven-1715/org/apache/maven/indexer/maven-indexer/6.1.1/maven-indexer-6.1.1-source-release.zip
>
> a9bc67895f1a76b5bf7c3bd4270ecc97de477ac4b05945bc15d59d71ccac9699b8b56f9216a29bc7c63a1c838fcd2aa05ae9681753d6d69a5594fdd0961e5196
>
> Staging site:
> https://maven.apache.org/maven-indexer-archives/maven-indexer-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>


Re: [VOTE] Release Maven Indexer 6.1.1

2022-02-15 Thread Olivier Lamy
+1

On Mon, 14 Feb 2022 at 20:48, Tamás Cservenák  wrote:

> Howdy,
>
> We solved many issues (6.1.0 canceled release + 6.1.1 are both assigned to
> 6.1.1 version):
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317523=12351333
>
> There are still some issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MINDEXER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> Staging repository:
> https://repository.apache.org/content/repositories/maven-1715/
>
> Source release and SHA512 checksum:
>
> https://repository.apache.org/content/repositories/maven-1715/org/apache/maven/indexer/maven-indexer/6.1.1/maven-indexer-6.1.1-source-release.zip
>
> a9bc67895f1a76b5bf7c3bd4270ecc97de477ac4b05945bc15d59d71ccac9699b8b56f9216a29bc7c63a1c838fcd2aa05ae9681753d6d69a5594fdd0961e5196
>
> Staging site:
> https://maven.apache.org/maven-indexer-archives/maven-indexer-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>


Re: Conventional Commits with the maven-release-plugin

2022-02-15 Thread Olivier Lamy
sounds an interesting idea.
would you mind having this as PRs to ease code review?

On Tue, 15 Feb 2022 at 03:00, Niels Basjes  wrote:

> Hi,
>
> I would like to use the ideas from the Conventional Commits to
> automatically determine the next version for my release when releasing with
> the maven-release-plugin.
>
> Since this is not yet a part of the current version of the release plugin I
> decided to give it a go myself.
>
> So far I have succeeded in creating a new VersionPolicy that does this and
> I'm wondering if the committers would consider including this idea or not.
> I expect my code will need some more cleanups and changes on my end before
> it can be included.
>
> Summary of what I had to change to make this work:
> In maven-scm (
> https://github.com/nielsbasjes/maven-scm/tree/SCM-xxx-ChangelogTags )
> - I had to add the functionality that a ChangeSet could contain the tags
> present on the commits as well.
>   It is generic and I've added this functionality for gitexe and jgit.
>   For gitexe I had to change the command used by the changelog command to
> get the tags.
>
> In maven-release (
> https://github.com/nielsbasjes/maven-release/tree/MRELEASE-xxx-CCSEMVER )
> - I extended the VersionPolicyRequest to include the connection to the SCM
> and a config parameter (right now a String) to configure the patterns to
> look for in the pom.xml of the project that is to be released.
> - I created a new VersionPolicy that examines the tags and commit messages
> and from this computes if a patch, minor or major version update is needed.
>
> To check it actually works I created a dummy test project that has this
> plugin:
> https://github.com/nielsbasjes/releasetester/blob/main/pom.xml#L94
>
> So simply put: Should I file two jira tickets and put up the pull requests
> so you can review my ideas ?
>
> --
> Best regards / Met vriendelijke groeten,
>
> Niels Basjes
>


Re: Upcoming release of maven-dependency-plugin

2022-02-15 Thread Elliotte Rusty Harold
On Tue, Feb 15, 2022 at 5:53 PM Slawomir Jaranowski
 wrote:

> Simply the problem is that dependencies present as transitive for any
> dependency in compile scope should be not reported as "Non-test scoped".
> So we should check if dependency listed as "Non-test scoped" are not
> present as transitive dependency for other used in compile scope.
>

Can you elaborate on that? It seems to me that a normal unflattened
pom.xml should not declare transitive dependencies. In fact it's
pretty important that it not do so. For instance, if A's src/test
depend on Guava but A's src/java does not depend on Guava, then A
should only declare a test scope dependency on Guava, even if it also
depends on something else at compile time that does depend on Guava.

-- 
Elliotte Rusty Harold
elh...@ibiblio.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[ANN] Apache Maven PMD Plugin 3.16.0 Released

2022-02-15 Thread Andreas Dangel
The Maven team is pleased to announce the release of the Apache Maven 
PMD Plugin, version 3.16.0


A Maven plugin for the PMD toolkit, that produces a report on both code 
rule violations and detected copy and paste

fragments, as well as being able to fail the build based on these metrics.

https://maven.apache.org/plugins/maven-pmd-plugin/

You should specify the version in your project's plugin configuration:


  org.apache.maven.plugins
  maven-pmd-plugin
  3.16.0



Release Notes - Maven PMD Plugin - Version 3.16.0

Bug
* [MPMD-325] Could not find class due to IncompatibleClassChangeError 
warning

* [MPMD-324] Ruleset URLs have hyphen replaced with forwardslash
* [MPMD-323] ResourceManager should use project base dir instead of pom 
location


Improvement
* [MPMD-328] Shared GitHub Actions

Task
* [MPMD-327] Upgrade to PMD 6.42.0
* [MPMD-326] Set Maven 3.1.1 as minimum version

Enjoy,

-The Maven team


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[RESULT] [VOTE] Release Apache Maven PMD Plugin version 3.16.0

2022-02-15 Thread Andreas Dangel

Hi,

The vote has passed with the following result:

+1 : Michael Osipov, Sylwester Lachiewicz, Hervé Boutemy, Andreas 
Dangel, Tamás Cservenák


PMC quorum: reached.

I will promote the artifacts to the central repo.

Regards,
Andreas



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Upcoming release of maven-dependency-plugin

2022-02-15 Thread Slawomir Jaranowski
Hi,

After community testing current snapshot version of plugin, we have new
important issue: https://issues.apache.org/jira/browse/MDEP-791

Simply the problem is that dependencies present as transitive for any
dependency in compile scope should be not reported as "Non-test scoped".
So we should check if dependency listed as "Non-test scoped" are not
present as transitive dependency for other used in compile scope.

IMHO it should be done in maven-dependency-analyzer.

Questions how to discover if project dependency is also present as
transitive for another dependency?

The next challenge is that maven-dependency-analyzer still use Maven Api in
version 2.0.5 upgrade to 3.x is blocked by using maven-plugin-testing-tools
in version 1.3 ...

Any hint how to resolve such issue?



niedz., 13 lut 2022 o 23:31 Falko Modler  napisał(a):

> Hi,
>
> my experiments failed.
>
> Maven is just too eager to validate versions (which is a good thing in
> general), so setting such version properties via a plugin (even without
> requiresDependencyResolution) won't help with the cases I had in my mind.
>
> I think https://issues.apache.org/jira/browse/MNG-6378 comes close to
> what I'd actually need. I'll leave a comment there.
>
> Long story short: No delay for doing a release from my side!
>
> Cheers,
>
> Falko
>
>
> Am 10.02.2022 um 12:39 schrieb Tibor Digana:
> > Hi Falco, do not keep it in your mind, file a Jira ticket. If you post a
> PR
> > in progress, it would be worth to give a feedback in advance. Somebody
> may
> > guide you in the right direction rather sooner than later. T
> >
> > Dňa št 10. 2. 2022, 11:45 Falko Modler  napísal(a):
> >
> >> TBH, I haven't created an issue yet. I wanted to create a working draft
> >> first and play around with it to see whether it meets my needs.
> >>
> >> I might be able to finish it on Sunday.
> >>
> >> Cheers,
> >>
> >> Falko
> >>
> >> Am 10.02.2022 um 09:40 schrieb Slawomir Jaranowski:
> >>> Hi Falko
> >>>
> >>> Which issue are you working on?
> >>> How much time do you need to finish your work?
> >>>
> >>> czw., 10 lut 2022 o 01:07 Falko Modler  napisał(a):
> >>>
>  Hi Slawomir,
> 
>  a few weeks ago I started working on extending the "properties" goal
> to
>  create a version property per dependency.
> 
>  This would be very useful for projects like Quarkus that have a big
> BOM
>  and would like to reuse versions from that BOM for various things in
>  integration tests etc.
> 
>  It would be nice to have more time to finish that, but I wouldn't call
>  this "critical".
> 
>  Cheers,
> 
>  Falko
> 
>  Am 09.02.2022 um 23:50 schrieb Slawomir Jaranowski:
> > Hi,
> >
> > There are 17 issues resolved
> >
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227=12340588
> > Some of them are critical.
> >
> > Do we have plans to resolve more issues in the near future?
> >
> > Last release was about 7 months ago.
> >
> > If there are no objections I can take care of it next week.
> >
>  -
>  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>  For additional commands, e-mail: dev-h...@maven.apache.org
> 
> 
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> >> For additional commands, e-mail: dev-h...@maven.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

-- 
Sławomir Jaranowski


Re: [DISCUSS] Modello release

2022-02-15 Thread Vladimir Sitnikov
>correctly even if the encoding changes, because that will lead to the file
>being overwritten.

Once again: decoding does **not** guarantee you get **invalid** string when
decoding fails.
The replacement string might look like a regular string, and it might even
collide with the input string.

Here's an example:
1. Suppose someone writes out.txt file a Cyrillic letter ф in UTF-8
encoding.
jshell> "ф".getBytes("UTF-8")
$1 ==> byte[2] { -47, -124 }

2. Suppose there's an encoding UTF-Z that replaces unmappable bytes with ?
(ASCII "?")
Suppose UTF-Z treats all "negative bytes" as undecodable.

3. Suppose someone attempts to write "??" ( two ASCII question marks) using
UTF-Z encoding to the file out.txt
The expected file contents should be like 63, 63.
"CachingWriter" would try to decode file contents using UTF-Z, and it would
end up with "??" (two ASCII question marks because the file contains two
negative bytes).

4. The result of decoding would artificially match to the desired string
contents (remember, that at step 3 we wanted to store "??"),
so the caching writer would **skip** file overwrite even though the file
must be updated.

Note: the example does not work for UTF-8 because UTF-8 uses a special
"illegal" character for unmappable chars.
However, there's no guarantee every encoding would use illegal chars for
undecodable cases.

Vladimir


Re: [DISCUSS] Modello release

2022-02-15 Thread Guillaume Nodet
Le mar. 15 févr. 2022 à 08:19, Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> a écrit :

> >the result string will be corrupted when read
>
> The javadoc does not guarantee the string will be "corrupted" :-/
>
> The "default replacement string" is quite a vague definition,
> so there might be an encoding where "default replacement string"
> means regular ASCII question mark "?".
>

Yes, so the string will definitely not be the same, so the current code is
working
correctly even if the encoding changes, because that will lead to the file
being
overwritten.


>
> All in all, String->byte is way easier to reason about.
>

Agreed.


>
> WDYT on having something like that in Maven core?
>

Sure, would you mean raising a JIRA issue on MSHARED ?
  https://issues.apache.org/jira/projects/MSHARED


>
> Vladimir
>


-- 

Guillaume Nodet