Re: maven javadoc aggregator goals (aggregator-jar)

2023-08-21 Thread Christoph Läubrich

There are various issues reported:

https://issues.apache.org/jira/browse/MJAVADOC-707
https://issues.apache.org/jira/browse/MJAVADOC-747
https://issues.apache.org/jira/browse/MJAVADOC-769
... and even more ...

Sadly the only solution currently is to use an old version of javadoc 
plugin (what might has other issues ... ) :-\





Am 22.08.23 um 06:23 schrieb Henning Schmiedehausen:

I have a large-ish project that builds JPMS "Automatic-Module-Name"
artifacts. At this point, I have the system to create per module javadocs
that use Java 9+ style (.../target/apidocs/{module.name}/module-summary.html
is the starting page).

Now I am trying to aggregate the various artifacts into a single, project
javadoc jar which contains all the modules. I tried a somewhat naive
approach, adding a new maven module to the project using "pom" as
packaging, declaring dependencies on all my maven modules and add a javadoc
configuration:




















*maven-javadoc-plugin
   javadoc-jar
 aggregate-jar
package
true
false

org.jdbi:*
   
*

this does not work. The plugin never considers the build being JPMS
modularized, creates an options file with a class path only and then fails
during building the aggregation jar.

I changed the packaging of the module in which the aggregate jar is built
from pom to jar. This now creates a javadoc/apidocs/options file that uses
a module path and also patches all the modules
that are included. However, this now fails with








*MavenReportException: Error while generating Javadoc:[ERROR] Exit code:
1[ERROR] error: too many patched modules
(org.jdbi.v3.core,org.jdbi.v3.caffeine,org.jdbi.v3.cache.noop,org.jdbi.v3.testing),
use --module-source-path[ERROR] 1 error[ERROR] Command line was:
/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/javadoc
-J-Xmx1024m @options @packages[ERROR][ERROR] Refer to the generated Javadoc
files in '/Users/henning/code/jdbi/javadoc/target/apidocs' dir.*

At this point, I am stuck. It is not clear to me how to create an aggregate
jar correctly. I looked at the MJAVADOC-639 integration test which seems to
be similar to my first approach.

Any pointers appreciated.

-h



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



maven javadoc aggregator goals (aggregator-jar)

2023-08-21 Thread Henning Schmiedehausen
I have a large-ish project that builds JPMS "Automatic-Module-Name"
artifacts. At this point, I have the system to create per module javadocs
that use Java 9+ style (.../target/apidocs/{module.name}/module-summary.html
is the starting page).

Now I am trying to aggregate the various artifacts into a single, project
javadoc jar which contains all the modules. I tried a somewhat naive
approach, adding a new maven module to the project using "pom" as
packaging, declaring dependencies on all my maven modules and add a javadoc
configuration:




















*maven-javadoc-plugin
  javadoc-jar
aggregate-jar
package
true
false

org.jdbi:*
  
*

this does not work. The plugin never considers the build being JPMS
modularized, creates an options file with a class path only and then fails
during building the aggregation jar.

I changed the packaging of the module in which the aggregate jar is built
from pom to jar. This now creates a javadoc/apidocs/options file that uses
a module path and also patches all the modules
that are included. However, this now fails with








*MavenReportException: Error while generating Javadoc:[ERROR] Exit code:
1[ERROR] error: too many patched modules
(org.jdbi.v3.core,org.jdbi.v3.caffeine,org.jdbi.v3.cache.noop,org.jdbi.v3.testing),
use --module-source-path[ERROR] 1 error[ERROR] Command line was:
/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/javadoc
-J-Xmx1024m @options @packages[ERROR][ERROR] Refer to the generated Javadoc
files in '/Users/henning/code/jdbi/javadoc/target/apidocs' dir.*

At this point, I am stuck. It is not clear to me how to create an aggregate
jar correctly. I looked at the MJAVADOC-639 integration test which seems to
be similar to my first approach.

Any pointers appreciated.

-h


Re: [VOTE] Release Apache Maven Archiver version 3.6.1

2023-08-21 Thread Herve Boutemy
+1

Reproducible Build ok: reference build done with JDK 17 on *nix with umask 022

Regards,

Hervé

On 2023/08/19 10:59:50 Slawomir Jaranowski wrote:
> Hi,
> 
> We solved 7 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922=12353169
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-archiver
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1985/
> https://repository.apache.org/content/repositories/maven-1985/org/apache/maven/maven-archiver/3.6.1/maven-archiver-3.6.1-source-release.zip
> 
> Source release checksum(s):
> maven-archiver-3.6.1-source-release.zip - SHA-512 :
> d3256edb89a346225395a3876d041455ac258c3fddad9d1288115b58b34c0a454b4eb892e04f5f120b84334751f5df83de71ae8611c661fd06f15e998d98f135
> 
> Staging site:
> https://maven.apache.org/shared-archives/maven-archiver-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -- 
> Sławomir Jaranowski
> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Enforcer version 3.4.0

2023-08-21 Thread Herve Boutemy
+1

Reproducible Build ok: reference build done with JDK 17 on *nix with umask 022

Regards,

Hervé

On 2023/08/19 16:54:40 Slawomir Jaranowski wrote:
> Hi,
> 
> We solved 9 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12353101
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MENFORCER%20AND%20resolution%20%3D%20Unresolved
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1986/
> https://repository.apache.org/content/repositories/maven-1986/org/apache/maven/enforcer/enforcer/3.4.0/enforcer-3.4.0-source-release.zip
> 
> Source release checksum(s):
> enforcer-3.4.0-source-release.zip - SHA-512 :
> b9acac178d095f32fbeed73b278c2dcb07081f1ef1e6a520f990f31217278edff05c19a7945bef99088e8e8e3d9a6212b6fb23bb5de1356bb849e5e0835a9651
> 
> Staging site:
> https://maven.apache.org/enforcer-archives/enforcer-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -- 
> Sławomir Jaranowski
> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Maven plugins and JPMS

2023-08-21 Thread Gary Gregory
Thanks for the feedback Romain.

I created https://github.com/moditect/moditect/issues/210

Gary

On Mon, Aug 21, 2023 at 7:32 AM Romain Manni-Bucau
 wrote:
>
> Hi Gary,
>
> Most of the module-path listed there is not intended to be used as module
> (maven plugin stack is a good example of that) so looks like moditech
> should support classpath option too as the JVM and not assume everything is
> a module from my window.
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github  |
> LinkedIn  | Book
> 
>
>
> Le lun. 21 août 2023 à 13:26, Gary Gregory  a
> écrit :
>
> > I forgot to say:
> >
> > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)
> > Maven home: /usr/local/Cellar/maven/3.9.4/libexec
> > Java version: 11.0.20, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk@11/11.0.20/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "13.5", arch: "x86_64", family: "mac"
> >
> > Gary
> >
> > On Mon, Aug 21, 2023 at 7:24 AM Gary Gregory 
> > wrote:
> > >
> > > Are there any plans for getting plugins to build with JPMS? For
> > > example, trying to generate a module description with the Moditect
> > > plugin fails for the Commons commons-build-plugin:
> > >
> > > Error:  Modules maven.model and maven.model.builder export package
> > > org.apache.maven.model.merge to module maven.shared.utils
> > >
> > > Details from
> > https://github.com/apache/commons-build-plugin/actions/runs/5925574518/job/16065261054
> > >
> > > [INFO] --- moditect-maven-plugin:1.0.0.Final:add-module-info
> > > (add-module-infos) @ commons-build-plugin ---
> > > [INFO] Running jdeps --generate-module-info
> > >
> > /home/runner/work/commons-build-plugin/commons-build-plugin/target/moditect
> > > --add-modules
> > plexus.utils,org.apache.commons.compress,com.google.guice,plexus.sec.dispatcher,maven.shared.utils,maven.model,org.apache.maven.resolver,plexus.cipher,maven.builder.support,maven.repository.metadata,aopalliance,plexus.component.annotations,
> > plexus.io
> > ,com.github.luben.zstd_jni,org.graalvm.sdk,plexus.classworlds,org.tukaani.xz,maven.settings.builder,maven.resolver.provider,failureaccess,maven.script.ant,maven.plugin.api,javax.annotation.api,plexus.ant.factory,org.slf4j,ant,maven.settings,plexus.archiver,org.graalvm.js,com.oracle.truffle.regex,org.graalvm.js.scriptengine,ant.launcher,org.eclipse.sisu.inject,org.apache.commons.lang3,snappy,com.google.common,
> > org.apache.commons.io
> > ,org.apache.maven.resolver.util,maven.core,org.eclipse.sisu.plexus,plexus.interpolation,org.graalvm.truffle,javax.inject,org.apache.maven.resolver.named,org.apache.maven.resolver.impl,org.apache.maven.resolver.spi,maven.artifact,maven.model.builder
> > > --module-path
> > /home/runner/.m2/repository/org/codehaus/plexus/plexus-utils/3.5.1/plexus-utils-3.5.1.jar:/home/runner/.m2/repository/org/apache/commons/commons-compress/1.23.0/commons-compress-1.23.0.jar:/home/runner/.m2/repository/com/google/inject/guice/5.1.0/guice-5.1.0.jar:/home/runner/.m2/repository/org/codehaus/plexus/plexus-sec-dispatcher/2.0/plexus-sec-dispatcher-2.0.jar:/home/runner/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.3.4/maven-shared-utils-3.3.4.jar:/home/runner/.m2/repository/org/apache/maven/maven-model/3.9.4/maven-model-3.9.4.jar:/home/runner/.m2/repository/org/apache/maven/resolver/maven-resolver-api/1.9.14/maven-resolver-api-1.9.14.jar:/home/runner/.m2/repository/org/codehaus/plexus/plexus-cipher/2.0/plexus-cipher-2.0.jar:/home/runner/.m2/repository/org/apache/maven/maven-builder-support/3.9.4/maven-builder-support-3.9.4.jar:/home/runner/.m2/repository/org/apache/maven/maven-repository-metadata/3.9.4/maven-repository-metadata-3.9.4.jar:/home/runner/.m2/repository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar:/home/runner/.m2/repository/org/codehaus/plexus/plexus-component-annotations/2.1.0/plexus-component-annotations-2.1.0.jar:/home/runner/.m2/repository/org/codehaus/plexus/plexus-io/3.4.1/plexus-io-3.4.1.jar:/home/runner/.m2/repository/com/github/luben/zstd-jni/1.5.5-2/zstd-jni-1.5.5-2.jar:/home/runner/.m2/repository/org/graalvm/sdk/graal-sdk/
> > 

Re: Maven plugins and JPMS

2023-08-21 Thread Romain Manni-Bucau
Hi Gary,

Most of the module-path listed there is not intended to be used as module
(maven plugin stack is a good example of that) so looks like moditech
should support classpath option too as the JVM and not assume everything is
a module from my window.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 21 août 2023 à 13:26, Gary Gregory  a
écrit :

> I forgot to say:
>
> Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)
> Maven home: /usr/local/Cellar/maven/3.9.4/libexec
> Java version: 11.0.20, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@11/11.0.20/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.5", arch: "x86_64", family: "mac"
>
> Gary
>
> On Mon, Aug 21, 2023 at 7:24 AM Gary Gregory 
> wrote:
> >
> > Are there any plans for getting plugins to build with JPMS? For
> > example, trying to generate a module description with the Moditect
> > plugin fails for the Commons commons-build-plugin:
> >
> > Error:  Modules maven.model and maven.model.builder export package
> > org.apache.maven.model.merge to module maven.shared.utils
> >
> > Details from
> https://github.com/apache/commons-build-plugin/actions/runs/5925574518/job/16065261054
> >
> > [INFO] --- moditect-maven-plugin:1.0.0.Final:add-module-info
> > (add-module-infos) @ commons-build-plugin ---
> > [INFO] Running jdeps --generate-module-info
> >
> /home/runner/work/commons-build-plugin/commons-build-plugin/target/moditect
> > --add-modules
> plexus.utils,org.apache.commons.compress,com.google.guice,plexus.sec.dispatcher,maven.shared.utils,maven.model,org.apache.maven.resolver,plexus.cipher,maven.builder.support,maven.repository.metadata,aopalliance,plexus.component.annotations,
> plexus.io
> ,com.github.luben.zstd_jni,org.graalvm.sdk,plexus.classworlds,org.tukaani.xz,maven.settings.builder,maven.resolver.provider,failureaccess,maven.script.ant,maven.plugin.api,javax.annotation.api,plexus.ant.factory,org.slf4j,ant,maven.settings,plexus.archiver,org.graalvm.js,com.oracle.truffle.regex,org.graalvm.js.scriptengine,ant.launcher,org.eclipse.sisu.inject,org.apache.commons.lang3,snappy,com.google.common,
> org.apache.commons.io
> ,org.apache.maven.resolver.util,maven.core,org.eclipse.sisu.plexus,plexus.interpolation,org.graalvm.truffle,javax.inject,org.apache.maven.resolver.named,org.apache.maven.resolver.impl,org.apache.maven.resolver.spi,maven.artifact,maven.model.builder
> > --module-path
> /home/runner/.m2/repository/org/codehaus/plexus/plexus-utils/3.5.1/plexus-utils-3.5.1.jar:/home/runner/.m2/repository/org/apache/commons/commons-compress/1.23.0/commons-compress-1.23.0.jar:/home/runner/.m2/repository/com/google/inject/guice/5.1.0/guice-5.1.0.jar:/home/runner/.m2/repository/org/codehaus/plexus/plexus-sec-dispatcher/2.0/plexus-sec-dispatcher-2.0.jar:/home/runner/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.3.4/maven-shared-utils-3.3.4.jar:/home/runner/.m2/repository/org/apache/maven/maven-model/3.9.4/maven-model-3.9.4.jar:/home/runner/.m2/repository/org/apache/maven/resolver/maven-resolver-api/1.9.14/maven-resolver-api-1.9.14.jar:/home/runner/.m2/repository/org/codehaus/plexus/plexus-cipher/2.0/plexus-cipher-2.0.jar:/home/runner/.m2/repository/org/apache/maven/maven-builder-support/3.9.4/maven-builder-support-3.9.4.jar:/home/runner/.m2/repository/org/apache/maven/maven-repository-metadata/3.9.4/maven-repository-metadata-3.9.4.jar:/home/runner/.m2/repository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar:/home/runner/.m2/repository/org/codehaus/plexus/plexus-component-annotations/2.1.0/plexus-component-annotations-2.1.0.jar:/home/runner/.m2/repository/org/codehaus/plexus/plexus-io/3.4.1/plexus-io-3.4.1.jar:/home/runner/.m2/repository/com/github/luben/zstd-jni/1.5.5-2/zstd-jni-1.5.5-2.jar:/home/runner/.m2/repository/org/graalvm/sdk/graal-sdk/
> 

Re: Maven plugins and JPMS

2023-08-21 Thread Gary Gregory
I forgot to say:

Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)
Maven home: /usr/local/Cellar/maven/3.9.4/libexec
Java version: 11.0.20, vendor: Homebrew, runtime:
/usr/local/Cellar/openjdk@11/11.0.20/libexec/openjdk.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "13.5", arch: "x86_64", family: "mac"

Gary

On Mon, Aug 21, 2023 at 7:24 AM Gary Gregory  wrote:
>
> Are there any plans for getting plugins to build with JPMS? For
> example, trying to generate a module description with the Moditect
> plugin fails for the Commons commons-build-plugin:
>
> Error:  Modules maven.model and maven.model.builder export package
> org.apache.maven.model.merge to module maven.shared.utils
>
> Details from 
> https://github.com/apache/commons-build-plugin/actions/runs/5925574518/job/16065261054
>
> [INFO] --- moditect-maven-plugin:1.0.0.Final:add-module-info
> (add-module-infos) @ commons-build-plugin ---
> [INFO] Running jdeps --generate-module-info
> /home/runner/work/commons-build-plugin/commons-build-plugin/target/moditect
> --add-modules 
> plexus.utils,org.apache.commons.compress,com.google.guice,plexus.sec.dispatcher,maven.shared.utils,maven.model,org.apache.maven.resolver,plexus.cipher,maven.builder.support,maven.repository.metadata,aopalliance,plexus.component.annotations,plexus.io,com.github.luben.zstd_jni,org.graalvm.sdk,plexus.classworlds,org.tukaani.xz,maven.settings.builder,maven.resolver.provider,failureaccess,maven.script.ant,maven.plugin.api,javax.annotation.api,plexus.ant.factory,org.slf4j,ant,maven.settings,plexus.archiver,org.graalvm.js,com.oracle.truffle.regex,org.graalvm.js.scriptengine,ant.launcher,org.eclipse.sisu.inject,org.apache.commons.lang3,snappy,com.google.common,org.apache.commons.io,org.apache.maven.resolver.util,maven.core,org.eclipse.sisu.plexus,plexus.interpolation,org.graalvm.truffle,javax.inject,org.apache.maven.resolver.named,org.apache.maven.resolver.impl,org.apache.maven.resolver.spi,maven.artifact,maven.model.builder
> --module-path 
> 

Maven plugins and JPMS

2023-08-21 Thread Gary Gregory
Are there any plans for getting plugins to build with JPMS? For
example, trying to generate a module description with the Moditect
plugin fails for the Commons commons-build-plugin:

Error:  Modules maven.model and maven.model.builder export package
org.apache.maven.model.merge to module maven.shared.utils

Details from 
https://github.com/apache/commons-build-plugin/actions/runs/5925574518/job/16065261054

[INFO] --- moditect-maven-plugin:1.0.0.Final:add-module-info
(add-module-infos) @ commons-build-plugin ---
[INFO] Running jdeps --generate-module-info
/home/runner/work/commons-build-plugin/commons-build-plugin/target/moditect
--add-modules 
plexus.utils,org.apache.commons.compress,com.google.guice,plexus.sec.dispatcher,maven.shared.utils,maven.model,org.apache.maven.resolver,plexus.cipher,maven.builder.support,maven.repository.metadata,aopalliance,plexus.component.annotations,plexus.io,com.github.luben.zstd_jni,org.graalvm.sdk,plexus.classworlds,org.tukaani.xz,maven.settings.builder,maven.resolver.provider,failureaccess,maven.script.ant,maven.plugin.api,javax.annotation.api,plexus.ant.factory,org.slf4j,ant,maven.settings,plexus.archiver,org.graalvm.js,com.oracle.truffle.regex,org.graalvm.js.scriptengine,ant.launcher,org.eclipse.sisu.inject,org.apache.commons.lang3,snappy,com.google.common,org.apache.commons.io,org.apache.maven.resolver.util,maven.core,org.eclipse.sisu.plexus,plexus.interpolation,org.graalvm.truffle,javax.inject,org.apache.maven.resolver.named,org.apache.maven.resolver.impl,org.apache.maven.resolver.spi,maven.artifact,maven.model.builder
--module-path