Re: JPMS support, refactored proposal

2024-01-03 Thread Martin Desruisseaux
Le 2024-01-03 à 21 h 31, Romain Manni-Bucau a écrit : Can you compile this test case with the dependency on the class-path, without omitting the module-info in the compilation? This is exactly the case, module-info is injected somehow - a common case is by generating its bytecode but

Re: please do a release of maven-archetypes so wider audience can benefit from minimal jdk of 1.8

2024-01-03 Thread Elliotte Rusty Harold
Is https://issues.apache.org/jira/browse/MARCHETYPES-78 done? That is, are all the archetypes now updated, or are there still some left? On Wed, Jan 3, 2024 at 8:54 AM Jiri Vanek wrote: > > Hello! > > There was couple of PRs which made maven-archetypes jdk21 friendly. Can you > consider a

Re: JPMS support, refactored proposal

2024-01-03 Thread Romain Manni-Bucau
Le mer. 3 janv. 2024 à 19:25, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-01-03 à 17 h 15, Romain Manni-Bucau a écrit : > > > see it as "where classpath is in core comes from the time maven was > > only for java libs" (i'd say maven 2 cause I don't know maven 1). >

Re: JPMS support, refactored proposal

2024-01-03 Thread Martin Desruisseaux
Le 2024-01-03 à 17 h 15, Romain Manni-Bucau a écrit : see it as "where classpath is in core comes from the time maven was only for java libs" (i'd say maven 2 cause I don't know maven 1). The CLASSPATH_CONSTITUENT property and related isAddedToClasspath() methods were added in Maven 4. I let

Re: JPMS support, refactored proposal

2024-01-03 Thread Romain Manni-Bucau
Le mer. 3 janv. 2024 à 17:03, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-01-03 à 16 h 45, Romain Manni-Bucau a écrit : > > maven4 introduces the notion of "services" (...snip...) So guess all > > is there to do it and core can stay as this for backward compat > >

Re: JPMS support, refactored proposal

2024-01-03 Thread Martin Desruisseaux
Le 2024-01-03 à 16 h 45, Romain Manni-Bucau a écrit : maven4 introduces the notion of "services" (...snip...) So guess all is there to do it and core can stay as this for backward compat (maven4 must support maven3) but nothing more. Current services are class-path aware, with

Re: JPMS support, refactored proposal

2024-01-03 Thread Romain Manni-Bucau
Le mer. 3 janv. 2024 à 16:11, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-01-03 à 15 h 19, Romain Manni-Bucau a écrit : > > > I can agree with that so let's move it in a plugin related code maybe? > > > The call is on core Maven developers. If Tamas (or someone

Re: JPMS support, refactored proposal

2024-01-03 Thread Martin Desruisseaux
Le 2024-01-03 à 15 h 19, Romain Manni-Bucau a écrit : I can agree with that so let's move it in a plugin related code maybe? The call is on core Maven developers. If Tamas (or someone else) moves everything related to class-path to another location, I will follow. But I think it would need

Re: JPMS support, refactored proposal

2024-01-03 Thread Romain Manni-Bucau
Le mer. 3 janv. 2024 à 14:45, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-01-03 à 12 h 08, Romain Manni-Bucau a écrit : > >> I would like to see a proof in the form of an "hello world" > >> application (…snip…) > > > > Yot got some on github. > > > Can you share

please do a release of maven-archetypes so wider audience can benefit from minimal jdk of 1.8

2024-01-03 Thread Jiri Vanek
Hello! There was couple of PRs which made maven-archetypes jdk21 friendly. Can you consider a reelase so more people can benefit from those changes? TYVM! -- Jiri Vanek Mgr. Principal QA Software Engineer Red Hat Inc. +420 775 39 01 09

Re: JPMS support, refactored proposal

2024-01-03 Thread Martin Desruisseaux
Le 2024-01-03 à 12 h 08, Romain Manni-Bucau a écrit : I would like to see a proof in the form of an "hello world" application (…snip…) Yot got some on github. Can you share the URL? defaulting on the classpath is fine only if the library developers applied workarounds (…snip…) The

Re: JPMS support, refactored proposal

2024-01-03 Thread Romain Manni-Bucau
Le mer. 3 janv. 2024 à 11:50, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-01-03 à 09 h 08, Romain Manni-Bucau a écrit : > > > (…snip…) just to answer trivially to "But if an artifact is included, > > it should (at least by default) always be placed consistently on

Re: JPMS support, refactored proposal

2024-01-03 Thread Martin Desruisseaux
Le 2024-01-03 à 09 h 08, Romain Manni-Bucau a écrit : (…snip…) just to answer trivially to "But if an artifact is included, it should (at least by default) always be placed consistently on the class-path or module-path.", it is obvious it is not the case for several plugins like surefire

[CANCELED] [VOTE] Release Maven Surefire version 3.2.4

2024-01-03 Thread Michael Osipov
I need to cancel the vote again. Marc Philipp found a regression: https://github.com/apache/maven-surefire/pull/702#discussion_r1439664959 I will drop the staging repo, address the issue and respin as 3.2.5 shortly. M - To

Re: JPMS support, refactored proposal

2024-01-03 Thread Romain Manni-Bucau
Martin I can understand that theorically your proposal look good but just to answer trivially to "But if an artifact is included, it should (at least by default) always be placed consistently on the class-path or module-path.", it is obvious it is not the case for several plugins like surefire