[GitHub] maven pull request: [MNG-2199] Version ranges not supported for pa...

2014-06-12 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/21 [MNG-2199] Version ranges not supported for parent artifacts You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte/maven

[GitHub] maven pull request: [MNG-2199] Version ranges not supported for pa...

2014-06-12 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/21#issuecomment-45974252 I have done several releases using 'release:prepare release:perform' with a parent version range in use. The release plugin won't write the resolved parent

[GitHub] maven pull request: [MNG-2199] Version ranges not supported for pa...

2014-06-13 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/21#issuecomment-45980581 From what I can tell, release:prepare-with-pom should work the same way as before. What this patch basically does is to resolve any parent version range

[GitHub] maven pull request: [MNG-2199] Version ranges not supported for pa...

2014-06-13 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/21#issuecomment-45980866 http://wiki.eclipse.org/Aether/New_and_Noteworthy#Version_Ranges --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-integration-testing pull request: [MNG-2199] Version ranges ...

2014-06-13 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven-integration-testing/pull/7 [MNG-2199] Version ranges not supported for parent artifacts Integration tests corresponding to Maven PR #21. You can merge this pull request into a Git repository

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46546268 Another option would be to provide support for activations based on some language like: activation expressionOS IS 'Linux' AND ( PROPERTY 'Some Name

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46547866 Could be as simple as: ``` activation script engine-name= || extension= || mime-type=simple script evaluating to a boolean/script /activation

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

2014-12-17 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/32 [MPIR-238] Addition of command line flag '--legacy-reactor-resolution'. See http://jira.codehaus.org/browse/MPIR-238 This pull request will add a new command line flag '--legacy

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

2014-12-17 Thread ChristianSchulte
Github user ChristianSchulte closed the pull request at: https://github.com/apache/maven/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

2014-12-17 Thread ChristianSchulte
GitHub user ChristianSchulte reopened a pull request: https://github.com/apache/maven/pull/32 [MPIR-238] Addition of command line flag '--legacy-reactor-resolution'. See http://jira.codehaus.org/browse/MPIR-238 This pull request will add a new command line flag '--legacy

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

2014-12-17 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-67438782 See http://jira.codehaus.org/browse/MNG-5738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

2014-12-18 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-67459407 Are you referring to git rebase -i upstream/master then squash all commits and push that ? --- If your project is set up for it, you can

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2014-12-18 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-67605975 Rebased and then pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2014-12-19 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-67621081 I would need a way to disable workspace resolution mainly for the `site` lifecycle. cmd svn checkout .../tags/maven-3.0 cmd cd maven-3.0

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2014-12-19 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-67622663 It is re-enabling the following workflow in Maven 3. cmd mvn release:prepare cmd mvn release:perform Wait until the artifacts

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2014-12-19 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-67625161 Maybe the proper solution would be to control this behaviour based on an attribute of the lifecycle ? So a lifecycle can be flagged as producing artifacts

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2014-12-19 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-67626029 Feeding the tagged sources to the reports is not an issue. Feeding intermediate build results is. That's like the tagged sources changing with every build

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-11 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-78290027 I totally agree with this. Do not cripple Maven to support bad ideas or concepts. Supported by Maven as an indicator for something. Not supported by Maven so

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-11 Thread ChristianSchulte
Github user ChristianSchulte closed the pull request at: https://github.com/apache/maven/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-12 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-78281257 @jvanzyl: You would not want the `test-jar` goal to package compiled test classes instrumented by some reporting tool, would you ? So the forking logic needs

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-11 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-78226219 I am really no fan of adding just another workaround. @Jason: Are you suggesting to split site rendering from report data generation ? So the build

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-05 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-77428933 I have no experience with the cobertura plugin. I just added ``` reportPlugin groupIdorg.codehaus.mojo/groupId artifactIdcobertura-maven

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-03 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-76933957 What's the state of the current head as of today ? I just wanted to test the cobertura plugin but cannot build the site with Maven 3.2.6-SNAPSHOT due

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-24 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-75848081 I am still convinced that it is a good idea to allow Maven 3 'mvn site-deploy' to work the same way as Maven 2. What's the issue with that ? --- If your project

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-25 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-75990941 There are situations the behaviour is not wrong, in my opinion. Resolution for non project `packaging` related lifecycles, for example. Maven could detect

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-24 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-75794059 Regarding the recent discussion about releasing 3.2.6 as 3.3.0: Could this be part of 3.3.0, please ? --- If your project is set up for it, you can reply

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-25 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-76081933 Could not be more confusing. Apache Maven is a software project management and comprehension tool. Based on the concept of a project object model (POM

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-25 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-76122905 ``` parent module1 module2 ``` With Maven 3 I need to ``` cmdcd parent mvn site-deploy -N cd module1 mvn site-deploy

[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...

2015-12-17 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/50#issuecomment-165627334 Can you please 'rebase' the commit onto 'origin/master' so that I can merge it without conflicts? --- If your project is set up for it, you can reply

[GitHub] maven pull request: String handling issues identified by PMD

2016-02-09 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-181984267 This has been committed. See MNG-5934. Please close this pull request manually. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: fix release profile to use source:jar-no-fork ...

2016-02-09 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/61#issuecomment-181983567 This has been committed. See MNG-5940. Please close this pull request manually. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-23 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-188009400 @barthel: See [c31be833a6f8d9266990a708efe624d09fa06dec](https://github.com/ChristianSchulte/maven/commit/c31be833a6f8d9266990a708efe624d09fa06dec) --- If your

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-18 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven-surefire/pull/144 Resource leaks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte/maven-surefire master Alternatively you can

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-26 Thread ChristianSchulte
Github user ChristianSchulte commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/144#discussion_r103110034 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java --- @@ -69,8 +69,8

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-26 Thread ChristianSchulte
Github user ChristianSchulte commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/144#discussion_r103110250 --- Diff: surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java --- @@ -236,13 +236,17 @@ private static void

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-26 Thread ChristianSchulte
Github user ChristianSchulte commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/144#discussion_r103109929 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java --- @@ -240,6 +240,10

[GitHub] maven issue #99: [MNG-6127] Fix plugin execution configuration interference

2016-11-23 Thread ChristianSchulte
Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/99 Could you please also provide an integration test against [maven-integration-testing](https://github.com/apache/maven-integration-testing). --- If your project is set up for it, you can

[GitHub] maven-integration-testing pull request #20: Integration tests for various JI...

2017-03-25 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven-integration-testing/pull/20 Integration tests for various JIRA issues. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte/maven

[GitHub] maven pull request #107: Fixes to various JIRA issues.

2017-03-11 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/107 Fixes to various JIRA issues. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte/maven master Alternatively you can

[GitHub] maven pull request #124: Make resolver debug log messages for projects and p...

2017-06-21 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/124 Make resolver debug log messages for projects and plugins consistent. The graph returned by the resolver after resolution is logged at debug level. This pull request only updates those

[GitHub] maven issue #107: Fixes to various JIRA issues.

2017-06-14 Thread ChristianSchulte
Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/107 You'll need to merge the resolver bugfixes as well to make the IT work, of course. [MRESOLVER-8](https://github.com/ChristianSchulte/maven-resolver/commit

[GitHub] maven issue #143: [MNG-5359] Declared execution in PluginMgmt gets bound to ...

2017-12-30 Thread ChristianSchulte
Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/143 [Corresponding IT pull request.](https://github.com/apache/maven-integration-testing/pull/27) --- - To unsubscribe, e

[GitHub] maven pull request #147: [MNG-5527] Dependency management import should supp...

2017-12-30 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/147 [MNG-5527] Dependency management import should support relocations. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte

[GitHub] maven issue #148: [MNG-5600] Dependency management import should support exc...

2017-12-30 Thread ChristianSchulte
Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/148 [Corresponding IT pull request.](https://github.com/apache/maven-integration-testing/pull/30) --- - To unsubscribe, e

[GitHub] maven pull request #148: [MNG-5600] Dependency management import should supp...

2017-12-30 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/148 [MNG-5600] Dependency management import should support exclusions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte

[GitHub] maven pull request #146: [MNG-4463] Dependency management import should supp...

2017-12-30 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/146 [MNG-4463] Dependency management import should support version ranges. Closes #64 without merging. ITs are pending to be committed. You can merge this pull request into a Git repository

[GitHub] maven issue #146: [MNG-4463] Dependency management import should support ver...

2017-12-30 Thread ChristianSchulte
Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/146 [Corresponding IT pull request.](https://github.com/apache/maven-integration-testing/pull/28) --- - To unsubscribe, e

[GitHub] maven issue #147: [MNG-5527] Dependency management import should support rel...

2017-12-30 Thread ChristianSchulte
Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/147 [Corresponding IT pull request.](https://github.com/apache/maven-integration-testing/pull/29) --- - To unsubscribe, e

[GitHub] maven pull request #144: [MNG-2893] Update the DefaultPluginManager to not u...

2017-12-24 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/144 [MNG-2893] Update the DefaultPluginManager to not use a project depMa… …n for controlling it's transitive dependencies You can merge this pull request into a Git repository by running

[GitHub] maven pull request #145: [MNG-6112] Central repository in the 4.0.0 super PO...

2017-12-24 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/145 [MNG-6112] Central repository in the 4.0.0 super POM should declare u… …pdate policy 'never'. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] maven pull request #143: [MNG-5359] Declared execution in PluginMgmt gets bo...

2017-12-24 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/143 [MNG-5359] Declared execution in PluginMgmt gets bound to lifecycle (… …regression) You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] maven pull request #142: [MNG-6114] Profiles from the global settings should...

2017-12-24 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/142 [MNG-6114] Profiles from the global settings should be ordered before… … profiles from the user settings. You can merge this pull request into a Git repository by running: $ git

[GitHub] maven pull request #141: [MNG-6164] Collections inconsistently immutable.

2017-12-24 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven/pull/141 [MNG-6164] Collections inconsistently immutable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte/maven MNG-6164