maven pull request: [MNG-5075] MavenProject.getParent throws undocumented I...

2013-04-29 Thread jglick 
GitHub user jglick opened a pull request:

https://github.com/apache/maven/pull/8

[MNG-5075] MavenProject.getParent throws undocumented ISE

Fix for [MNG-5075](http://jira.codehaus.org/browse/MNG-5075): 
`MavenProject.getParent` throws `IllegalStateException` when there is a model 
building error. Patch (updated version of JIRA original) just sends any 
problems to the logger and returns `null`, which is not great but is at least 
now documented and will prevent innocent clients from being fatally broken by 
an unchecked exception.

I am `jgl...@apache.org` and intend this patch to be submitted to the ASF 
under the ASL 2.0.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jglick/maven MavenProject-getParent-MNG-5075

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/8.patch


commit a46507975719751d306eb9d90efe6c00030b94a6
Author: Jesse Glick jgl...@cloudbees.com
Date:   2013-04-29T15:55:46Z

[MNG-5075] MavenProject.getParent throws undocumented ISE




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

maven pull request: [MNG-5075] MavenProject.getParent throws undocumented I...

2014-01-06 Thread jglick 
Github user jglick closed the pull request at:

https://github.com/apache/maven/pull/8


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-enforcer pull request #23: Adding RequireUpperBoundDeps.excludes optio...

2017-06-12 Thread jglick 
GitHub user jglick opened a pull request:

https://github.com/apache/maven-enforcer/pull/23

Adding RequireUpperBoundDeps.excludes option

Needed to implement 
[JENKINS-41631](https://issues.jenkins-ci.org/browse/JENKINS-41631): there are 
certain known cases (that for various reasons cannot be fixed any time in the 
near future) where a dependency is older than a transitive version, yet this 
has been manually confirmed as acceptable, and we wish to enforce the ban for 
everything else. Analogous to exclude options on various other rules.

@reviewbybees for my colleages

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jglick/maven-enforcer 
RequireUpperBoundDeps.excludes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-enforcer/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-enforcer pull request #22: Site fixes

2017-06-12 Thread jglick 
GitHub user jglick opened a pull request:

https://github.com/apache/maven-enforcer/pull/22

Site fixes

Some fixes I found desirable or necessary when testing site generation 
locally.

@reviewbybees for my colleagues

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jglick/maven-enforcer site-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-enforcer/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit 765fb8eec32a730e247779008f8630da8407fafe
Author: Jesse Glick <jgl...@cloudbees.com>
Date:   2017-06-12T22:29:06Z

Grammar error.

commit 6408b6f2383bcb906fffdc9fe2ef701b461d5c74
Author: Jesse Glick <jgl...@cloudbees.com>
Date:   2017-06-12T22:29:45Z

Pick up fix of https://github.com/mojohaus/extra-enforcer-rules/issues/13.

commit fb93d6b2f53734f302c0fc300c823eba212a67e0
Author: Jesse Glick <jgl...@cloudbees.com>
Date:   2017-06-12T22:30:01Z

Fix Javadoc error considered fatal by JDK 8.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-enforcer pull request #22: [MENFORCER-272] Site fixes

2017-06-15 Thread jglick 
Github user jglick closed the pull request at:

https://github.com/apache/maven-enforcer/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-enforcer pull request #23: [MENFORCER-273] Adding RequireUpperBoundDep...

2017-06-15 Thread jglick 
Github user jglick closed the pull request at:

https://github.com/apache/maven-enforcer/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #25: Importing a BOM works even when ...

2017-11-28 Thread jglick 
GitHub user jglick opened a pull request:

https://github.com/apache/maven-integration-testing/pull/25

Importing a BOM works even when it has the same components in dep mgmt

Does not correspond to any known bug, but it seems like a potentially 
unusual practice deserving of test coverage.

@reviewbybees esp. @stephenc who wondered whether this actually works

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jglick/maven-integration-testing 
cyclic-import-scope

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit 8b0ba74bf5c355713ca3727fc792e0b6d86c2a40
Author: Jesse Glick <jgl...@cloudbees.com>
Date:   2017-11-28T23:39:16Z

Demonstrating that importing a BOM works even when it declares those same 
components in dependency management.




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #25: Importing a BOM works even when ...

2017-11-28 Thread jglick 
Github user jglick commented on a diff in the pull request:


https://github.com/apache/maven-integration-testing/pull/25#discussion_r153657505
  
--- Diff: 
core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java ---
@@ -654,6 +654,7 @@ public static Test suite()
 suite.addTestSuite( MavenITmng0249ResolveDepsFromReactorTest.class 
);
 suite.addTestSuite( MavenITmng0187CollectedProjectsTest.class );
 suite.addTestSuite( MavenITmng0095ReactorFailureBehaviorTest.class 
);
+suite.addTestSuite( MavenIT0199CyclicImportScopeTest.class );
--- End diff --

Was unclear what the naming scheme was here, so I just made something up.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #25: Importing a BOM works even when ...

2017-11-28 Thread jglick 
Github user jglick commented on a diff in the pull request:


https://github.com/apache/maven-integration-testing/pull/25#discussion_r153657727
  
--- Diff: 
core-it-suite/src/test/java/org/apache/maven/it/MavenIT0199CyclicImportScopeTest.java
 ---
@@ -0,0 +1,56 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import org.apache.maven.it.util.ResourceExtractor;
+
+public class MavenIT0199CyclicImportScopeTest extends 
AbstractMavenIntegrationTestCase {
+
+public MavenIT0199CyclicImportScopeTest() {
+super(ALL_MAVEN_VERSIONS);
--- End diff --

Well, tested against 3.5.2. Did not try running against, say, 2.x. Is there 
some automated process which does this?


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #25: Importing a BOM works even when ...

2017-11-28 Thread jglick 
Github user jglick commented on a diff in the pull request:


https://github.com/apache/maven-integration-testing/pull/25#discussion_r153657657
  
--- Diff: 
core-it-suite/src/test/java/org/apache/maven/it/MavenIT0199CyclicImportScopeTest.java
 ---
@@ -0,0 +1,56 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import org.apache.maven.it.util.ResourceExtractor;
+
+public class MavenIT0199CyclicImportScopeTest extends 
AbstractMavenIntegrationTestCase {
+
+public MavenIT0199CyclicImportScopeTest() {
+super(ALL_MAVEN_VERSIONS);
+}
+
+public void testit0199() throws Exception {
+// v1: parent not using BOM; explicit dep from componentB → 
componentA
+// v2: BOM introduced; componentB → componentA picks up implicit 
version 1 from main@v1
+// v3: components now inheriting indirectly from an older version 
of the BOM that includes them; componentB → componentA version overridden
+for (int i = 1; i <= 3; i++) {
+build("v" + i + "/parent", null);
+build("v" + i + "/componentA", "target/componentA-" + i + 
".jar");
+build("v" + i + "/componentB", "target/componentB-" + i + 
".jar");
+build("v" + i + "/main", "bundle/target/bundle-" + i + ".jar");
+}
+}
+
+private void build(String module, String expectedArtifact) throws 
Exception {
+File testDir = 
ResourceExtractor.simpleExtractResources(getClass(), "/cyclic-import-scope");
+Verifier verifier = newVerifier(new 
File(testDir.getAbsolutePath(), module).getAbsolutePath());
+verifier.setAutoclean(false);
+verifier.deleteDirectory("target");
+verifier.executeGoal("install");
--- End diff --

Tested iteratively using

```sh
rm -rfv repo/test
mvn clean test -f core-it-suite -Prun-its -Dmaven.repo.local=`pwd`/repo 
-Dtest=org.apache.maven.it.MavenIT0199CyclicImportScopeTest
```


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org