[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-29 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143988014 Rebased onto 2a9a07b0a and re-pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-29 Thread josephw
Github user josephw closed the pull request at: https://github.com/apache/maven/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-28 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143918594 I've verified the behaviour. To reproduce: MAVEN_OPTS="-Duser.country=th -Duser.language=th" mvn deploy It doesn't fail, but the snap

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-12 Thread josephw
GitHub user josephw opened a pull request: https://github.com/apache/maven/pull/65 MNG-5877: Ensure that snapshot versions use the Gregorian calendar. Snapshot versioning should use the Gregorian calendar for consistency across systems. Apply the fix reported by Anders Forsell

[GitHub] maven pull request: MNG-5297: Mark as deprecated.

2015-09-07 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/51#issuecomment-138286028 @kwin, @mosabua - is this current form acceptable as a fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven pull request: MNG-5297: Mark as deprecated.

2015-09-07 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/51#issuecomment-138302328 Even if it wasn't the intended use, way back in Maven 2: 4 would give: $ mvn2 validate [INFO] Scanning

[GitHub] maven pull request: MNG-5297: Mark as deprecated.

2015-09-07 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/51#issuecomment-138297080 @jvanzyl although the original change was unconditional deprecation, I changed it after comments so the current language in the patch is intended to reflect

[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...

2015-09-07 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/50#issuecomment-138297741 @birkedal, does this change look okay after the switch to backticks? Or, if you're a Solaris user, does that other idiom seem better? --- If your project is set up

[GitHub] maven pull request: MNG-5297: Mark prerequisites as deprecated.

2015-06-17 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/51#issuecomment-112843851 @kwin , @mosabua: thanks. I've rewritten it to reflect that distinction, that it's only deprecated for compile-time enforcement. --- If your project is set up

[GitHub] maven pull request: MNG-5297: Mark prerequisites as deprecated.

2015-06-11 Thread josephw
GitHub user josephw opened a pull request: https://github.com/apache/maven/pull/51 MNG-5297: Mark prerequisites as deprecated. MNG-4840 indicates that the Enforcer plugin should be preferred to prerequisites. Indicate that in the documentation. You can merge this pull request

[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...

2015-06-08 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/50#issuecomment-110022166 I've pushed a further change to switch $(..) to backticks. However, perhaps [this idiom](https://bugs.freedesktop.org/show_bug.cgi?id=5278) would be a better way

[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...

2015-06-07 Thread josephw
GitHub user josephw opened a pull request: https://github.com/apache/maven/pull/50 MNG-5837: Use a subshell, rather than the 'local' keyword, for POSIX compliance 'local' is not POSIX, but supported by most shells. However, it's not supported by Solaris's /bin/sh, so use

[GitHub] maven-plugins pull request: MECLIPSE-738: Fix constructing a Linke...

2015-03-27 Thread josephw
Github user josephw closed the pull request at: https://github.com/apache/maven-plugins/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven-plugins pull request: MECLIPSE-738: Fix constructing a Linke...

2015-02-28 Thread josephw
GitHub user josephw opened a pull request: https://github.com/apache/maven-plugins/pull/45 MECLIPSE-738: Fix constructing a LinkedResource with a locationURI Allow that either, but not both, and not neither, of the location properties could be set. Include tests, and upgrade

[GitHub] maven pull request: MNG-5734: Fail, rather than just warning, on e...

2015-02-24 Thread josephw
Github user josephw closed the pull request at: https://github.com/apache/maven/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: Simplify the bootstrapping instructions to rem...

2015-02-21 Thread josephw
Github user josephw closed the pull request at: https://github.com/apache/maven/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: MNG-5734: Fail, rather than just warning, on e...

2015-02-20 Thread josephw
GitHub user josephw opened a pull request: https://github.com/apache/maven/pull/37 MNG-5734: Fail, rather than just warning, on empty 'module' entries. An incorrect non-blank module is currently treated as an error. Behave the same way for a blank module, rather than simply

[GitHub] maven pull request: Simplify the bootstrapping instructions to rem...

2015-02-20 Thread josephw
GitHub user josephw opened a pull request: https://github.com/apache/maven/pull/38 Simplify the bootstrapping instructions to remove use of M2_HOME. General consensus on maven-dev ([Remove M2_HOME setup from download page instructions](http://mail-archives.apache.org/mod_mbox/maven