[GitHub] maven issue #101: Spelling api
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/101 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #100: Spelling non-API change
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #100: Spelling non-API change
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #103: spelling: excident
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 I can live with that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #103: spelling: excident
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 Well, ideally we'd pick things not likely to be typo'd (your second one would be `Depended`). Anyway, I'm more or less willing to take any pair of things you're happy w/.\ one pair to consider is `into` and `from` -- they're clearly distinct, they're short, and they have the same character count. Possibly `linkInto`, `linkFrom`, `addLinkInto`. Not sure I like it. I really didn't come here to rewrite terminology. I have a toolchain that uses maven, and I figured I owed maven a PR... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #103: spelling: excident
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 https://proofwiki.org/wiki/Definition:Incident_(Graph_Theory) Offers "incident to" and "incident from". Offhand, I'd suggest moving away from graph theory towards packaging or something else. Graph theory while interesting isn't really going to help someone figure this stuff out. I mean, it's possible to replace all incidents of incident/excident w/ incidentTo/incidentFrom, but that won't make the code easier to read. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #103: spelling: excident
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 I studied graph theory starting in middle school. I know the other thing is a made up word. But, the problem is... consider lines... What is the opposite of a perpendicular line? Is it ... * a parallel line? * a line that intersects but not at a 90-degree angle? * a line that is skew? What precise aspect of lines is this thing trying to express? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #100: Spelling non-API change
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 sonatype/plexus-sec-dispatcher#4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #103: spelling: excident
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 I doubt it. Do you understand the code enough to be able to / can you try to read it and then describe what the code is interested in describing? (try to avoid using anything that sounds similar to any of the candidate word roots). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #100: Spelling non-API change
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 @michael-o : this PR is roughly "non-API change". I split off #101 for the API change (and included deprecation, but not docs, that's too much to ask). #102 is a bug fix, I think, so I split it out. #103 isn't really finished, because well, I'm not sure what the right word is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #100: Spelling
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 @michael-o split -- please follow-up in #103 as that's a messier kettle --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #103: spelling: excident
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/103 spelling: excident split from #100 This is for consistency. I know it's a public API. But, I don't know if this is the word you want. If it is, we can add the @Deprecated annotation. If it isn't, then we should figure out the right word and fix the others too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/maven spelling-consistency-excident Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 commit 9e532086beab9921727eecf3e655b0f1cad2adf4 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:46:46Z spelling: excident --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #102: spelling: vertices
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/102 spelling: vertices split from #100 I think this is a bug fix. I can't figure out how it could work otherwise. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/maven spelling-vertices Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/102.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #102 commit 73e72d2b0aeaefa7bea50476183d3e1d137f0382 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T04:56:58Z spelling: vertices --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #101: Spelling api
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/101 Spelling api split from #100 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/maven spelling-api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #101 commit f36828ca52d384249240ed831f771f1b6e13568b Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:29:31Z spelling: collector commit 60a0c53288bde82e4a54972dda4b9e3bdcf89021 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:35:55Z spelling: executions commit ad92dc2626c4b1a90c9b512447558196cd1cddb4 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T04:50:04Z spelling: repositories commit ea52458478ce9b87f64e4ae8bcb7bdc8cba38cf9 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T04:57:23Z spelling: workspace --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #100: Spelling
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97254243 --- Diff: maven-model-builder/src/test/java/org/apache/maven/model/interpolation/AbstractModelInterpolatorTest.java --- @@ -67,7 +67,7 @@ protected void assertProblemFree( SimpleProblemCollector collector ) assertEquals( "Expected no fatals", 0, collector.getFatals().size() ); } -protected void assertColllectorState( int numFatals, int numErrors, int numWarnings, +protected void assertCollectorState( int numFatals, int numErrors, int numWarnings, --- End diff -- I guess this is an api --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #100: Spelling
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253963 --- Diff: maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/LifecycleExecutionPlanCalculatorStub.java --- @@ -88,7 +88,7 @@ public final static MojoDescriptor SITE_DEPLOY = createMojoDescriptor( "site-deploy" ); -public int getNumberOfExceutions( ProjectBuildList projectBuildList ) +public int getNumberOfExecutions( ProjectBuildList projectBuildList ) --- End diff -- I'm hoping this isn't really a public api, but if it is... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #100: Spelling
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253779 --- Diff: maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java --- @@ -108,14 +108,14 @@ public MetadataResolutionRequest setLocalRepository( ArtifactRepository localRep return this; } -public List getRemoteRepostories() +public List getRemoteRepositories() --- End diff -- This is probably an api change. I can provide deprecation markers and/or split this into a distinct PR (applies for all similar items) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #100: Spelling
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253891 --- Diff: maven-core/src/main/java/org/apache/maven/repository/DelegatingLocalArtifactRepository.java --- @@ -61,7 +61,7 @@ public void setIdeWorkspace( LocalArtifactRepository localRepository ) this.ideWorkspace = localRepository; } -public LocalArtifactRepository getIdeWorspace() +public LocalArtifactRepository getIdeWorkspace() --- End diff -- This would be an api change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #100: Spelling
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253878 --- Diff: maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java --- @@ -105,7 +105,7 @@ public ProjectSorter( Collection projects ) vertices.put( project.getVersion(), dag.addVertex( projectId ) ); } -for ( Vertex projectVertex : dag.getVerticies() ) +for ( Vertex projectVertex : dag.getVertices() ) --- End diff -- this change stands alone, I can't find anything else that uses this spelling, but lots of things use the corrected spelling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #100: Spelling
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253624 --- Diff: maven-compat/src/main/java/org/apache/maven/repository/MetadataGraphNode.java --- @@ -57,7 +57,7 @@ public MetadataGraphNode addIncident( MetadataGraphNode node ) return this; } -public MetadataGraphNode addExident( MetadataGraphNode node ) +public MetadataGraphNode addExcident( MetadataGraphNode node ) --- End diff -- This would be an api change. I'm not even sure if this is a correct word. I'm fairly confident that you are using two spellings for the same concept. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #100: Spelling
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/100 Spelling You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/maven spelling Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #100 commit 80cdc35cb1b9fafc188ce78d94fee3d2ebfaf6b7 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:27:41Z spelling: artifact commit 5b099e2f12b4122cd1e3876b05d31a0092070b9c Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:28:07Z spelling: attachment commit 58c39c00ce0c21c2feaff812a25f4967da322ae7 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:29:01Z spelling: codehaus commit 0fba0742791c54cd125683d650394f8abe7e5d21 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:29:17Z spelling: colleagues commit 370b58f51f42c45834b87efc06fb9f29517d3eed Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:29:31Z spelling: collector commit 83923fe00ba09af9226c69128f589f8786416be5 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:29:40Z spelling: configure commit 63ddf032b18493df9572476b61fa5a36e329092c Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:29:52Z spelling: comparison commit 2541a4e6f877b1ff0542be8ce9bbb075f6668c8c Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:29:59Z spelling: concurrency commit 4ade41b6e5ed2740d789bc0da64b036957539838 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:30:18Z spelling: creation commit 6ae3c4c7730a47244b76bac1c4954225e2f38f6b Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:31:34Z spelling: decrypter commit 71235886f7d8fc59ae25128849037761fa0fa262 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:32:05Z spelling: dependency commit 0d06338d1c1dbc6ddc6e93daeef46c44a832562f Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:32:27Z spelling: descriptor commit f2481e4d17d13ed76bd20ba9e6c9aee57e699580 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:33:42Z spelling: downstream commit d3aeb2d7b6f27caf1537a7c87e39618ffcf2b7e1 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:34:14Z spelling: efficient commit 7cc9183db4edd81ecf5c099d4587d935ac44dcfa Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:34:21Z spelling: elements commit c4916cbb3f2e052449404be28c7817692470d09c Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:35:03Z spelling: encounters commit e00c30f31ddf816461660744d073d990c9c8065d Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:35:20Z spelling: encountered commit ec188c495e0e45f9c3669e0e549235edd3698865 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:35:26Z spelling: environments commit 37f446fb53d631211f67d0270dbfbf9c26861439 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:35:55Z spelling: executions commit 8ed09e533dfead73eec676481e3172630e6c2c59 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:42:09Z spelling: executed commit e8a7fa9997c5dfaa5310569ba8271e608d7b1bdb Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:46:46Z spelling: excident commit 015013702f2349094c45b4a9c8b984d4fba2f7a6 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:52:44Z spelling: explicitly commit 6194e8f89e3ce1a2cc7386116ca0caba7a00a0a6 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:54:47Z spelling: happens commit 7899cc63dfedb26eb96c8ace37b277a2996a5c9c Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:55:00Z spelling: hierarchy commit 2e0688f34fe24d42d5578ed7cc60fc832372f25d Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:55:35Z spelling: inherited commit ab2739fda5da633ea20c17f605bed2e4d72c739e Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:56:06Z spelling: hierarchical commit cb6c97b33eaf89566b066d44f9436127f210a057 Author: Josh Soref <jso...@users.noreply.github.com> Date: 2017-01-23T01:59:50Z spelling: implementers commit b202b284c1812c8fa2b5ab001e90b4500cd2b244 Author: Josh Soref <jso...@users.noreply.git
