As explained over slack it moves the problem and creates by design new
ones, if urging a revert is easier IMHO.
Long term fix can be a ref counting or so but no regression, at least in
single thread, is better anyway for end users I think.
Le lun. 23 août 2021 à 12:12, Falko Modler a écrit :
>
There is an open PR for that as well: https://github.com/apache/maven/pull/521
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
The one Olivier spotted is not fixed.
Le lun. 23 août 2021 à 11:02, Falko Modler a écrit :
> Why revert? Are you aware of any other regression caused by that?
> Both known regressions have been fixed (not yet merged).
>
> Having said that, as discussed previously, a solution without a TL is
>
Why revert? Are you aware of any other regression caused by that?
Both known regressions have been fixed (not yet merged).
Having said that, as discussed previously, a solution without a TL is
preferable in the long run but probably requires a more invasive approach that
is too big for a 3.8.x
+1 to revert this threadlocal thing in a 3.8.3
Breaks too silently mojo and is hard to track and technically it is
solvable on our side.
Le lun. 23 août 2021 à 08:29, Slawomir Jaranowski
a écrit :
> Hi,
>
> I think that https://issues.apache.org/jira/browse/MNG-7215 is also
> important, it
Hi,
I think that https://issues.apache.org/jira/browse/MNG-7215 is also
important, it breaks the build maven site for projects ...
Please don't extend the manual process ... nowadays we have everything to
do automatically, every (or most of) plugin has IT tests ... so we need
just to run its
Unfortunately, this commit introduced another, more severe regression:
https://issues.apache.org/jira/browse/MNG-7220
I was able to fix it already: https://github.com/apache/maven/pull/527
IMO, this warrants a timely 3.8.3 release. WDYT?
PS: If there are no automated tests of the standard
Hi,
The vote has passed with the following result:
+1: Michael Osipov, Tamás Cservenák, Olivier Lamy, Enrico Olivelli, Karl
Heinz Marbaise, Robert Scholte, Sylwester Lachiewicz, Arnaud Héritier,
Dan Tran, Tibor Digana
PMC quorum: reached
I will promote the artifacts to the central repo,
On Thu, 12 Aug 2021 at 11:54, Olivier Lamy wrote:
> No it's not that simple :) and probably doesn;t impact many plugins (btw
> those plugins are using a wrong pattern :) )
>
> In your mojo you have this field:
> @Parameter(defaultValue = "${project}", readonly = true)
> private
No it's not that simple :) and probably doesn;t impact many plugins (btw
those plugins are using a wrong pattern :) )
In your mojo you have this field:
@Parameter(defaultValue = "${project}", readonly = true)
private MavenProject project;
Within the mojo you do
List classpathElements
sounds to me, it impacts any plugin creating a class loader? such jaxws?
-D
On Wed, Aug 11, 2021 at 4:20 AM Olivier Lamy wrote:
> On Wed, 11 Aug 2021 at 21:16, Michael Osipov wrote:
>
> > Merci Olivier for testing.
> > Would you say that the change in Maven just revealed this bug in that
> >
On Wed, 11 Aug 2021 at 21:16, Michael Osipov wrote:
> Merci Olivier for testing.
> Would you say that the change in Maven just revealed this bug in that
> particular plugin?
>
Yes we can say that :)
I just hope no other plugins do something similar
> Am 2021-08-11 um 06:03 schrieb
Merci Olivier for testing.
Would you say that the change in Maven just revealed this bug in that
particular plugin?
Am 2021-08-11 um 06:03 schrieb Olivier Lamy:
did the bisect and found this
*➜ **maven-core* *git:(**42c99b45e**)* git bisect good
76d5f0d942f52650d3bdf775b6af42d23d69066b is
did the bisect and found this
*➜ **maven-core* *git:(**42c99b45e**)* git bisect good
76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
Author: Falko Modler
Date: Fri Jun 25 19:28:40 2021 +0200
[MNG-6843] Parallel build
interesting this code change in the plugin fix the issue with the staged
3.8.2
https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
looking at commits log not sure if we touched something related to thread
context classloader?
On Wed, 11 Aug 2021
found some breaking change.
this plugin is not working anymore:
https://github.com/jetty-project/h2spec-maven-plugin
mvn verify
got ClassNotFoundException
On Wed, 11 Aug 2021 at 03:50, Falko Modler wrote:
> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
> really see a
I checked it briefly with Quarkus (almost 1k modules) and I couldn't really see
a difference.
Cheers,
Falko
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Thank you for testing a bit more, Dan, I can't see anything particular on
my end either, but I don't have access to any really huge builds at
the moment, since I'm on vacation
All in all, I do however feel comfortable to vote now: +1 (non-binding)
- Eric Lilja
On Tue, Aug 10, 2021 at 10:29 AM
+1
On Wed, Aug 4, 2021 at 10:02 PM Michael Osipov wrote:
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
>
> There are still a couple of issues left in JIRA:
>
>
Further testing and comparison with current builds, there is no concrete
evidence of performance degradation.
here is my +1 ( none binding)
Sorry about noise
-D
On Mon, Aug 9, 2021 at 5:13 PM Dan Tran wrote:
> Hello,
>
> I am not able to dedicate the time to do bisecting this issue
>
> -D
Hello,
I am not able to dedicate the time to do bisecting this issue
-D
On Mon, Aug 9, 2021 at 3:03 AM Eric Lilja wrote:
> It's an impressive list of fixes and we are many that would like to see a
> 3.8.2 release appear. Question for me is if the particular change
> that appears to cause a
It's an impressive list of fixes and we are many that would like to see a
3.8.2 release appear. Question for me is if the particular change
that appears to cause a general performance degradation on the scale of ten
percent is worth it (if it indeed can be isolated to particular JIRA and
not due
+1
Tested on several projects with no issue
I agree that the performance is a bit degraded but nothing blocker compared
the value of the fixes introduced here.
On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz
wrote:
> +1
>
> niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte
> napisał:
>
+1
niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte
napisał:
> +1
> On 4-8-2021 22:02:18, Michael Osipov wrote:
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
>
> There are still a couple of issues left in JIRA:
>
>
+1
On 4-8-2021 22:02:18, Michael Osipov wrote:
Hi,
We solved 68 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
There are still a couple of issues left in JIRA:
Hi,
+1 from me
tested with several project and testing during the last days... without
any issue.
Kind regards
Karl Heinz Marbaise
On 04.08.21 22:02, Michael Osipov wrote:
Hi,
We solved 68 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
There are
+1 (non binding)
Enrico
Il Dom 8 Ago 2021, 10:07 Michael Osipov ha scritto:
> Am 2021-08-04 um 22:02 schrieb Michael Osipov:
> > Hi,
> >
> > We solved 68 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
> >
> >
> > There are still a couple of
Am 2021-08-04 um 22:02 schrieb Michael Osipov:
Hi,
We solved 68 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
There are still a couple of issues left in JIRA:
Am 2021-08-06 um 12:07 schrieb Falko Modler:
Hi all,
it wouldn't surprise me if it was that ThreadLocal quickfix from my PR.
I think everyone agrees that it is a bandaid solution but well, correctness and
stability over (some) speed, IMO.
I absolutely agree here!
Hi all,
it wouldn't surprise me if it was that ThreadLocal quickfix from my PR.
I think everyone agrees that it is a bandaid solution but well, correctness and
stability over (some) speed, IMO.
It would be nice to limit this workaround to only when aggregating goals are
involved but that seems
+1
include some interesting fixes
Thanks to take care of this!
On Thu, 5 Aug 2021 at 06:02, Michael Osipov wrote:
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
>
> There are still a couple of issues left in JIRA:
>
>
Am 2021-08-04 um 22:02 schrieb Michael Osipov:
Hi,
We solved 68 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
There are still a couple of issues left in JIRA:
Dan,
thank you very much for testing. Do you think you could bisect to the
commit which introduced the 10% overhead? Maybe it is really the
classpath concurrency issue which has been addressed by Falko Modler.
Also can you try Maven from master and see whether you can reproduce the
10%?
tested with my company internal build with 300+ modules. the build time
increase by 10%. Not sure if anyone sees the same. but I am happy to take
it due to the fix at the classpath concurrency issue.
Thanks for pushing this out
-D
On Thu, Aug 5, 2021 at 1:23 PM Tamás Cservenák wrote:
> +1
>
+1
T
On Wed, Aug 4, 2021 at 10:02 PM Michael Osipov wrote:
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
>
> There are still a couple of issues left in JIRA:
>
>
Hi,
We solved 68 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12349965
There are still a couple of issues left in JIRA:
36 matches
Mail list logo
