Re: [2/2] maven git commit: [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in the 4.0.0 super POM.

2017-03-25 Thread Stephen Connolly 
FTR, this was a commit on a branch and the branch is now deleted... so all
is OK here

On 25 March 2017 at 08:29, Stephen Connolly  wrote:

> Is this withdrawn or where is the revert commit?
>
> On Tue 21 Mar 2017 at 18:44, Hervé BOUTEMY  wrote:
>
>> -1
>>
>> see MNG-5164
>>
>> Regards,
>>
>> Hervé
>>
>> Le mardi 21 mars 2017, 18:20:21 CET schu...@apache.org a écrit :
>> > [MNG-6113] Rename the 'Central Repository' to 'Maven Central
>> Repository' in
>> > the 4.0.0 super POM.
>> >
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/maven/repo
>> > Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/0f0040a1
>> > Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/0f0040a1
>> > Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/0f0040a1
>> >
>> > Branch: refs/heads/MNG-6113
>> > Commit: 0f0040a1915bfd14cf60342eb1680ed59eaea92b
>> > Parents: 27ab750
>> > Author: Christian Schulte 
>> > Authored: Tue Mar 21 00:31:53 2017 +0100
>> > Committer: Christian Schulte 
>> > Committed: Tue Mar 21 19:20:00 2017 +0100
>> >
>> > --
>> >  .../src/main/resources/org/apache/maven/model/pom-4.0.0.xml  | 4
>> ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> > --
>> >
>> >
>> > http://git-wip-us.apache.org/repos/asf/maven/blob/0f0040a1/
>> maven-model-build
>> > er/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
>> > --
>> diff
>> > --git
>> > a/maven-model-builder/src/main/resources/org/apache/
>> maven/model/pom-4.0.0.x
>> > ml
>> > b/maven-model-builder/src/main/resources/org/apache/
>> maven/model/pom-4.0.0.x
>> > ml index 9487a9a..c9770b0 100644
>> > ---
>> > a/maven-model-builder/src/main/resources/org/apache/
>> maven/model/pom-4.0.0.x
>> > ml +++
>> > b/maven-model-builder/src/main/resources/org/apache/
>> maven/model/pom-4.0.0.x
>> > ml @@ -26,7 +26,7 @@ under the License.
>> >
>> >  
>> >central
>> > -  Central Repository
>> > +  Maven Central Repository
>> >https://repo.maven.apache.org/maven2
>> >default
>> >
>> > @@ -41,7 +41,7 @@ under the License.
>> >
>> >  
>> >central
>> > -  Central Repository
>> > +  Maven Central Repository
>> >https://repo.maven.apache.org/maven2
>> >default
>> >
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>> --
> Sent from my phone
>

Re: [2/2] maven git commit: [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in the 4.0.0 super POM.

2017-03-25 Thread Stephen Connolly 
Is this withdrawn or where is the revert commit?

On Tue 21 Mar 2017 at 18:44, Hervé BOUTEMY  wrote:

> -1
>
> see MNG-5164
>
> Regards,
>
> Hervé
>
> Le mardi 21 mars 2017, 18:20:21 CET schu...@apache.org a écrit :
> > [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository'
> in
> > the 4.0.0 super POM.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/0f0040a1
> > Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/0f0040a1
> > Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/0f0040a1
> >
> > Branch: refs/heads/MNG-6113
> > Commit: 0f0040a1915bfd14cf60342eb1680ed59eaea92b
> > Parents: 27ab750
> > Author: Christian Schulte 
> > Authored: Tue Mar 21 00:31:53 2017 +0100
> > Committer: Christian Schulte 
> > Committed: Tue Mar 21 19:20:00 2017 +0100
> >
> > --
> >  .../src/main/resources/org/apache/maven/model/pom-4.0.0.xml  | 4
> ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > --
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/maven/blob/0f0040a1/maven-model-build
> > er/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
> > --
> diff
> > --git
> >
> a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> > ml
> >
> b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> > ml index 9487a9a..c9770b0 100644
> > ---
> >
> a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> > ml +++
> >
> b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> > ml @@ -26,7 +26,7 @@ under the License.
> >
> >  
> >central
> > -  Central Repository
> > +  Maven Central Repository
> >https://repo.maven.apache.org/maven2
> >default
> >
> > @@ -41,7 +41,7 @@ under the License.
> >
> >  
> >central
> > -  Central Repository
> > +  Maven Central Repository
> >https://repo.maven.apache.org/maven2
> >default
> >
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone

Re: [2/2] maven git commit: [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in the 4.0.0 super POM.

2017-03-25 Thread Hervé BOUTEMY 
Le mardi 21 mars 2017, 19:51:08 CET Christian Schulte a écrit :
> Am 03/21/17 um 19:44 schrieb Hervé BOUTEMY:
> > -1
> > 
> > see MNG-5164
> 
> Thanks for pointing this out.
you know, it's just a "git blame": our convention that comment starts with the 
Jira id is really great to give more sense to our codebase evolution

And that's why having good descriptions in Jira issues is also critical: it 
will be read years after being written, by someone trying to figure out why a 
code is written like it is (because now it looks like a bug...).

That makes me remember you that MNG-6183 is waiting for such a description 
(and MNG-6182 for a review since I did what I saw from code change, but I may 
have missed some important points)

> I closed the issue "Won't Fix" and flagged
> it a duplicate of MNG-5164. Branch is dropped.
thank you

> This would have went unnoticed into the 3.4.0 release :-).
no, that was not unnoticed: that was only evaluated and chosen to be not told, 
focusing on more critical issues (to avoid adding even more pressure on more 
different topics: focus on priorities...)

Regards,

Hervé

> 
> Regards,



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [2/2] maven git commit: [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in the 4.0.0 super POM.

2017-03-21 Thread Christian Schulte 
Am 03/21/17 um 19:44 schrieb Hervé BOUTEMY:
> -1
> 
> see MNG-5164

Thanks for pointing this out. I closed the issue "Won't Fix" and flagged
it a duplicate of MNG-5164. Branch is dropped. This would have went
unnoticed into the 3.4.0 release :-).

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [2/2] maven git commit: [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in the 4.0.0 super POM.

2017-03-21 Thread Hervé BOUTEMY 
-1

see MNG-5164

Regards,

Hervé

Le mardi 21 mars 2017, 18:20:21 CET schu...@apache.org a écrit :
> [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in
> the 4.0.0 super POM.
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/0f0040a1
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/0f0040a1
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/0f0040a1
> 
> Branch: refs/heads/MNG-6113
> Commit: 0f0040a1915bfd14cf60342eb1680ed59eaea92b
> Parents: 27ab750
> Author: Christian Schulte 
> Authored: Tue Mar 21 00:31:53 2017 +0100
> Committer: Christian Schulte 
> Committed: Tue Mar 21 19:20:00 2017 +0100
> 
> --
>  .../src/main/resources/org/apache/maven/model/pom-4.0.0.xml  | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> --
> 
> 
> http://git-wip-us.apache.org/repos/asf/maven/blob/0f0040a1/maven-model-build
> er/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
> -- diff
> --git
> a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> ml
> b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> ml index 9487a9a..c9770b0 100644
> ---
> a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> ml +++
> b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> ml @@ -26,7 +26,7 @@ under the License.
>
>  
>central
> -  Central Repository
> +  Maven Central Repository
>https://repo.maven.apache.org/maven2
>default
>
> @@ -41,7 +41,7 @@ under the License.
>
>  
>central
> -  Central Repository
> +  Maven Central Repository
>https://repo.maven.apache.org/maven2
>default
>



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org