[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #24: [MSHARED-987] Make use of SISU

2021-09-08 Thread GitBox


rfscholte commented on pull request #24:
URL: 
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-915137419


   To me the change is too big to validate, so it must proof itself for the 
several plugins out there that depend on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #24: [MSHARED-987] Make use of SISU

2021-05-02 Thread GitBox


rfscholte commented on pull request #24:
URL: 
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830853914


   I think I know what you've done. Whereas I started with the single jar 
approach,  you separated the code into modules.
   I can't see the new structure, but I know there were sometimes even 3 
implementation due to changes in Aether. How did you solve that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org