[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

2016-09-19 Thread britter
Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
@Tibor17 you have to follow the workflow described 
[here](http://wiki.apache.org/commons/UsingGIT#Applying_Pull_Requests_.28for_git_based_components.29).
 It's not possible to merge using the UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

2016-09-19 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
>>Did you know, that it is possible to mark PRs as merged in GitHub?
I don't see such option in GUI. Is not it because of we are not the owner 
of this repo `apache`?
Maybe they sould make be ASF member, however I am in ASF Maven group.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

2016-09-19 Thread britter
Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
@Tibor17 thank you for integrating this. Did you know, that it is possible 
to mark PRs as merged in GitHub? I've documented the workflow in the [Apache 
Commons 
Wiki](http://wiki.apache.org/commons/UsingGIT#Applying_Pull_Requests_.28for_git_based_components.29).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

2016-09-18 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
@britter 
Thank you for contributing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

2016-09-18 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
@britter 
I have created Jira issue for this Task
https://issues.apache.org/jira/browse/SUREFIRE-1282



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

2016-09-17 Thread britter
Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/120
  
Hello @Tibor17 

I've addressed you're comment about comparing Strings. There already is an 
API for comparing JavaVersions in SystemUtils. Hope you like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org