[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-12-01 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter I will push it to the branch junit5. Afterwards can you provide one more PR to merge junit5 branch from origin/master? --- If your project is set up for it, you can reply

[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-12-01 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/135 @Tibor17 okay, let's discuss the details of the engine look up once we have some integrations tests in place. Do you want anything to be changed in this PR or can we merge it?

[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter I think no user would like to specify `` in plugin in POM and he would not specify whether junit4 or junit5 as a duplicate to provider dependency. Basically all we need to

[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter It is not the right way to detect the presents of the JUnit annotations in classpath because the test classes may initialize static context yet in Maven process like we do

[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter Yes, Let's use profiles for our testing purposes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-11-25 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/135 @Tibor17: answering your comment from #133: > In reality the user would use only one dependency and not the profiles. WDYT ? Yes, this is just for testing purposes, so that