[GitHub] maven-surefire issue #163: Surefire-report

2017-12-04 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/163
  
@shafiullas
This commit is quite good but you have to fix the code style and register 
this issue at JIRA.
The code conventions are listed in 
https://maven.apache.org/developers/conventions/code.html
In the middle of the page is XML for Eclipse and IDEA. You can use it to 
configure your tool.
Then run the local build mvn install -P run-its. The build has 1400 tests, 
so it usually takes 50 minutes to complete on SSD disk.
Please rework the code style according to Maven convention in our project 
and use `git commit --ammend`. There should be only single commit per PR and 
the message should refer to JIRA ID, something like:
[SUREFIRE-12345] Surefire-report
and you can register at our JIRA here:
https://issues.apache.org/jira/projects/SUREFIRE


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire issue #163: Surefire-report

2017-09-08 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/163
  
@shafiullas 
Please rebase your branch.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire issue #163: Surefire-report

2017-09-08 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/163
  
@shafiullas 
Register in Jira and open issue in 
https://issues.apache.org/jira/browse/SUREFIRE. The message of the commit and 
GitHub issue should be renamed to something like:
[SUREFIRE-12345] Same issue title as current GitHub.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org