Github user mikebrock commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-46737130
I think that could be pretty cool. I see no reason why not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-46562788
@mikebrock Do you think MVEL would be suitable for a one expression
evaluator for a Maven profile activator? Imagine putting a MavenProject/pom.xml
in the MVEL context and
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-46555048
I think Christian's idea is better as the logic is contained to the
specific activator. I'm not keen at all to add conditional logic to the POM
model anywhere, or any type
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-46547866
Could be as simple as:
```
simple script
evaluating to a boolean
```
'engine-name' translates to javax.script.ScriptEngine.getEngineByNa
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-46546268
Another option would be to provide support for activations based on some
language like:
OS IS 'Linux' AND ( PROPERTY 'Some Name' IS 'true' OR JDK IS
'1.
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-46524647
First of all - thanks for your email.
I understand, that this will ruin current ORing technique, but at least it
could be fixed with copying for a while.
Github user FredipusRex commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-46523185
You do realize that the current OR condition is actually out in use right
now in many POM files, right? This was previously the subject of a patch
(MNG-3106) - original
Github user MysterionRise closed the pull request at:
https://github.com/apache/maven/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45826259
@jvanzyl Looks correct, please close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45825613
Let me check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45820916
@Konstantin, I've applied your patch and pushed the integration test. Try
it out and if it's good then close the pull request.
---
If your project is set up for it, you ca
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45811451
This change will actually make it match the book.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user mosabua commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45811127
if we need to change something in the book - I can take care of that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45744828
Ok, I've written an integration test and I'll see what falls out on the
Maven dev list today.
---
If your project is set up for it, you can reply to this email and have yo
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45732464
Yes, that's not uncommon. The PR is fine, just waiting for any feedback on
the Maven dev list. There is one IT I would disable going forward (which tests
that the activator
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45731774
Hm, probably you are correct. I've just have strong feeling, when somebody
said 'Sonatype' - think about 'Maven' and vice-versa.
Regarding PR, let me know, if
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45731568
Yes, that is the Sonatype book which is the de facto reference for Maven
but not the official specification but probably as close to one as we have. The
actual documentatio
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45731386
http://jira.codehaus.org/browse/MNG-4565 - take a look here. It have link
for reference
http://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.h
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45731097
What's the link you used for reference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45704618
I've implement this patch, only cause it's 100% relates with official
documentation.
---
If your project is set up for it, you can reply to this email and have your
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/20#issuecomment-45681556
I have argued on the Maven dev list to process your patch. The current
implementation I believe to be incorrect.
---
If your project is set up for it, you can reply to thi
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-45673757
I'm looking for a way to make this work, but this breaks MNG-3106 where the
current behaviour is to OR the activators. I agree there are cases where AND is
preferable but I
GitHub user MysterionRise opened a pull request:
https://github.com/apache/maven/pull/20
[MNG-4565] Multiple profile activation conditions does not work
Add possibilty to use multiple activators and have AND between them
You can merge this pull request into a Git repository by runni
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-45644286
Sorry, cut and paste error on my part when closing the other issues. Can
you reopen the PR again and I'll process it this afternoon.
---
If your project is set up for it,
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-45643803
I'm sorry, I don't understand, why you close this PR? Does it bad? I miss
something?
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/maven/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-45442939
Tonight I'll try to process all the outstanding PRs. I'll let you know if I
need anything.
---
If your project is set up for it, you can reply to this email and have your
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-45431277
Just wonder, is there anything I could do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-45138360
Cool, I'll take a look at look at the specific IT failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-45134460
I've update pull request. I change my approach, so it will not now a
platform dependable. But ITs are still failing at weird place. I'm 100% sure,
that it's not my fa
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44831587
Good stuff. I will try it today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44797771
I created a simple shell script to help validate a pull request against the
Maven integration tests. This script is not great, and running the Maven
integration tests is no
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44757042
I'm 100% don't wanna rush. I will think about special activator for testing
purpose (It could be _AlwaysTrueActivator_). I will try to give it a try
tomorrow.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44756700
Maybe creating an activator specifically for testing this might be better.
I will take a look as soon as I can. Likely tomorrow. Thanks for your patience,
we'll get this in
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44756676
I will take a look as soon as I can. Maybe making an activator specifically
for helping us test this will be better. Thanks for being patient, we'll get
this sorted and int
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44756590
Not understand your point about failing against master.
I agree that platform activators is not good idea. So same with JDK
activator, right? I'm only left wi
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44756291
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
2014-02-14T12:37:52-05:00)
Maven home: /Users/jvanzyl/m2
Java version: 1.7.0_21, vendor: Oracle Corpora
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44755927
Awesome,this is the only platform, I couldn't test against.Could you
specify your _mvn -version_ output? I will try to fix test.
---
If your project is set up for it
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44755377
I used Maven, master branch at revision
73d35ba9597cd867717310ae8813376888debb9b. I applied your patch to master, and
ran the tests with Maven 3.2.1 on OSX.
---
If your p
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44751378
Could you tell me, what did you use?
I've run tests on Linux:
mvn -version
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-
I applied your changes and your test fails. If you want to take look and
validate I will take a look later in the weekend.
---
T E S T S
---
Running org.apache.maven.model.building.ComplexActi
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44749028
Any updates on my pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user MysterionRise opened a pull request:
https://github.com/apache/maven/pull/16
[MNG-4565] Multiple profile activation conditions does not work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MysterionRise/maven MNG-4565
43 matches
Mail list logo
