Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-13 Thread Benedikt Ritter
Tibor Digana schrieb am Di., 11. Okt. 2016 um 10:01 Uhr: > Both old Jenkins builds [1] already use JDK 8. > So this should not be a problem. > Perfect! I have something put together in a local branch. I think you're going to like it :-) > > [1] >

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-11 Thread Tibor Digana
Both old Jenkins builds [1] already use JDK 8. So this should not be a problem. [1] https://builds.apache.org/job/maven-surefire/ https://builds.apache.org/job/maven-surefire-windows/ On Mon, Oct 10, 2016 at 7:03 PM, Benedikt Ritter [via Maven] < ml-node+s40175n5882750...@n5.nabble.com> wrote:

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-10 Thread Benedikt Ritter
Hello again, Tibor Digana schrieb am Mi., 5. Okt. 2016 um 00:05 Uhr: > >>Or do we want to even share the test projects and work with profiles in > the test project pom? > > I mean this. > > It pretty depends on what we are going to test, either: > + features of

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-09 Thread Benedikt Ritter
Hello Tibor, I've played around a bit with the idea and I think there is a problem: If you want to compile and run test using JUnit 4 annotations using JUnit 5, you need the vintage enigne in your dependencies. Otherwise you get compile errors, because neither jupiter engine nor jupiter api ship

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-09 Thread Benedikt Ritter
Hello Tibor, I think I understand what you're thinking of. I'll give it a try and see if I can come up with something useful :-) Regards, Benedikt Tibor Digana schrieb am Mi., 5. Okt. 2016 um 00:18 Uhr: > Instead of using in Surefire (may affect the > ITs), there

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-04 Thread Tibor Digana
Instead of using in Surefire (may affect the ITs), there is a better trick. See the POM surefire-junit47. You will see the section of compiler endorsed classpath but Surefire has different one: maven-dependency-plugin main process-sources copy

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-04 Thread Tibor Digana
>>Or do we want to even share the test projects and work with profiles in the test project pom? I mean this. It pretty depends on what we are going to test, either: + features of surefire-junit5 provider, or + features of junit5 itself. I would say the provider in the first phase, and in the

[SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-04 Thread Benedikt Ritter
Hello Tibor, Tibor Digana schrieb am Di., 4. Okt. 2016 um 02:29 Uhr: > Can you simplify and speed up writing integration tests in the way that you > would parameterize the existing JUnit 4 testing by adding Maven profiles > (one default profile and junit5 profile)