[RESULT] [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-17 Thread Tibor Digana 
Hi,

The vote has passed with the following result:

+1 : Romain Manni-Bucau, Michael Opsipov, Hervé BOUTEMY, Dan Tran, Enrico
Olivelli, Tibor Digana
  0 : none
-1 : none.

PMC quorum: accomplished.
I will promote the artifacts to the central repo.

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-17 Thread Tibor Digana 
Thank you, the vote has finished.
+1 : Romain Manni-Bucau, Michael Opsipov, Hervé BOUTEMY, Dan Tran, Enrico
Olivelli, Tibor Digana
  0 : none
-1 : none.

On Tue, Jun 16, 2020 at 11:50 PM Tibor Digana 
wrote:

> +1
>
>
> On Sat, Jun 13, 2020 at 3:46 PM Tibor Digana 
> wrote:
>
>> Hi,
>>
>> We solved 40 issues:
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12344612
>>
>> There are still a couple of issues left in JIRA:
>>
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1590/
>>
>> https://repository.apache.org/content/repositories/maven-1590/org/apache/maven/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
>>
>> Source release checksum(s):
>> surefire-3.0.0-M5-source-release.zip  sha1:
>> 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
>> surefire-3.0.0-M5-source-release.zip  sha512:
>> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f091081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
>>
>> Staging site:
>> http://maven.apache.org/surefire-archives/surefire-LATEST/
>>
>> Guide to testing staged releases:
>> http://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Cheers
>> Tibor
>>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-16 Thread Tibor Digana 
+1


On Sat, Jun 13, 2020 at 3:46 PM Tibor Digana  wrote:

> Hi,
>
> We solved 40 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12344612
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1590/
>
> https://repository.apache.org/content/repositories/maven-1590/org/apache/maven/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
>
> Source release checksum(s):
> surefire-3.0.0-M5-source-release.zip  sha1:
> 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> surefire-3.0.0-M5-source-release.zip  sha512:
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f091081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-15 Thread Enrico Olivelli 
+1 (non binding)
- checksums ok
- built locally on Fedora + JDK14, all tests passed (mvn install -Prun-its)
- Tested with a few projects, even with the new TCP implementation

Thank you Tibor for putting this all together



Enrico

Il giorno dom 14 giu 2020 alle ore 23:46 Dan Tran  ha
scritto:

> +1 tested with our 300+ maven modules build
>
> Found the following new 'good' behaviors/fixes
>
>1. Junit 4 test class now have 'public' scope at both class and method
> level.
>2. Exception at test 'setup' ( ie @Before) now show up as failures, They
> are ignored at M4
>
> Great works
>
> Thanks
>
>
>
> On Sat, Jun 13, 2020 at 3:40 PM Tibor Digana 
> wrote:
>
> > Hi Herve,
> >
> > We can fork the discussion about this problem apart in the Slack.
> > Thx for finding this.
> >
> > T
> >
> >
> > On Sat, Jun 13, 2020 at 9:35 PM Hervé BOUTEMY 
> > wrote:
> >
> > > +1
> > >
> > > near full reproducibility of reference artifacts with JDK 8 on Windows:
> > 48
> > > artifacts are ok, just 2 still have issues:
> > > - surefire-3.0.0-M5-source-release.zip: I don't know why my local build
> > > added 3 dependency-reduced-pom.xml that do not exist in reference build
> > > - surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for
> some
> > > shaded content, probably a subtle maven-shade-plugin bug
> > >
> > > Regards,
> > >
> > > Hervé
> > >
> > > Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit :
> > > > Hi,
> > > >
> > > > We solved 40 issues:
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927
> > > > rsion=12344612
> > > >
> > > > There are still a couple of issues left in JIRA:
> > > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20
> > > > status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > > >
> > > > Staging repo:
> > > > https://repository.apache.org/content/repositories/maven-1590/
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/maven-1590/org/apache/mav
> > > > en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
> > > >
> > > > Source release checksum(s):
> > > > surefire-3.0.0-M5-source-release.zip  sha1:
> > > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> > > > surefire-3.0.0-M5-source-release.zip  sha512:
> > > >
> > >
> >
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0
> > > > 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
> > > >
> > > > Staging site:
> > > > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > > >
> > > > Guide to testing staged releases:
> > > >
> http://maven.apache.org/guides/development/guide-testing-releases.html
> > > >
> > > > Vote open for 72 hours.
> > > >
> > > > [ ] +1
> > > > [ ] +0
> > > > [ ] -1
> > > >
> > > > Cheers
> > > > Tibor
> > >
> > >
> > >
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > >
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-14 Thread Dan Tran 
+1 tested with our 300+ maven modules build

Found the following new 'good' behaviors/fixes

   1. Junit 4 test class now have 'public' scope at both class and method
level.
   2. Exception at test 'setup' ( ie @Before) now show up as failures, They
are ignored at M4

Great works

Thanks



On Sat, Jun 13, 2020 at 3:40 PM Tibor Digana  wrote:

> Hi Herve,
>
> We can fork the discussion about this problem apart in the Slack.
> Thx for finding this.
>
> T
>
>
> On Sat, Jun 13, 2020 at 9:35 PM Hervé BOUTEMY 
> wrote:
>
> > +1
> >
> > near full reproducibility of reference artifacts with JDK 8 on Windows:
> 48
> > artifacts are ok, just 2 still have issues:
> > - surefire-3.0.0-M5-source-release.zip: I don't know why my local build
> > added 3 dependency-reduced-pom.xml that do not exist in reference build
> > - surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for some
> > shaded content, probably a subtle maven-shade-plugin bug
> >
> > Regards,
> >
> > Hervé
> >
> > Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit :
> > > Hi,
> > >
> > > We solved 40 issues:
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927
> > > rsion=12344612
> > >
> > > There are still a couple of issues left in JIRA:
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20
> > > status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1590/
> > >
> >
> https://repository.apache.org/content/repositories/maven-1590/org/apache/mav
> > > en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
> > >
> > > Source release checksum(s):
> > > surefire-3.0.0-M5-source-release.zip  sha1:
> > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> > > surefire-3.0.0-M5-source-release.zip  sha512:
> > >
> >
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0
> > > 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
> > >
> > > Staging site:
> > > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >
> > > Guide to testing staged releases:
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > Cheers
> > > Tibor
> >
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-14 Thread Enrico Olivelli 
John
This is the best forum but please start another email thread. This is the
official VOTE thread

Thanks for reporting your finding. It is very precious

Enrico

Il Dom 14 Giu 2020, 21:45 John Patrick  ha scritto:

> What is the best forum to discuss issues or configuration around
> compiler, surefire and jpms?
>
> Most of the issues I have, seam to be resolved with 3.0.0-M5, but;
> - already raising issue with IntelliJ now as they don't support 2
> module-info.java files in the same project, one under src/main/java
> and the other under src/test/java.
> - how can package private methods be tested? as compiler is now seeing
> the new test module-info.java but complaining about package exists in
> main and test module-info.
> - i might be making things more complex as i've using src/main/java
> and src/test/java for java 8 code, and src/main/java11 and
> src/test/java11 for java 11 code base. so creating multi version jars.
> java 8 builds an tests, then java 11 does verify, i then rebuild and
> test fully on java 11.
>
> John
>
>
> On Sat, 13 Jun 2020 at 23:40, Tibor Digana  wrote:
> >
> > Hi Herve,
> >
> > We can fork the discussion about this problem apart in the Slack.
> > Thx for finding this.
> >
> > T
> >
> >
> > On Sat, Jun 13, 2020 at 9:35 PM Hervé BOUTEMY 
> wrote:
> >
> > > +1
> > >
> > > near full reproducibility of reference artifacts with JDK 8 on
> Windows: 48
> > > artifacts are ok, just 2 still have issues:
> > > - surefire-3.0.0-M5-source-release.zip: I don't know why my local build
> > > added 3 dependency-reduced-pom.xml that do not exist in reference build
> > > - surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for
> some
> > > shaded content, probably a subtle maven-shade-plugin bug
> > >
> > > Regards,
> > >
> > > Hervé
> > >
> > > Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit :
> > > > Hi,
> > > >
> > > > We solved 40 issues:
> > > >
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927
> > > > rsion=12344612
> > > >
> > > > There are still a couple of issues left in JIRA:
> > > >
> > >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20
> > > > status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > > >
> > > > Staging repo:
> > > > https://repository.apache.org/content/repositories/maven-1590/
> > > >
> > >
> https://repository.apache.org/content/repositories/maven-1590/org/apache/mav
> > > > en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
> > > >
> > > > Source release checksum(s):
> > > > surefire-3.0.0-M5-source-release.zip  sha1:
> > > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> > > > surefire-3.0.0-M5-source-release.zip  sha512:
> > > >
> > >
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0
> > > > 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
> > > >
> > > > Staging site:
> > > > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > > >
> > > > Guide to testing staged releases:
> > > >
> http://maven.apache.org/guides/development/guide-testing-releases.html
> > > >
> > > > Vote open for 72 hours.
> > > >
> > > > [ ] +1
> > > > [ ] +0
> > > > [ ] -1
> > > >
> > > > Cheers
> > > > Tibor
> > >
> > >
> > >
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > >
> > >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-14 Thread John Patrick 
What is the best forum to discuss issues or configuration around
compiler, surefire and jpms?

Most of the issues I have, seam to be resolved with 3.0.0-M5, but;
- already raising issue with IntelliJ now as they don't support 2
module-info.java files in the same project, one under src/main/java
and the other under src/test/java.
- how can package private methods be tested? as compiler is now seeing
the new test module-info.java but complaining about package exists in
main and test module-info.
- i might be making things more complex as i've using src/main/java
and src/test/java for java 8 code, and src/main/java11 and
src/test/java11 for java 11 code base. so creating multi version jars.
java 8 builds an tests, then java 11 does verify, i then rebuild and
test fully on java 11.

John


On Sat, 13 Jun 2020 at 23:40, Tibor Digana  wrote:
>
> Hi Herve,
>
> We can fork the discussion about this problem apart in the Slack.
> Thx for finding this.
>
> T
>
>
> On Sat, Jun 13, 2020 at 9:35 PM Hervé BOUTEMY  wrote:
>
> > +1
> >
> > near full reproducibility of reference artifacts with JDK 8 on Windows: 48
> > artifacts are ok, just 2 still have issues:
> > - surefire-3.0.0-M5-source-release.zip: I don't know why my local build
> > added 3 dependency-reduced-pom.xml that do not exist in reference build
> > - surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for some
> > shaded content, probably a subtle maven-shade-plugin bug
> >
> > Regards,
> >
> > Hervé
> >
> > Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit :
> > > Hi,
> > >
> > > We solved 40 issues:
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927
> > > rsion=12344612
> > >
> > > There are still a couple of issues left in JIRA:
> > >
> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20
> > > status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1590/
> > >
> > https://repository.apache.org/content/repositories/maven-1590/org/apache/mav
> > > en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
> > >
> > > Source release checksum(s):
> > > surefire-3.0.0-M5-source-release.zip  sha1:
> > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> > > surefire-3.0.0-M5-source-release.zip  sha512:
> > >
> > e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0
> > > 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
> > >
> > > Staging site:
> > > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >
> > > Guide to testing staged releases:
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > Cheers
> > > Tibor
> >
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-13 Thread Tibor Digana 
Hi Herve,

We can fork the discussion about this problem apart in the Slack.
Thx for finding this.

T


On Sat, Jun 13, 2020 at 9:35 PM Hervé BOUTEMY  wrote:

> +1
>
> near full reproducibility of reference artifacts with JDK 8 on Windows: 48
> artifacts are ok, just 2 still have issues:
> - surefire-3.0.0-M5-source-release.zip: I don't know why my local build
> added 3 dependency-reduced-pom.xml that do not exist in reference build
> - surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for some
> shaded content, probably a subtle maven-shade-plugin bug
>
> Regards,
>
> Hervé
>
> Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit :
> > Hi,
> >
> > We solved 40 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927
> > rsion=12344612
> >
> > There are still a couple of issues left in JIRA:
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20
> > status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1590/
> >
> https://repository.apache.org/content/repositories/maven-1590/org/apache/mav
> > en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
> >
> > Source release checksum(s):
> > surefire-3.0.0-M5-source-release.zip  sha1:
> > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> > surefire-3.0.0-M5-source-release.zip  sha512:
> >
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0
> > 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-13 Thread Tibor Digana 
A big "Thank You" goes to our user and contributor Jonathan Bell who is
Assistant Professor at the George Mason University, his students, and our
Apache colleague Enrico Olivelli.
Of course a big "Thank You" goes to our Apache Maven team.

Along we speeded up the plugin with short startup and teardown time of
forked JVM. We made faster communication on the TCP level and process pipes
level as well.

Additionally, we improved smart resolver of JUnit5 Engines and fixed some
issues, see
https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
Regarding the JPMS, now the users can have "module-info.java" in
src/test/java. Here the user should be more careful if the module
descriptor was used in his project due to the behavior is determined by
this descriptor. For more information, see
https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/jpms.apt.vm

On Sat, Jun 13, 2020 at 10:02 PM Tibor Digana 
wrote:

> Yes, thank you Enrico.
>
> After a long time, we found a good reason to fix annoying issues which
> requires reworking some parts of the code. And also we were able to let the
> users use their implementation without asking us in Apache.
> We touched the milestone release where we could introduce the feature and
> let the people enable a new functionality.
>
> Maybe you guys know that the Surefire and Failsafe plugins were using
> std/in and std/out (pipes) as interprocess communication between Maven
> process and forked JVM.
> Often the users, especially the OSGi users, claimed that these pipes
> should be used by the tests.
> Additionally, there was a request, from one of our users at GitHub, that
> the Surefire fork VMs should be capable of distributing the load in
> horizontal direction (hardware) which would first of all require a new
> abstraction and communication facilities.
> Today we are able to accomplish this!
>
> We have introduced an abstraction which allows the users to implement
> their own communication facilities for their purposes.
> Of course, we provided two internal implementations.
> One defaults to the traditional pipes, and the second is using TCP/IP
> channels with authentication.
> The second implementation is especially interesting because you can enable
> a new way of communication using the TCP sockets:
>
>  implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>
>
>
> The std/out and std/err would be ready for use in your tests.
> One may ask, why we did not enable this TCP/IP channel by default.
> We want to let the users adapt first and check it out.
> Feel free to let us know about your findings.
>
> This approach gave you a certain freedom. For instance you can configure
> your extension.
> In the future we may introduce "bindAddress" in SurefireForkNodeFactory
> but this can be also done by the user:
>
>  implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory">
>
> 192.168.10.15
> 
>
> In the references you can find the documentation to the Extension API and
> SPI.
> This may help you out on implementing your own extensions.
>
> References:
>
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/process-communication.vm
>
>
>
>
>
>
> On Sat, Jun 13, 2020 at 9:15 PM Enrico Olivelli 
> wrote:
>
>> (I will cast my final vote on Monday)
>> Tibor
>> It is worth to note that this release includes the new communication
>> protocol between Maven and the forked JVM.
>> Can you please share a bit of help about how to try it?
>>
>> This is a great release of surefire, it is a big milestone for Maven and
>> Surefire
>>
>>
>> Enrico
>>
>> Il Sab 13 Giu 2020, 20:50 Michael Osipov  ha
>> scritto:
>>
>> > Am 2020-06-13 um 15:46 schrieb Tibor Digana:
>> > > Hi,
>> > >
>> > > We solved 40 issues:
>> > >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12344612
>> > >
>> > > There are still a couple of issues left in JIRA:
>> > >
>> >
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>> > >
>> > > Staging repo:
>> > > https://repository.apache.org/content/repositories/maven-1590/
>> > >
>> >
>> https://repository.apache.org/content/repositories/maven-1590/org/apache/maven/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
>> > >
>> > > Source release checksum(s):
>> > > surefire-3.0.0-M5-source-release.zip  sha1:
>> > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
>> > > surefire-3.0.0-M5-source-release.zip  sha512:
>> > >
>> >
>> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f091081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
>> > >
>> > > Staging site:
>> > > http://maven.apache.org/surefire-archives/surefire-LATEST/
>> > >
>> > > Guide to testing staged releases:
>> > >
>>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-13 Thread Tibor Digana 
Yes, thank you Enrico.

After a long time, we found a good reason to fix annoying issues which
requires reworking some parts of the code. And also we were able to let the
users use their implementation without asking us in Apache.
We touched the milestone release where we could introduce the feature and
let the people enable a new functionality.

Maybe you guys know that the Surefire and Failsafe plugins were using
std/in and std/out (pipes) as interprocess communication between Maven
process and forked JVM.
Often the users, especially the OSGi users, claimed that these pipes should
be used by the tests.
Additionally, there was a request, from one of our users at GitHub, that
the Surefire fork VMs should be capable of distributing the load in
horizontal direction (hardware) which would first of all require a new
abstraction and communication facilities.
Today we are able to accomplish this!

We have introduced an abstraction which allows the users to implement their
own communication facilities for their purposes.
Of course, we provided two internal implementations.
One defaults to the traditional pipes, and the second is using TCP/IP
channels with authentication.
The second implementation is especially interesting because you can enable
a new way of communication using the TCP sockets:




The std/out and std/err would be ready for use in your tests.
One may ask, why we did not enable this TCP/IP channel by default.
We want to let the users adapt first and check it out.
Feel free to let us know about your findings.

This approach gave you a certain freedom. For instance you can configure
your extension.
In the future we may introduce "bindAddress" in SurefireForkNodeFactory but
this can be also done by the user:



192.168.10.15


In the references you can find the documentation to the Extension API and
SPI.
This may help you out on implementing your own extensions.

References:
https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/process-communication.vm






On Sat, Jun 13, 2020 at 9:15 PM Enrico Olivelli  wrote:

> (I will cast my final vote on Monday)
> Tibor
> It is worth to note that this release includes the new communication
> protocol between Maven and the forked JVM.
> Can you please share a bit of help about how to try it?
>
> This is a great release of surefire, it is a big milestone for Maven and
> Surefire
>
>
> Enrico
>
> Il Sab 13 Giu 2020, 20:50 Michael Osipov  ha scritto:
>
> > Am 2020-06-13 um 15:46 schrieb Tibor Digana:
> > > Hi,
> > >
> > > We solved 40 issues:
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12344612
> > >
> > > There are still a couple of issues left in JIRA:
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1590/
> > >
> >
> https://repository.apache.org/content/repositories/maven-1590/org/apache/maven/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
> > >
> > > Source release checksum(s):
> > > surefire-3.0.0-M5-source-release.zip  sha1:
> > > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> > > surefire-3.0.0-M5-source-release.zip  sha512:
> > >
> >
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f091081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
> > >
> > > Staging site:
> > > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >
> > > Guide to testing staged releases:
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for 72 hours.
> >
> > Massive and impressive!
> >
> > +1
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-13 Thread Hervé BOUTEMY 
+1

near full reproducibility of reference artifacts with JDK 8 on Windows: 48 
artifacts are ok, just 2 still have issues:
- surefire-3.0.0-M5-source-release.zip: I don't know why my local build added 3 
dependency-reduced-pom.xml that do not exist in reference build
- surefire-shadefire-3.0.0-M5.jar: some strange timestamp issues for some 
shaded content, probably a subtle maven-shade-plugin bug

Regards,

Hervé

Le samedi 13 juin 2020, 15:46:10 CEST Tibor Digana a écrit :
> Hi,
> 
> We solved 40 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927
> rsion=12344612
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20
> status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1590/
> https://repository.apache.org/content/repositories/maven-1590/org/apache/mav
> en/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
> 
> Source release checksum(s):
> surefire-3.0.0-M5-source-release.zip  sha1:
> 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> surefire-3.0.0-M5-source-release.zip  sha512:
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f0
> 91081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
> 
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
> 
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> Cheers
> Tibor





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-13 Thread Enrico Olivelli 
(I will cast my final vote on Monday)
Tibor
It is worth to note that this release includes the new communication
protocol between Maven and the forked JVM.
Can you please share a bit of help about how to try it?

This is a great release of surefire, it is a big milestone for Maven and
Surefire


Enrico

Il Sab 13 Giu 2020, 20:50 Michael Osipov  ha scritto:

> Am 2020-06-13 um 15:46 schrieb Tibor Digana:
> > Hi,
> >
> > We solved 40 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12344612
> >
> > There are still a couple of issues left in JIRA:
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1590/
> >
> https://repository.apache.org/content/repositories/maven-1590/org/apache/maven/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
> >
> > Source release checksum(s):
> > surefire-3.0.0-M5-source-release.zip  sha1:
> > 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> > surefire-3.0.0-M5-source-release.zip  sha512:
> >
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f091081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
>
> Massive and impressive!
>
> +1
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-13 Thread Michael Osipov 

Am 2020-06-13 um 15:46 schrieb Tibor Digana:

Hi,

We solved 40 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12344612

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1590/
https://repository.apache.org/content/repositories/maven-1590/org/apache/maven/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip

Source release checksum(s):
surefire-3.0.0-M5-source-release.zip  sha1:
687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
surefire-3.0.0-M5-source-release.zip  sha512:
e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f091081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7

Staging site:
http://maven.apache.org/surefire-archives/surefire-LATEST/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.


Massive and impressive!

+1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-13 Thread Romain Manni-Bucau 
Mainly just ran some sanity checks but looks ok, +1 (non binding)

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le sam. 13 juin 2020 à 15:46, Tibor Digana  a
écrit :

> Hi,
>
> We solved 40 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12344612
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1590/
>
> https://repository.apache.org/content/repositories/maven-1590/org/apache/maven/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip
>
> Source release checksum(s):
> surefire-3.0.0-M5-source-release.zip  sha1:
> 687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
> surefire-3.0.0-M5-source-release.zip  sha512:
>
> e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f091081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>

[VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M5

2020-06-13 Thread Tibor Digana 
Hi,

We solved 40 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12344612

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1590/
https://repository.apache.org/content/repositories/maven-1590/org/apache/maven/surefire/surefire/3.0.0-M5/surefire-3.0.0-M5-source-release.zip

Source release checksum(s):
surefire-3.0.0-M5-source-release.zip  sha1:
687a89ceb4a1b2e5dd472deec8d3843f2a98b68f
surefire-3.0.0-M5-source-release.zip  sha512:
e88ced058923b349acfe1948d4c4a7ff6f4bef08e5685f2f2ac73cfb26ad35fd6578f05309f091081f01986b19bbca38a2fe6bf0fbd16980cd6f41228c529ee7

Staging site:
http://maven.apache.org/surefire-archives/surefire-LATEST/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Cheers
Tibor