Re: ASF Source Assembly now contains .gitignore and .gitattributes
> > On one hand, we all agree that .gitignore and .gitattributes (and so > > on) are useful when building a project (prior to the final packaging). > > The primary purpose of those files are git commands. > Having them evaluated by other tools is kind of unexpected (at least for > me)... Well, giving it a second thought, I have to agree that the primary purpose of those files are git commands, and it might not be a good idea to depend on them to be able to build the project. OTOH, if *source-release.zip files act as just the zip source distribution of the repository (similar to doing the "Download ZIP" from GitHub), then it makes sense that it includes those files, but it also means that every other file should also be included (eg. .cvsignore), but if the intention of the *source-release.zip files is to have a "clean" distribution of the source distribution then yes I agree that they should be filtered. In the end, it might be a matter of preference and/or configuration, Apache Calcite uses .gitattribute in the build, but many others might not need them, so a configurable option make sense here. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: ASF Source Assembly now contains .gitignore and .gitattributes
> On one hand, we all agree that .gitignore and .gitattributes (and so > on) are useful when building a project (prior to the final packaging). The primary purpose of those files are git commands. Having them evaluated by other tools is kind of unexpected (at least for me)... We already strip some other metadata which may potentially be evaluated during build as well (https://github.com/codehaus-plexus/plexus-utils/blob/7f5114af7d0c4d19838a9e0082758ec0f5e0269e/src/main/java/org/codehaus/plexus/util/AbstractScanner.java#L55). What about ".cvsignore"? That may be evaluated during build time as well. I agree that given the circumstances we should not try to strip too many things from either .jar, .source.jar or source.zip. Not sure if we need to actually reduce the default excludes from https://github.com/codehaus-plexus/plexus-utils/blob/7f5114af7d0c4d19838a9e0082758ec0f5e0269e/src/main/java/org/codehaus/plexus/util/AbstractScanner.java#L55 even further... Konrad - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: ASF Source Assembly now contains .gitignore and .gitattributes
Hi, There might be some confusion here, at least I'm a little confused with this thread. On one hand, we all agree that .gitignore and .gitattributes (and so on) are useful when building a project (prior to the final packaging). On the other hand, once the project is built is useless to have a .gitignore/.gitattribute, etc. on the final JAR package, this applies to maven-jar-plugin, maven-source-plugin, maven-javadoc-plugin and so on... Since the source-release-assembly generates a buildable release project, then it makes sense to include .gitignore/.gitattributes on the *source-release.zip file. On Fri, Sep 16, 2022 at 11:21 AM Slawomir Jaranowski wrote: > > Hi, > > Also apache-rat-plugin use .gitignore for skipping verification > > pt., 16 wrz 2022 o 11:14 Michael Osipov napisał(a): > > > Am 2022-09-16 um 11:03 schrieb Vladimir Sitnikov: > > >> “.gitignore” and “.gitattributes” files > > > > > > .gitignore and .gitattributes can easily be helpful during the build, so > > it > > > does sound strange to exclude them. > > > > > > For instance, Apache Calcite uses .gitattribute to configure that > > specific > > > files should have an "executable" bit in the resulting tar.gz archive: > > > > > https://github.com/apache/calcite/blob/e41555f568510df04d3883516b2195393a93426d/.gitattributes#L20-L21 > > > If one deletes the .gitattributes file, the resulting tar.gz will be > > broken. > > > > > > It does sound strange to me to exclude .gitattributes and .gitignore on > > the > > > basis of "SCM specific metadata". > > > > This is something I need to crunch on. Thanks for raising... > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- > Sławomir Jaranowski - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: ASF Source Assembly now contains .gitignore and .gitattributes
Hi, Also apache-rat-plugin use .gitignore for skipping verification pt., 16 wrz 2022 o 11:14 Michael Osipov napisał(a): > Am 2022-09-16 um 11:03 schrieb Vladimir Sitnikov: > >> “.gitignore” and “.gitattributes” files > > > > .gitignore and .gitattributes can easily be helpful during the build, so > it > > does sound strange to exclude them. > > > > For instance, Apache Calcite uses .gitattribute to configure that > specific > > files should have an "executable" bit in the resulting tar.gz archive: > > > https://github.com/apache/calcite/blob/e41555f568510df04d3883516b2195393a93426d/.gitattributes#L20-L21 > > If one deletes the .gitattributes file, the resulting tar.gz will be > broken. > > > > It does sound strange to me to exclude .gitattributes and .gitignore on > the > > basis of "SCM specific metadata". > > This is something I need to crunch on. Thanks for raising... > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Sławomir Jaranowski
Re: ASF Source Assembly now contains .gitignore and .gitattributes
Am 2022-09-16 um 11:03 schrieb Vladimir Sitnikov: “.gitignore” and “.gitattributes” files .gitignore and .gitattributes can easily be helpful during the build, so it does sound strange to exclude them. For instance, Apache Calcite uses .gitattribute to configure that specific files should have an "executable" bit in the resulting tar.gz archive: https://github.com/apache/calcite/blob/e41555f568510df04d3883516b2195393a93426d/.gitattributes#L20-L21 If one deletes the .gitattributes file, the resulting tar.gz will be broken. It does sound strange to me to exclude .gitattributes and .gitignore on the basis of "SCM specific metadata". This is something I need to crunch on. Thanks for raising... - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: ASF Source Assembly now contains .gitignore and .gitattributes
>“.gitignore” and “.gitattributes” files .gitignore and .gitattributes can easily be helpful during the build, so it does sound strange to exclude them. For instance, Apache Calcite uses .gitattribute to configure that specific files should have an "executable" bit in the resulting tar.gz archive: https://github.com/apache/calcite/blob/e41555f568510df04d3883516b2195393a93426d/.gitattributes#L20-L21 If one deletes the .gitattributes file, the resulting tar.gz will be broken. It does sound strange to me to exclude .gitattributes and .gitignore on the basis of "SCM specific metadata". Vladimir
Re: ASF Source Assembly now contains .gitignore and .gitattributes
Am 2022-09-14 um 08:48 schrieb Konrad Windszus: I believe that all file files which are necessary for CI, SCM and others are not required to be build in that build and are just noise. So I'd be in favor of a PR for this. Michael Thanks for the comment. As such excludes are useful for all packaging plugins WDYT about maintaining such an extended default excludes list in https://codehaus-plexus.github.io/plexus-archiver/apidocs/org/codehaus/plexus/archiver/Archiver.html instead of maintaining it per Maven plugin? I think this makes sense to have common non-SCM excludes like CI files and other stuff which are not related to the build itself. I am thinking about adding an addExtendedDefaultExcludes() to Archive which does the skipping when creating the archive (in addition to the limited default excludes from p-u Scanner skipping while listing files). Obviously the javadoc must outline the differences between the two exclude sets. To be on the safe side, it would probably make sense to make the extended default excludes of Archiver a real superset of the default excludes of p-u Scanner (and therefore also the derived PlexusIoFileResourceCollection. I like the idea of the default super set. The bigger one includes the smaller one and yet you can override if necesssary. Willing to review a PR if you want to work on it. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: ASF Source Assembly now contains .gitignore and .gitattributes
> I believe that all file files which are necessary for CI, SCM and others > are not required to be build in that build and are just noise. So I'd be > in favor of a PR for this. > > Michael Thanks for the comment. As such excludes are useful for all packaging plugins WDYT about maintaining such an extended default excludes list in https://codehaus-plexus.github.io/plexus-archiver/apidocs/org/codehaus/plexus/archiver/Archiver.html instead of maintaining it per Maven plugin? I am thinking about adding an addExtendedDefaultExcludes() to Archive which does the skipping when creating the archive (in addition to the limited default excludes from p-u Scanner skipping while listing files). Obviously the javadoc must outline the differences between the two exclude sets. To be on the safe side, it would probably make sense to make the extended default excludes of Archiver a real superset of the default excludes of p-u Scanner (and therefore also the derived PlexusIoFileResourceCollection. WDYT? Konrad - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: ASF Source Assembly now contains .gitignore and .gitattributes
Am 2022-09-13 um 13:51 schrieb Konrad Windszus: > Hi, > Due to the change https://github.com/codehaus-plexus/plexus-utils/commit/e8a8433894eae9e8f82cbba4b903508362e9322a all releases triggered with ASF Parent 27 contain a src.zip artifact which now also contain the previously exluded “.gitignore” and “.gitattributes” files. > The descriptor defining its format is set in https://github.com/apache/maven-apache-parent/blob/fe33d11d29d217a1c7758163d8b4ca2d8093de70/pom.xml#L405 and references http://svn.apache.org/viewvc/maven/resources/tags/apache-source-release-assembly-descriptor-1.0.6/src/main/resources/assemblies/source-shared.xml?revision=1742052=markup. The latter does not contain any SCM specific excludes but just leverages the default excludes from plexus-utils. > > IMHO we should change the descriptor to also remove SCM specific metadata, as those are IMHO never useful in the ASF source release distribution. > > Probably the same excludes should be applied to maven-source-plugin which currently also only relies on plexus-utils default excludes. > > WDYT? More that. Look at the Maven source bundle, contains useless stuff: * .github/ * Jenkinsfile * doap_Maven.rdf I believe that all file files which are necessary for CI, SCM and others are not required to be build in that build and are just noise. So I'd be in favor of a PR for this. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
ASF Source Assembly now contains .gitignore and .gitattributes
Hi, Due to the change https://github.com/codehaus-plexus/plexus-utils/commit/e8a8433894eae9e8f82cbba4b903508362e9322a all releases triggered with ASF Parent 27 contain a src.zip artifact which now also contain the previously exluded “.gitignore” and “.gitattributes” files. The descriptor defining its format is set in https://github.com/apache/maven-apache-parent/blob/fe33d11d29d217a1c7758163d8b4ca2d8093de70/pom.xml#L405 and references http://svn.apache.org/viewvc/maven/resources/tags/apache-source-release-assembly-descriptor-1.0.6/src/main/resources/assemblies/source-shared.xml?revision=1742052=markup. The latter does not contain any SCM specific excludes but just leverages the default excludes from plexus-utils. IMHO we should change the descriptor to also remove SCM specific metadata, as those are IMHO never useful in the ASF source release distribution. Probably the same excludes should be applied to maven-source-plugin which currently also only relies on plexus-utils default excludes. WDYT? Konrad - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
