Re: JavaxToolsCompiler

2015-09-18 Thread Robert Scholte
Op Fri, 18 Sep 2015 10:26:46 +0200 schreef Alan Bateman : On 17/09/2015 22:07, Robert Scholte wrote: I can confirm the fix. thanks! Robert Thanks for the confirmation. Just to double check, this is with the ToolProvider fix rather than the patch to the

Re: JavaxToolsCompiler

2015-09-18 Thread Alan Bateman
On 17/09/2015 22:07, Robert Scholte wrote: I can confirm the fix. thanks! Robert Thanks for the confirmation. Just to double check, this is with the ToolProvider fix rather than the patch to the compiler plugin that one of Stuart's mails referenced, right? As we're exchanging mail, I'm

Re: JavaxToolsCompiler

2015-09-17 Thread Robert Scholte
I can confirm the fix. thanks! Robert Op Wed, 16 Sep 2015 12:27:11 +0200 schreef Alan Bateman : On 14/09/2015 20:21, Stuart McCulloch wrote: Yes, the issue is that ToolProvider.getSystemJavaCompiler() is returning null when using the Jigsaw EA with Maven.

Re: JavaxToolsCompiler

2015-09-16 Thread Alan Bateman
On 14/09/2015 20:21, Stuart McCulloch wrote: Yes, the issue is that ToolProvider.getSystemJavaCompiler() is returning null when using the Jigsaw EA with Maven. AFAICT this is because it’s now using the service loader mechanism which is influenced by the Thread’s context ClassLoader The

JavaxToolsCompiler

2015-09-14 Thread Robert Scholte
Hi, On behalf of the Apache Maven team I'd like to ask for advice for changing the JavaxToolsCompiler[1] This implementation is used when java code is being compiled with Maven *by default*, so right now when pointing JAVA_HOME to the latest JDK9 version builds will fail. There are other

Re: JavaxToolsCompiler

2015-09-14 Thread Mandy Chung
On 09/14/2015 12:44 PM, Alan Bateman wrote: On 14/09/2015 20:21, Stuart McCulloch wrote: Yes, the issue is that ToolProvider.getSystemJavaCompiler() is returning null when using the Jigsaw EA with Maven. AFAICT this is because it’s now using the service loader mechanism which is influenced

Re: JavaxToolsCompiler

2015-09-14 Thread Robert Scholte
Op Mon, 14 Sep 2015 20:27:39 +0200 schreef Alan Bateman <alan.bate...@oracle.com>: On 14/09/2015 17:40, Robert Scholte wrote: Hi, On behalf of the Apache Maven team I'd like to ask for advice for changing the JavaxToolsCompiler[1] This implementation is used when java code is

Re: JavaxToolsCompiler

2015-09-14 Thread Alan Bateman
On 14/09/2015 17:40, Robert Scholte wrote: Hi, On behalf of the Apache Maven team I'd like to ask for advice for changing the JavaxToolsCompiler[1] This implementation is used when java code is being compiled with Maven *by default*, so right now when pointing JAVA_HOME to the latest JDK9

Re: JavaxToolsCompiler

2015-09-14 Thread Alan Bateman
On 14/09/2015 20:21, Stuart McCulloch wrote: Yes, the issue is that ToolProvider.getSystemJavaCompiler() is returning null when using the Jigsaw EA with Maven. AFAICT this is because it’s now using the service loader mechanism which is influenced by the Thread’s context ClassLoader That

Re: JavaxToolsCompiler

2015-09-14 Thread Stuart McCulloch
behalf of the Apache Maven team I'd like to ask for advice for > > changing the JavaxToolsCompiler[1] > > This implementation is used when java code is being compiled with > > Maven *by default*, so right now when pointing JAVA_HOME to the latest > > JDK9 version builds w