Re: Launcher script issues in 3.5.0.

2017-02-22 Thread Christian Schulte
Am 02/23/17 um 04:21 schrieb Igor Fedorenko: > On all platforms .mvn/ search is expected to start with directory > specified by -f parameter and keep doing "cd .." until it files .mvn/ > subdirectory or hits the filesystem root. What if I put a .mvn directory at the file system root? Will that

Re: Launcher script issues in 3.5.0.

2017-02-22 Thread Igor Fedorenko
On all platforms .mvn/ search is expected to start with directory specified by -f parameter and keep doing "cd .." until it files .mvn/ subdirectory or hits the filesystem root. The idea is to use .mvn/ subdirectory as a marker of multimodule project basedir. The build can be started from any

Re: Launcher script issues in 3.5.0.

2017-02-22 Thread Christian Schulte
Both issues seem to be related to MNG-5889. MNG-5889 branch created. If no one objects, I'll merge it to master when the build job completed successfully on Jenkins. Otherwise consider the MNG-5889 branch yours. Note: I just noticed that the Windows launcher does not stop searching for the .mvn

Re: Launcher script issues in 3.5.0.

2017-02-22 Thread Christian Schulte
Please see the attachment. Can someone please review this and apply the patches. Both launchers - Windows and Unix - should support directory names like "Spaces & Special Char" with this patch applied. I do not know what JIRA issue corresponds to these changes. Regards, -- Christian diff --git

Re: Launcher script issues in 3.5.0.

2017-02-22 Thread Christian Schulte
See the attached patch. This should make the Unix launcher support directory names like "Spaces & Special Char". At least here: SH_VERSION='@(#)PD KSH v5.2.14 99/07/13.2' Can someone review and apply this patch please. Thanks. Regards, -- Christian diff --git a/apache-maven/src/bin/mvn

Launcher script issues in 3.5.0.

2017-02-22 Thread Christian Schulte
Hi, our launchers (both Unix and Windows) still seem to be broken for directory names like "Spaces & Special Char". pwd /home/schulte $ mvn -version Apache Maven 3.5.0-SNAPSHOT (e6217a455547e5b3bcac310be18daf2a333cd5d1; 2017-02-21T01:24:24+01:00) Maven home: