Re: Open Pull Requests
Hi, I'm looking forward to the improvements introduced by Rob as well and therefore would like to kindly ask if there is a timeframe in which one which can expect the releases to happen or if there is anything additional needed to proceed? Best regards and thank you all for developing Maven! Tobias Am 02.06.2020 um 00:31 schrieb Robert Oxspring: > >>> Before we go to release stuff, will you need more changes maybe for >>> assembly plugin? >>> to make this faster and as we already did in past we can release all >>> together. >>> >> >> Great - good to know the process! >> >> I’d briefly forgotten this all started with the assembly plugin so will bump >> to SNAPSHOT dependencies locally and confirm whether further changes are >> necessary. >> > > I’ve had a quick test with SNAPSHOT versions of everything and all works as > expected. I don’t think there are any further changes I need. > > Thanks, > > Rob > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Open Pull Requests
>> Before we go to release stuff, will you need more changes maybe for >> assembly plugin? >> to make this faster and as we already did in past we can release all >> together. >> > > Great - good to know the process! > > I’d briefly forgotten this all started with the assembly plugin so will bump > to SNAPSHOT dependencies locally and confirm whether further changes are > necessary. > I’ve had a quick test with SNAPSHOT versions of everything and all works as expected. I don’t think there are any further changes I need. Thanks, Rob
Re: Open Pull Requests
>> I’d really like to get these changes into a released version of the >> resources plugin so that my team can make use of them… I presume that to do >> this we’d need to: >> >> 1. Release a Maven Shared Utils 3.3.1 (unless some other changes require a >> bigger release?) >> > > will be 3.3.0 > > >> 2. Bump Maven Filtering to use the new release >> 3. Release a Maven Filtering 3.1.2 (unless some other changes require a >> bigger release?) >> 4. Bump Maven Resource Plugin to use the new release >> 5. Release a Maven Resources Plugin 3.1.1 (unless some other changes >> require a bigger release?) >> > > I change versions to use SNAPSHOT so we can have easier testing and CI > testing all together. > > Before we go to release stuff, will you need more changes maybe for > assembly plugin? > to make this faster and as we already did in past we can release all > together. > Great - good to know the process! I’d briefly forgotten this all started with the assembly plugin so will bump to SNAPSHOT dependencies locally and confirm whether further changes are necessary. In the meantime I also took a look at a couple of issues from the backlog as a good will gesture - see https://github.com/apache/maven-shared-utils/pull/40 Thanks, Rob - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Open Pull Requests
On Wed, 27 May 2020 at 21:20, Robert Oxspring
wrote:
> Thanks all!
>
> I’d really like to get these changes into a released version of the
> resources plugin so that my team can make use of them… I presume that to do
> this we’d need to:
>
> 1. Release a Maven Shared Utils 3.3.1 (unless some other changes require a
> bigger release?)
>
will be 3.3.0
> 2. Bump Maven Filtering to use the new release
> 3. Release a Maven Filtering 3.1.2 (unless some other changes require a
> bigger release?)
> 4. Bump Maven Resource Plugin to use the new release
> 5. Release a Maven Resources Plugin 3.1.1 (unless some other changes
> require a bigger release?)
>
I change versions to use SNAPSHOT so we can have easier testing and CI
testing all together.
Before we go to release stuff, will you need more changes maybe for
assembly plugin?
to make this faster and as we already did in past we can release all
together.
>
> Is there anything I can do to help encourage or prompt (1) to happen -
> perhaps I should take a look through
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-shared-utils%20ORDER%20BY%20priority%20DESC
> <
> https://issues.apache.org/jira/issues/?jql=project%20=%20MSHARED%20AND%20resolution%20=%20Unresolved%20AND%20component%20=%20maven-shared-utils%20ORDER%20BY%20priority%20DESC>
> and see if any are easily fixable?
>
> Thanks again!
>
> Rob
>
> > On 26 May 2020, at 11:26, Olivier Lamy wrote:
> >
> > Hi
> > Thanks a lot.
> > I have merged the first one
> > 2 others moved as branch pr-{id} to check Jenkins build.
> > If no one else merged, I will finish my tomm.
> > cheers
> > Olivier
> >
> > On Tue, 26 May 2020 at 08:19, Robert Oxspring
> > wrote:
> >
> >> Hi folks,
> >>
> >>
> >> I’ve got a few open pull requests (one approved) but without any further
> >> action in the last week… is there anything I can do to encourage next
> steps
> >> towards getting the changes merged?
> >>
> >> https://github.com/apache/maven-shared-utils/pull/31 <
> >> https://github.com/apache/maven-shared-utils/pull/31>
> >>
> >> https://github.com/apache/maven-shared-utils/pull/28 <
> >> https://github.com/apache/maven-shared-utils/pull/28>
> >>
> >> https://github.com/apache/maven-filtering/pull/6 <
> >> https://github.com/apache/maven-filtering/pull/6>
> >>
> >> In terms of getting these into released versions, I presume the correct
> >> route forward is to campaign for a release of shared-utils, then bump
> >> filtering to use it and campaign for a release of that in turn?
> >>
> >> Thanks!
> >>
> >> Rob
> >
> >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
>
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Open Pull Requests
Thanks all!
I’d really like to get these changes into a released version of the resources
plugin so that my team can make use of them… I presume that to do this we’d
need to:
1. Release a Maven Shared Utils 3.3.1 (unless some other changes require a
bigger release?)
2. Bump Maven Filtering to use the new release
3. Release a Maven Filtering 3.1.2 (unless some other changes require a bigger
release?)
4. Bump Maven Resource Plugin to use the new release
5. Release a Maven Resources Plugin 3.1.1 (unless some other changes require a
bigger release?)
Is there anything I can do to help encourage or prompt (1) to happen - perhaps
I should take a look through
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-shared-utils%20ORDER%20BY%20priority%20DESC
<https://issues.apache.org/jira/issues/?jql=project%20=%20MSHARED%20AND%20resolution%20=%20Unresolved%20AND%20component%20=%20maven-shared-utils%20ORDER%20BY%20priority%20DESC>
and see if any are easily fixable?
Thanks again!
Rob
> On 26 May 2020, at 11:26, Olivier Lamy wrote:
>
> Hi
> Thanks a lot.
> I have merged the first one
> 2 others moved as branch pr-{id} to check Jenkins build.
> If no one else merged, I will finish my tomm.
> cheers
> Olivier
>
> On Tue, 26 May 2020 at 08:19, Robert Oxspring
> wrote:
>
>> Hi folks,
>>
>>
>> I’ve got a few open pull requests (one approved) but without any further
>> action in the last week… is there anything I can do to encourage next steps
>> towards getting the changes merged?
>>
>> https://github.com/apache/maven-shared-utils/pull/31 <
>> https://github.com/apache/maven-shared-utils/pull/31>
>>
>> https://github.com/apache/maven-shared-utils/pull/28 <
>> https://github.com/apache/maven-shared-utils/pull/28>
>>
>> https://github.com/apache/maven-filtering/pull/6 <
>> https://github.com/apache/maven-filtering/pull/6>
>>
>> In terms of getting these into released versions, I presume the correct
>> route forward is to campaign for a release of shared-utils, then bump
>> filtering to use it and campaign for a release of that in turn?
>>
>> Thanks!
>>
>> Rob
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Open Pull Requests
Hi
Thanks a lot.
I have merged the first one
2 others moved as branch pr-{id} to check Jenkins build.
If no one else merged, I will finish my tomm.
cheers
Olivier
On Tue, 26 May 2020 at 08:19, Robert Oxspring
wrote:
> Hi folks,
>
>
> I’ve got a few open pull requests (one approved) but without any further
> action in the last week… is there anything I can do to encourage next steps
> towards getting the changes merged?
>
> https://github.com/apache/maven-shared-utils/pull/31 <
> https://github.com/apache/maven-shared-utils/pull/31>
>
> https://github.com/apache/maven-shared-utils/pull/28 <
> https://github.com/apache/maven-shared-utils/pull/28>
>
> https://github.com/apache/maven-filtering/pull/6 <
> https://github.com/apache/maven-filtering/pull/6>
>
> In terms of getting these into released versions, I presume the correct
> route forward is to campaign for a release of shared-utils, then bump
> filtering to use it and campaign for a release of that in turn?
>
> Thanks!
>
> Rob
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Open Pull Requests
Hi folks, I’ve got a few open pull requests (one approved) but without any further action in the last week… is there anything I can do to encourage next steps towards getting the changes merged? https://github.com/apache/maven-shared-utils/pull/31 <https://github.com/apache/maven-shared-utils/pull/31> https://github.com/apache/maven-shared-utils/pull/28 <https://github.com/apache/maven-shared-utils/pull/28> https://github.com/apache/maven-filtering/pull/6 <https://github.com/apache/maven-filtering/pull/6> In terms of getting these into released versions, I presume the correct route forward is to campaign for a release of shared-utils, then bump filtering to use it and campaign for a release of that in turn? Thanks! Rob
Re: Open pull requests
Hi, yes please don't stop to help...as Robert and Enrico already mentioned every eye help.. Kind regards Karl Heinz Marbaise On 15.05.19 19:08, Robert Scholte wrote: Hi Joseph, great to hear you want to contribute, we appreciate that a lot! But you mind have noticed there are a huge amount of open issues and pull request and we simple can not catch up due to the limited amount of time and volunteers. Regarding the open PRs, I expect that most were created in a period where Maven itself was still on subversion, but the Apache Software Foundation provided read-only copies at Github. The integration between both systems was bad, we didn't get notifications and trying to patch it back to subversion was a nightmare. Things are better nowadays, but we still suffer from that period. My main activity is currently reading and writing daily e-mails and trying to get and keep everything stable.So development is not even in the top 3 activities. Going through older PRs is something that should be done, but I'm afraid it is not getting the highest priority. Don't let this be a message to stop contributing, just be aware that it requires some patience. thanks, Robert On 14-5-2019 06:21:17, Joseph Walton wrote: - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org As an interested contributor, I've opened a couple of pull requests, and it's not always clear what the next step is for a non-project-member to get things merged. To see how other PRs (https://github.com/apache/maven/pulls [https://github.com/apache/maven/pulls] -- currently, '32 open') are being handled, I thought it might make sense to chart them; chart attached. Notable: * a significant number were opened more than a year ago (as far back as 2014), haven't been merged and now have conflicts. Could they be closed? * some more recent ones are mergeable, and approved. Can these be merged? * for the other PRs in between -- do they need work, or would closing them send a clearer message? Thanks. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Open pull requests
Thank you Joseph, If you have time you can help us review the pending pulls and see if they are still useful and/or suggest changes before merge. Every eye on patches is very valuable and it helps commiters of the project in their work. Enrico Il mer 15 mag 2019, 19:08 Robert Scholte ha scritto: > Hi Joseph, > > great to hear you want to contribute, we appreciate that a lot! > But you mind have noticed there are a huge amount of open issues and pull > request and we simple can not catch up due to the limited amount of time > and volunteers. > > Regarding the open PRs, I expect that most were created in a period where > Maven itself was still on subversion, but the Apache Software Foundation > provided read-only copies at Github. > The integration between both systems was bad, we didn't get notifications > and trying to patch it back to subversion was a nightmare. > Things are better nowadays, but we still suffer from that period. > > My main activity is currently reading and writing daily e-mails and trying > to get and keep everything stable.So development is not even in the top 3 > activities. > Going through older PRs is something that should be done, but I'm afraid > it is not getting the highest priority. > > Don't let this be a message to stop contributing, just be aware that it > requires some patience. > > thanks, > Robert > > > On 14-5-2019 06:21:17, Joseph Walton wrote: > - To > unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional > commands, e-mail: dev-h...@maven.apache.org > As an interested contributor, I've opened a couple of pull requests, and > it's not always clear what the next step is for a non-project-member to get > things merged. > > To see how other PRs (https://github.com/apache/maven/pulls [ > https://github.com/apache/maven/pulls] -- currently, '32 open') are being > handled, I thought it might make sense to chart them; chart attached. > > Notable: > * a significant number were opened more than a year ago (as far back as > 2014), haven't been merged and now have conflicts. Could they be closed? > > * some more recent ones are mergeable, and approved. Can these be merged? > * for the other PRs in between -- do they need work, or would closing them > send a clearer message? > > Thanks. >
Re: Open pull requests
Hi Joseph, great to hear you want to contribute, we appreciate that a lot! But you mind have noticed there are a huge amount of open issues and pull request and we simple can not catch up due to the limited amount of time and volunteers. Regarding the open PRs, I expect that most were created in a period where Maven itself was still on subversion, but the Apache Software Foundation provided read-only copies at Github. The integration between both systems was bad, we didn't get notifications and trying to patch it back to subversion was a nightmare. Things are better nowadays, but we still suffer from that period. My main activity is currently reading and writing daily e-mails and trying to get and keep everything stable.So development is not even in the top 3 activities. Going through older PRs is something that should be done, but I'm afraid it is not getting the highest priority. Don't let this be a message to stop contributing, just be aware that it requires some patience. thanks, Robert On 14-5-2019 06:21:17, Joseph Walton wrote: - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org As an interested contributor, I've opened a couple of pull requests, and it's not always clear what the next step is for a non-project-member to get things merged. To see how other PRs (https://github.com/apache/maven/pulls [https://github.com/apache/maven/pulls] -- currently, '32 open') are being handled, I thought it might make sense to chart them; chart attached. Notable: * a significant number were opened more than a year ago (as far back as 2014), haven't been merged and now have conflicts. Could they be closed? * some more recent ones are mergeable, and approved. Can these be merged? * for the other PRs in between -- do they need work, or would closing them send a clearer message? Thanks.
Open pull requests
As an interested contributor, I've opened a couple of pull requests, and it's not always clear what the next step is for a non-project-member to get things merged. To see how other PRs (https://github.com/apache/maven/pulls -- currently, '32 open') are being handled, I thought it might make sense to chart them; chart attached. Notable: * a significant number were opened more than a year ago (as far back as 2014), haven't been merged and now have conflicts. Could they be closed? * some more recent ones are mergeable, and approved. Can these be merged? * for the other PRs in between -- do they need work, or would closing them send a clearer message? Thanks. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
