Re: Mesos Modules Design

2014-09-20 Thread Dominic Hamon
On Fri, Sep 19, 2014 at 2:43 PM, Niklas Nielsen nik...@mesosphere.io wrote: Hi Dominic, (response inlined) On 19 September 2014 13:03, Dominic Hamon dha...@twopensource.com wrote: I'm sorry, but I'm still having a hard time understanding why this needs to be dynamic. If the mesos

Re: Mesos Modules Design

2014-09-20 Thread Dominic Hamon
resending from the right account. sorry. On Fri, Sep 19, 2014 at 2:43 PM, Niklas Nielsen nik...@mesosphere.io wrote: Hi Dominic, (response inlined) On 19 September 2014 13:03, Dominic Hamon dha...@twopensource.com wrote: I'm sorry, but I'm still having a hard time understanding why this

Re: Review Request 25868: Refactor Libprocess: class ProcessReference

2014-09-20 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/#review54077 --- 3rdparty/libprocess/include/process/process_reference.hpp

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-20 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54078 --- src/master/master.cpp

Re: Review Request 25569: Refactor test environment validations

2014-09-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/ --- (Updated Sept. 20, 2014, 5:09 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25868: Refactor Libprocess: class ProcessReference

2014-09-20 Thread Joris Van Remoortere
On Sept. 20, 2014, 2:24 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/process_reference.hpp, line 9 https://reviews.apache.org/r/25868/diff/1/?file=698470#file698470line9 i wonder if we can still need this at all. would just having a std::shared_ptrSomeProcess

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- (Updated Sept. 20, 2014, 6:46 p.m.) Review request for mesos, Adam B and Ben

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- (Updated Sept. 20, 2014, 6:46 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54085 --- Bad patch! Reviews applied: [25866] Failed command:

Re: Review Request 25868: Refactor Libprocess: class ProcessReference

2014-09-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/#review54086 --- Thanks Joris! Any reason you want this exposed in the public