---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
(Updated Sept. 26, 2014, 6:09 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/#review54652
---
Patch looks great!
Reviews applied: [25848, 26071]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54654
---
Patch looks great!
Reviews applied: [26069]
All tests passed.
-
On Sept. 25, 2014, 11:48 p.m., Michael Park wrote:
Could you do a drive-by fix here to make the
[web](http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/)
version display the C++11 whitelist correctly? It seems to display
correctly on
On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, lines 96-99
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96
Why would the iterator be called `containerizer`?
s/containerizer/iterator/ ?
Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/
---
(Updated Sept. 26, 2014, 12:32 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/#review54676
---
Patch looks great!
Reviews applied: [25622]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/
---
(Updated Sept. 26, 2014, 3:31 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/#review54685
---
Please rebase to master as that function has diverged.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/
---
(Updated Sept. 26, 2014, 4:01 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/#review54695
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22994/#review54697
---
I'm discarding this review and will cleanup the patch, and create a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/#review54698
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/#review54699
---
src/Makefile.am
https://reviews.apache.org/r/25551/#comment94959
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54700
---
.gitignore-template
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/
---
Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
Bugs: mesos-1808
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54707
---
.gitignore-template
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54709
---
what version of clang-format does this expect? 3.5?
- Dominic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/
---
(Updated Sept. 26, 2014, 11:32 a.m.)
Review request for mesos, Bernd Mathiske,
See https://builds.apache.org/job/mesos-reviewbot/1735/
--
[...truncated 5409 lines...]
rm -f zookeeper/.deps/.dirstamp
rm -f zookeeper/.dirstamp
rm -f log/tool/*.lo
rm -f logging/*.o
rm -f logging/*.lo
rm -f master/*.o
rm -f master/*.lo
rm -f messages/*.o
20140926-184824-3176252227-40593-2591-0
I0926 18:48:24.313763 2620 authenticatee.hpp:219] Received SASL authentication
mechanisms: CRAM-MD5
I0926 18:48:24.313786 2620 authenticatee.hpp:245] Attempting to authenticate
with mechanism 'CRAM-MD5'
I0926 18:48:24.313823 2620 authenticator.hpp:262] Received
On Sept. 26, 2014, 5:48 p.m., Timothy Chen wrote:
.gitignore-template, line 27
https://reviews.apache.org/r/26069/diff/1/?file=705927#file705927line27
You're adding a .clang-format in the root folder but also git ignoring
it the same time. Will this file change on the fly?
Good
On Sept. 26, 2014, 6:31 p.m., Dominic Hamon wrote:
.gitignore-template, line 27
https://reviews.apache.org/r/26069/diff/1/?file=705927#file705927line27
i think it's better to put the contents of support/clang-format into
.clang-format and not ignore it.
How about keeping things
On Sept. 26, 2014, 6:31 p.m., Dominic Hamon wrote:
what version of clang-format does this expect? 3.5?
Yes. `clang-format-3.5` is expected.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26100/
---
Review request for mesos, Ben Mahler and Dominic Hamon.
Bugs: MESOS-1744
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26103/
---
Review request for mesos, Ben Mahler and Dominic Hamon.
Bugs: MESOS-1744
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26101/
---
Review request for mesos, Ben Mahler and Dominic Hamon.
Bugs: MESOS-1744
See https://builds.apache.org/job/mesos-reviewbot/1736/changes
Changes:
[idownes] Dynamically change poll interval in the reaper.
--
[...truncated 5415 lines...]
rm -f logging/*.lo
rm -f usage/.dirstamp
rm -f master/*.o
rm -f zookeeper/.deps/.dirstamp
rm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26101/#review54741
---
Ship it!
Ship It!
- Dominic Hamon
On Sept. 26, 2014, 2:40 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26100/#review54740
---
Ship it!
Ship It!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26103/#review54742
---
Ship it!
Ship It!
- Dominic Hamon
On Sept. 26, 2014, 2:40 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/
---
(Updated Sept. 26, 2014, 5:57 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/
---
(Updated Sept. 26, 2014, 11:22 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/
---
(Updated Sept. 26, 2014, 11:22 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 26, 2014, 7:26 p.m.)
Review request for mesos, Benjamin
On Sept. 24, 2014, 4:05 p.m., Timothy St. Clair wrote:
include/mesos/module.hpp, line 73
https://reviews.apache.org/r/25848/diff/5/?file=701882#file701882line73
Perhaps we can breakout in another JIRA, but I would to denote both
some form of AUTHORING as well as define api's as
On Sept. 24, 2014, 4:05 p.m., Timothy St. Clair wrote:
src/module/manager.hpp, line 141
https://reviews.apache.org/r/25848/diff/5/?file=701886#file701886line141
can't we use std::mutex now?
Kapil Arya wrote:
The current code relies on common/lock.hpp, that uses pthread
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/#review54753
---
src/Makefile.am
https://reviews.apache.org/r/25551/#comment95043
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/
---
(Updated Sept. 27, 2014, 12:34 a.m.)
Review request for mesos, Ian Downes, Jie
See https://builds.apache.org/job/mesos-reviewbot/1737/
--
[...truncated 5565 lines...]
rm -f tests/common/.dirstamp
rm -f usage/.deps/.dirstamp
rm -f usage/.dirstamp
rm -f zookeeper/.deps/.dirstamp
rm -f zookeeper/.dirstamp
rm -f master/*.lo
rm -f
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26101/#review54757
---
Bad patch!
Reviews applied: [26100, 26101]
Failed command: git
See https://builds.apache.org/job/mesos-reviewbot/1738/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26103/#review54759
---
Bad patch!
Reviews applied: [26100, 26103]
Failed command: git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review54762
---
Bad patch!
Reviews applied: [25789]
Failed command: git apply
See https://builds.apache.org/job/mesos-reviewbot/1742/
--
[...truncated 5408 lines...]
rm -f logging/*.lo
rm -f usage/.dirstamp
rm -f master/*.o
rm -f zookeeper/.deps/.dirstamp
rm -f zookeeper/.dirstamp
rm -f master/*.lo
rm -f messages/*.o
rm -f
45 matches
Mail list logo
